vero 0.9.1 → 0.10.0

data/spec/lib/senders/sidekiq_spec.rb

@@ -1,11 +1,17 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Vero::Senders::Sidekiq do
   subject { Vero::Senders::Sidekiq.new }
   describe :call do
-    it "should perform_async a Vero::SidekiqWorker" do
-      Vero::SidekiqWorker.should_receive(:perform_async).with('Vero::Api::Workers::Events::TrackAPI', "abc", {:test => "abc"}).once
-      subject.call(Vero::Api::Workers::Events::TrackAPI, "abc", {:test => "abc"})
+    it 'should perform_async a Vero::SidekiqWorker' do
+      expect(Vero::SidekiqWorker).to(
+        receive(:perform_async)
+        .with('Vero::Api::Workers::Events::TrackAPI', 'abc', { test: 'abc' })
+        .once
+      )
+      subject.call(Vero::Api::Workers::Events::TrackAPI, 'abc', { test: 'abc' })
     end
   end
 end
@@ -13,13 +19,14 @@ end
 describe Vero::SidekiqWorker do
   subject { Vero::SidekiqWorker.new }
   describe :perform do
-    it "should call the api method" do
+    it 'should call the api method' do
       mock_api = double(Vero::Api::Workers::Events::TrackAPI)
-      mock_api.should_receive(:perform).once
-      Vero::Api::Workers::Events::TrackAPI.stub(:new).and_return(mock_api)
-      Vero::Api::Workers::Events::TrackAPI.should_receive(:new).with("abc", {:test => "abc"}).once
+      expect(mock_api).to receive(:perform).once
+
+      allow(Vero::Api::Workers::Events::TrackAPI).to receive(:new).and_return(mock_api)
+      expect(Vero::Api::Workers::Events::TrackAPI).to receive(:new).with('abc', { test: 'abc' }).once
 
-      subject.perform('Vero::Api::Workers::Events::TrackAPI', "abc", {:test => "abc"})
+      subject.perform('Vero::Api::Workers::Events::TrackAPI', 'abc', { test: 'abc' })
     end
   end
-end
+end

data/spec/lib/trackable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 def vero_context(user, logging = true, async = false, disabled = true)
@@ -13,21 +15,21 @@ end
 describe Vero::Trackable do
   before :each do
     @request_params = {
-      :event_name => 'test_event',
-      :auth_token => 'YWJjZDEyMzQ6ZWZnaDU2Nzg=',
-      :identity => {:email => 'durkster@gmail.com', :age => 20, :_user_type => "User"},
-      :data => {:test => 1},
-      :development_mode => true
+      event_name: 'test_event',
+      auth_token: 'YWJjZDEyMzQ6ZWZnaDU2Nzg=',
+      identity: { email: 'durkster@gmail.com', age: 20, _user_type: 'User' },
+      data: { test: 1 },
+      development_mode: true
     }
-    @url = "https://api.getvero.com/api/v1/track.json"
+    @url = 'https://api.getvero.com/api/v1/track.json'
     @user = User.new
 
-    @content_type_params = {:content_type => :json, :accept => :json}
+    @content_type_params = { content_type: :json, accept: :json }
   end
 
-  context "the gem has not been configured" do
+  context 'the gem has not been configured' do
     before { Vero::App.reset! }
-    it "should raise an error when API requests are made" do
+    it 'should raise an error when API requests are made' do
       expect { @user.track(@request_params[:event_name], @request_params[:data]) }.to raise_error(RuntimeError)
 
       allow(@user).to receive(:post_later).and_return('success')
@@ -35,7 +37,7 @@ describe Vero::Trackable do
     end
   end
 
-  context "the gem has been configured" do
+  context 'the gem has been configured' do
     before do
       Vero::App.init do |c|
         c.api_key = 'abcd1234'
@@ -47,21 +49,21 @@ describe Vero::Trackable do
     describe :track! do
       before do
         @request_params = {
-          :event_name => 'test_event',
-          :identity => {:email => 'durkster@gmail.com', :age => 20, :_user_type => "User"},
-          :data => { :test => 1 },
-          :extras => {}
+          event_name: 'test_event',
+          identity: { email: 'durkster@gmail.com', age: 20, _user_type: 'User' },
+          data: { test: 1 },
+          extras: {}
         }
-        @url = "https://api.getvero.com/api/v1/track.json"
+        @url = 'https://api.getvero.com/api/v1/track.json'
       end
 
-      it "should not send a track request when the required parameters are invalid" do
+      it 'should not send a track request when the required parameters are invalid' do
         expect { @user.track!(nil) }.to raise_error(ArgumentError)
         expect { @user.track!('') }.to raise_error(ArgumentError)
         expect { @user.track!('test', '') }.to raise_error(ArgumentError)
       end
 
-      it "should send a `track!` request when async is set to false" do
+      it 'should send a `track!` request when async is set to false' do
         context = vero_context(@user)
         allow(@user).to receive(:with_vero_context).and_return(context)
 
@@ -72,7 +74,7 @@ describe Vero::Trackable do
         expect(@user.track!(@request_params[:event_name], @request_params[:data])).to eq(200)
 
         allow(Vero::Api::Events).to receive(:track!).and_return(200)
-        expect(Vero::Api::Events).to receive(:track!).with(@request_params.merge(:data => {}), context)
+        expect(Vero::Api::Events).to receive(:track!).with(@request_params.merge(data: {}), context)
         expect(@user.track!(@request_params[:event_name])).to eq(200)
       end
 
@@ -82,13 +84,9 @@ describe Vero::Trackable do
           allow(@user).to receive(:with_vero_context).and_return(@context)
         end
 
-        context 'not using Ruby 1.8.7' do
-          before { stub_const('RUBY_VERSION', '1.9.3') }
-
-          it 'sends' do
-            expect(@user.track!(@request_params[:event_name], @request_params[:data])).to be_nil
-            expect(@user.track!(@request_params[:event_name])).to be_nil
-          end
+        it 'sends' do
+          expect(@user.track!(@request_params[:event_name], @request_params[:data])).to be_nil
+          expect(@user.track!(@request_params[:event_name])).to be_nil
         end
       end
     end
@@ -96,14 +94,14 @@ describe Vero::Trackable do
     describe :identify! do
       before do
         @request_params = {
-          :id => nil,
-          :email => 'durkster@gmail.com',
-          :data => {:email => 'durkster@gmail.com', :age => 20, :_user_type => "User"}
+          id: nil,
+          email: 'durkster@gmail.com',
+          data: { email: 'durkster@gmail.com', age: 20, _user_type: 'User' }
         }
-        @url = "https://api.getvero.com/api/v2/users/track.json"
+        @url = 'https://api.getvero.com/api/v2/users/track.json'
       end
 
-      it "should send an `identify` request when async is set to false" do
+      it 'should send an `identify` request when async is set to false' do
         context = vero_context(@user)
         allow(@user).to receive(:with_vero_context).and_return(context)
 
@@ -119,12 +117,8 @@ describe Vero::Trackable do
           allow(@user).to receive(:with_vero_context).and_return(@context)
         end
 
-        context 'and not using Ruby 1.8.7' do
-          before { stub_const('RUBY_VERSION', '1.9.3') }
-
-          it 'sends' do
-            expect(@user.identify!).to be_nil
-          end
+        it 'sends' do
+          expect(@user.identify!).to be_nil
         end
       end
     end
@@ -132,14 +126,14 @@ describe Vero::Trackable do
     describe :update_user! do
       before do
         @request_params = {
-          :id => nil,
-          :email => 'durkster@gmail.com',
-          :changes => {:email => 'durkster@gmail.com', :age => 20, :_user_type => "User"},
+          id: nil,
+          email: 'durkster@gmail.com',
+          changes: { email: 'durkster@gmail.com', age: 20, _user_type: 'User' }
         }
-        @url = "https://api.getvero.com/api/v2/users/edit.json"
+        @url = 'https://api.getvero.com/api/v2/users/edit.json'
       end
 
-      it "should send an `update_user` request when async is set to false" do
+      it 'should send an `update_user` request when async is set to false' do
         context = Vero::Context.new(Vero::App.default_context)
         context.subject = @user
 
@@ -157,21 +151,8 @@ describe Vero::Trackable do
           allow(@user).to receive(:with_vero_context).and_return(@context)
         end
 
-        context 'and using Ruby 1.8.7' do
-          before { stub_const('RUBY_VERSION', '1.8.7') }
-
-          it 'raises an error' do
-            @context.config.disabled = false
-            expect { @user.with_vero_context.update_user! }.to raise_error(RuntimeError)
-          end
-        end
-
-        context 'and not using Ruby 1.8.7' do
-          before { stub_const('RUBY_VERSION', '1.9.3') }
-
-          it 'sends' do
-            expect(@user.with_vero_context.update_user!).to be_nil
-          end
+        it 'sends' do
+          expect(@user.with_vero_context.update_user!).to be_nil
         end
       end
     end
@@ -179,15 +160,15 @@ describe Vero::Trackable do
     describe :update_user_tags! do
       before do
         @request_params = {
-          :id => nil,
-          :email => 'durkster@gmail.com',
-          :add => [],
-          :remove => []
+          id: nil,
+          email: 'durkster@gmail.com',
+          add: [],
+          remove: []
         }
-        @url = "https://api.getvero.com/api/v2/users/tags/edit.json"
+        @url = 'https://api.getvero.com/api/v2/users/tags/edit.json'
       end
 
-      it "should send an `update_user_tags` request when async is set to false" do
+      it 'should send an `update_user_tags` request when async is set to false' do
         context = Vero::Context.new(Vero::App.default_context)
         context.subject = @user
         context.config.async = false
@@ -200,29 +181,27 @@ describe Vero::Trackable do
         expect(@user.with_vero_context.update_user_tags!).to eq(200)
       end
 
-      if RUBY_VERSION =~ /1\.9\./
-        it "should send using another thread when async is set to true" do
-          context = Vero::Context.new(Vero::App.default_context)
-          context.subject = @user
-          context.config.async = true
+      it 'should send using another thread when async is set to true' do
+        context = Vero::Context.new(Vero::App.default_context)
+        context.subject = @user
+        context.config.async = true
 
-          allow(@user).to receive(:with_vero_context).and_return(context)
+        allow(@user).to receive(:with_vero_context).and_return(context)
 
-          expect(@user.with_vero_context.update_user_tags!).to be_nil
-        end
+        expect(@user.with_vero_context.update_user_tags!).to be_nil
       end
     end
 
     describe :unsubscribe! do
       before do
         @request_params = {
-          :id => nil,
-          :email => 'durkster@gmail.com'
+          id: nil,
+          email: 'durkster@gmail.com'
         }
-        @url = "https://api.getvero.com/api/v2/users/unsubscribe.json"
+        @url = 'https://api.getvero.com/api/v2/users/unsubscribe.json'
       end
 
-      it "should send an `update_user` request when async is set to false" do
+      it 'should send an `update_user` request when async is set to false' do
         context = Vero::Context.new(Vero::App.default_context)
         context.subject = @user
         context.config.async = false
@@ -241,12 +220,8 @@ describe Vero::Trackable do
           allow(@user).to receive(:with_vero_context).and_return(@context)
         end
 
-        context 'and using Ruby 1.9.3' do
-          before { stub_const('RUBY_VERSION', '1.9.3') }
-
-          it 'sends' do
-            expect(@user.with_vero_context.unsubscribe!).to be_nil
-          end
+        it 'sends' do
+          expect(@user.with_vero_context.unsubscribe!).to be_nil
         end
       end
     end
@@ -254,20 +229,20 @@ describe Vero::Trackable do
     describe :trackable do
       before { User.reset_trackable_map! }
 
-      it "should build an array of trackable params" do
+      it 'should build an array of trackable params' do
         User.trackable :email, :age
-        expect(User.trackable_map).to eq([:email, :age])
+        expect(User.trackable_map).to eq(%i[email age])
       end
 
-      it "should append new trackable items to an existing trackable map" do
+      it 'should append new trackable items to an existing trackable map' do
         User.trackable :email, :age
         User.trackable :hair_colour
-        expect(User.trackable_map).to eq([:email, :age, :hair_colour])
+        expect(User.trackable_map).to eq(%i[email age hair_colour])
       end
 
       it "should append an extra's hash to the trackable map" do
-        User.trackable :email, {:extras => :properties}
-        expect(User.trackable_map).to eq([:email, {:extras => :properties}])
+        User.trackable :email, { extras: :properties }
+        expect(User.trackable_map).to eq([:email, { extras: :properties }])
       end
     end
 
@@ -277,70 +252,69 @@ describe Vero::Trackable do
         User.trackable :email, :age
       end
 
-      it "should return a hash of all values mapped by trackable" do
+      it 'should return a hash of all values mapped by trackable' do
         user = User.new
-        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :age => 20, :_user_type => "User"})
+        expect(user.to_vero).to eq({ email: 'durkster@gmail.com', age: 20, _user_type: 'User' })
 
         user = UserWithoutEmail.new
-        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :age => 20, :_user_type => "UserWithoutEmail"})
+        expect(user.to_vero).to eq({ email: 'durkster@gmail.com', age: 20, _user_type: 'UserWithoutEmail' })
 
         user = UserWithEmailAddress.new
-        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :age => 20, :_user_type => "UserWithEmailAddress"})
+        expect(user.to_vero).to eq({ email: 'durkster@gmail.com', age: 20, _user_type: 'UserWithEmailAddress' })
 
         user = UserWithoutInterface.new
-        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :age => 20, :_user_type => "UserWithoutInterface"})
+        expect(user.to_vero).to eq({ email: 'durkster@gmail.com', age: 20, _user_type: 'UserWithoutInterface' })
 
         user = UserWithNilAttributes.new
-        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :_user_type => "UserWithNilAttributes"})
+        expect(user.to_vero).to eq({ email: 'durkster@gmail.com', _user_type: 'UserWithNilAttributes' })
       end
 
-      it "should take into account any defined extras" do
+      it 'should take into account any defined extras' do
         user = UserWithExtras.new
         user.properties = nil
-        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :_user_type => "UserWithExtras"})
+        expect(user.to_vero).to eq({ email: 'durkster@gmail.com', _user_type: 'UserWithExtras' })
 
-        user.properties = "test"
-        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :_user_type => "UserWithExtras"})
+        user.properties = 'test'
+        expect(user.to_vero).to eq({ email: 'durkster@gmail.com', _user_type: 'UserWithExtras' })
 
         user.properties = {}
-        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :_user_type => "UserWithExtras"})
+        expect(user.to_vero).to eq({ email: 'durkster@gmail.com', _user_type: 'UserWithExtras' })
 
         user.properties = {
-          :age => 20,
-          :gender => "female"
+          age: 20,
+          gender: 'female'
         }
-        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :age => 20, :gender => "female", :_user_type => "UserWithExtras"})
+        expect(user.to_vero).to eq({ email: 'durkster@gmail.com', age: 20, gender: 'female', _user_type: 'UserWithExtras' })
 
         user = UserWithPrivateExtras.new
-        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :age => 26, :_user_type => "UserWithPrivateExtras"})
+        expect(user.to_vero).to eq({ email: 'durkster@gmail.com', age: 26, _user_type: 'UserWithPrivateExtras' })
       end
 
-      it "should allow extras to be provided instead :id or :email" do
+      it 'should allow extras to be provided instead :id or :email' do
         user = UserWithOnlyExtras.new
-        user.properties = {:email => user.email}
-        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :_user_type => "UserWithOnlyExtras"})
+        user.properties = { email: user.email }
+        expect(user.to_vero).to eq({ email: 'durkster@gmail.com', _user_type: 'UserWithOnlyExtras' })
       end
     end
 
     describe :with_vero_context do
-      it "should be able to change contexts" do
+      it 'should be able to change contexts' do
         user = User.new
-        expect(user.with_default_vero_context.config.config_params).to eq({:api_key=>"abcd1234", :secret=>"efgh5678"})
-        expect(user.with_vero_context({:api_key => "boom", :secret => "tish"}).config.config_params).to eq({:api_key=>"boom", :secret=>"tish"})
+        expect(user.with_default_vero_context.config.config_params).to eq({ api_key: 'abcd1234', secret: 'efgh5678' })
+        expect(user.with_vero_context({ api_key: 'boom', secret: 'tish' }).config.config_params).to eq({ api_key: 'boom', secret: 'tish' })
       end
     end
 
-    it "should work when Vero::Trackable::Interface is not included" do
+    it 'should work when Vero::Trackable::Interface is not included' do
       user = UserWithoutInterface.new
 
       request_params = {
-        :event_name => 'test_event',
-        :auth_token => 'YWJjZDEyMzQ6ZWZnaDU2Nzg=',
-        :identity => {:email => 'durkster@gmail.com', :age => 20, :_user_type => "UserWithoutInterface"},
-        :data => { :test => 1 },
-        :development_mode => true
+        event_name: 'test_event',
+        auth_token: 'YWJjZDEyMzQ6ZWZnaDU2Nzg=',
+        identity: { email: 'durkster@gmail.com', age: 20, _user_type: 'UserWithoutInterface' },
+        data: { test: 1 },
+        development_mode: true
       }
-      url = "https://api.getvero.com/api/v1/track.json"
 
       context = Vero::Context.new(Vero::App.default_context)
       context.subject = user

data/spec/lib/view_helpers_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 require 'rails'
@@ -5,9 +7,11 @@ require 'action_view'
 require 'active_support'
 require 'vero/view_helpers/javascript'
 
+# rubocop:disable Style/MixinUsage
 include Vero::ViewHelpers::Javascript
 include ActionView::Helpers
 include ActionView::Context
+# rubocop:enable Style/MixinUsage
 
 describe Vero::ViewHelpers::Javascript do
   before do
@@ -16,17 +20,17 @@ describe Vero::ViewHelpers::Javascript do
 
   subject { Vero::ViewHelpers::Javascript }
   describe :vero_javascript_tag do
-    it "should return an empty string if Vero::App is not properly configured" do
-      expect(subject.vero_javascript_tag).to eq("")
+    it 'should return an empty string if Vero::App is not properly configured' do
+      expect(subject.vero_javascript_tag).to eq('')
 
       Vero::App.init {}
-      expect(subject.vero_javascript_tag).to eq("")
+      expect(subject.vero_javascript_tag).to eq('')
     end
 
-    context "Vero::App has been properly configured" do
+    context 'Vero::App has been properly configured' do
       before :each do
-        @api_key = "abcd1234"
-        @api_secret = "secret"
+        @api_key = 'abcd1234'
+        @api_secret = 'secret'
         @api_dev_mode = false
 
         Vero::App.init do |c|
@@ -36,10 +40,10 @@ describe Vero::ViewHelpers::Javascript do
         end
       end
 
-      it "should return a properly formatted javascript snippet" do
+      it 'should return a properly formatted javascript snippet' do
         result = "<script type=\"text/javascript\">var _veroq = _veroq || [];setTimeout(function(){if(typeof window.Semblance==\"undefined\"){console.log(\"Vero did not load in time.\");for(var i=0;i<_veroq.length;i++){a=_veroq[i];if(a.length==3&&typeof a[2]==\"function\")a[2](null,false);}}},3000);_veroq.push(['init', {\"api_key\": \"#{@api_key}\", \"secret\": \"#{@api_secret}\"}]);(function() {var ve = document.createElement('script'); ve.type = 'text/javascript'; ve.async = true; ve.src = '//getvero.com/assets/m.js'; var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ve, s);})();</script>"
         expect(subject.vero_javascript_tag).to eq(result)
       end
     end
   end
-end
+end