vero 0.8.1 → 0.9.0

data/spec/lib/config_spec.rb

@@ -1,76 +1,74 @@
 require 'spec_helper'
 
 describe Vero::Config do
-  before :each do
-    @config = Vero::Config.new
-  end
+  let(:config) { Vero::Config.new }
 
   it "should be async by default" do
-    @config.async.should be(true)
+    expect(config.async).to be(true)
   end
 
   describe :reset! do
     it "should reset all attributes" do
-      @config.api_key = "abcd1234"
-      @config.secret  = "abcd1234"
+      config.api_key = "abcd1234"
+      config.secret  = "abcd1234"
+      config.reset!
 
-      @config.reset!
-      @config.api_key.should be_nil
-      @config.secret.should be_nil
+      expect(config.api_key).to be_nil
+      expect(config.secret).to be_nil
     end
   end
 
   describe :auth_token do
     it "should return nil if either api_key or secret are not set" do
-      @config.api_key = nil
-      @config.secret = "abcd"
-      @config.auth_token.should be_nil
+      config.api_key = nil
+      config.secret = "abcd"
+      expect(config.auth_token).to be_nil
 
-      @config.api_key = "abcd"
-      @config.secret = nil
-      @config.auth_token.should be_nil
+      config.api_key = "abcd"
+      config.secret = nil
+      expect(config.auth_token).to be_nil
 
-      @config.api_key = "abcd"
-      @config.secret = "abcd"
-      @config.auth_token.should_not be_nil
+      config.api_key = "abcd"
+      config.secret = "abcd"
+      expect(config.auth_token).not_to be_nil
     end
 
     it "should return an expected auth_token" do
-      @config.api_key = "abcd1234"
-      @config.secret = "efgh5678"
-      @config.auth_token.should == "YWJjZDEyMzQ6ZWZnaDU2Nzg="
+      config.api_key = "abcd1234"
+      config.secret = "efgh5678"
+      expect(config.auth_token).to eq("YWJjZDEyMzQ6ZWZnaDU2Nzg=")
     end
   end
 
   describe :request_params do
     it "should return a hash of auth_token and development_mode if they are set" do
-      @config.api_key = nil
-      @config.secret = nil
-      @config.development_mode = nil
-      @config.request_params.should == {}
+      config.api_key = nil
+      config.secret = nil
+      config.development_mode = nil
+      expect(config.request_params).to eq({})
 
-      @config.api_key = "abcd1234"
-      @config.secret = "abcd1234"
-      @config.request_params.should == {:auth_token => "YWJjZDEyMzQ6YWJjZDEyMzQ="}
+      config.api_key = "abcd1234"
+      config.secret = "abcd1234"
+      expect(config.request_params).to eq({:auth_token => "YWJjZDEyMzQ6YWJjZDEyMzQ="})
 
-      @config.development_mode = true
-      @config.request_params.should == {:auth_token => "YWJjZDEyMzQ6YWJjZDEyMzQ=", :development_mode => true}
+      config.development_mode = true
+      expect(config.request_params).to eq({:auth_token => "YWJjZDEyMzQ6YWJjZDEyMzQ=", :development_mode => true})
     end
   end
 
   describe :domain do
     it "should return https://api.getvero.com when not set" do
-      @config.domain.should == 'https://api.getvero.com'
-      @config.domain = 'blah.com'
-      @config.domain.should_not == 'https://api.getvero.com'
+      expect(config.domain).to eq('https://api.getvero.com')
+      config.domain = 'blah.com'
+      expect(config.domain).not_to eq('https://api.getvero.com')
     end
 
     it "should return the domain value" do
-      @config.domain = 'test.unbelieveable.com.au'
-      @config.domain.should == 'http://test.unbelieveable.com.au'
+      config.domain = 'test.unbelieveable.com.au'
+      expect(config.domain).to eq('http://test.unbelieveable.com.au')
 
-      @config.domain = 'http://test.unbelieveable.com.au'
-      @config.domain.should == 'http://test.unbelieveable.com.au'
+      config.domain = 'http://test.unbelieveable.com.au'
+      expect(config.domain).to eq('http://test.unbelieveable.com.au')
     end
   end
 
@@ -78,26 +76,36 @@ describe Vero::Config do
     it "by default it should return false regardless of Rails environment" do
       stub_env('development') {
         config = Vero::Config.new
-        config.development_mode.should be(false)
+        expect(config.development_mode).to be(false)
       }
 
       stub_env('test') {
         config = Vero::Config.new
-        config.development_mode.should be(false)
+        expect(config.development_mode).to be(false)
       }
 
       stub_env('production') {
         config = Vero::Config.new
-        config.development_mode.should be(false)
+        expect(config.development_mode).to be(false)
       }
     end
 
     it "can be overritten with the config block" do
-      @config.development_mode = true
-      @config.request_params[:development_mode].should be(true)
+      config.development_mode = true
+      expect(config.request_params[:development_mode]).to be(true)
+
+      config.reset!
+      expect(config.request_params[:development_mode]).to be(false)
+    end
+  end
+
+  describe :test_mode do
+    it 'should not raise error even though not configured properly' do
+      input = {:event_name => "test_event"}
+      mock_context = Vero::Context.new
+      allow(mock_context.config).to receive(:configured?).and_return(false)
 
-      @config.reset!
-      @config.request_params[:development_mode].should be(false)
+      expect { Vero::Api::Events.track!(input) }.to_not raise_error
     end
   end
 end

data/spec/lib/context_spec.rb

@@ -5,53 +5,53 @@ describe Vero::Context do
 
   it "accepts multiple parameter types in contructor" do
     context1 = Vero::Context.new({ :api_key => 'blah', :secret => 'didah' })
-    context1.should be_a(Vero::Context)
-    context1.config.api_key.should == 'blah'
-    context1.config.secret.should == 'didah'
+    expect(context1).to be_a(Vero::Context)
+    expect(context1.config.api_key).to eq('blah')
+    expect(context1.config.secret).to eq('didah')
 
     context2 = Vero::Context.new(context1)
-    context2.should be_a(Vero::Context)
-    context2.should_not be(context1)
-    context2.config.api_key.should == 'blah'
-    context2.config.secret.should == 'didah'
+    expect(context2).to be_a(Vero::Context)
+    expect(context2).not_to be(context1)
+    expect(context2.config.api_key).to eq('blah')
+    expect(context2.config.secret).to eq('didah')
 
     context3 = Vero::Context.new VeroUser.new('api_key', 'secret')
-    context3.should be_a(Vero::Context)
-    context3.config.api_key.should == 'api_key'
-    context3.config.secret.should == 'secret'
+    expect(context3).to be_a(Vero::Context)
+    expect(context3.config.api_key).to eq('api_key')
+    expect(context3.config.secret).to eq('secret')
   end
 
   describe :configure do
     it "should ignore configuring the config if no block is provided" do
       context.configure
-      context.configured?.should be(false)
+      expect(context.configured?).to be(false)
     end
 
     it "should pass configuration defined in the block to the config file" do
       context.configure do |c|
         c.api_key = "abcd1234"
       end
-      context.config.api_key.should == "abcd1234"
+      expect(context.config.api_key).to eq("abcd1234")
     end
 
     it "should init should be able to set async" do
       context.configure do |c|
         c.async = false
       end
-      context.config.async.should be(false)
+      expect(context.config.async).to be(false)
 
       context.configure do |c|
         c.async = true
       end
-      context.config.async.should be(true)
+      expect(context.config.async).to be(true)
     end
   end
 
   describe :disable_requests! do
     it "should change config.disabled" do
-      context.config.disabled.should be(false)
+      expect(context.config.disabled).to be(false)
       context.disable_requests!
-      context.config.disabled.should be(true)            
+      expect(context.config.disabled).to be(true)            
     end
   end
 end

data/spec/lib/sender_spec.rb

@@ -5,7 +5,7 @@ describe Vero::Sender do
 
   describe ".senders" do
     it "should be a Hash" do
-      subject.senders.should be_a(Hash)
+      expect(subject.senders).to be_a(Hash)
     end
 
     context 'when using Ruby with verion greater than 1.8.7' do
@@ -14,20 +14,21 @@ describe Vero::Sender do
       end
 
       it "should have a default set of senders (true, false, none, thread)" do
-        subject.senders.should == {
+        expect(subject.senders).to eq({
           true          => Vero::Senders::Thread,
           false         => Vero::Senders::Base,
           :none         => Vero::Senders::Base,
           :thread       => Vero::Senders::Thread,
-        }
+        })
       end
     end
 
     it "should automatically find senders that are not defined" do
-      subject.senders[:delayed_job].should  == Vero::Senders::DelayedJob
-      subject.senders[:resque].should       == Vero::Senders::Resque
-      subject.senders[:invalid].should      == Vero::Senders::Invalid
-      subject.senders[:none].should         == Vero::Senders::Base
+      expect(subject.senders[:delayed_job]).to  eq(Vero::Senders::DelayedJob)
+      expect(subject.senders[:resque]).to       eq(Vero::Senders::Resque)
+      expect(subject.senders[:sidekiq]).to      eq(Vero::Senders::Sidekiq)
+      expect(subject.senders[:invalid]).to      eq(Vero::Senders::Invalid)
+      expect(subject.senders[:none]).to         eq(Vero::Senders::Base)
     end
   end
 end

data/spec/lib/senders/sidekiq_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+describe Vero::Senders::Sidekiq do
+  subject { Vero::Senders::Sidekiq.new }
+  describe :call do
+    it "should perform_async a Vero::SidekiqWorker" do
+      Vero::SidekiqWorker.should_receive(:perform_async).with('Vero::Api::Workers::Events::TrackAPI', "abc", {:test => "abc"}).once
+      subject.call(Vero::Api::Workers::Events::TrackAPI, "abc", {:test => "abc"})
+    end
+  end
+end
+
+describe Vero::SidekiqWorker do
+  subject { Vero::SidekiqWorker.new }
+  describe :perform do
+    it "should call the api method" do
+      mock_api = double(Vero::Api::Workers::Events::TrackAPI)
+      mock_api.should_receive(:perform).once
+      Vero::Api::Workers::Events::TrackAPI.stub(:new).and_return(mock_api)
+      Vero::Api::Workers::Events::TrackAPI.should_receive(:new).with("abc", {:test => "abc"}).once
+
+      subject.perform('Vero::Api::Workers::Events::TrackAPI', "abc", {:test => "abc"})
+    end
+  end
+end

data/spec/lib/trackable_spec.rb

@@ -16,7 +16,7 @@ describe Vero::Trackable do
       :event_name => 'test_event',
       :auth_token => 'YWJjZDEyMzQ6ZWZnaDU2Nzg=',
       :identity => {:email => 'durkster@gmail.com', :age => 20, :_user_type => "User"},
-      :data => { :test => 1 },
+      :data => {:test => 1},
       :development_mode => true
     }
     @url = "https://api.getvero.com/api/v1/track.json"
@@ -28,10 +28,10 @@ describe Vero::Trackable do
   context "the gem has not been configured" do
     before { Vero::App.reset! }
     it "should raise an error when API requests are made" do
-      expect { @user.track(@request_params[:event_name], @request_params[:data]) }.to raise_error
+      expect { @user.track(@request_params[:event_name], @request_params[:data]) }.to raise_error(RuntimeError)
 
-      @user.stub(:post_later).and_return('success')
-      expect { @user.identity! }.to raise_error
+      allow(@user).to receive(:post_later).and_return('success')
+      expect { @user.identity! }.to raise_error(NoMethodError)
     end
   end
 
@@ -56,38 +56,38 @@ describe Vero::Trackable do
       end
 
       it "should not send a track request when the required parameters are invalid" do
-        expect { @user.track!(nil) }.to raise_error
-        expect { @user.track!('') }.to raise_error
-        expect { @user.track!('test', '') }.to raise_error
+        expect { @user.track!(nil) }.to raise_error(ArgumentError)
+        expect { @user.track!('') }.to raise_error(ArgumentError)
+        expect { @user.track!('test', '') }.to raise_error(ArgumentError)
       end
 
       it "should send a `track!` request when async is set to false" do
         context = vero_context(@user)
-        @user.stub(:with_vero_context).and_return(context)
+        allow(@user).to receive(:with_vero_context).and_return(context)
 
-        RestClient.stub(:post).and_return(200)
+        allow(RestClient).to receive(:post).and_return(200)
 
-        Vero::Api::Events.stub(:track!).and_return(200)
-        Vero::Api::Events.should_receive(:track!).with(@request_params, context)
-        @user.track!(@request_params[:event_name], @request_params[:data]).should == 200
+        allow(Vero::Api::Events).to receive(:track!).and_return(200)
+        expect(Vero::Api::Events).to receive(:track!).with(@request_params, context)
+        expect(@user.track!(@request_params[:event_name], @request_params[:data])).to eq(200)
 
-        Vero::Api::Events.stub(:track!).and_return(200)
-        Vero::Api::Events.should_receive(:track!).with(@request_params.merge(:data => {}), context)
-        @user.track!(@request_params[:event_name]).should == 200
+        allow(Vero::Api::Events).to receive(:track!).and_return(200)
+        expect(Vero::Api::Events).to receive(:track!).with(@request_params.merge(:data => {}), context)
+        expect(@user.track!(@request_params[:event_name])).to eq(200)
       end
 
       context 'when set to be async' do
         before do
           @context = vero_context(@user, true, true)
-          @user.stub(:with_vero_context).and_return(@context)
+          allow(@user).to receive(:with_vero_context).and_return(@context)
         end
 
         context 'not using Ruby 1.8.7' do
           before { stub_const('RUBY_VERSION', '1.9.3') }
 
           it 'sends' do
-            @user.track!(@request_params[:event_name], @request_params[:data]).should be_nil
-            @user.track!(@request_params[:event_name]).should be_nil
+            expect(@user.track!(@request_params[:event_name], @request_params[:data])).to be_nil
+            expect(@user.track!(@request_params[:event_name])).to be_nil
           end
         end
       end
@@ -105,25 +105,25 @@ describe Vero::Trackable do
 
       it "should send an `identify` request when async is set to false" do
         context = vero_context(@user)
-        @user.stub(:with_vero_context).and_return(context)
+        allow(@user).to receive(:with_vero_context).and_return(context)
 
-        Vero::Api::Users.stub(:track!).and_return(200)
-        Vero::Api::Users.should_receive(:track!).with(@request_params, context)
+        allow(Vero::Api::Users).to receive(:track!).and_return(200)
+        expect(Vero::Api::Users).to receive(:track!).with(@request_params, context)
 
-        @user.identify!.should == 200
+        expect(@user.identify!).to eq(200)
       end
 
       context 'when set to use async' do
         before do
           @context = vero_context(@user, false, true)
-          @user.stub(:with_vero_context).and_return(@context)
+          allow(@user).to receive(:with_vero_context).and_return(@context)
         end
 
         context 'and not using Ruby 1.8.7' do
           before { stub_const('RUBY_VERSION', '1.9.3') }
 
           it 'sends' do
-            @user.identify!.should be_nil
+            expect(@user.identify!).to be_nil
           end
         end
       end
@@ -143,18 +143,18 @@ describe Vero::Trackable do
         context = Vero::Context.new(Vero::App.default_context)
         context.subject = @user
 
-        @user.stub(:with_vero_context).and_return(context)
+        allow(@user).to receive(:with_vero_context).and_return(context)
 
-        Vero::Api::Users.stub(:edit_user!).and_return(200)
-        Vero::Api::Users.should_receive(:edit_user!).with(@request_params, context)
+        allow(Vero::Api::Users).to receive(:edit_user!).and_return(200)
+        expect(Vero::Api::Users).to receive(:edit_user!).with(@request_params, context)
 
-        @user.with_vero_context.update_user!.should == 200
+        expect(@user.with_vero_context.update_user!).to eq(200)
       end
 
       context 'when set to use async' do
         before do
           @context = vero_context(@user, false, true)
-          @user.stub(:with_vero_context).and_return(@context)
+          allow(@user).to receive(:with_vero_context).and_return(@context)
         end
 
         context 'and using Ruby 1.8.7' do
@@ -162,7 +162,7 @@ describe Vero::Trackable do
 
           it 'raises an error' do
             @context.config.disabled = false
-            expect { @user.with_vero_context.update_user! }.to raise_error
+            expect { @user.with_vero_context.update_user! }.to raise_error(RuntimeError)
           end
         end
 
@@ -170,7 +170,7 @@ describe Vero::Trackable do
           before { stub_const('RUBY_VERSION', '1.9.3') }
 
           it 'sends' do
-            @user.with_vero_context.update_user!.should be_nil
+            expect(@user.with_vero_context.update_user!).to be_nil
           end
         end
       end
@@ -192,12 +192,12 @@ describe Vero::Trackable do
         context.subject = @user
         context.config.async = false
 
-        @user.stub(:with_vero_context).and_return(context)
+        allow(@user).to receive(:with_vero_context).and_return(context)
 
-        Vero::Api::Users.stub(:edit_user_tags!).and_return(200)
-        Vero::Api::Users.should_receive(:edit_user_tags!).with(@request_params, context)
+        allow(Vero::Api::Users).to receive(:edit_user_tags!).and_return(200)
+        expect(Vero::Api::Users).to receive(:edit_user_tags!).with(@request_params, context)
 
-        @user.with_vero_context.update_user_tags!.should == 200
+        expect(@user.with_vero_context.update_user_tags!).to eq(200)
       end
 
       if RUBY_VERSION =~ /1\.9\./
@@ -206,9 +206,9 @@ describe Vero::Trackable do
           context.subject = @user
           context.config.async = true
 
-          @user.stub(:with_vero_context).and_return(context)
+          allow(@user).to receive(:with_vero_context).and_return(context)
 
-          @user.with_vero_context.update_user_tags!.should be_nil
+          expect(@user.with_vero_context.update_user_tags!).to be_nil
         end
       end
     end
@@ -227,25 +227,25 @@ describe Vero::Trackable do
         context.subject = @user
         context.config.async = false
 
-        @user.stub(:with_vero_context).and_return(context)
+        allow(@user).to receive(:with_vero_context).and_return(context)
 
-        Vero::Api::Users.stub(:unsubscribe!).and_return(200)
-        Vero::Api::Users.should_receive(:unsubscribe!).with(@request_params, context)
+        allow(Vero::Api::Users).to receive(:unsubscribe!).and_return(200)
+        expect(Vero::Api::Users).to receive(:unsubscribe!).with(@request_params, context)
 
-        @user.with_vero_context.unsubscribe!.should == 200
+        expect(@user.with_vero_context.unsubscribe!).to eq(200)
       end
 
       context 'when using async' do
         before do
           @context = vero_context(@user, false, true)
-          @user.stub(:with_vero_context).and_return(@context)
+          allow(@user).to receive(:with_vero_context).and_return(@context)
         end
 
         context 'and using Ruby 1.9.3' do
           before { stub_const('RUBY_VERSION', '1.9.3') }
 
           it 'sends' do
-            @user.with_vero_context.unsubscribe!.should be_nil
+            expect(@user.with_vero_context.unsubscribe!).to be_nil
           end
         end
       end
@@ -256,18 +256,18 @@ describe Vero::Trackable do
 
       it "should build an array of trackable params" do
         User.trackable :email, :age
-        User.trackable_map.should == [:email, :age]
+        expect(User.trackable_map).to eq([:email, :age])
       end
 
       it "should append new trackable items to an existing trackable map" do
         User.trackable :email, :age
         User.trackable :hair_colour
-        User.trackable_map.should == [:email, :age, :hair_colour]
+        expect(User.trackable_map).to eq([:email, :age, :hair_colour])
       end
 
       it "should append an extra's hash to the trackable map" do
         User.trackable :email, {:extras => :properties}
-        User.trackable_map.should == [:email, {:extras => :properties}]
+        expect(User.trackable_map).to eq([:email, {:extras => :properties}])
       end
     end
 
@@ -279,54 +279,54 @@ describe Vero::Trackable do
 
       it "should return a hash of all values mapped by trackable" do
         user = User.new
-        user.to_vero.should == {:email => 'durkster@gmail.com', :age => 20, :_user_type => "User"}
+        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :age => 20, :_user_type => "User"})
 
         user = UserWithoutEmail.new
-        user.to_vero.should == {:email => 'durkster@gmail.com', :age => 20, :_user_type => "UserWithoutEmail"}
+        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :age => 20, :_user_type => "UserWithoutEmail"})
 
         user = UserWithEmailAddress.new
-        user.to_vero.should == {:email => 'durkster@gmail.com', :age => 20, :_user_type => "UserWithEmailAddress"}
+        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :age => 20, :_user_type => "UserWithEmailAddress"})
 
         user = UserWithoutInterface.new
-        user.to_vero.should == {:email => 'durkster@gmail.com', :age => 20, :_user_type => "UserWithoutInterface"}
+        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :age => 20, :_user_type => "UserWithoutInterface"})
 
         user = UserWithNilAttributes.new
-        user.to_vero.should == {:email => 'durkster@gmail.com', :_user_type => "UserWithNilAttributes"}
+        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :_user_type => "UserWithNilAttributes"})
       end
 
       it "should take into account any defined extras" do
         user = UserWithExtras.new
         user.properties = nil
-        user.to_vero.should == {:email => 'durkster@gmail.com', :_user_type => "UserWithExtras"}
+        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :_user_type => "UserWithExtras"})
 
         user.properties = "test"
-        user.to_vero.should == {:email => 'durkster@gmail.com', :_user_type => "UserWithExtras"}
+        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :_user_type => "UserWithExtras"})
 
         user.properties = {}
-        user.to_vero.should == {:email => 'durkster@gmail.com', :_user_type => "UserWithExtras"}
+        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :_user_type => "UserWithExtras"})
 
         user.properties = {
           :age => 20,
           :gender => "female"
         }
-        user.to_vero.should == {:email => 'durkster@gmail.com', :age => 20, :gender => "female", :_user_type => "UserWithExtras"}
+        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :age => 20, :gender => "female", :_user_type => "UserWithExtras"})
 
         user = UserWithPrivateExtras.new
-        user.to_vero.should == {:email => 'durkster@gmail.com', :age => 26, :_user_type => "UserWithPrivateExtras"}
+        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :age => 26, :_user_type => "UserWithPrivateExtras"})
       end
 
       it "should allow extras to be provided instead :id or :email" do
         user = UserWithOnlyExtras.new
         user.properties = {:email => user.email}
-        user.to_vero.should == {:email => 'durkster@gmail.com', :_user_type => "UserWithOnlyExtras"}
+        expect(user.to_vero).to eq({:email => 'durkster@gmail.com', :_user_type => "UserWithOnlyExtras"})
       end
     end
 
     describe :with_vero_context do
       it "should be able to change contexts" do
         user = User.new
-        user.with_default_vero_context.config.config_params.should == {:api_key=>"abcd1234", :secret=>"efgh5678"}
-        user.with_vero_context({:api_key => "boom", :secret => "tish"}).config.config_params.should == {:api_key=>"boom", :secret=>"tish"}
+        expect(user.with_default_vero_context.config.config_params).to eq({:api_key=>"abcd1234", :secret=>"efgh5678"})
+        expect(user.with_vero_context({:api_key => "boom", :secret => "tish"}).config.config_params).to eq({:api_key=>"boom", :secret=>"tish"})
       end
     end
 
@@ -344,12 +344,12 @@ describe Vero::Trackable do
 
       context = Vero::Context.new(Vero::App.default_context)
       context.subject = user
-      context.stub(:post_now).and_return(200)
+      allow(context).to receive(:post_now).and_return(200)
 
-      user.stub(:with_vero_context).and_return(context)
+      allow(user).to receive(:with_vero_context).and_return(context)
 
-      RestClient.stub(:post).and_return(200)
-      user.vero_track(request_params[:event_name], request_params[:data]).should == 200
+      allow(RestClient).to receive(:post).and_return(200)
+      expect(user.vero_track(request_params[:event_name], request_params[:data])).to eq(200)
     end
   end
 end