veritrans 2.0.4 → 2.1.0

data/lib/veritrans/config.rb

@@ -1,12 +1,14 @@
 require 'yaml'
 require 'excon'
 
-module Veritrans
+class Veritrans
 
-  module Config
-    extend self
+  class Config
 
-    @api_host = "https://api.sandbox.veritrans.co.id"
+    def initialize(options = nil)
+      @api_host = "https://api.sandbox.veritrans.co.id"
+      apply(options) if options
+    end
 
     ##
     # Merhcant's Client key, used to make getToken request. (only for VT-Direct)
@@ -135,8 +137,13 @@ module Veritrans
 
     private
 
+    AVAILABLE_KEYS = [:server_key, :client_key, :api_host, :http_options]
+
     def apply(hash)
       hash.each do |key, value|
+        unless AVAILABLE_KEYS.include?(key.to_s.to_sym)
+          raise ArgumentError, "Unknown option #{key.inspect}, available keys: #{AVAILABLE_KEYS.map(&:inspect).join(", ")}"
+        end
         send(:"#{key}=", value)
       end
     end

data/lib/veritrans/events.rb

@@ -15,14 +15,14 @@
 # All possible events:
 #
 # * payment.success     == ['authorize', 'capture', 'settlement']
-# * payment.failed      == ['deny', 'canel', 'expire']
-# * payment.challenge   # when payment.froud_status == 'challenge'
+# * payment.failed      == ['deny', 'cancel', 'expire']
+# * payment.challenge   # when payment.fraud_status == 'challenge'
 #
 # * payment.authorize
 # * payment.capture
 # * payment.settlement
 # * payment.deny
-# * payment.canel
+# * payment.cancel
 # * payment.expire
 #
 # * error
@@ -32,7 +32,7 @@
 #     run Rack::URLMap.new("/" => MyApp.new, "/payment_events" => Veritrans::Events.new)
 #
 
-module Veritrans
+class Veritrans
   class Events
 
     # This is rack application

data/lib/veritrans/result.rb

@@ -1,15 +1,18 @@
-module Veritrans
+class Veritrans
   class Result
     attr_reader :data
     attr_reader :status
     attr_reader :response
+    attr_reader :request_options
+    attr_reader :time
+    attr_reader :url
 
-    def initialize(response, url, options, time)
+    def initialize(response, url, request_options, time)
       begin
         if url =~ %r{/v2/.+/transcript$}
           @data = {}
         else
-          @data = Veritrans._json_decode(response.body)
+          @data = Veritrans::Client._json_decode(response.body)
 
           # Failback for Hash#symbolize_keys
           @data.keys.each do |key|
@@ -18,7 +21,7 @@ module Veritrans
         end
 
       rescue => e
-        Veritrans.logger.info "Error parsing papi response #{e.message}"
+        Veritrans.logger.info "Error parsing Veritrans response #{e.message}"
         Veritrans.logger.info e.backtrace.join("\n")
         @data = {}
       end
@@ -27,7 +30,7 @@ module Veritrans
       @status = response.status
       @response = response
       @url = url
-      @options = options
+      @request_options = request_options
     end
 
     def success?
@@ -39,7 +42,7 @@ module Veritrans
       @data[:status_code] == '201'
     end
 
-    # Docs http://docs.veritrans.co.id/sandbox/status_code.html
+    # Docs http://docs.veritrans.co.id/en/api/status_code.html
     def status_code
       @data[:status_code].to_i
     end
@@ -52,6 +55,10 @@ module Veritrans
       @data[:redirect_url]
     end
 
+    def transaction_id
+      @data[:transaction_id]
+    end
+
     def messages
       if @data[:message].present?
         @data[:message].chomp(']').sub(/^\[/, '').split(',').map(&:strip)
@@ -75,7 +82,21 @@ module Veritrans
     def inspect
       time_ms = (@time * 1000).round
       data = @data.inspect.gsub(/:([^\s]+)=>/, "\\1: ")
-      "#<Veritrans::Result:#{object_id} ^^ http_status: #{@status} time: #{time_ms}ms ^^ data: #{data}>"
+      "#<#{self.class.to_s}:#{object_id} ^^ status: #{@status} time: #{time_ms}ms ^^ data: #{data}>"
+    end
+  end
+
+  class SnapResult < Result
+    def status_code
+      @response.status.to_i
+    end
+
+    def token_id
+      @data[:token_id]
+    end
+
+    def success?
+      status_code == 200
     end
   end
 end

data/lib/veritrans/version.rb

@@ -1,3 +1,3 @@
-module Veritrans
-  VERSION = "2.0.4"
+class Veritrans
+  VERSION = "2.1.0"
 end

data/spec/cli_spec.rb

@@ -1,4 +1,5 @@
 describe Veritrans do
+  include ActiveSupport::Testing::Stream
 
   before do
     stub_const("CONFIG", {})

data/spec/rails_plugin_spec.rb

@@ -6,11 +6,11 @@ require 'socket'
 describe "Rails plugin", vcr: false do
   include Capybara::DSL
 
-  MAIN_RAILS_VER = "4.1.9"
+  MAIN_RAILS_VER = "5.0.0.1"
   APP_DIR = "plugin_test"
   PLUGIN_DIR = File.expand_path("..", File.dirname(__FILE__))
 
-  RAILS_VERSIONS = ["4.0.13", "4.1.14", "4.2.5"]
+  RAILS_VERSIONS = ["4.0.13", "4.1.16", "4.2.7.1", "5.0.0.1"]
 
   before :all do
     FileUtils.mkdir_p("#{PLUGIN_DIR}/tmp")
@@ -70,7 +70,7 @@ describe "Rails plugin", vcr: false do
   end
 
   def generate_rails_app(rails_version)
-    gen = "rails _#{rails_version}_ new #{APP_DIR} -B -G --skip-spring -d sqlite3 --skip-turbolinks --skip-test-unit --no-rc"
+    gen = "rails _#{rails_version}_ new #{APP_DIR} -B -G --skip-spring -d sqlite3 --skip-turbolinks --skip-test-unit --skip-action-cable --no-rc --skip-puma --skip-listen"
     run_cmd(gen)
 
     gemfile_content = "
@@ -116,19 +116,27 @@ development:
       end
     end
 
-    Capybara.app_host = "http://localhost:#{@rails_port}"
+    Capybara.app_host = "http://127.0.0.1:#{@rails_port}"
 
     #puts "RAILS_DIR: #{@app_abs_path}"
 
-    while true
+    failed = 0
+    while failed < 10
       begin
         run_cmd("curl #{Capybara.app_host}/payments/new > /dev/null")
         break
       rescue Object => error
+        failed += 1
         p error
         puts "Retry"
+        sleep 0.3
       end
     end
+
+    if failed == 10
+      puts `tail -100 #{@app_abs_path}/log/development.log`
+      raise Exception, "can not start rails server"
+    end
   end
 
   def stop_rails_app
@@ -152,39 +160,72 @@ development:
     FileUtils.remove_entry_secure(@rails_dir) if @rails_dir
   end
 
-  RAILS_VERSIONS.each do |rails_version|
+  def submit_payment_form(card_number)
+    # CREATE PAYMENT 1
+    visit "/payments/new"
+
+    fill_in 'credit_card_number', with: card_number
+
+    click_button "Pay via VT-Direct"
+    puts "Clicked Pay"
+
+    # Waiting for get token request in javascript...
+    Timeout.timeout(60.seconds) do
+      loop do
+        #puts "Path: #{current_path}"
+        break if current_path != "/payments/new"
+        sleep 1
+      end
+    end
+
+    Timeout.timeout(10.seconds) do
+      loop do
+        break if page.body =~ /<body>/
+        sleep 0.1
+      end
+    end
+  end
+
+  RAILS_VERSIONS.each_with_index do |rails_version, spec_index|
+    next if rails_version.start_with?("5") && RUBY_VERSION < "2.2.2"
+
     it "should tests plugin (Rails #{rails_version})" do
       # PREPARE APP
       install_rails_in_tmp(rails_version)
       run_rails_app
 
-      # CREATE PAYMENT 1
-      visit "/payments/new"
-
-      click_button "Pay via VT-Direct"
+      card_numbers = [
+        "5481 1611 1111 1081",
+        "5410 1111 1111 1116",
+        "4011 1111 1111 1112",
+        "4411 1111 1111 1118",
+        "4811 1111 1111 1114",
+        "3528 6647 7942 9687",
+        "3528 2033 2456 4357"
+      ]
+      spec_index = (spec_index + RUBY_VERSION.gsub(/[^\d]/, '').to_i) % card_numbers.size
+      card_number = card_numbers[spec_index]
 
-      # Waiting for get token request in javascript...
-      Timeout.timeout(30.seconds) do
-        loop do
-          break if current_path != "/payments/new"
-          sleep 0.1
-        end
-      end
+      submit_payment_form(card_number)
 
-      Timeout.timeout(10.seconds) do
-        loop do
-          break if page.body =~ /<body>/
-          sleep 0.1
-        end
+      if page.body =~ /too many transactions/
+        puts "!!!!"
+        puts "Merchant has sent too many transactions to the same card number"
+        puts "!!!!"
+        #page.should have_content("Merchant has sent too many transactions to the same card number")
+        puts "Wait 10 seconds and retry"
+        sleep 10
+        submit_payment_form(card_number)
       end
 
-      if page.body =~ /too many transactions/
-        page.should have_content("Merchant has sent too many transactions to the same card number")
-      else
-        page.should have_content("Success, Credit Card transaction is successful")
+      if page.body !~ /transaction is successful/
+        puts page.body
       end
+      page.should have_content("Success, Credit Card transaction is successful")
 
-      created_order_id = ActiveSupport::JSON.decode(find("pre").text)["order_id"]
+      order_info = ActiveSupport::JSON.decode(find("pre").text)
+      puts "Order Info: #{order_info}"
+      created_order_id = order_info["order_id"]
       #Capybara::Screenshot.screenshot_and_open_image
 
       # CREATE PAYMENT 2
@@ -208,6 +249,10 @@ development:
         Veritrans::CLI.test_webhook(["#{Capybara.app_host}/payments/receive_webhook"])
       end
 
+      if result2 !~ /status: 200/
+        puts `tail -40 #{@app_abs_path}/log/development.log`
+      end
+
       result2.should =~ /status: 200/
       result2.should =~ /body: ok/
     end

data/spec/spec_helper.rb

@@ -12,6 +12,7 @@ require 'vcr'
 
 require 'capybara/rspec'
 require 'capybara/poltergeist'
+require 'active_support/testing/stream'
 
 Capybara.register_driver :poltergeist do |app|
   Capybara::Poltergeist::Driver.new(app,

data/spec/veritrans_client_spec.rb

@@ -1,4 +1,4 @@
-describe Veritrans do
+describe Veritrans::Client do
 
   before do
     hide_const("Rails")
@@ -21,11 +21,11 @@ describe Veritrans do
 
     result = Veritrans.request_with_logging(:get, Veritrans.config.api_host + "/ping", {})
 
-    api_request.headers["Host"].should == "api.sandbox.veritrans.co.id"
+    api_request.headers["Host"].should == "api.sandbox.veritrans.co.id:443"
   end
 
   it "should use Veritrans.http_options to attach hedaers", vcr: false do
-    Veritrans::Config.stub(:http_options) do
+    Veritrans.config.stub(:http_options) do
       { headers: { "X-Rspec" => "ok" } }
     end
 
@@ -40,6 +40,47 @@ describe Veritrans do
     api_request.headers["X-Rspec"].should == "ok"
   end
 
+  it "should be able to create other instance of client" do
+    #Veritrans.logger = Logger.new(STDOUT)
+
+    VCR.configure do |c|
+      c.allow_http_connections_when_no_cassette = true
+    end
+
+    other_client = Veritrans.new(
+      server_key: "69b61a1b-b0b1-450b-a697-37109dbbecb0",
+      logger: Logger.new("/dev/null")
+    ) # M000937
+
+    result = Veritrans.charge(
+      payment_type: "mandiri_clickpay",
+      transaction_details: {
+        gross_amount: 10_000,
+        order_id: Time.now.to_s
+      },
+      mandiri_clickpay: {
+        card_number: "4111 1111 1111 1111".gsub(/\s/, ''),
+        input3: "%05d" % (rand * 100000).to_i,
+        input2: 10000,
+        input1: "1" * 10,
+        token: "000000"
+      },
+    )
+
+    #p result.request_options
+
+    other_result = other_client.status(result.transaction_id)
+
+    other_result.status_code.should == 404
+    other_result.status_message.should == "The requested resource is not found"
+
+    #p other_result.request_options
+
+    VCR.configure do |c|
+      c.allow_http_connections_when_no_cassette = true
+    end
+  end
+
   it "should send charge vt-web request" do
     VCR.use_cassette('charge_vtweb') do
       result = Veritrans.charge('vtweb', transaction: { order_id: Time.now.to_s, gross_amount: 100_000 } )
@@ -127,4 +168,17 @@ describe Veritrans do
       result.status_message.should == "The requested resource is not found"
     end
   end
+
+  it "should handle network exceptions", vcr: false do
+    Excon::Connection.any_instance.stub(:send) do
+      raise Excon::Errors::SocketError, Excon::Errors::Error.new("testing exception")
+    end
+
+    result = Veritrans.expire("not-exists")
+    result.status.should == "500"
+    result.data.should == {
+      status_code: "500",
+      status_message: "Internal server error, no response from backend. Try again later"
+    }
+  end
 end

data/spec/veritrans_config_spec.rb

@@ -6,7 +6,7 @@ describe Veritrans::Config do
 
   it "should set Veritras as self inside config block" do
     Veritrans.config do
-      self.should == Veritrans
+      self.should == Veritrans.instance
     end
   end
 

data/spec/veritrans_events_spec.rb

@@ -1,4 +1,6 @@
 describe Veritrans do
+  include ActiveSupport::Testing::Stream
+
   before do
     stub_const("CONFIG", {})
     Veritrans.logger = Logger.new(STDOUT)

data/spec/veritrans_snap_spec.rb

@@ -0,0 +1,39 @@
+describe Veritrans::Config do
+
+  before do
+    hide_const("Rails")
+    Veritrans.logger = Logger.new("/dev/null")
+    Veritrans.setup do
+      config.load_config "./spec/configs/real_key.yml"
+    end
+
+    VCR.configure do |c|
+      c.allow_http_connections_when_no_cassette = true
+    end
+  end
+
+  after do
+    VCR.configure do |c|
+      c.allow_http_connections_when_no_cassette = false
+    end
+  end
+
+  def generate_order_id
+    "testing-#{rand.round(4)}-#{Time.now.to_i}"
+  end
+
+  it "should create widget token" do
+    response = Veritrans.create_snap_token(
+      transaction_details: {
+        order_id: generate_order_id,
+        gross_amount: 30_000
+      }
+    )
+
+    response.should be_a(Veritrans::SnapResult)
+    response.success?.should be_truthy
+    response.token_id.should be_present
+    response.token_id.should == response.data[:token_id]
+    response.inspect.should =~ /#<Veritrans::SnapResult:\d+ \^\^ status: 200 time: \d+ms \^\^ data: \{token_id: "[\da-f\-]+"\}>/
+  end
+end