veritas 0.0.5 → 0.0.6

data/lib/veritas.rb

@@ -11,6 +11,7 @@ require 'veritas/core_ext/time'
 
 require 'veritas/support/abstract_class'
 require 'veritas/support/aliasable'
+require 'veritas/support/comparator'
 require 'veritas/support/immutable'
 require 'veritas/support/visitable'
 

data/spec/integration/veritas/relation/efficient_enumerable_spec.rb

@@ -7,11 +7,11 @@ require 'spec_helper'
 class InfiniteList
   include Enumerable
 
-  Infinity = 1.0/0.0
-
   def each
-    0.upto(Infinity) do |index|
+    index = 0
+    loop do
       yield [ index ]
+      index += 1
     end
     self
   end

data/spec/shared/hash_method_behavior.rb

@@ -3,9 +3,14 @@
 shared_examples_for 'a hash method' do
   it_should_behave_like 'an idempotent method'
 
-  it { should be_instance_of(Fixnum) }
+  # TOOD: figure out if #hash under rbx should also always use Fixnum
+  if defined?(RUBY_ENGINE) && RUBY_ENGINE == 'rbx'
+    it { should be_kind_of(Integer) }
+  else
+    it { should be_instance_of(Fixnum) }
+  end
 
   it 'memoizes the hash code' do
-    subject.should eql(object.memoized('hash'))
+    subject.should eql(object.memoized(:hash))
   end
 end

data/spec/unit/date/pred_spec.rb

@@ -14,6 +14,6 @@ describe Date, '#pred' do
   end
 
   it 'is the inverse of #succ' do
-    subject.succ.should eql(object)
+    (subject + 1).should eql(object)
   end
 end

data/spec/unit/veritas/aggregate/equal_value_spec.rb

@@ -0,0 +1,52 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Aggregate, '#==' do
+  subject { object == other }
+
+  let(:described_class) { Class.new(Aggregate)           }
+  let(:object)          { described_class.new(attribute) }
+  let(:attribute)       { Attribute::Integer.new(:id)    }
+
+  context 'with the same object' do
+    let(:other) { object }
+
+    it { should be(true) }
+
+    it 'is symmetric' do
+      should eql(other == object)
+    end
+  end
+
+  context 'with an equivalent object' do
+    let(:other) { object.dup }
+
+    it { should be(true) }
+
+    it 'is symmetric' do
+      should eql(other == object)
+    end
+  end
+
+  context 'with an equivalent object of a subclass' do
+    let(:other) { Class.new(described_class).new(attribute) }
+
+    it { should be(true) }
+
+    it 'is symmetric' do
+      should eql(other == object)
+    end
+  end
+
+  context 'with an object having a different attribute' do
+    let(:other_attribute) { Attribute::Integer.new(:other_id)    }
+    let(:other)           { described_class.new(other_attribute) }
+
+    it { should be(false) }
+
+    it 'is symmetric' do
+      should eql(other.eql?(object))
+    end
+  end
+end

data/spec/unit/veritas/aggregate/hash_spec.rb

@@ -0,0 +1,15 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Aggregate, '#hash' do
+  subject { object.hash }
+
+  let(:described_class) { Class.new(Aggregate)           }
+  let(:object)          { described_class.new(attribute) }
+  let(:attribute)       { Attribute::Integer.new(:id)    }
+
+  it_should_behave_like 'a hash method'
+
+  it { should == described_class.hash ^ attribute.hash }
+end

data/spec/unit/veritas/aliasable/inheritable_alias_spec.rb

@@ -37,7 +37,7 @@ describe Aliasable, '#inheritable_alias' do
     file, line = aliasable.other.first.split(':')[0, 2]
 
     File.expand_path(file).should eql(File.expand_path('../../../../../lib/veritas/support/aliasable.rb', __FILE__))
-    line.to_i.should eql(23)
+    line.to_i.should eql(38)
   end
 
   it 'sets the file and line number properly' do

data/spec/unit/veritas/comparator/compare_spec.rb

@@ -0,0 +1,40 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Comparator, '#compare' do
+  subject { object.compare(*methods) }
+
+  let(:methods)  { [ :nil?, :to_s ]                }
+  let(:object)   { Class.new { extend Comparator } }
+  let(:instance) { object.new                      }
+
+  before do
+    object.instance_eval { include Immutable }
+  end
+
+  it { should equal(object) }
+
+  it 'includes Comparator::Methods' do
+    expect { subject }.to change { object.include?(Comparator::Methods) }.from(false).to(true)
+  end
+
+  it 'defines a #hash public instance method' do
+    expect { subject }.to change { object.public_instance_methods(false).map(&:to_s) }.from([]).to([ 'hash' ])
+  end
+
+  it 'defines a #hash method that uses the class and declared methods' do
+    subject
+    instance.hash.should equal(object.hash ^ false.hash ^ instance.to_s.hash)
+  end
+
+  it 'memoizes #hash' do
+    subject
+    instance.hash
+    instance.memoized(:hash).should_not be_nil
+  end
+
+  it 'defines a #cmp? private instance method' do
+    expect { subject }.to change { object.private_instance_methods(false).map(&:to_s) }.from([]).to([ 'cmp?' ])
+  end
+end

data/spec/unit/veritas/comparator/methods/eql_spec.rb

@@ -0,0 +1,48 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Comparator::Methods, '#eql?' do
+  subject { object.eql?(other) }
+
+  let(:described_class) { Class.new { include Comparator::Methods } }
+  let(:object)          { described_class.new                       }
+
+  before do
+    described_class.class_eval do
+      extend Comparator
+      include Immutable
+      compare :nil?
+    end
+  end
+
+  context 'with the same object' do
+    let(:other) { object }
+
+    it { should be(true) }
+
+    it 'is symmetric' do
+      should eql(other.eql?(object))
+    end
+  end
+
+  context 'with an equivalent object' do
+    let(:other) { object.dup }
+
+    it { should be(true) }
+
+    it 'is symmetric' do
+      should eql(other.eql?(object))
+    end
+  end
+
+  context 'with an equivalent object of a subclass' do
+    let(:other) { Class.new(described_class).new }
+
+    it { should be(false) }
+
+    it 'is symmetric' do
+      should eql(other.eql?(object))
+    end
+  end
+end

data/spec/unit/veritas/evaluator/context/respond_to_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe Evaluator::Context, '#respond_to?' do
-  subject { object.respond_to?(method) }
+  subject { object.respond_to?(method, include_private) }
 
   let(:attribute) { Attribute::Integer.new(:id)         }
   let(:header)    { Relation::Header.new([ attribute ]) }

data/spec/unit/veritas/function/predicate/enumerable/call_spec.rb

@@ -0,0 +1,36 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Function::Predicate::Enumerable, '#call' do
+  subject { object.call(tuple) }
+
+  let(:described_class) { Class.new(Function) { include Function::Binary } }
+  let(:header)          { Relation::Header.new([ [ :id, Integer ] ])       }
+  let(:tuple)           { Tuple.new(header, [ 1 ])                         }
+
+  before do
+    described_class.class_eval { include Function::Predicate::Enumerable }
+  end
+
+  context 'with an enumerable of non-callable objects' do
+    let(:object) { described_class.new(header[:id], [ 1 ]) }
+
+    it 'sends the left and right value to self.class.call' do
+      response = mock('#call response')
+      described_class.should_receive(:call).with(1, [ 1 ]).and_return(response)
+      should equal(response)
+    end
+  end
+
+  context 'with an enumerable of callable objects' do
+    let(:callable) { proc { 1 }                                     }
+    let(:object)   { described_class.new(header[:id], [ callable ]) }
+
+    it 'sends the left and right value to self.class.call' do
+      response = mock('#call response')
+      described_class.should_receive(:call).with(1, [ 1 ]).and_return(response)
+      should equal(response)
+    end
+  end
+end

data/spec/unit/veritas/function/unary/hash_spec.rb

@@ -0,0 +1,18 @@
+# encoding: utf-8
+
+require 'spec_helper'
+require File.expand_path('../fixtures/classes', __FILE__)
+
+describe Function::Unary, '#hash' do
+  subject { object.hash }
+
+  let(:described_class) { UnarySpecs::Object                  }
+  let(:attribute)       { Attribute::Integer.new(:id)         }
+  let(:header)          { Relation::Header.new([ attribute ]) }
+  let(:operand)         { attribute.eq(1)                     }
+  let(:object)          { described_class.new(operand)        }
+
+  it_should_behave_like 'a hash method'
+
+  it { should == described_class.hash ^ operand.hash }
+end

data/spec/unit/veritas/immutable/freeze_spec.rb

@@ -26,7 +26,7 @@ describe Immutable, '#freeze' do
     it 'sets a memoization instance variable' do
       object.should_not be_instance_variable_defined(:@__memory)
       subject
-      object.instance_variable_get(:@__memory).should be_instance_of(Immutable::Memory)
+      object.instance_variable_get(:@__memory).should be_instance_of(Hash)
     end
   end
 
@@ -44,7 +44,7 @@ describe Immutable, '#freeze' do
     end
 
     it 'sets an instance variable for memoization' do
-      subject.instance_variable_get(:@__memory).should be_instance_of(Immutable::Memory)
+      subject.instance_variable_get(:@__memory).should be_instance_of(Hash)
     end
   end
 end

data/spec/unit/veritas/immutable/memoize_spec.rb

@@ -41,4 +41,17 @@ describe Immutable, '#memoize' do
       object.send(method).should be_frozen
     end
   end
+
+  context 'when the method is already memoized' do
+    let(:value)    { stub }
+    let(:original) { nil  }
+
+    before do
+      object.memoize(method, original)
+    end
+
+    it 'does not change the value' do
+      expect { subject }.to_not change { object.send(method) }
+    end
+  end
 end

data/spec/unit/veritas/immutable/module_methods/memoize_spec.rb

@@ -26,7 +26,7 @@ shared_examples_for 'memoizes method' do
     file, line = object.new.send(method).first.split(':')[0, 2]
 
     File.expand_path(file).should eql(File.expand_path('../../../../../../lib/veritas/support/immutable.rb', __FILE__))
-    line.to_i.should eql(180)
+    line.to_i.should eql(185)
   end
 
   it 'sets the file and line number properly' do

data/spec/unit/veritas/relation/empty/class_methods/new_spec.rb

@@ -0,0 +1,30 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Relation::Empty, '.new' do
+  let(:object) { described_class      }
+  let(:header) { [ [ :id, Integer ] ] }
+
+  context 'with a header' do
+    subject { object.new(header) }
+
+    it { should be_instance_of(object) }
+
+    its(:header){ should == header }
+
+    its(:tuples) { should == [] }
+  end
+
+  context 'with a header and tuples' do
+    subject { object.new(header, tuples) }
+
+    let(:tuples) { mock('Tuples') }
+
+    it { should be_instance_of(object) }
+
+    its(:header){ should == header }
+
+    its(:tuples) { should equal(tuples) }
+  end
+end

data/spec/unit/veritas/relation/empty/each_spec.rb

@@ -5,12 +5,27 @@ require 'spec_helper'
 describe Relation::Empty, '#each' do
   subject { object.each { |tuple| yields << tuple } }
 
-  let(:object) { described_class.new([ [ :id, Integer ] ]) }
-  let(:yields) { []                                        }
+  let(:header) { [ [ :id, Integer ] ] }
+  let(:yields) { []                   }
 
-  it_should_behave_like 'an #each method'
+  context 'with an empty relation having no tuples' do
+    let(:object) { described_class.new(header) }
 
-  it 'yields no tuples' do
-    expect { subject }.to_not change { yields.dup }
+    it_should_behave_like 'an #each method'
+
+    it 'yields no tuples' do
+      expect { subject }.to_not change { yields.dup }
+    end
+  end
+
+  context 'with an empty relation having tuples' do
+    let(:tuples) { mock('Tuples')                      }
+    let(:object) { described_class.new(header, tuples) }
+
+    it_should_behave_like 'an #each method'
+
+    it 'yields no tuples' do
+      expect { subject }.to_not change { yields.dup }
+    end
   end
 end

data/spec/unit/veritas/relation/empty/size_spec.rb

@@ -0,0 +1,11 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Relation::Empty, '#size' do
+  subject { object.size }
+
+  let(:object) { described_class.new([ [ :id, Integer ] ]) }
+
+  it { should eql(0) }
+end

data/spec/unit/veritas/relation/header/hash_spec.rb

@@ -10,5 +10,5 @@ describe Relation::Header, '#hash' do
 
   it_should_behave_like 'a hash method'
 
-  it { should == described_class.hash ^ { :id => attribute }.hash }
+  it { should == described_class.hash ^ Set[attribute].hash }
 end

data/spec/unit/veritas/relation/materialized/empty_spec.rb

@@ -12,21 +12,11 @@ describe Relation::Materialized, '#empty?' do
     let(:body) { [] }
 
     it { should be(true) }
-
-    it 'does not execute body#each' do
-      body.should_not_receive(:each)
-      subject
-    end
   end
 
   context 'with a body containing an entry' do
     let(:body) { [ [ 1 ] ] }
 
     it { should be(false) }
-
-    it 'does not execute body#each' do
-      body.should_not_receive(:each)
-      subject
-    end
   end
 end

data/spec/unit/veritas/relation/operation/order/direction_set/class_methods/coerce_spec.rb

@@ -5,9 +5,10 @@ require 'spec_helper'
 describe Relation::Operation::Order::DirectionSet, '.coerce' do
   subject { object.coerce(argument) }
 
-  let(:directions)    { [ Attribute::Integer.new(:id) ] }
-  let(:object)        { described_class                 }
-  let(:direction_set) { object.new(directions)          }
+  let(:direction)     { Attribute::Integer.new(:id).desc }
+  let(:directions)    { [ direction ]                    }
+  let(:object)        { described_class                  }
+  let(:direction_set) { object.new(directions)           }
 
   context 'when the argument is a DirectionSet' do
     let(:argument) { direction_set }
@@ -15,6 +16,14 @@ describe Relation::Operation::Order::DirectionSet, '.coerce' do
     it { should equal(argument) }
   end
 
+  context 'when the argument is a Direction' do
+    let(:argument) { direction }
+
+    it { should be_instance_of(object) }
+
+    it { should == direction_set }
+  end
+
   context 'when the argument responds to #to_ary' do
     let(:argument) { directions }
 

data/tasks/metrics/heckle.rake

@@ -194,7 +194,7 @@ begin
         ObjectSpace.each_object(Module) do |descedant|
           next unless descedant.name =~ /\A#{root_module}(?::|\z)/ && mod >= descedant
           descedant_spec_prefix = spec_dir.join(descedant.name.underscore)
-          descedant_specs.concat(Pathname.glob(descedant_spec_prefix.join('*_spec.rb')))
+          descedant_specs << descedant_spec_prefix
 
           if method.to_s == 'initialize'
             descedant_specs.concat(Pathname.glob(descedant_spec_prefix.join('class_methods/new_spec.rb')))
@@ -209,8 +209,7 @@ begin
 
         ObjectSpace.each_object(Module) do |descedant|
           next unless descedant.name =~ /\A#{root_module}(?::|\z)/ && mod >= descedant
-          descedant_spec_prefix = spec_dir.join(descedant.name.underscore)
-          descedant_specs.concat(Pathname.glob(descedant_spec_prefix.join('class_methods/*_spec.rb')))
+          descedant_specs << spec_dir.join(descedant.name.underscore).join('class_methods')
         end
 
         specs << [ ".#{method}", descedant_specs ]

data/veritas.gemspec

@@ -4,17 +4,17 @@
 # -*- encoding: utf-8 -*-
 
 Gem::Specification.new do |s|
-  s.name = %q{veritas}
-  s.version = "0.0.5"
+  s.name = "veritas"
+  s.version = "0.0.6"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.authors = [%q{Dan Kubb}]
-  s.date = %q{2011-07-29}
-  s.description = %q{Simplifies querying of structured data using relational algebra}
-  s.email = %q{dan.kubb@gmail.com}
+  s.authors = ["Dan Kubb"]
+  s.date = "2011-10-04"
+  s.description = "Simplifies querying of structured data using relational algebra"
+  s.email = "dan.kubb@gmail.com"
   s.extra_rdoc_files = [
     "LICENSE",
-    "README.rdoc",
+    "README.md",
     "TODO"
   ]
   s.files = [
@@ -25,7 +25,7 @@ Gem::Specification.new do |s|
     "Gemfile",
     "Guardfile",
     "LICENSE",
-    "README.rdoc",
+    "README.md",
     "Rakefile",
     "TODO",
     "benchmarks/memory.rb",
@@ -128,6 +128,7 @@ Gem::Specification.new do |s|
     "lib/veritas/relation/operation/unary.rb",
     "lib/veritas/support/abstract_class.rb",
     "lib/veritas/support/aliasable.rb",
+    "lib/veritas/support/comparator.rb",
     "lib/veritas/support/evaluator.rb",
     "lib/veritas/support/immutable.rb",
     "lib/veritas/support/operation/binary.rb",
@@ -161,7 +162,9 @@ Gem::Specification.new do |s|
     "spec/unit/veritas/aggregate/count/methods/count_spec.rb",
     "spec/unit/veritas/aggregate/count/type_spec.rb",
     "spec/unit/veritas/aggregate/default_spec.rb",
+    "spec/unit/veritas/aggregate/equal_value_spec.rb",
     "spec/unit/veritas/aggregate/finalize_spec.rb",
+    "spec/unit/veritas/aggregate/hash_spec.rb",
     "spec/unit/veritas/aggregate/maximum/class_methods/call_spec.rb",
     "spec/unit/veritas/aggregate/maximum/class_methods/default_spec.rb",
     "spec/unit/veritas/aggregate/maximum/methods/maximum_spec.rb",
@@ -299,6 +302,8 @@ Gem::Specification.new do |s|
     "spec/unit/veritas/attribute/type_spec.rb",
     "spec/unit/veritas/attribute/valid_primitive_spec.rb",
     "spec/unit/veritas/attribute/valid_value_spec.rb",
+    "spec/unit/veritas/comparator/compare_spec.rb",
+    "spec/unit/veritas/comparator/methods/eql_spec.rb",
     "spec/unit/veritas/evaluator/context/add_spec.rb",
     "spec/unit/veritas/evaluator/context/element_reference_spec.rb",
     "spec/unit/veritas/evaluator/context/functions_spec.rb",
@@ -334,10 +339,7 @@ Gem::Specification.new do |s|
     "spec/unit/veritas/function/connective/negation/methods/fixtures/classes.rb",
     "spec/unit/veritas/function/connective/negation/methods/not_spec.rb",
     "spec/unit/veritas/function/connective/type_spec.rb",
-    "spec/unit/veritas/function/eql_spec.rb",
-    "spec/unit/veritas/function/equal_value_spec.rb",
     "spec/unit/veritas/function/fixtures/classes.rb",
-    "spec/unit/veritas/function/hash_spec.rb",
     "spec/unit/veritas/function/inspect_spec.rb",
     "spec/unit/veritas/function/numeric/absolute/class_methods/call_spec.rb",
     "spec/unit/veritas/function/numeric/absolute/inspect_spec.rb",
@@ -389,6 +391,7 @@ Gem::Specification.new do |s|
     "spec/unit/veritas/function/numeric/unary_plus/methods/unary_plus_spec.rb",
     "spec/unit/veritas/function/predicate/call_spec.rb",
     "spec/unit/veritas/function/predicate/class_methods/call_spec.rb",
+    "spec/unit/veritas/function/predicate/enumerable/call_spec.rb",
     "spec/unit/veritas/function/predicate/enumerable/class_methods/compare_method_spec.rb",
     "spec/unit/veritas/function/predicate/eql_spec.rb",
     "spec/unit/veritas/function/predicate/equality/class_methods/call_spec.rb",
@@ -501,6 +504,7 @@ Gem::Specification.new do |s|
     "spec/unit/veritas/function/unary/call_spec.rb",
     "spec/unit/veritas/function/unary/equal_value_spec.rb",
     "spec/unit/veritas/function/unary/fixtures/classes.rb",
+    "spec/unit/veritas/function/unary/hash_spec.rb",
     "spec/unit/veritas/function/unary/invertible/inverse_spec.rb",
     "spec/unit/veritas/function/unary/rename_spec.rb",
     "spec/unit/veritas/immutable/class_methods/freeze_object_spec.rb",
@@ -510,8 +514,6 @@ Gem::Specification.new do |s|
     "spec/unit/veritas/immutable/freeze_spec.rb",
     "spec/unit/veritas/immutable/memoize_spec.rb",
     "spec/unit/veritas/immutable/memoized_spec.rb",
-    "spec/unit/veritas/immutable/memory/element_reference_spec.rb",
-    "spec/unit/veritas/immutable/memory/element_set_spec.rb",
     "spec/unit/veritas/immutable/module_methods/included_spec.rb",
     "spec/unit/veritas/immutable/module_methods/memoize_spec.rb",
     "spec/unit/veritas/operation/binary/eql_spec.rb",
@@ -529,9 +531,11 @@ Gem::Specification.new do |s|
     "spec/unit/veritas/relation/directions_spec.rb",
     "spec/unit/veritas/relation/each_spec.rb",
     "spec/unit/veritas/relation/element_reference_spec.rb",
+    "spec/unit/veritas/relation/empty/class_methods/new_spec.rb",
     "spec/unit/veritas/relation/empty/each_spec.rb",
     "spec/unit/veritas/relation/empty/empty_spec.rb",
     "spec/unit/veritas/relation/empty/header_spec.rb",
+    "spec/unit/veritas/relation/empty/size_spec.rb",
     "spec/unit/veritas/relation/empty_spec.rb",
     "spec/unit/veritas/relation/eql_spec.rb",
     "spec/unit/veritas/relation/equal_value_spec.rb",
@@ -615,7 +619,6 @@ Gem::Specification.new do |s|
     "spec/unit/veritas/relation/operation/order/eql_spec.rb",
     "spec/unit/veritas/relation/operation/order/hash_spec.rb",
     "spec/unit/veritas/relation/operation/order/header_spec.rb",
-    "spec/unit/veritas/relation/operation/order/methods/order_spec.rb",
     "spec/unit/veritas/relation/operation/order/methods/sort_by_spec.rb",
     "spec/unit/veritas/relation/operation/reverse/class_methods/new_spec.rb",
     "spec/unit/veritas/relation/operation/reverse/directions_spec.rb",
@@ -652,10 +655,10 @@ Gem::Specification.new do |s|
     "tasks/yard.rake",
     "veritas.gemspec"
   ]
-  s.homepage = %q{https://github.com/dkubb/veritas}
-  s.require_paths = [%q{lib}]
-  s.rubygems_version = %q{1.8.5}
-  s.summary = %q{Ruby Relational Algebra}
+  s.homepage = "https://github.com/dkubb/veritas"
+  s.require_paths = ["lib"]
+  s.rubygems_version = "1.8.10"
+  s.summary = "Ruby Relational Algebra"
 
   if s.respond_to? :specification_version then
     s.specification_version = 3