veritas-optimizer 0.0.3 → 0.0.4

data/spec/unit/veritas/optimizer/relation/operation/binary/right_order_operand/optimize_spec.rb

@@ -0,0 +1,23 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Optimizer::Relation::Operation::Binary::RightOrderOperand, '#optimize' do
+  subject { object.optimize }
+
+  let(:base)     { Relation.new([ [ :id, Integer ] ], [].each) }
+  let(:left)     { base                                        }
+  let(:right)    { base.order                                  }
+  let(:relation) { left.union(right)                           }
+  let(:object)   { described_class.new(relation)               }
+
+  before do
+    object.should be_optimizable
+  end
+
+  it { should be_kind_of(relation.class) }
+
+  its(:left) { should equal(left) }
+
+  its(:right) { should equal(base) }
+end

data/spec/unit/veritas/optimizer/relation/operation/binary/right_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Binary, '#right' do
@@ -9,9 +11,5 @@ describe Optimizer::Relation::Operation::Binary, '#right' do
   let(:relation)  { mock('Relation', :left => left, :right => right) }
   let(:object)    { described_class.new(relation)                    }
 
-  before do
-    left.stub!(:optimize).and_return(left)
-  end
-
   it { should equal(optimized) }
 end

data/spec/unit/veritas/optimizer/relation/operation/binary/{unoptimized_operand → unoptimized_operands}/optimizable_spec.rb

@@ -1,6 +1,8 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
-describe Optimizer::Relation::Operation::Binary::UnoptimizedOperand, '#optimizable?' do
+describe Optimizer::Relation::Operation::Binary::UnoptimizedOperands, '#optimizable?' do
   subject { object.optimizable? }
 
   let(:optimized)   { Relation.new([ [ :id, Integer ] ], [ [ 1 ] ]) }

data/spec/unit/veritas/optimizer/relation/operation/binary/{unoptimized_operand → unoptimized_operands}/optimize_spec.rb

@@ -1,6 +1,8 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
-describe Optimizer::Relation::Operation::Binary::UnoptimizedOperand, '#optimize' do
+describe Optimizer::Relation::Operation::Binary::UnoptimizedOperands, '#optimize' do
   subject { object.optimize }
 
   let(:left)     { Relation.new([ [ :id, Integer ] ], [ [ 1 ] ].each) }

data/spec/unit/veritas/optimizer/relation/operation/combination/optimize_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Combination, '#optimize' do

data/spec/unit/veritas/optimizer/relation/operation/limit/equal_limit_operand/optimizable_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Limit::EqualLimitOperand, '#optimizable?' do

data/spec/unit/veritas/optimizer/relation/operation/limit/equal_limit_operand/optimize_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Limit::EqualLimitOperand, '#optimize' do

data/spec/unit/veritas/optimizer/relation/operation/limit/limit_operand/optimizable_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Limit::LimitOperand, '#optimizable?' do

data/spec/unit/veritas/optimizer/relation/operation/limit/limit_operand/optimize_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Limit::LimitOperand, '#optimize' do

data/spec/unit/veritas/optimizer/relation/operation/limit/unoptimized_operand/optimizable_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Limit::UnoptimizedOperand, '#optimizable?' do

data/spec/unit/veritas/optimizer/relation/operation/limit/unoptimized_operand/optimize_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Limit::UnoptimizedOperand, '#optimize' do

data/spec/unit/veritas/optimizer/relation/operation/limit/zero_limit/optimizable_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Limit::ZeroLimit, '#optimizable?' do

data/spec/unit/veritas/optimizer/relation/operation/limit/zero_limit/optimize_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Limit::ZeroLimit, '#optimize' do

data/spec/unit/veritas/optimizer/relation/operation/offset/offset_operand/optimizable_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Offset::OffsetOperand, '#optimizable?' do

data/spec/unit/veritas/optimizer/relation/operation/offset/offset_operand/optimize_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Offset::OffsetOperand, '#optimize' do

data/spec/unit/veritas/optimizer/relation/operation/offset/unoptimized_operand/optimizable_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Offset::UnoptimizedOperand, '#optimizable?' do

data/spec/unit/veritas/optimizer/relation/operation/offset/unoptimized_operand/optimize_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Offset::UnoptimizedOperand, '#optimize' do

data/spec/unit/veritas/optimizer/relation/operation/offset/zero_offset/optimizable_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Offset::ZeroOffset, '#optimizable?' do

data/spec/unit/veritas/optimizer/relation/operation/offset/zero_offset/optimize_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Offset::ZeroOffset, '#optimize' do

data/spec/unit/veritas/optimizer/relation/operation/order/one_limit_operand/optimizable_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Order::OneLimitOperand, '#optimizable?' do

data/spec/unit/veritas/optimizer/relation/operation/order/one_limit_operand/optimize_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Order::OneLimitOperand, '#optimize' do

data/spec/unit/veritas/optimizer/relation/operation/order/order_operand/optimizable_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Order::OrderOperand, '#optimizable?' do

data/spec/unit/veritas/optimizer/relation/operation/order/order_operand/optimize_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Order::OrderOperand, '#optimize' do
@@ -5,7 +7,7 @@ describe Optimizer::Relation::Operation::Order::OrderOperand, '#optimize' do
 
   let(:base)     { Relation.new([ [ :id, Integer ] ], [ [ 1 ] ].each) }
   let(:order)    { base.order                                         }
-  let(:relation) { order.order(order.directions.reverse)              }
+  let(:relation) { order.order { |order| order.directions.reverse }   }
   let(:object)   { described_class.new(relation)                      }
 
   before do

data/spec/unit/veritas/optimizer/relation/operation/order/unoptimized_operand/optimizable_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Order::UnoptimizedOperand, '#optimizable?' do

data/spec/unit/veritas/optimizer/relation/operation/order/unoptimized_operand/optimize_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Order::UnoptimizedOperand, '#optimize' do

data/spec/unit/veritas/optimizer/relation/operation/reverse/order_operand/optimizable_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Reverse::OrderOperand, '#optimizable?' do

data/spec/unit/veritas/optimizer/relation/operation/reverse/order_operand/optimize_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Reverse::OrderOperand, '#optimize' do

data/spec/unit/veritas/optimizer/relation/operation/reverse/reverse_operand/optimizable_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Reverse::ReverseOperand, '#optimizable?' do

data/spec/unit/veritas/optimizer/relation/operation/reverse/reverse_operand/optimize_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Reverse::ReverseOperand, '#optimize' do

data/spec/unit/veritas/optimizer/relation/operation/reverse/unoptimized_operand/optimizable_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Reverse::UnoptimizedOperand, '#optimizable?' do

data/spec/unit/veritas/optimizer/relation/operation/reverse/unoptimized_operand/optimize_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Reverse::UnoptimizedOperand, '#optimize' do

data/spec/unit/veritas/optimizer/relation/operation/unary/empty_operand/optimizable_spec.rb

@@ -1,10 +1,13 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Unary::EmptyOperand, '#optimizable?' do
   subject { object.optimizable? }
 
-  let(:relation) { mock('Relation', :operand => operand) }
-  let(:object)   { described_class.new(relation)         }
+  let(:header)   { mock('Header')                                           }
+  let(:relation) { mock('Relation', :operand => operand, :header => header) }
+  let(:object)   { described_class.new(relation)                            }
 
   context 'when the operand is empty' do
     let(:operand) { Relation::Empty.new([ [ :id, Integer ] ]) }

data/spec/unit/veritas/optimizer/relation/operation/unary/empty_operand/optimize_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Unary::EmptyOperand, '#optimize' do

data/spec/unit/veritas/optimizer/relation/operation/unary/header_spec.rb

@@ -0,0 +1,15 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Optimizer::Relation::Operation::Unary, '#header' do
+  subject { object.header }
+
+  let(:described_class) { Class.new(Optimizer::Relation::Operation::Unary)         }
+  let(:operand)         { mock('Operand')                                          }
+  let(:header)          { mock('Header')                                           }
+  let(:relation)        { mock('Relation', :operand => operand, :header => header) }
+  let(:object)          { described_class.new(relation)                            }
+
+  it { should equal(header) }
+end

data/spec/unit/veritas/optimizer/relation/operation/unary/materialized_operand/optimizable_spec.rb

@@ -1,10 +1,13 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Unary::MaterializedOperand, '#optimizable?' do
   subject { object.optimizable? }
 
-  let(:relation) { mock('Relation', :operand => operand) }
-  let(:object)   { described_class.new(relation)         }
+  let(:header)   { mock('Header')                                           }
+  let(:relation) { mock('Relation', :operand => operand, :header => header) }
+  let(:object)   { described_class.new(relation)                            }
 
   context 'when the operand is materialized' do
     let(:operand) { Relation::Materialized.new([ [ :id, Integer ] ], [ [ 1 ] ]) }

data/spec/unit/veritas/optimizer/relation/operation/unary/materialized_operand/optimize_spec.rb

@@ -1,3 +1,5 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Unary::MaterializedOperand, '#optimize' do

data/spec/unit/veritas/optimizer/relation/operation/unary/operand_spec.rb

@@ -1,13 +1,16 @@
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe Optimizer::Relation::Operation::Unary, '#operand' do
   subject { object.operand }
 
-  let(:described_class) { Class.new(Optimizer::Relation::Operation::Unary) }
-  let(:optimized)       { mock('Optimized')                                }
-  let(:operand)         { mock('Operand', :optimize => optimized)          }
-  let(:relation)        { mock('Relation', :operand => operand)            }
-  let(:object)          { described_class.new(relation)                    }
+  let(:described_class) { Class.new(Optimizer::Relation::Operation::Unary)         }
+  let(:optimized)       { mock('Optimized')                                        }
+  let(:operand)         { mock('Operand', :optimize => optimized)                  }
+  let(:header)          { mock('Header')                                           }
+  let(:relation)        { mock('Relation', :operand => operand, :header => header) }
+  let(:object)          { described_class.new(relation)                            }
 
   it { should equal(optimized) }
 end

data/spec/unit/veritas/optimizer/relation/operation/unary/order_operand/optimizable_spec.rb

@@ -0,0 +1,28 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Optimizer::Relation::Operation::Unary::OrderOperand, '#optimizable?' do
+  subject { object.optimizable? }
+
+  let(:described_class) { Class.new(Optimizer::Relation::Operation::Unary) }
+  let(:base)            { Relation.new([ [ :id, Integer ] ], [].each)      }
+  let(:relation)        { operand.project([])                              }
+  let(:object)          { described_class.new(relation)                    }
+
+  before do
+    described_class.class_eval { include Optimizer::Relation::Operation::Unary::OrderOperand }
+  end
+
+  context 'when operand is an order' do
+    let(:operand) { base.order }
+
+    it { should be(true) }
+  end
+
+  context 'when operand is not an order' do
+    let(:operand) { base }
+
+    it { should be(false) }
+  end
+end

data/spec/unit/veritas/optimizer/relation/operation/unary/order_operand/optimize_spec.rb

@@ -0,0 +1,27 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Optimizer::Relation::Operation::Unary::OrderOperand, '#optimize' do
+  subject { object.optimize }
+
+  let(:described_class) { Class.new(Optimizer::Relation::Operation::Unary) }
+  let(:base)            { Relation.new([ [ :id, Integer ] ], [].each)      }
+  let(:operand)         { base.order                                       }
+  let(:relation)        { operand.project([])                              }
+  let(:object)          { described_class.new(relation)                    }
+
+  before do
+    described_class.class_eval do
+      include Optimizer::Relation::Operation::Unary::OrderOperand
+
+      def wrap_operand
+        'Optimized'
+      end
+    end
+
+    object.should be_optimizable
+  end
+
+  it { should eql('Optimized') }
+end

data/spec/unit/veritas/optimizer/relation/operation/unary/unchanged_header/optimizable_spec.rb

@@ -0,0 +1,24 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Optimizer::Relation::Operation::Unary::UnchangedHeader, '#optimizable?' do
+  subject { object.optimizable? }
+
+  let(:operand)  { mock('Operand', :header => operand_header)               }
+  let(:header)   { mock('Header')                                           }
+  let(:relation) { mock('Relation', :operand => operand, :header => header) }
+  let(:object)   { described_class.new(relation)                            }
+
+  context 'when the header is not changed' do
+    let(:operand_header) { header }
+
+    it { should be(true) }
+  end
+
+  context 'when the header is changed' do
+    let(:operand_header) { mock('Changed Header') }
+
+    it { should be(false) }
+  end
+end

data/spec/unit/veritas/optimizer/relation/operation/unary/unchanged_header/optimize_spec.rb

@@ -0,0 +1,14 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Optimizer::Relation::Operation::Unary::UnchangedHeader, '#optimize' do
+  subject { object.optimize }
+
+  let(:operand)  { mock('Operand')                                          }
+  let(:header)   { mock('Header')                                           }
+  let(:relation) { mock('Relation', :operand => operand, :header => header) }
+  let(:object)   { described_class.new(relation)                            }
+
+  it { should equal(operand) }
+end

data/tasks/metrics/ci.rake

@@ -0,0 +1,7 @@
+desc 'Run metrics with Heckle'
+task :ci => [ 'ci:metrics', :heckle ]
+
+namespace :ci do
+  desc 'Run metrics'
+  task :metrics => [ :verify_measurements, :flog, :flay, :reek, :roodi, 'metrics:all' ]
+end

data/tasks/{quality → metrics}/heckle.rake

@@ -5,6 +5,7 @@ $LOAD_PATH.unshift(File.expand_path('../../../lib', __FILE__))
 
 begin
   require 'pathname'
+  require 'backports'
   require 'active_support/inflector'
   require 'heckle'
   require 'mspec'

data/tasks/{quality → metrics}/metric_fu.rake

@@ -2,6 +2,9 @@ begin
   require 'metric_fu'
   require 'json'
 
+  # XXX: temporary hack until metric_fu is fixed
+  MetricFu::Saikuro.class_eval { include FileUtils }
+
   MetricFu::Configuration.run do |config|
     config.rcov = {
       :environment => 'test',

data/tasks/spec.rake

@@ -35,4 +35,5 @@ rescue LoadError
   end
 end
 
+task :test    => :spec
 task :default => :spec