verikloak-audience 0.2.6 → 0.2.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1ba5a1ca7162831839679e843f5def72fb8efeecb4b88e9cded4d6aa283c66a3
-  data.tar.gz: 4a4a71f5408b0b77cb63ffa9b5bc998a721de2083133234b1dfa2e96c4afb609
+  metadata.gz: 88a1386b46aebb2940ede856bdde5993bd68a05000d71f9f5784d73dd85c2fc6
+  data.tar.gz: cf84cfe50d3a6acf004ce0535b02b1644693d2c89b78e422d809b0f184e53cc3
 SHA512:
-  metadata.gz: d54e6ccb8c86555cb3c3821355912fc283e155fb103cdb7df5a0166e59163f9ea086ea1a7fcdbb7c7a82aa76b65b120d166379cfacd18fcff610bdb9fe4fc65a
-  data.tar.gz: c610ec408d85b8bd89b1a7f60d112731b3dbcaac696e66a993caa790c2ee5bb8c8b2f43227c87c681b3a1384fb59cca43e267ecd4a0f69f43f924187cc90f0ea
+  metadata.gz: c97758819fac422b4f81e5d22655b677f7d1bd762430e8fd68d038b1fdf9adce004da3261b6de5d2af66874a9dc2a417a1c1272933d51acd979e55416131e4dc
+  data.tar.gz: b12d1fa1f74f5b4d1bb17e461956ecabf4e094eb673b9a03e47bb174603ebcacf3d6bc3a48bab9854df8c3d94b3f6a7d252080f83248ca841354465554191740

data/CHANGELOG.md

@@ -7,6 +7,26 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ---
 
+## [0.2.8] - 2025-09-28
+
+### Changed
+- Require `rails/generators` directly in the install generator and inherit via `::Rails::Generators::Base` to avoid constant lookup issues in non-Rails contexts.
+- Document the generator purpose with a `desc` string so `rails g --help` includes a clearer description.
+
+### Fixed
+- Stub Thor semantics in the generator spec and restore `tmpdir` usage so error handling tests assert `Thor::Error`, matching the real generator behavior.
+- Ensure the generator spec recreates missing template and destination conflict scenarios using the same API surface Rails provides.
+
+## [0.2.7] - 2025-09-27
+
+### Changed
+- Rails Railtie now syncs `env_claims_key`, `required_aud`, and `resource_client` defaults with verikloak-rails configuration after boot.
+- Generator template converted to ERB and bundled with the gem so `rails g verikloak:audience:install` produces the initializer without relying on Rails internals.
+- Middleware option validation tightened to fail fast on unknown overrides with clearer error messages.
+
+### Documentation
+- Added RubyDoc comments across the Railtie to clarify initializer responsibilities and helper methods.
+
 ## [0.2.6] - 2025-09-23
 
 ### Added

data/lib/generators/verikloak/audience/install/install_generator.rb

@@ -1,11 +1,6 @@
 # frozen_string_literal: true
 
-begin
-  require 'rails/generators'
-  require 'rails/generators/base'
-rescue LoadError
-  # Allow the generator to be required without Rails.
-end
+require 'rails/generators'
 
 module Verikloak
   module Audience
@@ -14,13 +9,13 @@ module Verikloak
       # application. This generator creates an initializer that inserts the
       # audience middleware after the core Verikloak middleware once it is
       # available.
-      class InstallGenerator < (defined?(Rails::Generators::Base) ? Rails::Generators::Base : Object)
-        source_root File.expand_path('templates', __dir__) if respond_to?(:source_root)
+      class InstallGenerator < ::Rails::Generators::Base
+        source_root File.expand_path('templates', __dir__)
 
-        def create_initializer
-          return unless respond_to?(:template, true)
+        desc 'Creates an initializer for verikloak-audience middleware integration.'
 
-          template 'verikloak_audience.rb.tt', 'config/initializers/verikloak_audience.rb'
+        def create_initializer
+          template 'initializer.rb.erb', 'config/initializers/verikloak_audience.rb'
         end
       end
     end

data/lib/generators/verikloak/audience/install/templates/initializer.rb.erb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+# Insert the audience middleware after the core Verikloak middleware once it
+# has been loaded into the application.
+if defined?(Rails) && Rails.respond_to?(:application)
+  Verikloak::Audience::Railtie.insert_middleware(Rails.application)
+end

data/lib/verikloak/audience/checker.rb

@@ -44,7 +44,7 @@ module Verikloak
       # @param required [Array<String>]
       # @return [Boolean]
       def strict_single?(claims, required)
-        aud = Array(claims['aud']).map(&:to_s)
+        aud = normalized_audiences(claims)
         return false if required.empty?
 
         # Must contain all required and have no unexpected extra (order-insensitive)
@@ -57,7 +57,7 @@ module Verikloak
       # @param required [Array<String>]
       # @return [Boolean]
       def allow_account?(claims, required)
-        aud = Array(claims['aud']).map(&:to_s)
+        aud = normalized_audiences(claims)
         return false if required.empty?
 
         # Permit 'account' extra
@@ -89,13 +89,10 @@ module Verikloak
       def suggest(claims, cfg)
         claims = normalize_claims(claims)
 
-        aud = Array(claims['aud']).map(&:to_s)
-        req = cfg.required_aud_list
-        has_roles = !Array(claims.dig('resource_access', cfg.resource_client.to_s, 'roles')).empty?
-
-        return :strict_single if aud.sort == req.sort
-        return :allow_account if (aud - req) == ['account'] && (req - aud).empty?
-        return :resource_or_aud if has_roles
+        required = cfg.required_aud_list
+        return :strict_single if strict_single?(claims, required)
+        return :allow_account if allow_account?(claims, required)
+        return :resource_or_aud if resource_or_aud?(claims, cfg.resource_client.to_s, required)
 
         :strict_single
       end
@@ -120,6 +117,16 @@ module Verikloak
       end
       module_function :normalize_claims
       private_class_method :normalize_claims
+
+      # Normalize audience claims into a predictable array of strings.
+      #
+      # @param claims [Hash]
+      # @return [Array<String>]
+      def normalized_audiences(claims)
+        Array(claims['aud']).map(&:to_s)
+      end
+      module_function :normalized_audiences
+      private_class_method :normalized_audiences
     end
   end
 end

data/lib/verikloak/audience/configuration.rb

@@ -23,6 +23,7 @@ module Verikloak
     #   @return [Boolean]
     class Configuration
       DEFAULT_RESOURCE_CLIENT = 'rails-api'
+      DEFAULT_ENV_CLAIMS_KEY = 'verikloak.user'
 
       attr_accessor :profile, :required_aud, :resource_client,
                     :suggest_in_logs
@@ -35,7 +36,7 @@ module Verikloak
         @profile         = :strict_single
         @required_aud    = []
         @resource_client = DEFAULT_RESOURCE_CLIENT
-        self.env_claims_key = 'verikloak.user'
+        self.env_claims_key = DEFAULT_ENV_CLAIMS_KEY
         @suggest_in_logs = true
       end
 
@@ -121,23 +122,19 @@ module Verikloak
       # @return [void]
       def ensure_resource_client!(audiences)
         client = resource_client.to_s
+        error_msg = 'resource_client must match one of required_aud when using :resource_or_aud profile'
 
-        needs_inference = needs_resource_client_inference?(client, audiences)
+        if needs_resource_client_inference?(client, audiences)
+          raise Verikloak::Audience::ConfigurationError, error_msg unless audiences.one?
+
+          self.resource_client = audiences.first
+          client = resource_client.to_s
 
-        if needs_inference
-          if audiences.one?
-            self.resource_client = audiences.first
-            client = resource_client.to_s
-          else
-            raise Verikloak::Audience::ConfigurationError,
-                  'resource_client must match one of required_aud when using :resource_or_aud profile'
-          end
         end
 
         return if audiences.include?(client)
 
-        raise Verikloak::Audience::ConfigurationError,
-              'resource_client must match one of required_aud when using :resource_or_aud profile'
+        raise Verikloak::Audience::ConfigurationError, error_msg
       end
 
       # Decide whether the resource client should be inferred from the

data/lib/verikloak/audience/middleware.rb

@@ -57,16 +57,14 @@ module Verikloak
       # @return [void]
       def apply_overrides!(opts)
         cfg = @config
-        opts.each_key do |key|
+        opts.each do |key, value|
           writer = "#{key}="
-          next if cfg.respond_to?(writer)
+          unless cfg.respond_to?(writer)
+            raise Verikloak::Audience::ConfigurationError,
+                  "unknown middleware option :#{key}"
+          end
 
-          raise Verikloak::Audience::ConfigurationError,
-                "unknown middleware option :#{key}"
-        end
-
-        opts.each do |k, v|
-          cfg.public_send("#{k}=", v)
+          cfg.public_send(writer, value)
         end
       end
 
@@ -90,11 +88,9 @@ module Verikloak
       # @return [void]
       def log_warning(env, message)
         logger = env['verikloak.logger'] || env['rack.logger'] || env['action_dispatch.logger']
-        if logger.respond_to?(:warn)
-          logger.warn(message)
-        else
-          warn(message)
-        end
+        return logger.warn(message) if logger.respond_to?(:warn)
+
+        Kernel.warn(message)
       end
     end
   end

data/lib/verikloak/audience/railtie.rb

@@ -35,6 +35,7 @@ module Verikloak
 
       initializer 'verikloak_audience.configuration' do
         config.after_initialize do
+          self.class.apply_verikloak_rails_configuration
           next if Verikloak::Audience::Railtie.skip_configuration_validation?
 
           Verikloak::Audience.config.validate!
@@ -45,6 +46,9 @@ module Verikloak
       # Verikloak middleware is available and already present. Extracted for
       # testability without requiring a full Rails boot process.
       #
+      # Insert the audience middleware after the base Verikloak middleware when
+      # both are available on the stack.
+      #
       # @param app [#middleware] An object exposing a Rack middleware stack via `#middleware`.
       # @return [void]
       def self.insert_middleware(app)
@@ -53,6 +57,8 @@ module Verikloak
         middleware_stack = app.middleware
         return unless middleware_stack.respond_to?(:include?)
 
+        return if middleware_stack.include?(::Verikloak::Audience::Middleware)
+
         unless middleware_stack.include?(::Verikloak::Middleware)
           warn_missing_core_middleware
           return
@@ -85,7 +91,7 @@ module Verikloak
       #
       # @return [void]
       def self.warn_missing_core_middleware
-        logger = rails_logger
+        logger = (::Rails.logger if defined?(::Rails) && ::Rails.respond_to?(:logger))
 
         if logger
           logger.warn(WARNING_MESSAGE)
@@ -94,20 +100,6 @@ module Verikloak
         end
       end
 
-      # Retrieves the Rails application logger if available.
-      #
-      # This method safely attempts to access the Rails logger, returning nil
-      # if Rails is not defined, doesn't respond to the logger method, or if
-      # the logger itself is nil.
-      #
-      # @return [Logger, nil] the Rails logger instance, or nil if unavailable
-      def self.rails_logger
-        return unless defined?(::Rails)
-        return unless ::Rails.respond_to?(:logger)
-
-        ::Rails.logger
-      end
-
       # Rails short commands (`g`, `d`) are stripped from ARGV fairly early in
       # the boot process. Treat `verikloak:*:install` generators as safe so they
       # can run before configuration files exist.
@@ -119,25 +111,32 @@ module Verikloak
       #
       # @return [Boolean]
       def self.skip_configuration_validation?
-        command = first_rails_command
-        return false unless command
+        tokens = first_cli_tokens
+        return false if tokens.empty?
+
+        command = tokens.first
+        return true if COMMANDS_SKIPPING_VALIDATION.include?(command)
 
-        COMMANDS_SKIPPING_VALIDATION.include?(command) || verikloak_install_generator?(command)
+        tokens.any? { |token| verikloak_install_generator?(token) }
       end
 
-      # Capture the first non-option argument passed to the Rails CLI,
-      # ignoring wrapper tokens such as "rails".
+      # Capture the first non-option arguments passed to the Rails CLI,
+      # ignoring wrapper tokens such as "rails". Only the first two tokens are
+      # relevant for generator detection, so we keep the return list short.
       #
-      # @return [String, nil]
-      def self.first_rails_command
+      # @return [Array<String>] ordered CLI tokens that may signal a generator
+      def self.first_cli_tokens
+        tokens = []
+
         ARGV.each do |arg|
           next if arg.start_with?('-')
           next if arg == 'rails'
 
-          return arg
+          tokens << arg
+          break if tokens.size >= 2
         end
 
-        nil
+        tokens
       end
 
       # Detect whether the provided CLI token refers to a Verikloak install
@@ -150,6 +149,118 @@ module Verikloak
 
         command.start_with?('verikloak:') && command.end_with?(':install')
       end
+
+      class << self
+        # Synchronize configuration with verikloak-rails when it is present.
+        # Aligns env_claims_key, required_aud, and resource_client defaults so
+        # that both gems operate on the same Rack env payload and audience list.
+        #
+        # @return [void]
+        def apply_verikloak_rails_configuration
+          rails_config = verikloak_rails_config
+          return unless rails_config
+
+          Verikloak::Audience.configure do |cfg|
+            sync_env_claims_key(cfg, rails_config)
+            sync_required_aud(cfg, rails_config)
+            sync_resource_client(cfg, rails_config)
+          end
+        end
+
+        private
+
+        # Resolve the verikloak-rails configuration object if the gem is loaded.
+        #
+        # @return [Verikloak::Rails::Configuration, nil]
+        def verikloak_rails_config
+          return unless defined?(::Verikloak::Rails)
+          return unless ::Verikloak::Rails.respond_to?(:config)
+
+          ::Verikloak::Rails.config
+        rescue StandardError
+          nil
+        end
+
+        # Align the environment claims key with the one configured in verikloak-rails.
+        #
+        # @param cfg [Verikloak::Audience::Configuration]
+        # @param rails_config [Verikloak::Rails::Configuration]
+        # @return [void]
+        def sync_env_claims_key(cfg, rails_config)
+          return unless rails_config.respond_to?(:user_env_key)
+
+          user_key = rails_config.user_env_key
+          return if blank?(user_key)
+
+          current = cfg.env_claims_key
+          return unless current.nil? || current == Verikloak::Audience::Configuration::DEFAULT_ENV_CLAIMS_KEY
+
+          cfg.env_claims_key = user_key
+        end
+
+        # Populate required audiences from the verikloak-rails configuration when absent.
+        #
+        # @param cfg [Verikloak::Audience::Configuration]
+        # @param rails_config [Verikloak::Rails::Configuration]
+        # @return [void]
+        def sync_required_aud(cfg, rails_config)
+          return unless cfg_required_aud_blank?(cfg)
+          return unless rails_config.respond_to?(:audience)
+
+          audiences = normalized_audiences(rails_config.audience)
+          return if audiences.empty?
+
+          cfg.required_aud = audiences.size == 1 ? audiences.first : audiences
+        end
+
+        # Infer the resource client based on the configured audience when possible.
+        #
+        # @param cfg [Verikloak::Audience::Configuration]
+        # @param rails_config [Verikloak::Rails::Configuration]
+        # @return [void]
+        def sync_resource_client(cfg, rails_config)
+          return unless rails_config.respond_to?(:audience)
+
+          audiences = normalized_audiences(rails_config.audience)
+          return unless audiences.size == 1
+
+          current_client = cfg.resource_client
+          unless blank?(current_client) || current_client == Verikloak::Audience::Configuration::DEFAULT_RESOURCE_CLIENT
+            return
+          end
+
+          cfg.resource_client = audiences.first
+        end
+
+        # Determine whether the audience configuration is effectively empty.
+        #
+        # @param cfg [Verikloak::Audience::Configuration]
+        # @return [Boolean]
+        def cfg_required_aud_blank?(cfg)
+          value_blank?(cfg.required_aud)
+        end
+
+        # Generic blank? helper that tolerates nil, empty, or blank-ish values.
+        #
+        # @param value [Object]
+        # @return [Boolean]
+        def value_blank?(value)
+          return true if value.nil?
+          return true if value.respond_to?(:empty?) && value.empty?
+
+          value.to_s.empty?
+        end
+
+        alias blank? value_blank?
+
+        # Coerce the given source into an array of non-empty string audiences.
+        #
+        # @param source [Object]
+        # @return [Array<String>]
+        def normalized_audiences(source)
+          Array(source).compact.map(&:to_s).reject(&:empty?)
+        end
+      end
     end
   end
 end

data/lib/verikloak/audience/version.rb

@@ -4,6 +4,6 @@ module Verikloak
   module Audience
     # Current gem version.
     # @return [String]
-    VERSION = '0.2.6'
+    VERSION = '0.2.8'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: verikloak-audience
 version: !ruby/object:Gem::Version
-  version: 0.2.6
+  version: 0.2.8
 platform: ruby
 authors:
 - taiyaky
@@ -60,6 +60,7 @@ files:
 - LICENSE
 - README.md
 - lib/generators/verikloak/audience/install/install_generator.rb
+- lib/generators/verikloak/audience/install/templates/initializer.rb.erb
 - lib/verikloak-audience.rb
 - lib/verikloak/audience.rb
 - lib/verikloak/audience/checker.rb
@@ -75,7 +76,7 @@ metadata:
   source_code_uri: https://github.com/taiyaky/verikloak-audience
   changelog_uri: https://github.com/taiyaky/verikloak-audience/blob/main/CHANGELOG.md
   bug_tracker_uri: https://github.com/taiyaky/verikloak-audience/issues
-  documentation_uri: https://rubydoc.info/gems/verikloak-audience/0.2.6
+  documentation_uri: https://rubydoc.info/gems/verikloak-audience/0.2.8
   rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths: