verified_holidays 0.3.1 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c9c851b992fdefecb26db75afbe6c4c04d289ad871e355e481d224fb6218f938
-  data.tar.gz: bcb850940dc6a86e5b72d877765377e1614f26b92b6848588f45a015d3bbaeec
+  metadata.gz: 6daf6bd2f68005f635e997644c83097605f8a3716ea49decc9f756fb020be27a
+  data.tar.gz: 3c7d1e1cdf6a4e7514951e8f6f21dd6a229c17ad2ff201c18793e7af911f1f94
 SHA512:
-  metadata.gz: 341026a59a66206f49f91ac8028abc5f9f780541a3283f17449dee6f630020354e6a208f7f9eec8aed9e1181d658645ef657f013754d28ab967e7483595d62ab
-  data.tar.gz: 8f67f420814c7bfbbc089604522b331656dc5b27432a9c6899b5267abb9a0eb3eabdb1cc1320c120f46167c34752aa737bf9e3fd10d971eb2aca46ec6c22b6e6
+  metadata.gz: 924ed9a8aa2469bac79d3ae9912eb9f042309a8c32b7111d6f3f8a72671bfdd1d10f1d12f7141590e7a1162bbbf6920e430660d42f31e5361a198d085d1beb16
+  data.tar.gz: f9459d943472843c129ba579a8e49ec33c2865415cdc0e24725310a3e45cbfca4415bc25119067ab3b04271464e330a6e485e1d092366e2c0df62dc8397a9828

data/CHANGELOG.md

@@ -1,5 +1,28 @@
 # Changelog
 
+## [0.3.3](https://github.com/verified-holidays/verified_holidays/compare/verified_holidays/v0.3.2...verified_holidays/v0.3.3) (2026-08-22)
+
+
+### Bug Fixes
+
+* add English names for holidays present in the dataset ([#32](https://github.com/verified-holidays/verified_holidays/issues/32)) ([1f92812](https://github.com/verified-holidays/verified_holidays/commit/1f92812aea09b9f27d6034556f0576997bdac1db))
+* raise FetchError on a non-success Cabinet Office response ([#28](https://github.com/verified-holidays/verified_holidays/issues/28)) ([6d55172](https://github.com/verified-holidays/verified_holidays/commit/6d55172f5eac707e54f5039cf2fbed3ea224af08))
+* reject a Cabinet Office response that holds no holidays ([#30](https://github.com/verified-holidays/verified_holidays/issues/30)) ([9040ff5](https://github.com/verified-holidays/verified_holidays/commit/9040ff5f089dcecfdad827f480cac5950663fc99))
+* use YAML.dump when writing holidays.yml ([#31](https://github.com/verified-holidays/verified_holidays/issues/31)) ([be2879b](https://github.com/verified-holidays/verified_holidays/commit/be2879b143408af0764057c1e83343f6e9235a9c))
+
+
+### Miscellaneous
+
+* label docs/ branches from the branch prefix ([#33](https://github.com/verified-holidays/verified_holidays/issues/33)) ([b6867f6](https://github.com/verified-holidays/verified_holidays/commit/b6867f6febe29cfc06d423a4b94a948287437c2e))
+* point the tests label at test/ instead of spec/ ([#35](https://github.com/verified-holidays/verified_holidays/issues/35)) ([f86d05b](https://github.com/verified-holidays/verified_holidays/commit/f86d05b29643c5bdb191aef8b17c72a1874b6f39))
+
+## [0.3.2](https://github.com/verified-holidays/verified_holidays/compare/verified_holidays/v0.3.1...verified_holidays/v0.3.2) (2026-08-22)
+
+
+### Miscellaneous
+
+* write source comments in English ([#26](https://github.com/verified-holidays/verified_holidays/issues/26)) ([aa1879f](https://github.com/verified-holidays/verified_holidays/commit/aa1879f993affaf651f4b8d56277964c617b1f35))
+
 ## [0.3.1](https://github.com/verified-holidays/verified_holidays/compare/verified_holidays/v0.3.0...verified_holidays/v0.3.1) (2026-04-28)
 
 

data/README.md

@@ -54,11 +54,11 @@ VerifiedHolidays.year(2026)
 
 ```ruby
 holiday = VerifiedHolidays.between(Date.new(2026, 1, 1), Date.new(2026, 1, 1)).first
-holiday.date     # => #<Date: 2026-01-01>
-holiday.name     # => "元日"
-holiday.name_en  # => "New Year's Day"
-holiday.wday_name # => "Thursday"
-holiday.week     # => "Thursday" (alias for wday_name)
+holiday.date      # => #<Date: 2026-01-01>
+holiday.name      # => "元日"
+holiday.name_en   # => "New Year's Day"
+holiday.wday_name # => "木"
+holiday.week      # => "木" (alias for wday_name)
 ```
 
 ## Compatibility with holiday_jp
@@ -85,6 +85,11 @@ result.extra       # => entries in Cabinet Office CSV but not in local data
 result.mismatched  # => entries with different names
 ```
 
+If the Cabinet Office responds with anything other than success — an outage, a
+moved file, a redirect — or answers with something that holds no holidays at
+all, `verify!` raises `VerifiedHolidays::CabinetOffice::FetchError` rather than
+reporting the data as mismatched.
+
 Or via Rake:
 
 ```sh

data/lib/verified_holidays/cabinet_office.rb

@@ -9,19 +9,30 @@ module VerifiedHolidays
   class CabinetOffice
     CSV_URL = 'https://www8.cao.go.jp/chosei/shukujitsu/syukujitsu.csv'
 
+    # Raised when the Cabinet Office CSV cannot be retrieved.
+    class FetchError < StandardError; end
+
     def self.fetch
-      uri = URI.parse(CSV_URL)
-      response = Net::HTTP.get(uri)
+      holidays = parse(download_csv)
+      raise FetchError, "#{CSV_URL} returned no holidays" if holidays.empty?
+
+      holidays
+    end
+
+    def self.download_csv
+      response = Net::HTTP.get_response(URI.parse(CSV_URL))
+      unless response.is_a?(Net::HTTPSuccess)
+        raise FetchError, "Failed to fetch #{CSV_URL}: HTTP #{response.code} #{response.message}"
+      end
 
       # Remove UTF-8 BOM bytes if present (before encoding conversion)
-      raw = response.b
+      raw = response.body.b
       raw = raw.byteslice(3..) if raw.byteslice(0, 3) == "\xEF\xBB\xBF".b
 
       # Convert from CP932 (Shift_JIS) to UTF-8
-      utf8 = raw.force_encoding('CP932').encode('UTF-8')
-
-      parse(utf8)
+      raw.force_encoding('CP932').encode('UTF-8')
     end
+    private_class_method :download_csv
 
     def self.presence(str)
       str&.strip&.then { |s| s unless s.empty? }

data/lib/verified_holidays/dataset.rb

@@ -41,7 +41,7 @@ module VerifiedHolidays
     private
 
     def to_date(value)
-      # DateTime は Date のサブクラスだが、明示的に .to_date で Date に変換
+      # DateTime is a subclass of Date, so convert it explicitly with .to_date.
       return value.to_date if value.is_a?(DateTime) || value.is_a?(Time)
       return value if value.is_a?(Date)
 

data/lib/verified_holidays/holiday.rb

@@ -23,12 +23,17 @@ module VerifiedHolidays
       '勤労感謝の日' => 'Labor Thanksgiving Day',
       '振替休日' => 'Substitute Holiday',
       '休日' => "Citizens' Holiday",
+      '休日（祝日扱い）' => 'Public Holiday',
       '体育の日' => 'Health and Sports Day',
+      '体育の日（スポーツの日）' => 'Health and Sports Day (Sports Day)',
       '国民の休日' => "Citizens' Holiday",
+      '即位礼正殿の儀' => 'Enthronement Ceremony',
       '即位礼正殿の儀の行われる日' => 'Enthronement Ceremony',
       '即位の日' => 'Enthronement Day',
       '天皇の即位の日及び即位礼正殿の儀の行われる日を休日とする法律' => 'Holiday by Law',
       'みどりの日（国民の休日）' => "Greenery Day (Citizens' Holiday)",
+      '結婚の儀' => 'Imperial Wedding Ceremony',
+      '大喪の礼' => 'Imperial Funeral Ceremony',
     }.freeze
 
     attr_reader :date, :name

data/lib/verified_holidays/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module VerifiedHolidays
-  VERSION = '0.3.1'
+  VERSION = '0.3.3'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: verified_holidays
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.3
 platform: ruby
 authors:
 - Kenta Ishizaki