verified_double 0.4.1 → 0.4.2

data/CHANGELOG.markdown

@@ -1,3 +1,8 @@
+0.4.2 - 2013-09-28
+------------------
+
+[#25] Fix: cannot mock is_a? on a VerifiedDouble instance double.
+
 0.4.1 - 2013-08-17
 ------------------
 

data/features/CHANGELOG.markdown

@@ -1,3 +1,8 @@
+0.4.2 - 2013-09-28
+------------------
+
+[#25] Fix: cannot mock is_a? on a VerifiedDouble instance double.
+
 0.4.1 - 2013-08-17
 ------------------
 

data/lib/verified_double.rb

@@ -3,6 +3,8 @@ require 'rspec/mocks'
 
 require 'verified_double/boolean'
 require 'verified_double/can_record_interactions'
+require 'verified_double/is_a_class_double'
+require 'verified_double/is_an_instance_double'
 require 'verified_double/matchers'
 require 'verified_double/method_signature'
 require 'verified_double/method_signature/value'
@@ -23,11 +25,15 @@ module VerifiedDouble
 
   def self.of_class(class_name, options = {})
     options[:transfer_nested_constants] = true if options[:transfer_nested_constants].nil?
-    VerifiedDouble.record(stub_const(class_name, Class.new, options))
+    d = stub_const(class_name, Class.new, options)
+    d.extend(VerifiedDouble::IsAClassDouble)
+    VerifiedDouble.record(d)
   end
 
   def self.of_instance(*args)
     d = double(*args)
+    d.extend(VerifiedDouble::IsAnInstanceDouble)
+
     simple_double = SimpleDouble.new(d)
 
     if args[1]

data/lib/verified_double/can_record_interactions.rb

@@ -5,6 +5,10 @@ module VerifiedDouble
       super(*return_values)
     end
 
+    def can_record_interactions?
+      true
+    end
+
     def should_receive(*args)
       VerifiedDouble.registry.add_method_signature(self, args[0])
       super(*args).tap {|result| result.extend(VerifiedDouble::CanRecordInteractions) }
@@ -21,4 +25,4 @@ module VerifiedDouble
       super(*args)
     end
   end
-end
+end

data/lib/verified_double/is_a_class_double.rb

@@ -0,0 +1,8 @@
+module VerifiedDouble
+  module IsAClassDouble
+    def verified_class_double?
+      true
+    end
+  end
+end
+

data/lib/verified_double/is_an_instance_double.rb

@@ -0,0 +1,8 @@
+module VerifiedDouble
+  module IsAnInstanceDouble
+    def verified_instance_double?
+      true
+    end
+  end
+end
+

data/lib/verified_double/method_signature/value.rb

@@ -6,7 +6,7 @@ module VerifiedDouble
       def self.from(content)
         if content == true || content == false
           BooleanValue.new(content)
-        elsif content.is_a?(RSpec::Mocks::Mock)
+        elsif content.respond_to?(:verified_instance_double?) && content.verified_instance_double?
           RspecDoubleValue.new(content)
         elsif content.is_a?(Module)
           ClassValue.new(content)

data/lib/verified_double/rspec_mocks_syntax_overrides.rb

@@ -1,7 +1,7 @@
 module VerifiedDouble
   module RSpecMocksSyntaxOverrides
     def allow(*args)
-      if args[0].is_a?(VerifiedDouble::CanRecordInteractions)
+      if args[0].respond_to?(:can_record_interactions?)
         VerifiedDouble.registry.current_double = args[0]
       else
         VerifiedDouble.registry.current_double = nil
@@ -10,7 +10,7 @@ module VerifiedDouble
     end
 
     def expect(*args)
-      if args[0].is_a?(VerifiedDouble::CanRecordInteractions)
+      if args[0].respond_to?(:can_record_interactions?)
         VerifiedDouble.registry.current_double = args[0]
       else
         VerifiedDouble.registry.current_double = nil

data/lib/verified_double/simple_double.rb

@@ -19,7 +19,7 @@ module VerifiedDouble
     end
 
     def class_double?
-      internal.is_a?(Class)
+      internal.respond_to?(:verified_class_double?)
     end
 
     def method_operator

data/lib/verified_double/version.rb

@@ -1,3 +1,3 @@
 module VerifiedDouble
-  VERSION = "0.4.1"
+  VERSION = "0.4.2"
 end

data/spec/verified_double/method_signature/value_spec.rb

@@ -33,10 +33,26 @@ describe VerifiedDouble::MethodSignature::Value do
     end
 
     context "where content is an rspec mock" do
-      let(:content) { double(:stuff) }
+      let(:content) { VerifiedDouble.of_instance('Stuff') }
       it { expect(subject).to be_a(VerifiedDouble::MethodSignature::RspecDoubleValue) }
     end
 
+    context "where content is an rspec mock mocking its is_a? method",
+      verifies_contract: 'Stuff#is_a?(Class)=>VerifiedDouble::Boolean' do
+
+      let(:content) { VerifiedDouble.of_instance('Stuff') }
+
+      before do
+        expect(content).to receive(:is_a?).with(Object).and_return(true)
+      end
+
+      it { expect(subject).to be_a(VerifiedDouble::MethodSignature::RspecDoubleValue) }
+
+      after do
+        content.is_a?(Object)
+      end
+    end
+
     context "where content is a class double" do
       let(:content){ stub_const(class_name, Class.new, transfer_nested_constants: true) }
 

data/spec/verified_double/simple_double_spec.rb

@@ -5,8 +5,8 @@ describe VerifiedDouble::SimpleDouble do
   end
 
   let(:class_name) {  'Dummy' }
-  let(:some_instance_double) { double(class_name) }
-  let(:some_class_double) { stub_const(class_name, Class.new) }
+  let(:some_instance_double) { VerifiedDouble.of_instance(class_name) }
+  let(:some_class_double) { VerifiedDouble.of_class(class_name) }
 
   let(:simple_instance_double) { described_class.new(some_instance_double) }
   let(:simple_class_double) { described_class.new(some_class_double) }

metadata

@@ -2,14 +2,14 @@
 name: verified_double
 version: !ruby/object:Gem::Version
   prerelease: 
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - George Mendoza
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-17 00:00:00.000000000 Z
+date: 2013-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   type: :runtime
@@ -117,6 +117,8 @@ files:
 - lib/verified_double.rb
 - lib/verified_double/boolean.rb
 - lib/verified_double/can_record_interactions.rb
+- lib/verified_double/is_a_class_double.rb
+- lib/verified_double/is_an_instance_double.rb
 - lib/verified_double/matchers.rb
 - lib/verified_double/method_signature.rb
 - lib/verified_double/method_signature/boolean_value.rb