verified_double 0.0.2 → 0.1.0

data/spec/verified_double_spec.rb

@@ -3,9 +3,9 @@ require 'verified_double'
 
 describe VerifiedDouble do
   describe ".registry" do
-    it "is a array by default" do
+    it "is a array", verifies_contract: 'VerifiedDouble.registry()=>Array' do
       registry = VerifiedDouble.registry
-      expect(registry).to be_a(Array)
+      expect(registry).to be_an(Array)
     end
 
     it "is memoized" do
@@ -13,7 +13,18 @@ describe VerifiedDouble do
     end
   end
 
-  describe ".of_instance(class_name)" do
+  describe ".verified_signatures_from_matchers" do
+    it "is an array", verifies_contract: 'VerifiedDouble.verified_signatures_from_matchers()=>Array' do
+      verified_signatures_from_matchers = VerifiedDouble.verified_signatures_from_matchers
+      expect(verified_signatures_from_matchers).to be_an(Array)
+    end
+
+    it "is memoized" do
+      expect(VerifiedDouble.verified_signatures_from_matchers).to equal(VerifiedDouble.verified_signatures_from_matchers)
+    end
+  end
+
+  describe ".of_instance(class_name, method_stubs={})" do
     let(:class_name){ 'Object' }
 
     let(:subject) { described_class.of_instance(class_name) }
@@ -25,9 +36,19 @@ describe VerifiedDouble do
     end
 
     it "adds the double to the registry" do
-      described_class.registry.clear
       recording_double = subject
-      expect(described_class.registry).to eq([recording_double])
+      expect(described_class.registry.last).to eq(recording_double)
+    end
+
+    context "with method_stubs hash", verifies_contract: 'Object#some_method()=>Symbol' do
+      let(:stubbed_method){ :some_method }
+      let(:assumed_output){ :some_output }
+
+      subject { described_class.of_instance(class_name, some_method: assumed_output) }
+
+      it "stubs the methods of the instance" do
+        expect(subject.send(stubbed_method)).to eq(assumed_output)
+      end
     end
   end
 
@@ -44,9 +65,51 @@ describe VerifiedDouble do
     end
 
     it "adds the double to the registry" do
-      described_class.registry.clear
       recording_double = subject
-      expect(described_class.registry).to eq([recording_double])
+      expect(described_class.registry.last).to eq(recording_double)
+    end
+
+    context "with methods hash", verifies_contract: 'Object.some_method()=>Symbol' do
+      let(:stubbed_method){ :some_method }
+      let(:assumed_output){ :some_output }
+
+      subject { described_class.of_class(class_name, some_method: assumed_output) }
+
+      it "stubs the methods of the class" do
+        expect(subject.send(stubbed_method)).to eq(assumed_output)
+      end
+    end
+  end
+
+  describe ".report_unverified_signatures" do
+    let(:nested_example_group) { double('nested_example_group') }
+    let(:method_signatures_report) { VerifiedDouble.of_instance('VerifiedDouble::MethodSignaturesReport') }
+    let(:method_signatures_report_class) {
+      VerifiedDouble.of_class('VerifiedDouble::MethodSignaturesReport') }
+
+
+    it "builds a method signatures report, determines unverified signatures, and ouputs them" do
+      nested_example_group
+        .stub_chain(:class, :descendant_filtered_examples)
+        .and_return([])
+
+      method_signatures_report_class.should_receive(:new).and_return(method_signatures_report)
+
+      actions = [
+        :set_registered_signatures,
+        :set_verified_signatures_from_tags,
+        :set_verified_signatures_from_matchers,
+        :merge_verified_signatures,
+        :identify_unverified_signatures,
+        :output_unverified_signatures]
+
+      actions.each do |action|
+        method_signatures_report
+          .should_receive(action)
+          .and_return(method_signatures_report)
+      end
+
+      described_class.report_unverified_signatures(nested_example_group)
     end
   end
 end

data/verified_double.gemspec

@@ -18,11 +18,9 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
 
   gem.add_runtime_dependency "rspec"
-  gem.add_runtime_dependency "rspec-fire", '~> 1.1.3'
 
   gem.add_development_dependency "aruba"
   gem.add_development_dependency "cucumber"
   gem.add_development_dependency "pry"
   gem.add_development_dependency "activesupport"
-
 end

metadata

@@ -2,14 +2,14 @@
 name: verified_double
 version: !ruby/object:Gem::Version
   prerelease: 
-  version: 0.0.2
+  version: 0.1.0
 platform: ruby
 authors:
 - George Mendoza
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-22 00:00:00.000000000 Z
+date: 2013-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   type: :runtime
@@ -27,22 +27,6 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
   name: rspec
-- !ruby/object:Gem::Dependency
-  type: :runtime
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.1.3
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.1.3
-  name: rspec-fire
 - !ruby/object:Gem::Dependency
   type: :development
   requirement: !ruby/object:Gem::Requirement
@@ -122,36 +106,32 @@ files:
 - README.md
 - Rakefile
 - features/CHANGELOG.markdown
+- features/accessor_method_contracts.feature
 - features/customizing_arguments_and_return_values.feature
 - features/readme.md
+- features/rspec_mock_compatibility.feature
 - features/step_definitions/verified_double_steps.rb
 - features/support/requires.rb
-- features/verified_double.feature
+- features/verified_mocks.feature
+- features/verified_stubs.feature
 - lib/verified_double.rb
 - lib/verified_double/boolean.rb
-- lib/verified_double/get_registered_signatures.rb
-- lib/verified_double/get_unverified_signatures.rb
-- lib/verified_double/get_verified_signatures.rb
+- lib/verified_double/matchers.rb
 - lib/verified_double/method_signature.rb
 - lib/verified_double/method_signature_value.rb
-- lib/verified_double/output_unverified_signatures.rb
+- lib/verified_double/method_signatures_report.rb
 - lib/verified_double/parse_method_signature.rb
 - lib/verified_double/recording_double.rb
-- lib/verified_double/report_unverified_signatures.rb
-- lib/verified_double/verify_doubles_service.rb
+- lib/verified_double/relays_to_internal_double_returning_self.rb
 - lib/verified_double/version.rb
 - spec/spec_helper.rb
 - spec/unit_helper.rb
-- spec/verified_double/get_registered_signatures_spec.rb
-- spec/verified_double/get_unverified_signatures_spec.rb
-- spec/verified_double/get_verified_signatures_spec.rb
+- spec/verified_double/matchers_spec.rb
 - spec/verified_double/method_signature_spec.rb
 - spec/verified_double/method_signature_value_spec.rb
-- spec/verified_double/output_unverified_signatures_spec.rb
+- spec/verified_double/method_signatures_report_spec.rb
 - spec/verified_double/parse_method_signature_spec.rb
 - spec/verified_double/recording_double_spec.rb
-- spec/verified_double/report_unverified_signatures_spec.rb
-- spec/verified_double/verify_doubles_service_spec.rb
 - spec/verified_double_spec.rb
 - verified_double.gemspec
 homepage: https://www.relishapp.com/gsmendoza/verified-double
@@ -181,22 +161,21 @@ summary: VerifiedDouble would record any mock made in the test suite. It would t
   verify if the mock is valid by checking if there is a test against it.
 test_files:
 - features/CHANGELOG.markdown
+- features/accessor_method_contracts.feature
 - features/customizing_arguments_and_return_values.feature
 - features/readme.md
+- features/rspec_mock_compatibility.feature
 - features/step_definitions/verified_double_steps.rb
 - features/support/requires.rb
-- features/verified_double.feature
+- features/verified_mocks.feature
+- features/verified_stubs.feature
 - spec/spec_helper.rb
 - spec/unit_helper.rb
-- spec/verified_double/get_registered_signatures_spec.rb
-- spec/verified_double/get_unverified_signatures_spec.rb
-- spec/verified_double/get_verified_signatures_spec.rb
+- spec/verified_double/matchers_spec.rb
 - spec/verified_double/method_signature_spec.rb
 - spec/verified_double/method_signature_value_spec.rb
-- spec/verified_double/output_unverified_signatures_spec.rb
+- spec/verified_double/method_signatures_report_spec.rb
 - spec/verified_double/parse_method_signature_spec.rb
 - spec/verified_double/recording_double_spec.rb
-- spec/verified_double/report_unverified_signatures_spec.rb
-- spec/verified_double/verify_doubles_service_spec.rb
 - spec/verified_double_spec.rb
 has_rdoc: 

data/lib/verified_double/get_registered_signatures.rb

@@ -1,11 +0,0 @@
-module VerifiedDouble
-  class GetRegisteredSignatures
-    def initialize(double_registry)
-      @double_registry = double_registry
-    end
-
-    def execute
-      @double_registry.map(&:method_signatures).flatten.uniq
-    end
-  end
-end

data/lib/verified_double/get_unverified_signatures.rb

@@ -1,13 +0,0 @@
-module VerifiedDouble
-  class GetUnverifiedSignatures
-    def initialize(get_registered_signatures, get_verified_signatures)
-      @get_registered_signatures, @get_verified_signatures = get_registered_signatures, get_verified_signatures
-    end
-
-    def execute
-      @get_registered_signatures.execute.select{|registered_signature|
-       @get_verified_signatures.execute.all?{|verified_signature|
-        ! registered_signature.accepts?(verified_signature) } }
-    end
-  end
-end

data/lib/verified_double/get_verified_signatures.rb

@@ -1,17 +0,0 @@
-module VerifiedDouble
-  class GetVerifiedSignatures
-    def initialize(nested_example_group)
-      @nested_example_group = nested_example_group
-    end
-
-    def execute
-      results = @nested_example_group
-        .class
-        .descendant_filtered_examples
-        .map{|example| example.metadata[:verifies_contract] }
-        .compact
-        .uniq
-        .map{|method_signature_string| ParseMethodSignature.new(method_signature_string).execute }
-    end
-  end
-end

data/lib/verified_double/output_unverified_signatures.rb

@@ -1,18 +0,0 @@
-module VerifiedDouble
-  class OutputUnverifiedSignatures
-    def initialize(get_unverified_signatures)
-      @get_unverified_signatures = get_unverified_signatures
-    end
-
-    def execute
-      if unverified_signatures.any?
-        output = ["The following mocks are not verified:" ] + unverified_signatures.map(&:recommended_verified_signature)
-        puts output.join("\n")
-      end
-    end
-
-    def unverified_signatures
-      @unverified_signatures ||= @get_unverified_signatures.execute
-    end
-  end
-end

data/lib/verified_double/report_unverified_signatures.rb

@@ -1,16 +0,0 @@
-module VerifiedDouble
-  class ReportUnverifiedSignatures
-    attr_accessor :double_registry, :nested_example_group
-
-    def initialize(double_registry, nested_example_group)
-      @double_registry, @nested_example_group = double_registry, nested_example_group
-    end
-
-    def execute
-      VerifiedDouble::OutputUnverifiedSignatures.new(
-        VerifiedDouble::GetUnverifiedSignatures.new(
-          VerifiedDouble::GetRegisteredSignatures.new(double_registry),
-          VerifiedDouble::GetVerifiedSignatures.new(nested_example_group))).execute
-    end
-  end
-end

data/lib/verified_double/verify_doubles_service.rb

@@ -1,15 +0,0 @@
-module VerifiedDouble
-  class VerifyDoublesService
-    def initialize(world)
-      @world = world
-    end
-
-    def execute
-      unverified_method_signatures = @world.unverified_method_signatures
-      if unverified_method_signatures.any?
-        output = ["The following mocks are not verified:" ] + unverified_method_signatures
-        puts output.join("\n")
-      end
-    end
-  end
-end

data/spec/verified_double/get_registered_signatures_spec.rb

@@ -1,42 +0,0 @@
-require 'unit_helper'
-require 'verified_double/get_registered_signatures'
-
-describe VerifiedDouble::GetRegisteredSignatures do
-  let(:method_signature_1) {
-    VerifiedDouble::MethodSignature.new(class_name: 'Object', method_operator: '#', method: 'to_s') }
-
-  let(:method_signature_2) {
-    VerifiedDouble::MethodSignature.new(class_name: 'Object', method_operator: '#', method: 'inspect') }
-
-  let(:recording_double_1) {
-    fire_double('VerifiedDouble::RecordingDouble',
-      method_signatures: [method_signature_1]) }
-
-  let(:recording_double_2) {
-    fire_double('VerifiedDouble::RecordingDouble',
-      method_signatures: [method_signature_2]) }
-
-  subject { described_class.new(double_registry) }
-
-  describe "#execute" do
-    context "with multiple recording doubles in the registry" do
-      let(:double_registry){ [recording_double_1, recording_double_2] }
-
-      it "maps and flattens the method signatures of the recording doubles" do
-        expect(subject.execute).to eq([method_signature_1, method_signature_2])
-      end
-    end
-
-    context "with recording doubles with duplicate signatures" do
-      let(:recording_double_2) {
-        fire_double('VerifiedDouble::RecordingDouble',
-          method_signatures: [method_signature_1]) }
-
-      let(:double_registry){ [recording_double_1, recording_double_2] }
-
-      it "returns distinct method signatures" do
-        expect(subject.execute).to eq([method_signature_1])
-      end
-    end
-  end
-end

data/spec/verified_double/get_unverified_signatures_spec.rb

@@ -1,52 +0,0 @@
-require 'unit_helper'
-require 'verified_double/get_unverified_signatures'
-
-describe VerifiedDouble::GetUnverifiedSignatures do
-  let(:get_registered_signatures_service){
-    fire_double('VerifiedDouble::GetRegisteredSignatures') }
-
-  let(:get_verified_signatures_service){
-    fire_double('VerifiedDouble::GetVerifiedSignatures') }
-
-  subject { described_class.new(get_registered_signatures_service, get_verified_signatures_service) }
-
-  describe "#execute" do
-    let(:registered_signature) {
-      VerifiedDouble::MethodSignature.new(
-        class_name: 'Person',
-        method: 'find',
-        method_operator: '.',
-        args: [VerifiedDouble::MethodSignatureValue.new(1)]) }
-
-    let(:registered_signature_without_match) {
-      VerifiedDouble::MethodSignature.new(
-        class_name: 'Person',
-        method: 'save!',
-        method_operator: '#') }
-
-    let(:verified_signature) {
-      VerifiedDouble::MethodSignature.new(
-        class_name: 'Person',
-        method: 'find',
-        method_operator: '.',
-        args: [VerifiedDouble::MethodSignatureValue.new(Object)]) }
-
-    it "retains registered signatures that cannot accept any of the verified_signatures" do
-      expect(registered_signature.accepts?(verified_signature)).to be_true
-      expect(registered_signature_without_match.accepts?(verified_signature)).to be_false
-
-      get_registered_signatures_service
-        .should_receive(:execute)
-        .and_return([registered_signature, registered_signature_without_match])
-
-      get_verified_signatures_service
-        .should_receive(:execute)
-        .at_least(:once)
-        .and_return([verified_signature])
-
-      expect(subject.execute).to eq([registered_signature_without_match])
-    end
-  end
-end
-
-

data/spec/verified_double/get_verified_signatures_spec.rb

@@ -1,63 +0,0 @@
-require 'unit_helper'
-require 'verified_double/get_verified_signatures'
-
-describe VerifiedDouble::GetVerifiedSignatures do
-  let(:method_signature) { VerifiedDouble::MethodSignature.new }
-
-  let(:nested_example_group){ double(:nested_example_group) }
-
-  let(:parse_method_signature_service) {
-    fire_double('VerifiedDouble::ParseMethodSignature') }
-
-  let(:parse_method_signature_service_class) {
-    fire_class_double('VerifiedDouble::ParseMethodSignature').as_replaced_constant }
-
-  subject { described_class.new(nested_example_group) }
-
-  describe "#execute" do
-    let(:example_with_verified_contract_tag){
-      double(:example_with_verified_contract_tag,
-        metadata: { verifies_contract: 'signature' }) }
-
-    let(:example_without_verified_contract_tag){
-      double(:example_without_verified_contract_tag,
-        metadata: { focus: true }) }
-
-    it "filters rspec examples with the tag 'verifies_contract'" do
-      nested_example_group
-        .stub_chain(:class, :descendant_filtered_examples)
-        .and_return([example_with_verified_contract_tag, example_without_verified_contract_tag])
-
-      parse_method_signature_service_class
-        .should_receive(:new)
-        .with(example_with_verified_contract_tag.metadata[:verifies_contract])
-        .and_return(parse_method_signature_service)
-
-      parse_method_signature_service
-        .should_receive(:execute)
-        .and_return(method_signature)
-
-      expect(subject.execute).to eq([method_signature])
-    end
-
-    it "returns unique signatures" do
-      nested_example_group
-        .stub_chain(:class, :descendant_filtered_examples)
-        .and_return([example_with_verified_contract_tag, example_with_verified_contract_tag])
-
-      parse_method_signature_service_class
-        .should_receive(:new)
-        .with(example_with_verified_contract_tag.metadata[:verifies_contract])
-        .at_least(:once)
-        .and_return(parse_method_signature_service)
-
-      parse_method_signature_service
-        .should_receive(:execute)
-        .and_return(method_signature)
-
-      expect(subject.execute).to eq([method_signature])
-    end
-  end
-end
-
-