verifalia 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a9268cdfd8adf22bf8c53aaccb317df2ca89c73d
-  data.tar.gz: 0c875f61b52640e85ea599761af5eba0894d431e
+  metadata.gz: 2c358b49dba6da5733e1237ac5720e346841e86d
+  data.tar.gz: 719bab74ee4ad157eb5ee0dd43c770acd88d7ae6
 SHA512:
-  metadata.gz: 1fba2b844ea0d21a932f734804954ab41b9422ea4554edd340ac297283e463c5b29752cd62065541180c8f1f452e67e50377d3eaa5eebf646679af085ede140d
-  data.tar.gz: f35f86c72f10877bd0de0442241ac93284e5cd4cf49862420b01646f5a19c1d2abcf2a9840509dc6626463398f7051e3b6a5d5ed4a19ddba5c101129383375c5
+  metadata.gz: 4a3229ddab59f599439431eb78da0a2db5f75ce200f8cc1d328d51e19e273da8a91d588d055c7cade4f8059af7a5681c487da79a1a25ae4f413ff7b6a1de27cd
+  data.tar.gz: 868e9a260e23e6f883b9c10ecfb421bb13c9c50a09d17b60238682f04fb47026ec27978500f78e4829a3a5997cdac6534bce6239ccba62495783ddb47a70f828

data/lib/rest/email_validations.rb

@@ -1,4 +1,5 @@
 require 'rest_client'
+require 'json'
 module Verifalia
   module REST
     class EmailValidations
@@ -33,6 +34,7 @@ module Verifalia
           @unique_id = JSON.parse(r)["uniqueID"]
           @response = nil
           @error = nil
+          @query_result = nil
           @unique_id
         rescue => e
           compute_error(e)
@@ -47,17 +49,17 @@ module Verifalia
       #
       def query
         raise ArgumentError, 'You must call verify first or supply and uniqueId' unless @unique_id
-        unless @response
+        if @response == nil || @response.code != 200
           begin
-            r = @resource[@unique_id].get
-            @response = JSON.parse(r)
+            @response = @resource[@unique_id].get
+            @query_result = JSON.parse(@response)
             @error = nil
           rescue => e
             compute_error(e)
             return false
           end
         end
-        @response
+        @query_result
       end
 
       ##
@@ -71,6 +73,7 @@ module Verifalia
           r = @resource[@unique_id].delete
           @error = nil
           @response = nil
+          @query_result = nil
           @unique_id = nil
           true
         rescue => e
@@ -85,7 +88,7 @@ module Verifalia
       #
       def completed?
         query_progress = query["progress"]
-        query_progress["noOfTotalEntries"] == query_progress["noOfCompletedEntries"]
+        @response.code == 200 && query_progress["noOfTotalEntries"] == query_progress["noOfCompletedEntries"]
       end
 
       def error
@@ -119,8 +122,8 @@ module Verifalia
         def build_resource(config, account_sid, account_token)
           api_url = "#{config[:host]}/#{config[:api_version]}/email-validations"
           opts = {
-            user: account_sid, 
-            password: account_token, 
+            user: account_sid,
+            password: account_token,
             headers: { content_type: :json }
           }
           return RestClient::Resource.new api_url, opts

data/lib/verifalia/version.rb

@@ -1,3 +1,3 @@
 module Verifalia
-  VERSION = "1.0.2"
+  VERSION = "1.0.3"
 end

data/spec/rest/email_validations_spec.rb

@@ -8,8 +8,8 @@ describe Verifalia::REST::EmailValidations do
     it 'create RestClient::Resource with correct parameters' do
       api_url = "#{config[:host]}/#{config[:api_version]}/email-validations"
       opts = {
-        user: 'someSid', 
-        password: 'someToken', 
+        user: 'someSid',
+        password: 'someToken',
         headers: { content_type: :json }
       }
 
@@ -35,6 +35,7 @@ describe Verifalia::REST::EmailValidations do
   context 'initialized' do
     let(:resource) { double().as_null_object }
     let(:response) { double().as_null_object }
+    let(:response_json) { double().as_null_object }
     before(:each) do
       @email_validations = Verifalia::REST::EmailValidations.new(config, 'someSid', 'someToken')
       @email_validations.instance_variable_set('@resource', resource)
@@ -55,7 +56,7 @@ describe Verifalia::REST::EmailValidations do
         data = emails.map { |email| { inputData: email }}
         content = { entries: data }.to_json
         expect(resource).to receive(:post).with(content).and_return(response)
-        expect(JSON).to receive(:parse).with(response).and_return(response)
+        expect(JSON).to receive(:parse).with(response).and_return(response_json)
         @email_validations.verify(emails)
       end
 
@@ -144,21 +145,45 @@ describe Verifalia::REST::EmailValidations do
     end
 
     describe '#completed?' do
-      let(:completed_query) do
-        { "progress"=> { "noOfTotalEntries" => 1, "noOfCompletedEntries" => 1 } }
-      end
-      let(:incompleted_query) do
-        { "progress"=> { "noOfTotalEntries" => 0, "noOfCompletedEntries" => 1 } }
+      let(:response) { double().as_null_object }
+
+      before(:each) do
+        @email_validations.instance_variable_set('@response', response)
       end
 
-      it 'should return true if completed' do
-        expect(@email_validations).to receive(:query).and_return(completed_query)
-        expect(@email_validations.completed?).to be true
+
+      context 'with 202 http code response' do
+        before(:each) do
+          allow(response).to receive(:code).and_return(202)
+          allow(@email_validations).to receive(:query).and_return({ "progress" => nil })
+        end
+
+        it 'should return false' do
+          expect(@email_validations.completed?).to be false
+        end
       end
 
-      it 'should return false if not completed' do
-        expect(@email_validations).to receive(:query).and_return(incompleted_query)
-        expect(@email_validations.completed?).to be false
+      context 'with 200 http code response' do
+        let(:completed_query) do
+          { "progress"=> { "noOfTotalEntries" => 1, "noOfCompletedEntries" => 1 } }
+        end
+        let(:incompleted_query) do
+          { "progress"=> { "noOfTotalEntries" => 0, "noOfCompletedEntries" => 1 } }
+        end
+
+        before(:each) do
+          allow(response).to receive(:code).and_return(200)
+        end
+
+        it 'should return true if completed' do
+          allow(@email_validations).to receive(:query).and_return(completed_query)
+          expect(@email_validations.completed?).to be true
+        end
+
+        it 'should return false if not completed' do
+          allow(@email_validations).to receive(:query).and_return(incompleted_query)
+          expect(@email_validations.completed?).to be false
+        end
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: verifalia
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Verifalia