verdict 0.8.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: dd82ab981cc4c81f2b23f45dbfd6085ee4516a70
-  data.tar.gz: 02e7e6e193a70f05ade2cc207f396f7e249a49ae
+SHA256:
+  metadata.gz: ef6e75a9737694176e2d31ed58fe999222189c2f86a30099fd34a2892756b570
+  data.tar.gz: 5010e420ef5cc2bfd79223ba1ef91526fe429d8040272cc2eaa0cf072a05246e
 SHA512:
-  metadata.gz: a5c0c8723feb906c79ceb96358a5fd7d1fd2abc59358a6c430741f275cb8293f84357cda76a885925c7db071864acdb4e0f17b6639c15f60a5b3ad1e4e289f86
-  data.tar.gz: d7c49f872ca05140a5f7b555ea9fddc18b06f749b5b50b9f074f5f921f464b5e253a8039b2f61521334f9c01c65d5059ea2a3e2e3072c6a9b9667ce5ebf2d375
+  metadata.gz: a4389fc051d535c43bd81198023ab8dc38c26eca9805f751f235b3dc08fddcb9d123c70c513751b118c24470303448577047802f86b23f81e18a926218231b8c
+  data.tar.gz: 1b478420092e7fd734e14d11f28a7bfcca6c019a56d8eb4d193b331993a7596e770a25ca0f63e82a648292ca331feffcc18523bbe3799d1db077a98bc1ddbc6d

data/.github/probots.yml

@@ -0,0 +1,2 @@
+enabled:
+  - cla

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## v0.9.0
+**This version has breaking changes**
+* Eagerly load experiment definitions when booting Rails, so that multi-threaded applications do not face a race-condition when populating experiments.
+* Fixes deprecated `assert_equal` tests that return nil.
+
 ## v0.8.0
 **This version has breaking changes**
 

data/README.md

@@ -55,7 +55,7 @@ You'll need to pass along the subject (think User, Product or any other Model cl
 
 ``` ruby
 context = { ... } # anything you want to pass along to the qualify block.
-case Verdict['my experiment'].switch(shop, context)
+case Verdict['my_experiment'].switch(shop, context)
 when :test
   # Handle test group
 when :control

data/lib/verdict/railtie.rb

@@ -12,6 +12,7 @@ class Verdict::Railtie < Rails::Railtie
   config.to_prepare do
     # Clear Verdict's cache in order to avoid "A copy of ... has been removed from the module tree but is still active!"
     Verdict.clear_repository_cache
+    Verdict.discovery
   end
 
   rake_tasks do

data/lib/verdict/version.rb

@@ -1,3 +1,3 @@
 module Verdict
-  VERSION = "0.8.0"
+  VERSION = "0.9.0"
 end

data/test/app/experiments/test_rails_app_experiment.rb

@@ -0,0 +1,10 @@
+Verdict::Experiment.define(:test_rails_app_experiment) do
+  qualify { true }
+
+  groups do
+    group(:test, 4)
+    group(:control, :rest)
+  end
+
+  storage(Verdict::Storage::RedisStorage.new(Redis.current))
+end

data/test/assignment_test.rb

@@ -20,11 +20,11 @@ class AssignmentTest < Minitest::Test
     assert_kind_of Time, assignment.created_at
 
     non_assignment = Verdict::Assignment.new(@experiment, 'test_subject_id', nil, nil)
-    assert_equal nil, non_assignment.group
+    assert_nil non_assignment.group
     assert !non_assignment.returning?
     assert !non_assignment.qualified?
-    assert_equal nil, non_assignment.to_sym
-    assert_equal nil, non_assignment.handle
+    assert_nil non_assignment.to_sym
+    assert_nil non_assignment.handle
     assert_kind_of Time, assignment.created_at
   end
 
@@ -68,7 +68,7 @@ class AssignmentTest < Minitest::Test
       assert_equal 'test_subject_id', json['subject']
       assert_equal false, json['qualified']
       assert_equal false, json['returning']
-      assert_equal nil, json['group']
+      assert_nil json['group']
       assert_equal '2012-01-01T00:00:00Z', json['created_at']
     end
   end

data/test/experiment_test.rb

@@ -34,7 +34,7 @@ class ExperimentTest < Minitest::Test
     non_qualified = e.assign(us_subject)
     assert_kind_of Verdict::Assignment, non_qualified
     refute non_qualified.qualified?
-    assert_equal nil, non_qualified.group
+    assert_nil non_qualified.group
   end
 
   def test_multiple_qualifier
@@ -64,7 +64,7 @@ class ExperimentTest < Minitest::Test
     non_qualified = e.assign(en_subject)
     assert_kind_of Verdict::Assignment, non_qualified
     refute non_qualified.qualified?
-    assert_equal nil, non_qualified.group
+    assert_nil non_qualified.group
   end
 
   module CountryIsCanadaHelper
@@ -101,7 +101,7 @@ class ExperimentTest < Minitest::Test
     non_qualified = e.assign(us_subject)
     assert_kind_of Verdict::Assignment, non_qualified
     refute non_qualified.qualified?
-    assert_equal nil, non_qualified.group
+    assert_nil non_qualified.group
   end
 
   def test_disqualify_empty_identifier
@@ -113,7 +113,7 @@ class ExperimentTest < Minitest::Test
     end
 
     refute e.assign(nil).qualified?
-    assert_equal nil, e.convert('', :mygoal)
+    assert_nil e.convert('', :mygoal)
   end
 
   def test_assignment
@@ -139,7 +139,7 @@ class ExperimentTest < Minitest::Test
 
     assert_equal :a,  e.switch(1)
     assert_equal :b,  e.switch(2)
-    assert_equal nil, e.switch(3)
+    assert_nil e.switch(3)
   end
 
   def test_experiment_without_manual_assignment_timestamps_option

data/test/fake_app.rb

@@ -0,0 +1,12 @@
+require 'rails'
+require "active_model/railtie"
+require "action_controller/railtie"
+require "action_view/railtie"
+require "verdict/railtie"
+
+# Create a rails app
+module Dummy
+  class Application < Rails::Application
+    config.root = "test"
+  end
+end

data/test/rake_tasks_test.rb

@@ -12,7 +12,7 @@ class RakeTasksTest < Minitest::Test
 
   def setup
     require 'rake' unless defined?(Rake)
-    Rake::Task.define_task(:environment) 
+    Rake::Task.define_task(:environment)
     Rake.application.rake_require('verdict/tasks')
 
     @experiment = TestExperiment.define(:rake, store_unqualified: true) do

data/test/segmenters/static_segmenter_test.rb

@@ -20,6 +20,6 @@ class StaticSegmenterTest < Minitest::Test
 
   def test_assigment
     assert_equal @segmenter.groups['beta'], @segmenter.assign('id2', stub(id: 'id2'), nil)
-    assert_equal nil, @segmenter.assign('id3', stub(id: 'id3'), nil)
+    assert_nil @segmenter.assign('id3', stub(id: 'id3'), nil)
   end
 end

data/test/storage/legacy_redis_storage_test.rb

@@ -50,7 +50,8 @@ class LegacyRedisStorageTest < Minitest::Test
     returning_assignment = @experiment.assign('subject_2')
     assert returning_assignment.returning?
     assert_equal new_assignment.experiment, returning_assignment.experiment
-    assert_equal new_assignment.group, returning_assignment.group
+    assert_nil new_assignment.group
+    assert_nil returning_assignment.group
   end
 
   def test_assign_should_return_unqualified_when_redis_is_unavailable_for_reads

data/test/storage/redis_storage_test.rb

@@ -47,7 +47,8 @@ class RedisStorageTest < Minitest::Test
     returning_assignment = @experiment.assign('subject_2')
     assert returning_assignment.returning?
     assert_equal new_assignment.experiment, returning_assignment.experiment
-    assert_equal new_assignment.group, returning_assignment.group
+    assert_nil new_assignment.group
+    assert_nil returning_assignment.group
   end
 
   def test_assign_should_return_unqualified_when_redis_is_unavailable_for_reads

data/test/verdict_rails_test.rb

@@ -0,0 +1,19 @@
+require 'test_helper'
+require 'fake_app'
+
+class VerdictRailsTest < Minitest::Test
+  def setup
+    Verdict.clear_repository_cache
+    new_rails_app = Dummy::Application.new
+    new_rails_app.initialize!
+  end
+
+  def test_verdict_railtie_should_find_directory_path
+    assert_equal Verdict.directory, Rails.root.join('app', 'experiments')
+  end
+
+  def test_verdict_should_eager_load_discovery
+    expected_experiment = Verdict.instance_variable_get('@repository')
+    assert expected_experiment.include?("test_rails_app_experiment")
+  end
+end

data/verdict.gemspec

@@ -22,4 +22,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency("mocha")
   gem.add_development_dependency("timecop")
   gem.add_development_dependency("redis")
+  gem.add_development_dependency("rails")
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: verdict
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-02 00:00:00.000000000 Z
+date: 2019-06-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -80,6 +80,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Shopify Experiments classes
 email:
 - kevin.mcphillips@shopify.com
@@ -88,6 +102,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/probots.yml"
 - ".gitignore"
 - ".travis.yml"
 - CHANGELOG.md
@@ -118,11 +133,13 @@ files:
 - lib/verdict/tasks.rake
 - lib/verdict/version.rb
 - shipit.rubygems.yml
+- test/app/experiments/test_rails_app_experiment.rb
 - test/assignment_test.rb
 - test/conversion_test.rb
 - test/event_logger_test.rb
 - test/experiment_test.rb
 - test/experiments_repository_test.rb
+- test/fake_app.rb
 - test/group_test.rb
 - test/metadata_test.rb
 - test/rake_tasks_test.rb
@@ -135,6 +152,7 @@ files:
 - test/storage/memory_storage_test.rb
 - test/storage/redis_storage_test.rb
 - test/test_helper.rb
+- test/verdict_rails_test.rb
 - verdict.gemspec
 homepage: http://github.com/Shopify/verdict
 licenses: []
@@ -155,17 +173,19 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A library to centrally define experiments for your application, and collect
   assignment information.
 test_files:
+- test/app/experiments/test_rails_app_experiment.rb
 - test/assignment_test.rb
 - test/conversion_test.rb
 - test/event_logger_test.rb
 - test/experiment_test.rb
 - test/experiments_repository_test.rb
+- test/fake_app.rb
 - test/group_test.rb
 - test/metadata_test.rb
 - test/rake_tasks_test.rb
@@ -178,3 +198,4 @@ test_files:
 - test/storage/memory_storage_test.rb
 - test/storage/redis_storage_test.rb
 - test/test_helper.rb
+- test/verdict_rails_test.rb