verdict 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a1929eb3266514c557ec595e7fa7f80065a1b600
-  data.tar.gz: 1f34b0ad26c876f348649ad04d96a9f0c077ea48
+  metadata.gz: dd82ab981cc4c81f2b23f45dbfd6085ee4516a70
+  data.tar.gz: 02e7e6e193a70f05ade2cc207f396f7e249a49ae
 SHA512:
-  metadata.gz: 63801e6ec63ae74dcb33c418090fec977a4598e23da4ff6bc642e2041025915f5ea8eda536ff7c5415dfd18106d1dc1c1fe339b6901b26663b70bfcad4d8803f
-  data.tar.gz: 982e62386331ba13174d3e758a9624ba76b80e45e30ba59f788c65a239585a74abd6386f79622e0dd7314328c0e7843852a01bb6a4b4f7597f6b1d3618f99644
+  metadata.gz: a5c0c8723feb906c79ceb96358a5fd7d1fd2abc59358a6c430741f275cb8293f84357cda76a885925c7db071864acdb4e0f17b6639c15f60a5b3ad1e4e289f86
+  data.tar.gz: d7c49f872ca05140a5f7b555ea9fddc18b06f749b5b50b9f074f5f921f464b5e253a8039b2f61521334f9c01c65d5059ea2a3e2e3072c6a9b9667ce5ebf2d375

data/CHANGELOG.md

@@ -1,3 +1,23 @@
+## v0.8.0
+**This version has breaking changes**
+
+* Experiments that have `store_unqualified` set to `false` will now have previous assignments loaded on `assign` regardless of whether or not the merchant no longer qualifies
+* Here's the change in logic for `assign` based on whether or not the `store_unqualified` flag is on:
+
+Old behaviour:
+
+| store_unqualified                                                           | true | false |
+|-----------------------------------------------------------------------------|------|-------|
+| assignments for subjects that don't qualify are persisted in the database                   | yes  | no    |
+| existing assignments are returned (even if subject doesn't qualify anymore) | yes  | no    |
+
+New behaviour:
+
+| store_unqualified                                                           | true | false |
+|-----------------------------------------------------------------------------|------|-------|
+| assignments for subjects that don't qualify are persisted in the database                   | yes  | no    |
+| existing assignments are returned (even if subject doesn't qualify anymore) | yes  | **yes** |
+
 ## v0.7.0
 **This version has breaking changes**
 

data/lib/verdict/experiment.rb

@@ -26,7 +26,6 @@ class Verdict::Experiment
     instance_eval(&block) if block_given?
   end
 
-
   def subject_type(type = nil)
     return @subject_type if type.nil?
     @subject_type = type
@@ -120,12 +119,17 @@ class Verdict::Experiment
   end
 
   def assign(subject, context = nil)
-    identifier = retrieve_subject_identifier(subject)
-    assignment = if store_unqualified?
-      assignment_with_unqualified_persistence(identifier, subject, context)
-    else
-      assignment_without_unqualified_persistence(identifier, subject, context)
-    end
+    previous_assignment = lookup(subject)
+
+    subject_identifier = retrieve_subject_identifier(subject)
+    assignment = if previous_assignment
+                   previous_assignment
+                 elsif subject_qualifies?(subject, context)
+                   group = segmenter.assign(subject_identifier, subject, context)
+                   subject_assignment(subject, group, nil, group.nil?)
+                 else
+                   nil_assignment(subject)
+                 end
 
     store_assignment(assignment)
   rescue Verdict::StorageError
@@ -225,28 +229,6 @@ class Verdict::Experiment
     assignment.permanent? && !assignment.returning? && (store_unqualified? || assignment.qualified?)
   end
 
-  def assignment_with_unqualified_persistence(subject_identifier, subject, context)
-    previous_assignment = lookup(subject)
-    return previous_assignment unless previous_assignment.nil?
-    if subject_qualifies?(subject, context)
-      group = segmenter.assign(subject_identifier, subject, context)
-      subject_assignment(subject, group, nil, group.nil?)
-    else
-      nil_assignment(subject)
-    end
-  end
-
-  def assignment_without_unqualified_persistence(subject_identifier, subject, context)
-    if subject_qualifies?(subject, context)
-      previous_assignment = lookup(subject)
-      return previous_assignment unless previous_assignment.nil?
-      group = segmenter.assign(subject_identifier, subject, context)
-      subject_assignment(subject, group, nil, group.nil?)
-    else
-      nil_assignment(subject)
-    end
-  end
-
   def subject_identifier(subject)
     subject.respond_to?(:id) ? subject.id : subject.to_s
   end

data/lib/verdict/tasks.rake

@@ -16,7 +16,7 @@ module Verdict
 
     def self.experiment
       experiment_handle = Verdict::Rake.require_env('experiment')
-      Verdict[experiment_handle] or raise "Experiment `#{handle}` not found"
+      Verdict[experiment_handle] or raise "Experiment `#{experiment_handle}` not found"
     end
 
     def self.group

data/lib/verdict/version.rb

@@ -1,3 +1,3 @@
 module Verdict
-  VERSION = "0.7.0"
+  VERSION = "0.8.0"
 end

data/test/experiment_test.rb

@@ -22,7 +22,7 @@ class ExperimentTest < Minitest::Test
 
     subject_stub = Struct.new(:id, :country)
     ca_subject = subject_stub.new(1, 'CA')
-    us_subject = subject_stub.new(1, 'US')
+    us_subject = subject_stub.new(2, 'US')
 
     assert e.qualifiers.all? { |q| q.call(ca_subject) }
     refute e.qualifiers.all? { |q| q.call(us_subject) }
@@ -89,7 +89,7 @@ class ExperimentTest < Minitest::Test
 
     subject_stub = Struct.new(:id, :country)
     ca_subject = subject_stub.new(1, 'CA')
-    us_subject = subject_stub.new(1, 'US')
+    us_subject = subject_stub.new(2, 'US')
 
     assert e.qualifiers.all? { |q| q.call(ca_subject, nil) }
     refute e.qualifiers.all? { |q| q.call(us_subject, nil) }
@@ -153,7 +153,7 @@ class ExperimentTest < Minitest::Test
   def test_experiment_with_manual_assignment_timestamps_option
     e = Verdict::Experiment.new('test', manual_assignment_timestamps: true) do
       groups { group :all, 100 }
-    end   
+    end
 
     assert e.manual_assignment_timestamps?
   end
@@ -166,20 +166,22 @@ class ExperimentTest < Minitest::Test
     assert_raises(Verdict::EmptySubjectIdentifier) { e.retrieve_subject_identifier(stub(to_s: '')) }
   end
 
-  def test_new_unqualified_assignment_without_store_unqualified
+  def test_assignment_without_store_unqualified_always_fetches_old_assignment_if_available
     mock_store, mock_qualifier = Verdict::Storage::MockStorage.new, mock('qualifier')
     e = Verdict::Experiment.new('test') do
       qualify { mock_qualifier.qualifies? }
       storage mock_store, store_unqualified: false
+      groups { group :all, 100 }
     end
 
-    mock_qualifier.expects(:qualifies?).returns(false)
-    mock_store.expects(:retrieve_assignment).never
+    qualified_assignment = e.subject_assignment(mock('identifier'), e.group(:all), Time.now)
+
+    mock_store.expects(:retrieve_assignment).returns(qualified_assignment).once
     mock_store.expects(:store_assignment).never
     e.assign(mock('subject'))
   end
 
-  def test_returning_qualified_assignment_without_store_unqualified
+  def test_new_unqualified_assignment_without_store_unqualified_does_not_store_if_merchant_not_qualified
     mock_store, mock_qualifier = Verdict::Storage::MockStorage.new, mock('qualifier')
     e = Verdict::Experiment.new('test') do
       qualify { mock_qualifier.qualifies? }
@@ -187,9 +189,8 @@ class ExperimentTest < Minitest::Test
       groups { group :all, 100 }
     end
 
-    qualified_assignment = e.subject_assignment(mock('identifier'), e.group(:all), Time.now)
-    mock_qualifier.expects(:qualifies?).returns(true)
-    mock_store.expects(:retrieve_assignment).returns(qualified_assignment).once
+    mock_qualifier.expects(:qualifies?).returns(false)
+    mock_store.expects(:retrieve_assignment).returns(nil).once
     mock_store.expects(:store_assignment).never
     e.assign(mock('subject'))
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: verdict
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-28 00:00:00.000000000 Z
+date: 2017-08-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest