verdict 0.3.2 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e7f6af0cf2210f8a66cdb675286728f39a6728d9
-  data.tar.gz: a9ad8ae9babb3c5bdb01cfce0ae4f9f4cef8cc9d
+  metadata.gz: c1f491060e7463a0121982c8a73c55c164e7a5b1
+  data.tar.gz: 86ec4f4226aae28170ab89a1f9e3b6f4ef7150e3
 SHA512:
-  metadata.gz: 69cb9b3377d9fdbf2345e08e65b194f3e5b5d69d461d3b11a1c92b078f9051cfe153ae356ad4332b15515b0d8ef9c5995d9b567ab9fa0e95b0c0faa5be493c89
-  data.tar.gz: 4dc4b3c36750840dc3b702ee71c041242d68af3ba359fde4bdb5eea24746c6e3a39cc3837bece1959b18f3ca00d3bd604b9fda9c67535c951cdb34d8d3d3a5ea
+  metadata.gz: a139d649a3990f8d2336dbb24ed980edfc344b03c621fee969137b8bd2e063ac0dbfc36801dcda2d044e0a484094da82380dc0e3332e12c9684120e49e7b0e79
+  data.tar.gz: d3c25106668841a418b3e5ee9e95dd929964da20f8b82ed5d85345b9e1d29dd22483f2581d622539bcaef9f1d01b5634d078cc821735c5dae5387247dc0341b0

data/.gitignore

@@ -15,3 +15,4 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+dump.rdb

data/.travis.yml

@@ -5,7 +5,7 @@ rvm:
   - 2.0.0
   - 2.1.0
   - ruby-head
-  - rbx
+  - rbx-2.2.6
   - jruby-19mode
 matrix:
   allow_failures:

data/README.md

@@ -78,7 +78,6 @@ an object that responds to the following methods:
 * `store_assignment(assignment)`
 * `retrieve_assignment(experiment, subject_identifier)`
 * `remove_assignment(experiment, subject_identifier)`
-* `clear_experiment(experiment)`
 * `retrieve_start_timestamp(experiment)`
 * `store_start_timestamp(experiment, timestamp)`
 

data/lib/verdict/experiment.rb

@@ -2,7 +2,7 @@ class Verdict::Experiment
 
   include Verdict::Metadata
 
-  attr_reader :handle, :qualifier, :subject_storage, :event_logger
+  attr_reader :handle, :qualifier, :storage, :event_logger
 
   def self.define(handle, *args, &block)
     experiment = self.new(handle, *args, &block)
@@ -16,7 +16,7 @@ class Verdict::Experiment
     options = default_options.merge(options)
     @qualifier                   = options[:qualifier]
     @event_logger                = options[:event_logger] || Verdict::EventLogger.new(Verdict.default_logger)
-    @subject_storage             = storage(options[:storage] || :memory)
+    @storage                     = storage(options[:storage] || :memory)
     @store_unqualified           = options[:store_unqualified]
     @segmenter                   = options[:segmenter]
     @subject_type                = options[:subject_type]
@@ -57,15 +57,15 @@ class Verdict::Experiment
     @qualifier = block
   end
 
-  def storage(subject_storage = nil, options = {})
-    return @subject_storage if subject_storage.nil?
+  def storage(storage = nil, options = {})
+    return @storage if storage.nil?
 
     @store_unqualified = options[:store_unqualified] if options.has_key?(:store_unqualified)
-    @subject_storage = case subject_storage
+    @storage = case storage
       when :memory; Verdict::Storage::MemoryStorage.new
       when :none;   Verdict::Storage::MockStorage.new
-      when Class;   subject_storage.new
-      else          subject_storage
+      when Class;   storage.new
+      else          storage
     end
   end
 
@@ -75,7 +75,7 @@ class Verdict::Experiment
   end
 
   def started_at
-    @started_at ||= @subject_storage.retrieve_start_timestamp(self)
+    @started_at ||= @storage.retrieve_start_timestamp(self)
   end
 
   def started?
@@ -147,7 +147,7 @@ class Verdict::Experiment
   end    
 
   def store_assignment(assignment)
-    @subject_storage.store_assignment(assignment) if should_store_assignment?(assignment)
+    @storage.store_assignment(assignment) if should_store_assignment?(assignment)
     event_logger.log_assignment(assignment)
     assignment
   end
@@ -157,7 +157,7 @@ class Verdict::Experiment
   end
 
   def remove_subject_assignment_by_identifier(subject_identifier)
-    @subject_storage.remove_assignment(self, subject_identifier)
+    @storage.remove_assignment(self, subject_identifier)
   end
 
   def switch(subject, context = nil)
@@ -172,10 +172,6 @@ class Verdict::Experiment
     fetch_assignment(subject_identifier)
   end
 
-  def wrapup
-    @subject_storage.clear_experiment(self)
-  end
-
   def retrieve_subject_identifier(subject)
     identifier = subject_identifier(subject).to_s
     raise Verdict::EmptySubjectIdentifier, "Subject resolved to an empty identifier!" if identifier.empty?
@@ -213,7 +209,7 @@ class Verdict::Experiment
   end
 
   def fetch_assignment(subject_identifier)
-    @subject_storage.retrieve_assignment(self, subject_identifier)
+    @storage.retrieve_assignment(self, subject_identifier)
   end
 
   def disqualify_empty_identifier?
@@ -262,11 +258,11 @@ class Verdict::Experiment
   end
 
   def set_start_timestamp
-    @subject_storage.store_start_timestamp(self, started_now = Time.now.utc)
+    @storage.store_start_timestamp(self, started_now = Time.now.utc)
     started_now
   end
 
   def ensure_experiment_has_started
-    @started_at ||= @subject_storage.retrieve_start_timestamp(self) || set_start_timestamp
+    @started_at ||= @storage.retrieve_start_timestamp(self) || set_start_timestamp
   end
 end

data/lib/verdict/storage/base_storage.rb

@@ -0,0 +1,72 @@
+module Verdict
+  module Storage
+    class BaseStorage
+
+      # Should store the assignments to allow quick lookups.
+      # - Assignments should be unique on the combination of
+      #   `assignment.experiment.handle` and `assignment.subject_identifier`.
+      # - The main property to store is `group.handle`
+      # - Should return true if stored successfully.
+      def store_assignment(assignment)
+        hash = { group: assignment.handle, created_at: assignment.created_at.strftime('%FT%TZ') }
+        set(assignment.experiment.handle.to_s, "assignment_#{assignment.subject_identifier}", JSON.dump(hash))
+      end
+
+      # Should do a fast lookup of an assignment of the subject for the given experiment.
+      # - Should return nil if not found in store
+      # - Should return an Assignment instance otherwise.
+      def retrieve_assignment(experiment, subject_identifier)
+        if value = get(experiment.handle.to_s, "assignment_#{subject_identifier}")
+          hash = JSON.parse(value)
+          experiment.subject_assignment(
+            subject_identifier,
+            experiment.group(hash['group']),
+            Time.xmlschema(hash['created_at'])
+          )
+        end
+      end
+
+      # Should remove the subject from storage, so it will be reassigned later.
+      def remove_assignment(experiment, subject_identifier)
+        remove(experiment.handle.to_s, "assignment_#{subject_identifier}")
+      end
+
+      # Retrieves the start timestamp of the experiment
+      def retrieve_start_timestamp(experiment)
+        if timestamp = get(experiment.handle.to_s, 'started_at')
+          Time.parse(timestamp)
+        end
+      end
+
+      # Stores the timestamp on which the experiment was started
+      def store_start_timestamp(experiment, timestamp)
+        set(experiment.handle.to_s, 'started_at', timestamp.utc.strftime('%FT%TZ'))
+      end
+
+
+      # Retrieves a key in a given scope from storage.
+      # - The scope and key are both provided as string.
+      # - Should return a string value if the key is found in the scope, nil otherwise.
+      # - Should raise Verdict::StorageError if anything goes wrong.
+      def get(scope, key)
+        raise NotImplementedError
+      end
+
+      # Retrieves a key in a given scope from storage.
+      # - The scope, key, and value are all provided as string.
+      # - Should return true if the item was successfully stored.
+      # - Should raise Verdict::StorageError if anything goes wrong.
+      def set(scope, key, value)
+        raise NotImplementedError
+      end
+
+      # Retrieves a key in a given scope from storage.
+      # - The scope and key are both provided as string.
+      # - Should return true if the item was successfully removed from storage.
+      # - Should raise Verdict::StorageError if anything goes wrong.
+      def remove(scope, key)
+        raise NotImplementedError
+      end
+    end
+  end
+end

data/lib/verdict/storage/legacy_redis_storage.rb

@@ -0,0 +1,57 @@
+module Verdict
+  module Storage
+    class LegacyRedisStorage
+      attr_accessor :redis, :key_prefix
+
+      def initialize(redis = nil, options = {})
+        @redis = redis
+        @key_prefix = options[:key_prefix] || 'experiments/'
+      end
+
+      def retrieve_assignment(experiment, subject_identifier)
+        if value = redis.hget(generate_experiment_key(experiment), subject_identifier)
+          hash = JSON.parse(value)
+          experiment.subject_assignment(
+            subject_identifier,
+            experiment.group(hash['group']),
+            DateTime.parse(hash['created_at']).to_time
+          )
+        end
+      rescue ::Redis::BaseError => e
+        raise Verdict::StorageError, "Redis error: #{e.message}"
+      end
+
+      def store_assignment(assignment)
+        hash = { group: assignment.handle, created_at: assignment.created_at }
+        redis.hset(generate_experiment_key(assignment.experiment), assignment.subject_identifier, JSON.dump(hash))
+      rescue ::Redis::BaseError => e
+        raise Verdict::StorageError, "Redis error: #{e.message}"
+      end
+
+      def remove_assignment(experiment, subject_identifier)
+        redis.hdel(generate_experiment_key(experiment), subject_identifier)
+      end
+
+      def retrieve_start_timestamp(experiment)
+        if started_at = redis.get(generate_experiment_start_timestamp_key(experiment))
+          DateTime.parse(started_at).to_time
+        end
+      end
+
+      def store_start_timestamp(experiment, timestamp)
+        redis.setnx(generate_experiment_start_timestamp_key(experiment), timestamp.to_s)
+      end
+
+
+      private
+
+      def generate_experiment_key(experiment)
+        "#{@key_prefix}#{experiment.handle}"
+      end
+
+      def generate_experiment_start_timestamp_key(experiment)
+        "#{@key_prefix}#{experiment.handle}/started_at"
+      end
+    end
+  end
+end

data/lib/verdict/storage/memory_storage.rb

@@ -1,39 +1,25 @@
 module Verdict
   module Storage
-    class MemoryStorage
-      attr_reader :assignments, :start_timestamps
+    class MemoryStorage < BaseStorage
+      attr_reader :storage
 
       def initialize
-        @assignments = {}
-        @start_timestamps = {}
+        @storage = {}
       end
 
-      def store_assignment(assignment)
-        @assignments[assignment.experiment.handle] ||= {}
-        @assignments[assignment.experiment.handle][assignment.subject_identifier] = assignment.returning
-        true
+      def get(scope, key)
+        @storage[scope] ||= {}
+        @storage[scope][key]
       end
 
-      def retrieve_assignment(experiment, subject_identifier)
-        experiment_store = @assignments[experiment.handle] || {}
-        experiment_store[subject_identifier]
+      def set(scope, key, value)
+        @storage[scope] ||= {}
+        @storage[scope][key] = value
       end
 
-      def remove_assignment(experiment, subject_identifier)
-        @assignments[experiment.handle] ||= {}
-        @assignments[experiment.handle].delete(subject_identifier)
-      end
-
-      def clear_experiment(experiment)
-        @assignments.delete(experiment.handle)
-      end
-
-      def retrieve_start_timestamp(experiment)
-        @start_timestamps[experiment.handle]
-      end
-
-      def store_start_timestamp(experiment, timestamp)
-        @start_timestamps[experiment.handle] = timestamp
+      def remove(scope, key)
+        @storage[scope] ||= {}
+        @storage[scope].delete(key)
       end
     end
   end

data/lib/verdict/storage/mock_storage.rb

@@ -1,37 +1,15 @@
 module Verdict
   module Storage
-    class MockStorage
-      # Should store the assignments to allow quick lookups.
-      # - Assignments should be unique on the combination of
-      #   `assignment.experiment.handle` and `assignment.subject_identifier`.
-      # - The main property to store is `group.handle`
-      # - Should return true if stored successfully.
-      def store_assignment(assignment)
+    class MockStorage < BaseStorage
+      def set(scope, key, value)
         false
       end
 
-      # Should do a fast lookup of an assignment of the subject for the given experiment.
-      # - Should return nil if not found in store
-      # - Should return an Assignment instance otherwise.
-      def retrieve_assignment(experiment, subject_identifier)
+      def get(scope, key)
         nil
       end
 
-      # Should remove the subject from storage, so it will be reassigned later.
-      def remove_assignment(experiment, subject_identifier)
-      end
-
-      # Should clear out the storage used for this experiment
-      def clear_experiment(experiment)
-      end
-
-      # Retrieves the start timestamp of the experiment
-      def retrieve_start_timestamp(experiment)
-        nil
-      end
-
-      # Stores the timestamp on which the experiment was started
-      def store_start_timestamp(experiment, timestamp)
+      def remove(scope, key)
       end
     end
   end

data/lib/verdict/storage/redis_storage.rb

@@ -1,6 +1,6 @@
 module Verdict
   module Storage
-    class RedisStorage
+    class RedisStorage < BaseStorage
       attr_accessor :redis, :key_prefix
 
       def initialize(redis = nil, options = {})
@@ -8,54 +8,28 @@ module Verdict
         @key_prefix = options[:key_prefix] || 'experiments/'
       end
 
-      def retrieve_assignment(experiment, subject_identifier)
-        if value = redis.hget(generate_experiment_key(experiment), subject_identifier)
-          hash = JSON.parse(value)
-          experiment.subject_assignment(
-            subject_identifier,
-            experiment.group(hash['group']),
-            DateTime.parse(hash['created_at']).to_time
-          )
-        end
+      def get(scope, key)
+        redis.hget("#{@key_prefix}#{scope}", key)
       rescue ::Redis::BaseError => e
         raise Verdict::StorageError, "Redis error: #{e.message}"
       end
 
-      def store_assignment(assignment)
-        hash = { group: assignment.handle, created_at: assignment.created_at }
-        redis.hset(generate_experiment_key(assignment.experiment), assignment.subject_identifier, JSON.dump(hash))
+      def set(scope, key, value)
+        redis.hset("#{@key_prefix}#{scope}", key, value)
       rescue ::Redis::BaseError => e
         raise Verdict::StorageError, "Redis error: #{e.message}"
       end
 
-      def remove_assignment(experiment, subject_identifier)
-        redis.hdel(generate_experiment_key(experiment), subject_identifier)
-      end
-
-      def clear_experiment(experiment)
-        redis.del(generate_experiment_key(experiment))
-        redis.del(generate_experiment_start_timestamp_key(experiment))
-      end
-
-      def retrieve_start_timestamp(experiment)
-        if started_at = redis.get(generate_experiment_start_timestamp_key(experiment))
-          DateTime.parse(started_at).to_time
-        end
-      end
-
-      def store_start_timestamp(experiment, timestamp)
-        redis.setnx(generate_experiment_start_timestamp_key(experiment), timestamp.to_s)
+      def remove(scope, key)
+        redis.hdel("#{@key_prefix}#{scope}", key)
+      rescue ::Redis::BaseError => e
+        raise Verdict::StorageError, "Redis error: #{e.message}"
       end
 
-
       private
 
-      def generate_experiment_key(experiment)
-        "#{@key_prefix}#{experiment.handle}"
-      end
-
-      def generate_experiment_start_timestamp_key(experiment)
-        "#{@key_prefix}#{experiment.handle}/started_at"
+      def generate_scope_key(scope)
+        "#{@key_prefix}#{scope}"
       end
     end
   end

data/lib/verdict/storage.rb

@@ -1,3 +1,5 @@
+require 'verdict/storage/base_storage'
 require 'verdict/storage/mock_storage'
 require 'verdict/storage/memory_storage'
 require 'verdict/storage/redis_storage'
+require 'verdict/storage/legacy_redis_storage'

data/lib/verdict/version.rb

@@ -1,3 +1,3 @@
 module Verdict
-  VERSION = "0.3.2"
+  VERSION = "0.4.0"
 end

data/shipit.rubygems.yml

@@ -0,0 +1 @@
+# using the default shipit config

data/test/conversion_test.rb

@@ -19,7 +19,7 @@ class ConversionTest < Minitest::Test
   end
 
   def test_assignment_lookup
-    @experiment.subject_storage.expects(:retrieve_assignment).with(@experiment, 'test_subject_id')
+    @experiment.storage.expects(:retrieve_assignment).with(@experiment, 'test_subject_id')
     conversion = Verdict::Conversion.new(@experiment, 'test_subject_id', :test_goal)
     conversion.assignment
   end

data/test/experiment_test.rb

@@ -278,8 +278,8 @@ class ExperimentTest < Minitest::Test
       groups { group :all, 100 }
     end
 
-    e.subject_storage.expects(:retrieve_start_timestamp).returns(nil)
-    e.subject_storage.expects(:store_start_timestamp).once
+    e.storage.expects(:retrieve_start_timestamp).returns(nil)
+    e.storage.expects(:store_start_timestamp).once
     e.send(:ensure_experiment_has_started)
   end
 
@@ -289,8 +289,8 @@ class ExperimentTest < Minitest::Test
     end
 
     e.send(:ensure_experiment_has_started)
-    e.subject_storage.expects(:retrieve_start_timestamp).never
-    e.subject_storage.expects(:store_start_timestamp).never
+    e.storage.expects(:retrieve_start_timestamp).never
+    e.storage.expects(:store_start_timestamp).never
     e.send(:ensure_experiment_has_started)
   end
 
@@ -299,8 +299,8 @@ class ExperimentTest < Minitest::Test
       groups { group :all, 100 }
     end
 
-    e.subject_storage.expects(:retrieve_start_timestamp).returns(Time.now.utc)
-    e.subject_storage.expects(:store_start_timestamp).never
+    e.storage.expects(:retrieve_start_timestamp).returns(Time.now.utc)
+    e.storage.expects(:store_start_timestamp).never
     e.send(:ensure_experiment_has_started)
   end
 

data/test/storage/{redis_subject_storage_test.rb → legacy_redis_storage_test.rb}

@@ -1,11 +1,11 @@
 require 'test_helper'
 
-class RedisSubjectStorageTest < Minitest::Test
+class LegacyRedisStorageTest < Minitest::Test
 
   def setup
     @redis = ::Redis.new(host: REDIS_HOST, port: REDIS_PORT)
-    @storage = storage = Verdict::Storage::RedisStorage.new(@redis)
-    @experiment = Verdict::Experiment.new(:redis_storage) do
+    @storage = storage = Verdict::Storage::LegacyRedisStorage.new(@redis)
+    @experiment = Verdict::Experiment.new(:legacy_redis_storage) do
       qualify { |s| s == 'subject_1' }
       groups { group :all, 100 }
       storage storage, store_unqualified: true
@@ -13,11 +13,12 @@ class RedisSubjectStorageTest < Minitest::Test
   end
 
   def teardown
-    @storage.clear_experiment(@experiment)
+    @redis.del('experiments/legacy_redis_storage')
+    @redis.del('experiments/legacy_redis_storage/started_at')
   end
 
   def test_generate_experiment_key_should_generate_namespaced_key
-    assert_equal 'experiments/redis_storage', @storage.send(:generate_experiment_key, @experiment)
+    assert_equal 'experiments/legacy_redis_storage', @storage.send(:generate_experiment_key, @experiment)
   end
 
   def test_store_and_retrieve_qualified_assignment
@@ -70,14 +71,6 @@ class RedisSubjectStorageTest < Minitest::Test
     assert !@redis.hexists(experiment_key, 'subject_3')
   end
 
-  def test_clear_experiment
-    experiment_key = @storage.send(:generate_experiment_key, @experiment)
-    new_assignment = @experiment.assign('subject_3')
-    assert @redis.exists(experiment_key)
-    @experiment.wrapup
-    assert !@redis.exists(experiment_key)
-  end
-
   def test_started_at
     key = @storage.send(:generate_experiment_start_timestamp_key, @experiment)
 

data/test/storage/{memory_subject_storage_test.rb → memory_storage_test.rb}

@@ -1,6 +1,6 @@
 require 'test_helper'
 
-class MemorySubjectStorageTest < Minitest::Test
+class MemoryStorageTest < Minitest::Test
 
   def setup
     @storage = storage = Verdict::Storage::MemoryStorage.new
@@ -12,12 +12,6 @@ class MemorySubjectStorageTest < Minitest::Test
     @subject = stub(id: 'bootscale')
   end
 
-  def test_wrapup
-    @experiment.assign(@subject)
-    @experiment.wrapup
-    assert @experiment.lookup(@subject).nil?
-  end
-
   def test_with_memory_store
     assignment_1 = @experiment.assign(@subject)
     assignment_2 = @experiment.assign(@subject)
@@ -32,14 +26,18 @@ class MemorySubjectStorageTest < Minitest::Test
   end
 
   def test_remove_assignment
-    assert !@experiment.assign(@subject).returning?
-    @experiment.wrapup
+    assignment = @experiment.assign(@subject)
+    assert !assignment.returning?
+
+    assert @experiment.assign(@subject).returning?
+    @storage.remove_assignment(@experiment, @subject.id)
     assert !@experiment.assign(@subject).returning?
   end
 
   def test_started_at
-    assert @storage.start_timestamps[@experiment.handle].nil?
+    assert @storage.get(@experiment.handle.to_s, 'started_at').nil?
     @experiment.send(:ensure_experiment_has_started)
-    assert @storage.start_timestamps[@experiment.handle].instance_of?(Time)
+    refute @storage.get(@experiment.handle.to_s, 'started_at').nil?
+    assert_instance_of Time, @experiment.started_at
   end
 end

data/test/storage/redis_storage_test.rb

@@ -0,0 +1,76 @@
+require 'test_helper'
+
+class RedisStorageTest < Minitest::Test
+
+  def setup
+    @redis = ::Redis.new(host: REDIS_HOST, port: REDIS_PORT)
+    @storage = storage = Verdict::Storage::RedisStorage.new(@redis)
+    @experiment = Verdict::Experiment.new(:redis_storage) do
+      qualify { |s| s == 'subject_1' }
+      groups { group :all, 100 }
+      storage storage, store_unqualified: true
+    end
+  end
+
+  def teardown
+    @redis.del('experiments/redis_storage')
+  end
+
+  def experiment_key
+    'experiments/redis_storage'
+  end
+
+  def test_store_and_retrieve_qualified_assignment
+    refute @redis.hexists(experiment_key, 'assignment_subject_1')
+
+    new_assignment = @experiment.assign('subject_1')
+    assert new_assignment.qualified?
+    refute new_assignment.returning?
+
+    assert @redis.hexists(experiment_key, 'assignment_subject_1')
+
+    returning_assignment = @experiment.assign('subject_1')
+    assert returning_assignment.returning?
+    assert_equal new_assignment.experiment, returning_assignment.experiment
+    assert_equal new_assignment.group, returning_assignment.group
+  end
+
+  def test_store_and_retrieve_unqualified_assignment
+    refute @redis.hexists(experiment_key, 'assignment_subject_2')
+
+    new_assignment = @experiment.assign('subject_2')
+
+    refute new_assignment.returning?
+    refute new_assignment.qualified?
+    assert @redis.hexists(experiment_key, 'assignment_subject_2')
+
+    returning_assignment = @experiment.assign('subject_2')
+    assert returning_assignment.returning?
+    assert_equal new_assignment.experiment, returning_assignment.experiment
+    assert_equal new_assignment.group, returning_assignment.group
+  end
+
+  def test_assign_should_return_unqualified_when_redis_is_unavailable_for_reads
+    @redis.stubs(:hget).raises(::Redis::BaseError, "Redis is down")
+    assert !@experiment.assign('subject_1').qualified?
+  end
+
+  def test_assign_should_return_unqualified_when_redis_is_unavailable_for_writes
+    @redis.stubs(:hset).raises(::Redis::BaseError, "Redis is down")
+    assert !@experiment.assign('subject_1').qualified?
+  end
+
+  def test_remove_subject_assignment
+    @experiment.assign('subject_3')
+    assert @redis.hexists(experiment_key, 'assignment_subject_3')
+    @experiment.remove_subject_assignment('subject_3')
+    refute @redis.hexists(experiment_key, 'assignment_subject_3')
+  end
+
+  def test_started_at
+    refute @redis.hexists(experiment_key, "started_at")
+    a = @experiment.send(:ensure_experiment_has_started)
+    assert @redis.hexists(experiment_key, "started_at")
+    assert_equal a, @experiment.started_at
+  end
+end

metadata

@@ -1,105 +1,83 @@
 --- !ruby/object:Gem::Specification
 name: verdict
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.4.0
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
-cert_chain:
-- |
-  -----BEGIN CERTIFICATE-----
-  MIIDcDCCAligAwIBAgIBATANBgkqhkiG9w0BAQUFADA/MQ8wDQYDVQQDDAZhZG1p
-  bnMxFzAVBgoJkiaJk/IsZAEZFgdzaG9waWZ5MRMwEQYKCZImiZPyLGQBGRYDY29t
-  MB4XDTE0MDUxNTIwMzM0OFoXDTE1MDUxNTIwMzM0OFowPzEPMA0GA1UEAwwGYWRt
-  aW5zMRcwFQYKCZImiZPyLGQBGRYHc2hvcGlmeTETMBEGCgmSJomT8ixkARkWA2Nv
-  bTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAL0/81O3e1vh5smcwp2G
-  MpLQ6q0kejQLa65bPYPxdzWA1SYOKyGfw+yR9LdFzsuKpwWzKq6zX35lj1IckWS4
-  bNBEQzxmufUxU0XPM02haFB8fOfDJzdXsWte9Ge4IFwahwn68gpMqN+BvxL+KMYz
-  Iut9YmN44d4LZdsENEIO5vmybuG2vYDz7R56qB0PA+Q2P2CdhymsBad2DQs69FBo
-  uico9V6VMYYctL9lCYdzu9IXrOYNTt88suKIVzzAlHOKeN0Ng5qdztFoTR8sfxDr
-  Ydg3KHl5n47wlpgd8R0f/4b5gGxW+v9pyJCgQnLlRu7DedVSvv7+GMtj3g9r3nhJ
-  KqECAwEAAaN3MHUwCQYDVR0TBAIwADALBgNVHQ8EBAMCBLAwHQYDVR0OBBYEFI/o
-  maf34HXbUOQsdoLHacEKQgunMB0GA1UdEQQWMBSBEmFkbWluc0BzaG9waWZ5LmNv
-  bTAdBgNVHRIEFjAUgRJhZG1pbnNAc2hvcGlmeS5jb20wDQYJKoZIhvcNAQEFBQAD
-  ggEBADkK9aj5T0HPExsov4EoMWFnO+G7RQ28C30VAfKxnL2UxG6i4XMHVs6Xi94h
-  qXFw1ec9Y2eDUqaolT3bviOk9BB197+A8Vz/k7MC6ci2NE+yDDB7HAC8zU6LAx8Y
-  Iqvw7B/PSZ/pz4bUVFlTATif4mi1vO3lidRkdHRtM7UePSn2rUpOi0gtXBP3bLu5
-  YjHJN7wx5cugMEyroKITG5gL0Nxtu21qtOlHX4Hc4KdE2JqzCPOsS4zsZGhgwhPs
-  fl3hbtVFTqbOlwL9vy1fudXcolIE/ZTcxQ+er07ZFZdKCXayR9PPs64heamfn0fp
-  TConQSX2BnZdhIEYW+cKzEC/bLc=
-  -----END CERTIFICATE-----
-date: 2014-05-16 00:00:00.000000000 Z
+cert_chain: []
+date: 2014-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '5.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '5.2'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: redis
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Shopify Experiments classes
@@ -110,8 +88,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".travis.yml"
+- .gitignore
+- .travis.yml
 - Gemfile
 - LICENSE
 - README.md
@@ -131,12 +109,14 @@ files:
 - lib/verdict/segmenters/rollout_segmenter.rb
 - lib/verdict/segmenters/static_segmenter.rb
 - lib/verdict/storage.rb
+- lib/verdict/storage/base_storage.rb
+- lib/verdict/storage/legacy_redis_storage.rb
 - lib/verdict/storage/memory_storage.rb
 - lib/verdict/storage/mock_storage.rb
 - lib/verdict/storage/redis_storage.rb
 - lib/verdict/tasks.rake
 - lib/verdict/version.rb
-- shipit.yml
+- shipit.rubygems.yml
 - test/assignment_test.rb
 - test/conversion_test.rb
 - test/event_logger_test.rb
@@ -149,8 +129,10 @@ files:
 - test/segmenters/random_percentage_segmenter_test.rb
 - test/segmenters/rollout_segmenter_test.rb
 - test/segmenters/static_segmenter_test.rb
-- test/storage/memory_subject_storage_test.rb
-- test/storage/redis_subject_storage_test.rb
+- test/storage/base_storage_test.rb
+- test/storage/legacy_redis_storage_test.rb
+- test/storage/memory_storage_test.rb
+- test/storage/redis_storage_test.rb
 - test/test_helper.rb
 - verdict.gemspec
 homepage: http://github.com/Shopify/verdict
@@ -162,17 +144,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: A library to centrally define experiments for your application, and collect
@@ -190,6 +172,8 @@ test_files:
 - test/segmenters/random_percentage_segmenter_test.rb
 - test/segmenters/rollout_segmenter_test.rb
 - test/segmenters/static_segmenter_test.rb
-- test/storage/memory_subject_storage_test.rb
-- test/storage/redis_subject_storage_test.rb
+- test/storage/base_storage_test.rb
+- test/storage/legacy_redis_storage_test.rb
+- test/storage/memory_storage_test.rb
+- test/storage/redis_storage_test.rb
 - test/test_helper.rb

data/shipit.yml

@@ -1,15 +0,0 @@
-dependencies:
-  override:
-    - bundle install --path=./data/bundler
-
-deploy:
-  override:
-    - |
-      BUILD=`bundle exec rake build`
-      if [ $? != 0 ]; then
-        echo $BUILD;
-        exit 1;
-      fi
-      PKG=`echo $BUILD | cut -d" " -f5 | sed -e s/\.$//`;
-      VERSION=`bundle exec rake build | cut -d" " -f2`;
-      gem push $PKG

metadata.gz.sig

@@ -1,3 +0,0 @@
-_����F�HL��oR^�aa�G���K��6W���l�k����o�V<!��?g/Ϲ�;�'J�.�S��l�m����;���B"��#�J��a���jN��ה�Ӈ���[
KQP�
�
-�
-���7�
'O��
H��5ڋ�