verdict 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8efebedf53fee289950045fc2396359440dc0e15
-  data.tar.gz: 94bba89fe604abab1cd2f60b45b66bff0424ee75
+  metadata.gz: ad853660b0d33894ee603240d466111f9d451112
+  data.tar.gz: e304f2bf2f68695e90be81aa9b10dceb24bb3603
 SHA512:
-  metadata.gz: 538a77d48203d92c91a42072d9f64e60f9ab3b1d8ee857d380bfcd61328c73f1d9d96682db1a5dbb1c43c8ae4d52c57b38d156863408b77673b879c17ac4fa1a
-  data.tar.gz: c9535d06da2da5bef7a547b9565515f227dc8789d5d690d0b68867a5b5b6835a6dcf7645ee2dfa7a37d072d47cb22b932a0d014bc51c83dc4cff3734de03a0f0
+  metadata.gz: e60e581e4a84de8ed7acede5131765c2ab95ffb4a90cf97c65e5d65b28157b289057b451317a4ff155b4ab48b4d64104f2b7973cc8486b4880711fc4287026b0
+  data.tar.gz: 89c30e1b36f5b247607210a25fa29939e500346012167ab0c04295bb313dbea144bd2109e70d4b269dde0680ac9a10be0e741de6c8faedbedc52f704b2d328c7

data/lib/verdict/segmenters/fixed_percentage_segmenter.rb

@@ -26,7 +26,7 @@ module Verdict
       end
 
       def assign(identifier, subject, context)
-        percentile = Digest::MD5.hexdigest("#{@experiment.handle}#{identifier}").to_i(16) % 100
+        percentile = Digest::MD5.hexdigest("#{@experiment.handle}#{identifier}#{self.class.salt}").to_i(16) % 100
         groups.values.find { |group| group.percentile_range.include?(percentile) }
       end
 
@@ -51,6 +51,10 @@ module Verdict
           super(options).merge(percentage: percentage_size)
         end
       end
+
+      class << self
+        attr_accessor :salt
+      end
     end
   end
 end

data/lib/verdict/segmenters/random_percentage_segmenter.rb

@@ -0,0 +1,18 @@
+module Verdict
+  module Segmenters
+    class RandomPercentageSegmenter < FixedPercentageSegmenter
+
+      attr_accessor :random
+
+      def initialize(*args)
+        super
+        @random = Random.new
+      end
+
+      def assign(identifier, subject, context)
+        percentile = @random.rand(100)
+        groups.values.find { |group| group.percentile_range.include?(percentile) }
+      end
+    end
+  end
+end

data/lib/verdict/segmenters.rb

@@ -1,4 +1,5 @@
 require 'verdict/segmenters/base_segmenter'
 require 'verdict/segmenters/static_segmenter'
 require 'verdict/segmenters/fixed_percentage_segmenter'
+require 'verdict/segmenters/random_percentage_segmenter'
 require 'verdict/segmenters/rollout_segmenter'

data/lib/verdict/version.rb

@@ -1,3 +1,3 @@
 module Verdict
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

data/test/segmenters/fixed_percentage_segmenter_test.rb

@@ -85,4 +85,25 @@ class FixedPercentageSegmenterTest < Minitest::Test
     assert_equal 'rest', json['handle']
     assert_equal 67, json['percentage']
   end
+
+  def test_salt_changes_segmentation
+    s = Verdict::Segmenters::FixedPercentageSegmenter.new(Verdict::Experiment.new('test'))
+    s.group :a, 50
+    s.group :b, 50
+    s.verify!
+
+    groups = { 'a' => 0, 'b' => 0 }
+    100.times { |n| groups[s.assign(n.to_s, nil, nil).handle] += 1 }
+
+    assert_equal 54, groups['a']
+    assert_equal 46, groups['b']
+
+    Verdict::Segmenters::FixedPercentageSegmenter.stubs(:salt).returns("whatever")
+
+    groups = { 'a' => 0, 'b' => 0 }
+    100.times { |n| groups[s.assign(n.to_s, nil, nil).handle] += 1 }
+
+    assert_equal 50, groups['a']
+    assert_equal 50, groups['b']
+  end
 end

data/test/segmenters/random_percentage_segmenter_test.rb

@@ -0,0 +1,37 @@
+require 'test_helper'
+
+class RandomPercentageSegmenterTest < Minitest::Test
+
+  def setup
+    @segmenter = Verdict::Segmenters::RandomPercentageSegmenter.new(Verdict::Experiment.new('test'))
+    @segmenter.group :segment1, 50
+    @segmenter.group :segment2, 50
+    @segmenter.verify!
+  end
+
+  def test_random_assignment
+    @segmenter.random = Random.new(1)
+
+    groups = { segment1: 0, segment2: 0 }
+    100.times do |n|
+      group = @segmenter.assign(n.to_s, nil, nil)
+      groups[group.handle.to_sym] += 1
+    end
+
+    assert_equal 54, groups[:segment1]
+    assert_equal 46, groups[:segment2]
+  end
+
+  def test_random_assignment_with_different_seed
+    @segmenter.random = Random.new(2)
+
+    groups = { segment1: 0, segment2: 0 }
+    100.times do |n|
+      group = @segmenter.assign(n.to_s, nil, nil)
+      groups[group.handle.to_sym] += 1
+    end
+
+    assert_equal 44, groups[:segment1]
+    assert_equal 56, groups[:segment2]
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: verdict
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-27 00:00:00.000000000 Z
+date: 2014-03-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -105,6 +105,7 @@ files:
 - lib/verdict/segmenters.rb
 - lib/verdict/segmenters/base_segmenter.rb
 - lib/verdict/segmenters/fixed_percentage_segmenter.rb
+- lib/verdict/segmenters/random_percentage_segmenter.rb
 - lib/verdict/segmenters/rollout_segmenter.rb
 - lib/verdict/segmenters/static_segmenter.rb
 - lib/verdict/storage.rb
@@ -122,6 +123,7 @@ files:
 - test/metadata_test.rb
 - test/rake_tasks_test.rb
 - test/segmenters/fixed_percentage_segmenter_test.rb
+- test/segmenters/random_percentage_segmenter_test.rb
 - test/segmenters/rollout_segmenter_test.rb
 - test/segmenters/static_segmenter_test.rb
 - test/storage/memory_subject_storage_test.rb
@@ -147,7 +149,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: A library to centrally define experiments for your application, and collect
@@ -162,9 +164,9 @@ test_files:
 - test/metadata_test.rb
 - test/rake_tasks_test.rb
 - test/segmenters/fixed_percentage_segmenter_test.rb
+- test/segmenters/random_percentage_segmenter_test.rb
 - test/segmenters/rollout_segmenter_test.rb
 - test/segmenters/static_segmenter_test.rb
 - test/storage/memory_subject_storage_test.rb
 - test/storage/redis_subject_storage_test.rb
 - test/test_helper.rb
-has_rdoc: