verdict 0.16.0 → 0.16.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c8ad702f655cca4734df9f1019f7df665cbe04914468bdcb07ae2a5e9fcc27ca
-  data.tar.gz: f31057b426bb631a36d99bc9a6f1588078b0009909ad25c2f5daa2180a407d66
+  metadata.gz: a6d20d61b4b74ae3cdc111f872f18c6bcedf9165bed983dfc489d826edad4e99
+  data.tar.gz: 5a23b9b6b678b0e7c7ccdd8c4df24f6029ee6f5c8a3ba16e9850147974b0a490
 SHA512:
-  metadata.gz: 1ac4f9f4cef8e978fc36ea7848cee6b4ab15cb895d57598388f4b42997f141189a51c511f4a4b877f254b8a0d32909a153aa00da8b7e42940dbaed6d7ec9e4ec
-  data.tar.gz: f03f49ca42347dc3bf54c0ab449df49df32e6b5fc175392e3259b4e238324de03406f64d38a17e8744f662ec9543319a41bebec0df12031f9f0ab03bb05253c2
+  metadata.gz: 3c931d20970cb9a75a8f9780d6648493dbf6ca2a5a9eb61f79f35896063b603b36f611cc1e6175710075d0271afad9f73efd795b09eb55c63848dc67def3a68c
+  data.tar.gz: '0599822d437c5e7e512a0a75e64312aaf97008d0ae31b75bacab6bdc8361a0750b22f9e14f31d70c7b41df771c20267a2719e883a0394b161e1d4367901252d7'

data/.github/workflows/ci.yml

@@ -0,0 +1,39 @@
+name: CI
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby:
+          - 2.5
+          - 2.6
+          - 2.7
+          - head
+          - jruby
+    services:
+      redis:
+        image: redis
+        options: >-
+          --health-cmd "redis-cli ping"
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
+        ports:
+          - 6379:6379
+    name: Tests Ruby ${{ matrix.ruby }}
+    steps:
+      - uses: actions/checkout@v1
+      - name: Set up Ruby ${{ matrix.ruby }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+      - name: Run tests
+        run: |
+          gem install bundler
+          bundle install --jobs 4 --retry 3
+          bundle exec rake
+        env:
+          REDIS_HOST: localhost

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## v0.16.1
+* Change `RedisStorage` scrub to be iterative to avoid SystemStackError while cleaning big experiments
+
 ## v0.16.0
 * Allow configuring the `RedisStorage` with a [`ConnectionPool`](https://github.com/mperham/connection_pool) instead of a raw `Redis` connection.
 

data/Gemfile

@@ -2,7 +2,6 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in experiments.gemspec
 gemspec
-gem "rubysl", platform: :rbx
 gem "json", platform: :rbx
 
 group :development do

data/dev.yml

@@ -0,0 +1,11 @@
+name: verdict
+
+type: ruby
+
+up:
+  - ruby: 2.7.1
+  - bundler
+
+commands:
+  test:
+    run: rake test

data/lib/verdict/storage/redis_storage.rb

@@ -67,15 +67,17 @@ module Verdict
       end
 
       def scrub(scope, cursor: 0)
-        cursor, results = redis.with do |conn|
-          conn.hscan(scope_key(scope), cursor, count: PAGE_SIZE)
-        end
+        loop do
+          cursor, results = redis.with do |conn|
+            conn.hscan(scope_key(scope), cursor, count: PAGE_SIZE)
+          end
 
-        results.map(&:first).each do |key|
-          remove(scope, key)
-        end
+          results.map(&:first).each do |key|
+            remove(scope, key)
+          end
 
-        scrub(scope, cursor: cursor) unless cursor.to_i.zero?
+          break if cursor.to_i.zero?
+        end
       end
     end
   end

data/lib/verdict/version.rb

@@ -1,3 +1,3 @@
 module Verdict
-  VERSION = "0.16.0"
+  VERSION = "0.16.1"
 end

data/test/storage/cookie_storage_test.rb

@@ -6,7 +6,9 @@ require 'fake_app'
 class CookieStorageTest < Minitest::Test
   def setup
     @storage = Verdict::Storage::CookieStorage.new.tap do |s|
-      s.cookies = ActionDispatch::Cookies::CookieJar.new(nil)
+      request = mock()
+      request.stubs(:cookies_same_site_protection).returns(proc { :none })
+      s.cookies = ActionDispatch::Cookies::CookieJar.new(request)
     end
     @experiment = Verdict::Experiment.new(:cookie_storage_test) do
       groups { group :all, 100 }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: verdict
 version: !ruby/object:Gem::Version
-  version: 0.16.0
+  version: 0.16.1
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-22 00:00:00.000000000 Z
+date: 2020-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -117,14 +117,15 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".github/probots.yml"
+- ".github/workflows/ci.yml"
 - ".gitignore"
-- ".travis.yml"
 - CHANGELOG.md
 - CONTRIBUTING.md
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
+- dev.yml
 - docs/concepts.md
 - lib/verdict.rb
 - lib/verdict/assignment.rb

data/.travis.yml

@@ -1,16 +0,0 @@
-language: ruby
-cache: bundler
-before_install: gem update bundler
-script: bundle exec rake
-rvm:
-  - 2.5
-  - 2.6
-  - 2.7
-  - ruby-head
-  - jruby
-matrix:
-  allow_failures:
-    - rvm: ruby-head
-    - rvm: jruby
-services:
-  - redis-server