verdict 0.15.1 → 0.15.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 27eea30b628bf29627fe68762f18dea365ebc77d0ac34e8b1b63f24e29814276
-  data.tar.gz: 65a0cb4ae9247c75bdcff094a7546e673cda0d05f8a922c48ed7f448deb931b7
+  metadata.gz: 50c44fd8fcc0cf5605c9d21fd5eefcd4dddeffeb03c48e7ec046639d7154715b
+  data.tar.gz: d55759fff1145aa793f9ae42232518130ba93efcb5fb62a2f7cbfa24d0322a0f
 SHA512:
-  metadata.gz: 813097404fecc5c3f44121d68b5da2cb0213fcbadfa4b5b20c451286577b6d7e35900e636582fe3d4b1d6b95c6df3916da9e89ded291d042f11f963a8a58e895
-  data.tar.gz: ea1e6b44880d6a6dd085173abf4155f5e8605272d6d679c8dea8a71259d5b7b8f86b62adc39afb49e40126ef8cd547efda8904214a3d51f5881f96030498e028
+  metadata.gz: 8ed63a2aaf52ebffe454da41e3022e87df834b80130cb0ab14902466ea6d630ce9d046e1b202e32fc6491a2dc9974f4f825f50aaa14aa862103888f31d5c3df6
+  data.tar.gz: 12c379615c6593caf46749157ebca884d91fb17a97d81b7fc60c53cd3531785a0a0c078e79e4b387cd21676f26d55962e0a2ab1ba0caeacb5d99208c3f1e8f8d

data/.travis.yml

@@ -3,9 +3,9 @@ cache: bundler
 before_install: gem update bundler
 script: bundle exec rake
 rvm:
-  - 2.0
-  - 2.1
-  - 2.3.3
+  - 2.5
+  - 2.6
+  - 2.7
   - ruby-head
   - jruby
 matrix:

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## v0.15.2
+* Fix edge case where inheriting from `Verdict::Experiment` and overriding `subject_qualifies?` resulted in an error.
+
 ## v0.15.1
 * Make the `dynamic_qualifies` parameter in `Verdict::Experiment#subject_qualifies?` optional. This fixes a bug where users that were previously calling this method directly experienced issues after v0.15.0
 

data/lib/verdict/experiment.rb

@@ -148,7 +148,7 @@ class Verdict::Experiment
     subject_identifier = retrieve_subject_identifier(subject)
     assignment = if previous_assignment
       previous_assignment
-    elsif subject_qualifies?(subject, dynamic_qualifiers, context) && is_make_new_assignments?
+    elsif dynamic_subject_qualifies?(subject, dynamic_qualifiers, context) && is_make_new_assignments?
       group = segmenter.assign(subject_identifier, subject, context)
       subject_assignment(subject, group, nil, group.nil?)
     else
@@ -243,7 +243,7 @@ class Verdict::Experiment
     @disqualify_empty_identifier
   end
 
-  def subject_qualifies?(subject, dynamic_qualifiers = [], context = nil)
+  def subject_qualifies?(subject, context = nil, dynamic_qualifiers: [])
     ensure_experiment_has_started
     return false unless dynamic_qualifiers.all? { |qualifier| qualifier.call(subject) }
     everybody_qualifies? || @qualifiers.all? { |qualifier| qualifier.call(subject, context) }
@@ -295,4 +295,15 @@ class Verdict::Experiment
   def is_make_new_assignments?
     return !(@schedule_stop_new_assignment_timestamp && @schedule_stop_new_assignment_timestamp <= Time.now)
   end
+
+  # Used when a Experiment class has overridden the subject_qualifies? method prior to v0.15.0
+  # The previous version of subject_qualifies did not accept dynamic qualifiers, thus this is used to
+  # determine how many parameters to pass
+  def dynamic_subject_qualifies?(subject, dynamic_qualifiers, context)
+    if method(:subject_qualifies?).parameters.include?([:key, :dynamic_qualifiers])
+      subject_qualifies?(subject, context, dynamic_qualifiers: dynamic_qualifiers)
+    else
+      subject_qualifies?(subject, context)
+    end
+  end
 end

data/lib/verdict/version.rb

@@ -1,3 +1,3 @@
 module Verdict
-  VERSION = "0.15.1"
+  VERSION = "0.15.2"
 end

data/test/experiment_test.rb

@@ -668,15 +668,31 @@ class ExperimentTest < Minitest::Test
     custom_qualifier_a = Proc.new { |subject| subject.even? }
     custom_qualifier_b = Proc.new { |subject| subject > 0 }
 
-    e.switch(subject, qualifiers: [custom_qualifier_a, custom_qualifier_b])
-
     group = e.switch(subject, qualifiers: [custom_qualifier_a, custom_qualifier_b])
     assert_nil group
   end
 
+  def test_dynamic_subject_qualifies_call_overridden_method
+    e = MyExperiment.new('test') do
+      groups do
+        group :all, 100
+      end
+    end
+
+    group = e.switch(4)
+    assert_nil group
+  end
+
   private
 
   def redis
     @redis ||= ::Redis.new(host: REDIS_HOST, port: REDIS_PORT)
   end
 end
+
+class MyExperiment < Verdict::Experiment
+  def subject_qualifies?(subject, context = nil)
+    return false if subject.even?
+    super
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: verdict
 version: !ruby/object:Gem::Version
-  version: 0.15.1
+  version: 0.15.2
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-08 00:00:00.000000000 Z
+date: 2020-07-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest