verdict 0.1.0 → 0.1.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MDEzN2VlY2MyNGUyZmQ0MzY2YWViYTQ5NmRjMmVhZjUzMmFjZDNlYg==
+    ZDNjZTFjMmI3OTZlMDQyOTlkYTdjYzU5ZmNhZjMxYjcxODVhYmZmMQ==
   data.tar.gz: !binary |-
-    YmVlMzgxMDAxZDRjOGI2NmI0MzY2OTNkYzkxOGY2Y2VmNjFkM2EyMg==
+    MGU5YWNkZDY2YmIzNjhmZDAwNjFkODIzZGI0MGRmZjMwMWEwYzFlZg==
 SHA512:
   metadata.gz: !binary |-
-    MzJhMDlmYTRiMjI4NTRiZDI5ZGM4YWY2MTNkNTQxNzFiYjZkZDdkNGE1MmJm
-    NDdjZTEzMWU1NTBmNDllNDJhODRhYTcxYTNiYTgwOTI2NjA5ZmIyYTVlN2E1
-    ZjZjNzVkZGQyNTBlNGFiNDYzYmI2YTFjOWU4MDRmZWQzMjk2MjE=
+    MDI2ZDI3OTVhYjljZjU1Y2NiNDAyMWMwYTIyMTU1NTgwZGNhNTEzNWI0Nzdl
+    ZWYwNGM2MDA1ODE3ZWE5ZjFkOGZlZmI5MWRkY2IxOTI2ZDQ4MzZjNTA4N2Ex
+    MmYxZmNhMmYzOGM3Y2FkNTFiMDhmMTQ1ZjUwMzBjZjE2ZTViMGU=
   data.tar.gz: !binary |-
-    MGZmYTI3ODA4ZGMzMzhlMTM4ZThlYWZkMGU3NWE3YWYzZmY4NzY2ZDk0OGQ2
-    ZDEyYTUzN2VhYmU4MTdlNjRlY2M4OWI1MmJlOWMwNmZhMDRkMzg0OWQ2NGE1
-    ZGEwMmY3ODFjNDUwNjdlNGZmMDM4NmUyOWRjMmRlZGFiMjM4NTQ=
+    YTYxYTM4NGMxNjUwOWUyM2ZkYjI2NTZhOTFmOGRlYjMzMWQ1ZjU4YmIzOTUy
+    ZDQ2OTA0ZjNmZmY1OWJjMWVlOTI3NjliNzFmNmRkZjBkYzQ3NjNhNDIyODE1
+    NjQxYmM0YjI3MGE1MTc0N2E4NWQ2MjczMDRhYmM0N2I1YTAxZDk=

data/README.md

@@ -1,4 +1,4 @@
-# Verdict
+# Verdict [![Build Status](https://travis-ci.org/Shopify/verdict.png)](https://travis-ci.org/Shopify/verdict)
 
 This library allows you to define and use experiments in your application.
 
@@ -17,7 +17,7 @@ Add this line to your application's Gemfile, and run `bundle install`:
 
 ## Usage
 
-This gem contains the `Experiments::Experiment` model used create the experiment instance,
+This gem contains the `Verdict::Experiment` model used create the experiment instance,
 in order consistently modify application behaviour based on an object's unique key. 
 
 Define an experiment like so:
@@ -40,7 +40,7 @@ end
 ```
 
 Usually you want to place this in a file called **my_experiment.rb** in the 
-**/app/experiments** folder. Also, usually you want to subclass `Experiments::Experiment` 
+**/app/experiments** folder. Also, usually you want to subclass `Verdict::Experiment` 
 to set some default options for your app's environment, and call `define` on that class
 instead.
 
@@ -48,7 +48,7 @@ Refer to the experiment elsewhere in your codebase like this:
 
 ``` ruby
 context = { ... } # anything you want to pass along to the qualify block. 
-case Experiments['my experiment'].switch(shop, context)
+case Verdict['my experiment'].switch(shop, context)
 when :test
   # Handle test group
 when :control
@@ -71,12 +71,12 @@ an object that responds to the following tho methods:
 
 In which `experiment` is the Experiment instance, `subject_identifier` is a  
 string that uniquely identifies the subject, and `assignment` is an
-`Experiment::Assignment` instance. By default it will use `subject.id.to_s` as
+`Verdict::Assignment` instance. By default it will use `subject.id.to_s` as
 `subject_identifier`, but you can change that by overriding the 
 `def subject_identifier(subject)` method on the experiment.
 
-The library will also log every assignment to `Experiments.logger`. The Railtie
-sets `Experiment.logger` to `Rails.logger`, so experiment assignments will show
+The library will also log every assignment to `Verdict.logger`. The Railtie
+sets `Verdict.logger` to `Rails.logger`, so experiment assignments will show
 up in your Rails log. You can override the logging by overriding the 
 `def log_assignment(assignment)` method on the experiment.
 

data/lib/verdict/experiment.rb

@@ -14,12 +14,14 @@ class Verdict::Experiment
     @handle = handle.to_s
 
     options = default_options.merge(options)
-    @qualifier         = options[:qualifier]
-    @event_logger      = options[:event_logger] || Verdict::EventLogger.new(Verdict.default_logger)
-    @subject_storage   = options[:storage] || Verdict::Storage::MemoryStorage.new
-    @store_unqualified = options[:store_unqualified]
-    @segmenter         = options[:segmenter]
-    @subject_type      = options[:subject_type]
+    @qualifier                   = options[:qualifier]
+    @event_logger                = options[:event_logger] || Verdict::EventLogger.new(Verdict.default_logger)
+    @subject_storage             = options[:storage] || Verdict::Storage::MemoryStorage.new
+    @store_unqualified           = options[:store_unqualified]
+    @segmenter                   = options[:segmenter]
+    @subject_type                = options[:subject_type]
+    @disqualify_empty_identifier = options[:disqualify_empty_identifier]
+
     instance_eval(&block) if block_given?
   end
 
@@ -83,6 +85,8 @@ class Verdict::Experiment
     conversion = subject_conversion(identifier, goal)
     event_logger.log_conversion(conversion)
     conversion
+  rescue Verdict::EmptySubjectIdentifier
+    raise unless disqualify_empty_identifier?
   end
 
   def assign(subject, context = nil)
@@ -96,6 +100,16 @@ class Verdict::Experiment
     store_assignment(assignment)
   rescue Verdict::StorageError
     subject_assignment(identifier, nil, nil)
+  rescue Verdict::EmptySubjectIdentifier
+    if disqualify_empty_identifier?
+      subject_assignment(identifier, nil, nil)
+    else
+      raise
+    end
+  end
+
+  def disqualify_empty_identifier?
+    @disqualify_empty_identifier
   end
 
   def disqualify(subject)

data/lib/verdict/version.rb

@@ -1,3 +1,3 @@
 module Verdict
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/test/experiment_test.rb

@@ -37,6 +37,18 @@ class ExperimentTest < MiniTest::Unit::TestCase
     assert_equal nil, non_qualified.group
   end
 
+  def test_disqualify_empty_identifier
+    e = Verdict::Experiment.new('test', disqualify_empty_identifier: true) do
+      groups do
+        group :a, :half
+        group :b, :rest
+      end
+    end
+
+    assert !e.assign(nil).qualified?
+    assert_equal nil, e.convert('', :mygoal)
+  end
+
   def test_assignment
     e = Verdict::Experiment.new('test') do
       qualify { |subject| subject <= 2 }
@@ -46,6 +58,8 @@ class ExperimentTest < MiniTest::Unit::TestCase
       end
     end
 
+    assert_raises(Verdict::EmptySubjectIdentifier) { e.assign(nil) }
+
     assignment = e.assign(1)
     assert_kind_of Verdict::Assignment, assignment
     assert assignment.qualified?

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: verdict
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-17 00:00:00.000000000 Z
+date: 2014-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest