veracodecli 1.0.10 → 1.0.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 47a755b1783a8f5003057b7eec2a7c730df092da
-  data.tar.gz: 9879f64e287e149bdc8f7eecbb52dde685506f40
+  metadata.gz: 2b1a71295f50c1b317d7d7d3725479f1a6788daf
+  data.tar.gz: 61cb73f9560e48e6b84bab0327ee0d171b46a187
 SHA512:
-  metadata.gz: 6bad75a2293677e42e44152c2a52079f0d85aeebddba63bdd877f992b3279a2cdc59884a2950f9fb69e173892e04d0eaa6c70654c6ceb04608b861880a92f565
-  data.tar.gz: 0d7937a40cd678398a984b50708bbed3286bb9d2fe0a598fa349c17e4c520990f9e2e68c56f10491328ddbc9b11cde1bfd45e839631641d17d6af791a17c57be
+  metadata.gz: e30d4a55f21dba97daceb6fc90605fee934a0ca8fd21aee31d6b477a7d73cdf8765160082b9a434d97e0a5bde806a2e9517e560b21bb8bf01bc1d8f67ab44b63
+  data.tar.gz: 5695acabe10bf20fcfcdab7a912c2442a44e44c62bb8b305364e9b68116694999c3e7cf8d20c45fd96f90d9f9d44c6e371b8ea71d15950f70e9c323c89fe29eb

data/VERSION

@@ -1 +1 @@
-1.0.10
+1.0.11

data/lib/veracodecli/api.rb

@@ -2,6 +2,7 @@ require 'json'
 require 'active_support/core_ext/hash'
 require 'rest-client'
 require 'yaml'
+require 'nokogiri'
 require_relative 'settings'
 require_relative 'log'
 
@@ -9,9 +10,9 @@ module VeracodeApiBase
   def veracode_api_request(api_call, api_version: '4.0', **params)
     begin
       response = RestClient.get "https://#{Settings.veracode_username}:#{Settings.veracode_password}@analysiscenter.veracode.com/api/#{api_version}/#{api_call}", { params: params }
-      log = ResponseLogger.new "/home/#{ENV['USER']/veracodecli_data}"
+      log = ResponseLogger.new "/tmp"
       log.log api_call, response.code, response.body
-    rescue
+    rescue RestClient
       abort '401: Unauthorized. Veracode API call Failed, please check your veracode credentials or whitelisted IPs'
     end
     if [500,501,502,503].any?{|code| response.code == code} then abort 'Internal server error.' end
@@ -27,6 +28,28 @@ module VeracodeApiBase
     end
     `cd /tmp; zip -r sast_upload.zip sast_clone`
   end
+
+  def response_parse_app_id(response, app_name)
+    app_id = nil
+    doc = Nokogiri::XML response
+    doc.remove_namespaces!
+    if doc.xpath('//app').empty? then return nil end
+    doc.xpath('//app').each do |app|
+      if app.attributes['app_name'].value == app_name then app_id = app.attributes['app_id'].value end
+    end
+    app_id
+  end
+
+  def parse_new_app_id(response)
+    app_id = nil
+    doc = Nokogiri::XML response
+    doc.remove_namespaces!
+    if doc.xpath('//application').empty? then return nil end
+    doc.xpath('//application').each do |application|
+      app_id = application.attributes['app_id'].value
+    end
+    app_id
+  end
 end
 
 module VeracodeApiScan
@@ -34,22 +57,13 @@ module VeracodeApiScan
 
   def get_app_id(app_name)
     app_list = veracode_api_request 'getapplist.do', include_user_info: 'true'
-    scan = app_list.body.scan(/app_id=\"(.+)\" app_name=\"#{app_name}\"/)
-    if scan.empty?
-      app_id = scan[0][0]
-    else
-      app_id = nil
-    end
+    app_id = response_parse_app_id app_list.body, app_name
   end
 
   def create_app_profile(app_name, business_criticality, business_unit, team)
     create_app_response = veracode_api_request 'createapp.do', app_name: app_name, business_criticality: business_criticality, business_unit: business_unit, teams: team
-    scan = create_app_response.body.scan(/app_id=\"(.+)\" app_name=\"#{app_name}\"/)
-    if scan.empty?
-      fail 'createapp failed. Make sure you have supplied the correct parameters.'
-    else
-      app_id = scan[0][0]
-    end
+    app_id = parse_new_app_id create_app_response.body
+    if app_id.nil? then abort 'createapp failed. Check the logs.' end
   end
 
   def upload_file(app_id, archive_path)

data/lib/veracodecli/log.rb

@@ -7,14 +7,19 @@ class ResponseLogger
   end
 
   def log(call, code, response)
+    check_log_file "#{@path}/veracodecli.log"
     log = File.open "#{@path}/veracodecli.log", 'a+'
     log.write "#{call} called @ #{timestamp}"
-    log.write "HTTP #{code}"
+    log.write "HTTP #{code}\n"
     log.write response
     log.write "\n"
     log.close
   end
 
+  def check_log_file(file_path)
+    File.open file_path, 'w' unless File.exist? file_path
+  end
+
   def timestamp
     `date`
   end

data/veracodecli.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: veracodecli 1.0.10 ruby lib
+# stub: veracodecli 1.0.11 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "veracodecli"
-  s.version = "1.0.10"
+  s.version = "1.0.11"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["isaiah thiessen"]
-  s.date = "2015-11-03"
+  s.date = "2015-11-04"
   s.description = "Ruby based CLI for accessing veracode's api"
   s.email = "isaiah.thiessen@telus.com"
   s.executables = ["veracodecli"]
@@ -37,7 +37,6 @@ Gem::Specification.new do |s|
     "test/API.rb",
     "test/helper.rb",
     "test/test_veracodecli.rb",
-    "veracodecli-1.0.9.gem",
     "veracodecli.gemspec"
   ]
   s.homepage = "http://github.com/isand3r/veracodecli"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: veracodecli
 version: !ruby/object:Gem::Version
-  version: 1.0.10
+  version: 1.0.11
 platform: ruby
 authors:
 - isaiah thiessen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-03 00:00:00.000000000 Z
+date: 2015-11-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -246,7 +246,6 @@ files:
 - test/API.rb
 - test/helper.rb
 - test/test_veracodecli.rb
-- veracodecli-1.0.9.gem
 - veracodecli.gemspec
 homepage: http://github.com/isand3r/veracodecli
 licenses: