venus_media_library 1.1.0 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 53f9b683221215b76b95f0248dd87938ebba0a7066c36ccc7b02dc23fece50e0
-  data.tar.gz: acf9d06d3f9a7712568f9f05c9584ccc9fda2772de1bcad6e1b2090c1cf07e8f
+  metadata.gz: c419936bf15b299264f23527fa0d74f57860c031e279ada4cb04608a7d55e9d9
+  data.tar.gz: a6f877818f76baf0c43ad806109b981ba63e896ab53dcd01c6b855baf708f439
 SHA512:
-  metadata.gz: e1d247beff66e7d45750fcfa96813cdcb0bb7ed5a2cb0eb500486602f4b8354001ffc280fe399fbb504ad094b2e97b3715cb578b29e2aabce34d34b82fd4037f
-  data.tar.gz: e8928ccd013a969ff08cfef454886735297e5a74d84acc9b66a09335be91ede3a1a9f4f3dfbe59ede7a3b16acc4438b461b73b8c43c550e5ce01e989555b2999
+  metadata.gz: 4d4cd43c0e4b6945eac1bc77b9009b949e3b42bfcb3e9d241f1dc1fad99e5a623a9c0947525e6216ba5edf1d952fb0560405397b56600dc11748da1c89eb701b
+  data.tar.gz: 3c7794fb4b5f9ca228a12c8f78cb526c5e8d5a580beaeb6f7316cdc22fb464b46907dff569bb5b799419a5b1c9ff2e91b79db9040b134de29cb88e1a2f707596

data/CHANGELOG.md

@@ -4,6 +4,25 @@ All notable changes to this project are documented here. The format is based on
 [Keep a Changelog](https://keepachangelog.com/en/1.1.0/) and this project adheres
 to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.1.2] - 2026-08-19
+
+### Changed
+- The default admin predicate now recognises both the `admin?` **and**
+  `is_admin?` conventions (and returns non-admin for `nil`) instead of assuming
+  `admin?`. A host whose user model uses `is_admin?` no longer needs to set
+  `config.admin` just to avoid a `NoMethodError` from the role-gated library nav.
+  Any other scheme remains fully configurable via `config.admin`.
+
+## [1.1.1] - 2026-08-19
+
+### Fixed
+- The picker now hands host URL fields (via `media_picker_field`, e.g. an
+  `og:image`) an **absolute, public** Active Storage URL (honoring
+  `config.url_type`) instead of the relative, owner-gated `/…/assets/:id` engine
+  route. Since 1.0.0 that route was not fetchable by external crawlers, silently
+  breaking og:image, social cards, and image SEO. In-admin grid thumbnails keep
+  using the gated route, and owner-scoped access is unchanged.
+
 ## [1.1.0] - 2026-08-18
 
 ### Added

data/app/helpers/venus_media_library/images_helper.rb

@@ -19,16 +19,36 @@ module VenusMediaLibrary
       }
     end
 
-    # Permanent URL to the original file. Active Storage route helpers live on the
-    # host app, so they are reached through the `main_app` proxy. With
-    # url_type = :proxy the URL streams through Rails (works for private buckets
-    # and external crawlers); the default :redirect 302s to the storage URL.
+    # Permanent, PUBLIC URL to the original file — this is the value the picker
+    # writes into a host URL field (e.g. a page's og:image), so it must be
+    # absolute and fetchable by external crawlers (Facebook/Google/Twitter) with
+    # no session. It therefore uses Rails' public Active Storage routes, NOT the
+    # engine's owner-gated `asset_path` (an anonymous crawler hitting that route
+    # is bounced by the host's `authenticate_with` gate, silently breaking
+    # og:image / social cards). Owner-scoping still governs WHICH assets a member
+    # can SEE in the library (see visible_media_assets); it is orthogonal to the
+    # public URL a picked asset resolves to. Active Storage route helpers live on
+    # the host app, so they are reached through the `main_app` proxy. With
+    # url_type = :proxy the URL streams through Rails (works for private buckets);
+    # the default :redirect 302s to the storage URL. Mirrors PickerHelper's
+    # attach-mode preview so URL fields and attachment fields agree.
     def ml_blob_url(asset)
-      venus_media_library.asset_path(asset)
+      if VenusMediaLibrary.configuration.url_type == :proxy
+        main_app.rails_storage_proxy_url(asset.blob)
+      else
+        main_app.rails_blob_url(asset.blob)
+      end
+    rescue StandardError
+      # Last resort only: a relative path keeps the admin grid rendering when a
+      # URL host is unavailable. Absolute public URLs above are what host URL
+      # fields need; this fallback should not be the stored og:image value.
+      main_app.rails_blob_path(asset.blob)
     end
 
-    # Small variant used for the grid thumbnail. Falls back to the original URL
-    # when the blob can't be variated (e.g. SVG).
+    # Small variant used for the in-admin grid thumbnail. This runs behind the
+    # engine's auth in the admin library UI, so the owner-scoped engine route is
+    # correct here (it also honors the per-tenant visibility rules). Only the
+    # picked `url` above needs to be public.
     def ml_thumb_url(asset)
       venus_media_library.thumbnail_asset_path(asset)
     end

data/lib/venus_media_library/version.rb

@@ -1,3 +1,3 @@
 module VenusMediaLibrary
-  VERSION = "1.1.0"
+  VERSION = "1.1.2"
 end

data/lib/venus_media_library.rb

@@ -62,6 +62,18 @@ module VenusMediaLibrary
     # does not enumerate a cloud bucket or expose storage-provider credentials.
     attr_accessor :cloud_assets
 
+    # Default admin predicate. A gem shouldn't break just because a host app names
+    # its flag differently, so try the two common conventions — `admin?` then
+    # `is_admin?` — and fall back to non-admin. Hosts with any other scheme set
+    # their own `config.admin = ->(user) { ... }`.
+    DEFAULT_ADMIN = lambda do |user|
+      return false if user.nil?
+      return !!user.admin? if user.respond_to?(:admin?)
+      return !!user.is_admin? if user.respond_to?(:is_admin?)
+
+      false
+    end
+
     def initialize
       @allowed_content_types = %w[image/png image/jpeg image/jpg image/gif image/webp image/svg+xml]
       @thumbnail_size        = [ 300, 300 ]
@@ -71,7 +83,7 @@ module VenusMediaLibrary
       @url_type              = :redirect
       @authenticate_with     = nil
       @current_user          = -> { current_user }
-      @admin                 = ->(user) { user.admin? }
+      @admin                 = DEFAULT_ADMIN
       @asset_scope           = ->(scope) { scope }
       @legacy_blob_scope     = ->(scope) { scope.none }
       @static_assets         = -> { [] }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: venus_media_library
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.2
 platform: ruby
 authors:
 - Good Works On Earth