ventable 0.0.6 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 081c78cd805ad7b5dce14dbe88ad7177240152c6
-  data.tar.gz: 2a1a56d21086cdf8ce6dab880b2911af9bd8eb20
+  metadata.gz: d49bbdbaf27b03c942ba8887eb4eca4c89f63cbc
+  data.tar.gz: c75ae281c96bfa5998c6f338ba5fd6d5bb164ace
 SHA512:
-  metadata.gz: 81de27f259688d1132d67a6f0d47500c47ad10f1d5a9624c8f0890f49376cdc738ea9abc16cf958034579b50ce7614b7341d0112df4c2df2ef14fb377a5fab0e
-  data.tar.gz: 4e418cbc41c2c154b22be27f2cffaec76952da3e2dc49391b64c56ba18d862ef0859ccad5f74ed5c55349d9bf6f1697a823f862527188054cdf9ef3870163219
+  metadata.gz: 7d130ab305df24c7f31e1fc11dcf7cc64c560edd2311ff6330ebeb33394ed819e444795b8f6c5fb3aff8ba9371c96c746dbec17db3ac3b368a149891bde5fc0c
+  data.tar.gz: 2f12228bb3d42a58d7534f077844b26c5f1212c104b5da2bbf8aa4facb2f1783f86cfa1abc10e8b08982cbcfd6a07efbd6dd8f8afb9e76e42ecd271e06f07887

data/.atom-build.json

@@ -0,0 +1,10 @@
+{
+  "cmd": "eval \"$(rbenv init -)\"; bundle exec rspec",
+  "name": "Run All Specs",
+  "args": [ "-c", "-b", "-p 1", "--format progress"],
+  "sh": true,
+  "errorMatch": [
+    "rspec (?<file>[\\/0-9a-zA-Z\\._]+):(?<line>\\d+) #"
+  ],
+  "keymap": "cmd-2"
+}

data/.gitignore

@@ -3,7 +3,6 @@
 .bundle
 .config
 .yardoc
-Gemfile.lock
 InstalledFiles
 _yardoc
 coverage

data/.rspec

@@ -1,2 +1,4 @@
 --color
 --format progress
+--backtrace
+-p 1

data/Gemfile.lock

@@ -0,0 +1,72 @@
+PATH
+  remote: .
+  specs:
+    ventable (1.0.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    coderay (1.1.0)
+    diff-lcs (1.2.5)
+    ffi (1.9.10)
+    formatador (0.2.5)
+    guard (2.13.0)
+      formatador (>= 0.2.4)
+      listen (>= 2.7, <= 4.0)
+      lumberjack (~> 1.0)
+      nenv (~> 0.1)
+      notiffany (~> 0.0)
+      pry (>= 0.9.12)
+      shellany (~> 0.0)
+      thor (>= 0.18.1)
+    guard-compat (1.2.1)
+    guard-rspec (4.6.4)
+      guard (~> 2.1)
+      guard-compat (~> 1.1)
+      rspec (>= 2.99.0, < 4.0)
+    listen (3.0.5)
+      rb-fsevent (>= 0.9.3)
+      rb-inotify (>= 0.9)
+    lumberjack (1.0.10)
+    method_source (0.8.2)
+    nenv (0.2.0)
+    notiffany (0.0.8)
+      nenv (~> 0.1)
+      shellany (~> 0.0)
+    pry (0.10.3)
+      coderay (~> 1.1.0)
+      method_source (~> 0.8.1)
+      slop (~> 3.4)
+    rake (10.5.0)
+    rb-fsevent (0.9.7)
+    rb-inotify (0.9.5)
+      ffi (>= 0.5.0)
+    rspec (3.4.0)
+      rspec-core (~> 3.4.0)
+      rspec-expectations (~> 3.4.0)
+      rspec-mocks (~> 3.4.0)
+    rspec-core (3.4.1)
+      rspec-support (~> 3.4.0)
+    rspec-expectations (3.4.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.4.0)
+    rspec-mocks (3.4.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.4.0)
+    rspec-support (3.4.1)
+    shellany (0.0.1)
+    slop (3.6.0)
+    thor (0.19.1)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  guard-rspec
+  rake
+  rspec
+  rspec-mocks
+  ventable!
+
+BUNDLED WITH
+   1.11.2

data/README.md

@@ -184,7 +184,7 @@ via a background queue, such as Sidekiq or Resque. If you are interested in help
 
 For more information, check out the following blog post:
 
-[Detangling Business Logic in Rails Apps with Pure Ruby Observers](http://building.wanelo.com/post/57442907639/detangling-business-logic-in-rails-apps-with-poro).
+[Detangling Business Logic in Rails Apps with Pure Ruby Observers](http://building.wanelo.com/2013/08/05/detangling-business-logic-in-rails-apps-with-poro-events-and-observers.html).
 
 ## Contributing
 

data/lib/ventable/version.rb

@@ -1,3 +1,3 @@
 module Ventable
-  VERSION = "0.0.6"
+  VERSION = "1.0.0"
 end

data/spec/ventable/ventable_spec.rb

@@ -11,25 +11,25 @@ describe Ventable do
     after { Ventable.enable }
 
     it 'is true by default' do
-      expect(Ventable.enabled?).to be_true
+      expect(Ventable.enabled?).to be true
     end
 
     it 'is false after Ventable is disabled' do
       Ventable.disable
-      expect(Ventable.enabled?).to be_false
+      expect(Ventable.enabled?).to be false
     end
 
     it 'is true after Ventable is re-enabled' do
       Ventable.disable
       Ventable.enable
-      expect(Ventable.enabled?).to be_true
+      expect(Ventable.enabled?).to be true
     end
   end
 
   describe "including Ventable::Event" do
     it "should create a class instance variable to keep observers" do
-      TestEvent.observers.should_not be_nil
-      TestEvent.observers.should be_a(Set)
+      expect(TestEvent.observers).not_to be_nil
+      expect(TestEvent.observers.class.name).to eq("Set")
     end
 
     it "should see observers variable from instance methods" do
@@ -37,14 +37,14 @@ describe Ventable do
       TestEvent.new.instance_eval do
         observers = self.class.observers
       end
-      observers.should_not be_nil
+      expect(observers).to_not be_nil
     end
 
     it "should maintain separate sets of observers for each event" do
       class AnotherEvent
         include Ventable::Event
       end
-      AnotherEvent.observers.object_id.should_not == TestEvent.observers.object_id
+      expect(AnotherEvent.observers.object_id).to_not eq(TestEvent.observers.object_id)
     end
   end
 
@@ -62,38 +62,37 @@ describe Ventable do
         run_block = true
         event = e
       end
-      run_block.should_not be_true
-      event.should be_nil
+      expect(run_block).to eq(false)
+      expect(event).to be_nil
 
       # fire the event
       TestEvent.new.fire!
 
-      run_block.should be_true
-      event.should_not be_nil
+      expect(run_block).to be true
+      expect(event).not_to be_nil
     end
 
     it "should properly call a class observer" do
-      TestEvent.instance_eval do
+      class TestEvent
         class << self
           attr_accessor :flag
         end
-      end
-
-      TestEvent.class_eval do
-        def set_flag!
-          self.class.flag = true
+        self.flag = "unset"
+        def flag= value
+          self.class.flag = value
         end
       end
+
       class TestEventObserver
         def self.handle_test event
-          event.set_flag!
+          event.flag = "boo"
         end
       end
       TestEvent.notifies TestEventObserver
-      TestEvent.flag.should be_false
+      expect(TestEvent.flag).to eq("unset")
 
       TestEvent.new.fire!
-      TestEvent.flag.should be_true
+      expect(TestEvent.flag).to eq("boo")
     end
 
     it "should properly call a group of observers" do
@@ -118,19 +117,18 @@ describe Ventable do
         event_inside = event
       end
 
-      transaction_called.should be_false
-      transaction_already_completed.should be_false
-      observer_block_called.should be_false
+      expect(transaction_called).to be false
+      expect(transaction_already_completed).to be false
+      expect(observer_block_called).to be false
 
       TestEvent.new.fire!
 
-      transaction_called.should be_true
-      observer_block_called.should be_true
-      transaction_called.should be_true
-      transaction_already_completed.should be_false
-
-      event_inside.should_not be_nil
-      event_inside.should be_a(TestEvent)
+      expect(transaction_called).to be  true
+      expect(observer_block_called).to be  true
+      expect(transaction_called).to be  true
+      expect(transaction_already_completed).to be false
+      expect(event_inside).to_not be_nil
+      expect(event_inside).to be_a(TestEvent)
     end
 
     context 'when globally disabled' do
@@ -145,7 +143,7 @@ describe Ventable do
         end
 
         TestEvent.new.fire!
-        expect(observers_notified).to be_false
+        expect(observers_notified).to be false
       end
     end
   end
@@ -175,15 +173,15 @@ describe Ventable do
     end
 
     it "should properly set the callback method name" do
-      SomeAwesomeEvent.default_callback_method.should == :handle_some_awesome
-      Blah::AnotherSweetEvent.default_callback_method.should == :handle_blah__another_sweet
-      SomeOtherStuffHappened.default_callback_method.should == :handle_some_other_stuff_happened
-      ClassWithCustomCallbackMethodEvent.default_callback_method.should == :handle_my_special_event
+      expect(SomeAwesomeEvent.default_callback_method).to eq(:handle_some_awesome)
+      expect(Blah::AnotherSweetEvent.default_callback_method).to eq(:handle_blah__another_sweet)
+      expect(SomeOtherStuffHappened.default_callback_method).to eq(:handle_some_other_stuff_happened)
+      expect(ClassWithCustomCallbackMethodEvent.default_callback_method).to eq(:handle_my_special_event)
     end
   end
 
   describe "#configure" do
-    it "properly configures the event with observesrs" do
+    it "properly configures the event with observers" do
       notified_observer = false
       TestEvent.configure do
         notifies do
@@ -191,7 +189,7 @@ describe Ventable do
         end
       end
       TestEvent.new.fire!
-      notified_observer.should be_true
+      expect(notified_observer).to be true
     end
 
     it "configures observers with groups" do
@@ -207,8 +205,8 @@ describe Ventable do
         end
       end
       TestEvent.new.fire!
-      notified_observer.should be_true
-      called_transaction.should be_true
+      expect(notified_observer).to be true
+      expect(called_transaction).to be true
     end
 
     it "throws exception if :inside references unknown group" do
@@ -220,7 +218,7 @@ describe Ventable do
         end
         fail "Shouldn't reach here, must throw a valid exception"
       rescue Exception => e
-        e.class.should == Ventable::Error
+        expect(e.class).to eq(Ventable::Error)
       end
     end
     it "throws exception if nil observer added to the list" do
@@ -230,7 +228,7 @@ describe Ventable do
         end
         fail "Shouldn't reach here, must throw a valid exception"
       rescue Exception => e
-        e.class.should == Ventable::Error
+        expect(e.class).to eq(Ventable::Error)
       end
     end
   end

data/ventable.gemspec

@@ -16,6 +16,7 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
   gem.version       = Ventable::VERSION
 
+  gem.add_development_dependency "rake"
   gem.add_development_dependency "rspec"
   gem.add_development_dependency "rspec-mocks"
   gem.add_development_dependency 'guard-rspec'

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: ventable
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 1.0.0
 platform: ruby
 authors:
 - Konstantin Gredeskoul
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-02 00:00:00.000000000 Z
+date: 2016-01-28 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -59,10 +73,12 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".atom-build.json"
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
 - Gemfile
+- Gemfile.lock
 - Guardfile
 - LICENSE
 - README.md
@@ -92,11 +108,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Event/Observable design pattern in ruby
 test_files:
 - spec/spec_helper.rb
 - spec/ventable/ventable_spec.rb
-has_rdoc: