ventable 0.0.4 → 0.0.5

data/lib/ventable/event.rb

@@ -28,8 +28,10 @@ module ::Ventable
           around_block = observer_entry[:around_block]
           inside_block = -> { notify_observer_set(observer_entry[:observers]) }
           around_block.call(inside_block)
-        else
+        elsif observer_entry
           notify_observer(observer_entry)
+        else
+          raise Ventable::Error.new("nil in observer_entry set #{observer_set.inspect}!")
         end
       end
     end
@@ -44,9 +46,9 @@ module ::Ventable
     end
 
     def notify_class_observer(observer)
-      observer.respond_to?(self.class.default_callback_method) ?
-          observer.send(self.class.default_callback_method, self) :
-          observer.send(:handle_event, self)
+      return observer.send(self.class.default_callback_method, self) if observer.respond_to?(self.class.default_callback_method)
+      return observer.send(:handle_event, self) if observer.respond_to?(:handle_event)
+      raise Ventable::Error.new("suitable event handler method found in observer #{self.inspect}")
     end
 
     module ClassMethods
@@ -65,12 +67,14 @@ module ::Ventable
           end
           observer_set = observer_entry[:observers]
         end
-        observer_list.each { |o| observer_set << o } unless observer_list.empty?
+        raise Ventable::Error.new("found nil observer in params #{observer_list.inspect}") if observer_list.any?{|l| l.nil?}
+        observer_list.compact.each { |o| observer_set << o } unless observer_list.empty?
         observer_set << block if block
       end
 
       def group(name, &block)
-        raise "Group #{name} already defined by #{g}" if  find_observer_group(name)
+        g = find_observer_group(name)
+        raise "Group #{name} already defined by #{g}" if g
         self.observers <<
             { name: name,
               around_block: block,

data/lib/ventable/version.rb

@@ -1,3 +1,3 @@
 module Ventable
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/ventable/ventable_spec.rb

@@ -107,7 +107,9 @@ describe Ventable do
 
       transaction_called.should be_true
       observer_block_called.should be_true
+      transaction_called.should be_true
       transaction_already_completed.should be_false
+
       event_inside.should_not be_nil
       event_inside.should be_a(TestEvent)
     end
@@ -186,5 +188,15 @@ describe Ventable do
         e.class.should == Ventable::Error
       end
     end
+    it "throws exception if nil observer added to the list" do
+      begin
+        TestEvent.configure do
+          notifies nil
+        end
+        fail "Shouldn't reach here, must throw a valid exception"
+      rescue Exception => e
+        e.class.should == Ventable::Error
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ventable
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-22 00:00:00.000000000 Z
+date: 2013-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec