veneer 0.2.0 → 0.4.0

data/lib/veneer/lint/base.rb

@@ -0,0 +1,10 @@
+module Veneer
+  module Lint
+    module Base
+      def test_should_setup_the_veneer_lint_class_wrapper_with_a_klass
+        assert_not_nil @klass, "@klass should provide a class to test Veneer with"
+        assert_kind_of Class, @klass
+      end
+    end
+  end
+end

data/lib/veneer/lint/properties.rb

@@ -0,0 +1,78 @@
+module Veneer
+  module Lint
+    module Properties
+      include Veneer::Lint::Base
+      
+      def test_should_setup_properties_mapping
+        assert_not_nil @properties_mapping
+        assert_kind_of Hash, @properties_mapping
+        @properties_mapping.each do |k, v|
+          assert_kind_of Symbol, k
+          assert_kind_of Class, v
+        end
+      end
+      
+      def test_should_setup_expected_primary_keys
+        assert_not_nil @primary_keys
+        assert_kind_of Array, @primary_keys
+      end
+      
+      def test_properties
+        result = Veneer(@klass).properties
+        assert result.kind_of?(Array)
+        assert result.size > 0
+        property = result.first
+        assert_kind_of Veneer::Base::Property, property
+        assert_kind_of Class, property.type
+        assert_kind_of Symbol, property.name
+        assert_not_nil property.primary?
+      end
+      
+      def test_primary_keys
+        wrapped = Veneer(@klass)
+        properties = wrapped.properties
+        primary_keys = wrapped.primary_keys
+        
+        assert_equal @primary_keys, wrapped.primary_keys
+
+
+        desired_primary_keys = properties.select { |property| primary_keys.include? property.name }
+        assert_equal primary_keys.size, desired_primary_keys.size
+        
+        desired_primary_keys.each { |key| assert key.primary? }
+      end
+
+      def test_constraints
+        Veneer(@klass).properties.each do |property|
+          assert_not_nil property[:constraints]
+        end
+      end
+      
+      def test_length
+        @properties_with_length.each do |name, length|
+          assert_equal length, property_by_name(name).constraints[:length], "Expected #{name}.length to be #{length}."
+        end
+      end
+
+      def test_types_conversion
+        @properties_mapping.each do |name, expected_normalized_type|
+          assert_equal expected_normalized_type, property_by_name(name).type, "Expected #{name} to be #{expected_normalized_type}."
+        end
+      end
+
+      def test_validations
+        @properties_with_validations.each do |name, validator_classes|
+          validators = Veneer(@klass).validators_on(name)
+          assert_equal validator_classes.size, validators.size
+          validators.zip(validator_classes).each do |validator, expected_class|
+            assert_kind_of expected_class, validator
+          end
+        end
+      end
+
+      def property_by_name(name)
+        Veneer(@klass).properties.find { |prop| prop.name == name } or raise "Couldn't find property #{name}."
+      end
+    end
+  end
+end

data/lib/veneer/version.rb

@@ -1,3 +1,3 @@
 module Veneer
-  VERSION = "0.2.0"
+  VERSION = "0.4.0"
 end

data/test/support/helpers.rb

@@ -12,7 +12,16 @@ module Veneer
           end
         end
       end
-
     end # Helpers
+
+    module ActiveRecordHelper
+      class << self
+        def establish_connection
+          unless ::ActiveRecord::Base.connected?
+            ::ActiveRecord::Base.establish_connection(:adapter => "sqlite3", :database => ":memory:") 
+          end
+        end
+      end # Migrations
+    end # ActiveRecordHelper
   end # Test
 end # Veneer

data/test/test_helper.rb

@@ -3,12 +3,12 @@ require 'test/unit'
 require 'shoulda'
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 $LOAD_PATH.unshift(File.dirname(__FILE__))
+$LOAD_PATH.unshift(Dir.pwd)
 
+require 'veneer'
 require 'veneer/lint'
 
-Dir[File.join(File.dirname(__FILE__), "support", "**/*.rb")].each{|f| require f}
-
-require 'veneer'
+Dir[File.join(File.dirname(__FILE__),"support", "**/*.rb")].each{|f| require f}
 
 $validations = []
 

data/test/veneer/activerecord/test_adapter.rb

@@ -0,0 +1,80 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '..', "..", "test_helper"))
+
+begin
+  require 'active_record'
+rescue LoadError
+  require 'activerecord'
+end
+
+require 'veneer/adapters/activerecord'
+
+
+Veneer::Test::ActiveRecordHelper.establish_connection
+
+class CreateActiveRecordFoo < ActiveRecord::Migration
+
+  def self.up
+    create_table :active_record_foos, :force => true do |t|
+      t.string    :name
+      t.string    :title
+      t.string    :description
+      t.integer   :integer_field
+      t.integer   :order_field1
+      t.integer   :belonger_id
+      t.text      :text_field
+      t.float     :float_field
+      t.decimal   :decimal_field
+      t.datetime  :datetime_field
+      t.timestamp :timestamp_field
+      t.time      :time_field
+      t.datetime  :datetime_field
+      t.date      :date_field
+      t.binary    :binary_field
+      t.boolean   :boolean_field
+    end
+  end
+
+  def self.down
+    drop_table :active_record_foos
+  end
+end
+
+CreateActiveRecordFoo.up
+
+class ActiveRecordFoo < ActiveRecord::Base
+  has_many :items, :class_name => "ActiveRecordFoo", :foreign_key => 'belonger_id'
+  belongs_to :master, :class_name => "ActiveRecordFoo", :foreign_key => 'belonger_id'
+
+  validate :check_name
+
+  def self.veneer_spec_reset!
+    delete_all
+  end
+
+  def check_name
+    errors.add(:name, "Name cannot be 'invalid'") if name == "invalid"
+  end
+
+  def v_with_m_test
+    errors.add(:name, "Name cannot be v_with_m_test") if name == "v_with_m_test"
+  end
+end
+
+class ActiveRecordAdapterTest < ::Test::Unit::TestCase
+  include Veneer::Lint::Adapter
+
+  def setup
+    @klass              = ::ActiveRecordFoo
+    @valid_attributes   = {:name => "foo", :title => "title", :description => "description", :integer_field => 1}
+    @invalid_attributes = @valid_attributes.dup.merge(:name => "invalid")
+  end
+
+  def create_valid_items(num)
+    attr = @valid_attributes
+
+    (1..num).each do |i|
+      ActiveRecordFoo.create(:name => "#{attr[:name]}#{i}", :title => "#{attr[:title]}#{i}", :description => "#{attr[:description]}#{i}", :integer_field => 1)
+    end
+  end
+end
+

data/test/veneer/activerecord/test_properties.rb

@@ -0,0 +1,73 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '..', "..", "test_helper"))
+
+begin
+  require 'active_record'
+rescue LoadError
+  require 'activerecord'
+end
+
+require 'veneer/adapters/activerecord'
+
+
+Veneer::Test::ActiveRecordHelper.establish_connection
+
+class CreateActiveRecordBar < ActiveRecord::Migration
+  def self.up
+    create_table :active_record_bars, :force => true do |t|
+      t.string    :name
+      t.string    :string_field
+      t.integer   :integer_field
+      t.text      :text_field
+      t.float     :float_field
+      t.decimal   :decimal_field, :precision => 5, :scale => 2
+      t.datetime  :datetime_field
+      t.timestamp :timestamp_field
+      t.time      :time_field
+      t.datetime  :datetime_field
+      t.date      :date_field
+      t.binary    :binary_field
+      t.boolean   :boolean_field
+    end
+  end
+
+  def self.down
+    drop_table :active_record_bars
+  end
+end
+
+CreateActiveRecordBar.up
+
+class ActiveRecordBar < ActiveRecord::Base
+  validates_presence_of :integer_field
+end
+
+class ActiveRecordPropertiesTest < ::Test::Unit::TestCase
+  include Veneer::Lint::Properties
+
+  def setup
+    @klass              = ::ActiveRecordBar
+    @properties_mapping = {
+      :id => Integer,
+      :string_field => String,
+      :text_field => String,
+      :integer_field => Integer,
+      :float_field => Float,
+      :decimal_field => BigDecimal,
+      :datetime_field => DateTime,
+      :timestamp_field => DateTime,
+      :time_field => Time,
+      :date_field => Date,
+      :binary_field => StringIO,
+      :boolean_field => TrueClass
+    }
+    @primary_keys = [:id]
+    @properties_with_length = {
+      :string_field => 255,
+      :text_field => nil
+
+    }
+    @properties_with_validations = {
+      :integer_field => [ActiveModel::Validations::PresenceValidator]
+    }
+  end
+end

data/test/veneer/datamapper/test_adapter.rb

@@ -0,0 +1,71 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '..', "..", "test_helper"))
+require 'dm-core'
+require 'dm-migrations'
+require 'dm-aggregates'
+require 'veneer/adapters/datamapper'
+
+DataMapper.setup(:default, 'sqlite3::memory:')
+
+class DMFoo
+  include DataMapper::Resource
+  include ActiveModel::Validations
+
+  property :id,                  Serial
+  property :name,                String
+  property :title,               String
+  property :description,         String
+  property :integer_field,       Integer, :required => false
+  property :order_field1,        Integer
+  property :item_id,             Integer, :required => false
+  property :text_field,          Text
+  property :float_field,         Float
+  property :decimal_field,       Decimal, :scale => 0, :precision => 10
+  property :datetime_field,      DateTime
+  property :time_field,          Time
+  property :date_field,          Date
+  property :boolean_field,       Boolean
+  property :object_field,        Object
+  property :discriminator_field, Discriminator
+  
+  validate :check_name
+
+  has n,      :items,  self, :child_key => [:item_id]
+  belongs_to  :master, self, :child_key => [:item_id]
+
+  before :save do
+    throw :halt unless valid?
+  end
+
+  def check_name
+    errors.add(:base, "Invalid name") if name == "invalid"
+  end
+
+  def v_with_m_test
+    if name == "v_with_m_test"
+      [false, "name cannot be v_with_m_test"]
+    else
+      true
+    end
+  end
+end
+
+DataMapper.auto_migrate!
+
+class DataMapperAdapterTest < ::Test::Unit::TestCase
+  include Veneer::Lint::Adapter
+
+  def setup
+    @klass              = ::DMFoo
+    @valid_attributes   = {:name => "foo", :title => "title", :description => "description", :integer_field => 1}
+    @invalid_attributes = @valid_attributes.dup.merge(:name => "invalid")
+  end
+
+  def create_valid_items(num)
+    attr = @valid_attributes
+
+    (1..num).each do |i|
+      DMFoo.create(:name => "#{attr[:name]}#{i}", :title => "#{attr[:title]}#{i}", :description => "#{attr[:description]}#{i}", :integer_field => 1)
+    end
+  end  
+end
+

data/test/veneer/datamapper/test_properties.rb

@@ -0,0 +1,59 @@
+require File.expand_path(File.join(File.dirname(__FILE__), '..', "..", "test_helper"))
+require 'dm-core'
+require 'dm-migrations'
+require 'veneer/adapters/datamapper'
+
+DataMapper.setup(:default, 'sqlite3::memory:')
+
+class DMBar
+  include DataMapper::Resource
+  include ActiveModel::Validations
+
+  validates_presence_of :integer_field
+
+  property :id,                  Serial, :key => true
+  property :another_id,          Integer, :key => true
+  property :string_field,        String, :length => 255
+  property :integer_field,       Integer
+  property :text_field,          Text
+  property :float_field,         Float
+  property :decimal_field,       Decimal, :scale => 0, :precision => 10
+  property :datetime_field,      DateTime
+  property :time_field,          Time
+  property :date_field,          Date
+  property :boolean_field,       Boolean
+  property :object_field,        Object
+  property :discriminator_field, Discriminator
+end
+
+DataMapper.auto_migrate!
+
+class DataMapperPropertiesTest < ::Test::Unit::TestCase
+  include Veneer::Lint::Properties
+
+  def setup
+    @klass              = ::DMBar
+    @properties_mapping = {
+      :id => Integer, #Serial,             
+      :string_field => String,
+      :text_field => String,
+      :integer_field => Integer,
+      :float_field => Float,
+      :decimal_field => BigDecimal,
+      :datetime_field => DateTime,
+      :time_field => Time,
+      :date_field => Date,
+      :boolean_field => TrueClass,
+      :object_field => Object,
+      :discriminator_field => Class
+    }
+    @primary_keys = [:id, :another_id]
+    @properties_with_length = {
+      :string_field => 255,
+      :integer_field => nil
+    }
+    @properties_with_validations = {
+      :integer_field => [ActiveModel::Validations::PresenceValidator]
+    }
+  end
+end

data/test/veneer/{adapters/test_mongomapper.rb → mongomapper/test_adapter.rb}

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), "..", "..", "test_helper")
+require File.expand_path(File.join(File.dirname(__FILE__), '..', "..", "test_helper"))
 require 'mongo_mapper'
 
 require 'veneer/adapters/mongomapper'
@@ -13,9 +13,21 @@ class MongoFoo
   key :name,          String
   key :title,         String
   key :description,   String
+  key :integer_field, Integer
   key :order_field1,  Integer
+  key :float_field,   Float
+  key :date_field,    Date
+  key :boolean_field, Boolean
+  key :hash_field,    Hash
+  key :set_field,     Set
+  key :time_field,    Time
+  key :object_field,  Object
+  key :binary_field,  Binary
 
-  validate_on_create :check_name
+  validate :check_name, :on => :create
+
+  belongs_to :foo, :class_name => "MongoFoo"
+  many :foos, :class_name => "MongoFoo"
 
   def check_name
     errors.add(:name, "may not be invalid") if name == "invalid"
@@ -26,12 +38,12 @@ class MongoFoo
   end
 end
 
-class MongoMapperVeneerTest < ::Test::Unit::TestCase
-  include Veneer::Lint
+class MongoMapperAdapterTest < ::Test::Unit::TestCase
+  include Veneer::Lint::Adapter
 
   def setup
     @klass              = ::MongoFoo
-    @valid_attributes   = {:name => "foo", :title => "title", :description => "description"}
+    @valid_attributes   = {:name => "foo", :title => "title", :description => "description", :integer_field => 1}
     @invalid_attributes = @valid_attributes.dup.merge(:name => "invalid")
   end
 
@@ -39,11 +51,23 @@ class MongoMapperVeneerTest < ::Test::Unit::TestCase
     attr = @valid_attributes
 
     (1..num).each do |i|
-      MongoFoo.create(:name => "#{attr[:name]}#{i}", :title => "#{attr[:title]}#{i}", :description => "#{attr[:description]}#{i}")
+      MongoFoo.create(:name => "#{attr[:name]}#{i}", :title => "#{attr[:title]}#{i}", :description => "#{attr[:description]}#{i}", :integer_field => 1)
     end
   end
-end
-
-
-
-
+  
+  def properties_mappings
+    {
+      :_id => String, #ObjectID
+      :name => String,
+      :integer_field => Integer,
+      :float_field => Float,
+      :date_field => Date,
+      :boolean_field => TrueClass, 
+      :hash_field => Hash,
+      :set_field => Set,
+      :time_field => Time,
+      :object_field => Object,
+      :binary_field => StringIO
+    }
+  end
+end