vend 0.0.8 → 0.0.9

data/spec/integration/register_sale_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Vend::Resource::RegisterSale do
-
   let(:expected_attributes) do
     {
       'id'              => '98ce3dbf-e862-c811-fa93-10f6db3a8f66',
@@ -18,20 +17,20 @@ describe Vend::Resource::RegisterSale do
 
   let(:expected_collection_length) { 1 }
 
-  it_should_behave_like "a resource with a singular GET endpoint"
-  it_should_behave_like "a resource with a collection GET endpoint" do
+  it_behaves_like "a resource with a singular GET endpoint"
+  it_behaves_like "a resource with a collection GET endpoint" do
     let(:append_to_url) { '?page_size=200' }
   end
 
-  specify "register_sales are findable by state" do
-    client.RegisterSale.should respond_to(:find_by_state)
+  it "register_sales are findable by state" do
+    expect(client.RegisterSale).to respond_to(:find_by_state)
 
-    stub_request(:get, "https://bar:baz@foo.vendhq.com/api/register_sales?status[]=OPEN&status[]=CLOSED").
-      to_return(:status => 200, :body => get_mock_response('register_sales.find_by_state.json'))
+    stub_request(:get, "https://bar:baz@foo.vendhq.com/api/register_sales?status[]=OPEN&status[]=CLOSED")
+      .to_return(status: 200, body: get_mock_response('register_sales.find_by_state.json'))
 
     collection = client.RegisterSale.find_by_state([:OPEN, :CLOSED])
-    collection.first.should be_a Vend::Resource::RegisterSale
-    collection.first.id.should == "8dd57077-c158-f7db-d582-6785f43c9d72"
-    collection.first.register_sale_products.count.should == 2
+    expect(collection.first).to be_a Vend::Resource::RegisterSale
+    expect(collection.first.id).to eq "8dd57077-c158-f7db-d582-6785f43c9d72"
+    expect(collection.first.register_sale_products.count).to eq 2
   end
 end

data/spec/integration/register_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Vend::Resource::Register do
-
   let(:expected_attributes) do
     {
       'id'              => '6cbe2342-3d5f-11e0-8697-4040f540b50a',
@@ -12,5 +11,5 @@ describe Vend::Resource::Register do
 
   let(:expected_collection_length) { 1 }
 
-  it_should_behave_like "a resource with a collection GET endpoint"
+  it_behaves_like "a resource with a collection GET endpoint"
 end

data/spec/integration/supplier_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+describe Vend::Resource::Supplier do
+  let(:expected_attributes) do
+    {
+      'id' => '9fc84329-2d20-11e2-8057-080027706aa2',
+      'name'   => 'Brewer Supplies Ltd.'
+    }
+  end
+
+  let(:expected_collection_length) { 1 }
+
+  it_behaves_like "a resource with a collection GET endpoint"
+end

data/spec/integration/tax_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Vend::Resource::Tax do
-
   let(:expected_attributes) do
     {
       'id'        => '53b3501c-887c-102d-8a4b-a9cf13f17faa',
@@ -12,5 +11,5 @@ describe Vend::Resource::Tax do
 
   let(:expected_collection_length) { 1 }
 
-  it_should_behave_like "a resource with a collection GET endpoint"
+  it_behaves_like "a resource with a collection GET endpoint"
 end

data/spec/integration/user_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Vend::Resource::User do
-
   let(:expected_attributes) do
     {
       'id'        => '6ce4286c-3d5f-11e0-8697-4040f540b50a',
@@ -12,5 +11,5 @@ describe Vend::Resource::User do
 
   let(:expected_collection_length) { 2 }
 
-  it_should_behave_like "a resource with a collection GET endpoint"
+  it_behaves_like "a resource with a collection GET endpoint"
 end

data/spec/mock_responses/suppliers.json

@@ -0,0 +1,36 @@
+{
+    "suppliers": [
+        {
+            "id": "9fc84329-2d20-11e2-8057-080027706aa2",
+            "retailer_id": "9a5521c3-2d20-11e2-8057-080027706aa2",
+            "name": "Brewer Supplies Ltd.",
+            "description": "We supply all things brewed\n",
+            "source": "USER",
+            "contact": {
+                "first_name": "First",
+                "last_name": "Last",
+                "company_name": "Co co",
+                "phone": "1-234-555-1234",
+                "mobile": null,
+                "fax": null,
+                "email": "no-reply+brewer-contact@vendhq.com",
+                "twitter": null,
+                "website": "www.brewer-supplies.com",
+                "physical_address1": null,
+                "physical_address2": null,
+                "physical_suburb": null,
+                "physical_city": null,
+                "physical_postcode": null,
+                "physical_state": null,
+                "physical_country_id": null,
+                "postal_address1": "123 Street St",
+                "postal_address2": null,
+                "postal_suburb": "Suburbia",
+                "postal_city": "New York",
+                "postal_postcode": "12345",
+                "postal_state": "New York",
+                "postal_country_id": "US"
+            }
+        }
+    ]
+}

data/spec/spec_helper.rb

@@ -2,9 +2,8 @@ $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 require 'rubygems'
 require 'bundler/setup'
 require 'webmock/rspec'
-require 'rspec/its'
 require 'pry'
-Dir["./spec/support/**/*.rb"].each {|f| require f}
+Dir["./spec/support/**/*.rb"].each { |f| require f }
 
 require 'cgi'
 require 'vend'

data/spec/support/matchers/have_attributes.rb

@@ -1,7 +1,7 @@
 RSpec::Matchers.define :have_attributes do |expected|
-  match do |attributes|
-    expected.each do |key,value|
-      actual.send(key).should == value
+  match do |_attributes|
+    expected.each do |key, value|
+      expect(actual.send(key)).to eq value
     end
   end
 

data/spec/support/shared_examples/integration.rb

@@ -29,12 +29,11 @@ shared_examples "a resource with a collection GET endpoint" do
 
   it "gets the collection" do
     url = "https://%s:%s@%s.vendhq.com/api/%s%s" % [
-      username, password, store, class_basename.to_s.underscore.pluralize,
-      append_to_url
+      username, password, store, described_class.collection_name, append_to_url
     ]
 
     stub_request(:get, url).to_return(
-      :status => 200, :body => get_mock_from_path(:get)
+      status: 200, body: get_mock_from_path(:get)
     )
 
     collection = build_receiver.all
@@ -55,11 +54,11 @@ shared_examples "a resource with a singular GET endpoint" do
   end
 
   it "gets the resource" do
-    stub_request(:get, "https://#{username}:#{password}@#{store}.vendhq.com/api/#{class_basename.to_s.underscore.pluralize}/#{id}").
-    to_return(:status => 200, :body => get_mock_from_path(:get, :id => id))
+    stub_request(:get, "https://#{username}:#{password}@#{store}.vendhq.com/api/#{class_basename.to_s.underscore.pluralize}/#{id}")
+    .to_return(status: 200, body: get_mock_from_path(:get, id: id))
 
     objekt = build_receiver.find(id)
-    objekt.should have_attributes(expected_attributes)
+    expect(objekt).to have_attributes(expected_attributes)
   end
 end
 
@@ -73,9 +72,8 @@ shared_examples "a resource with a DELETE endpoint" do
   end
 
   it "deletes the resource" do
-
-    stub_request(:delete, "https://#{username}:#{password}@#{store}.vendhq.com/api/#{class_basename.to_s.underscore.pluralize}/#{expected_attributes['id']}").
-    to_return(status: 200, body: {}.to_json)
+    stub_request(:delete, "https://#{username}:#{password}@#{store}.vendhq.com/api/#{class_basename.to_s.underscore.pluralize}/#{expected_attributes['id']}")
+    .to_return(status: 200, body: {}.to_json)
 
     objekt = build_receiver.build(expected_attributes)
     expect(objekt.delete).to be_truthy

data/spec/support/shared_examples/logger.rb

@@ -1,25 +1,36 @@
 shared_examples_for "a logger" do
-  it { should respond_to(:debug) }
-  it { should respond_to(:info) }
-  it { should respond_to(:warn) }
-  it { should respond_to(:error) }
-  it { should respond_to(:fatal) }
+  specify :responds_to_debug do
+    expect(subject).to respond_to(:debug)
+  end
+
+  specify :responds_to_info do
+    expect(subject).to respond_to(:info)
+  end
+
+  specify :responds_to_warn do
+    expect(subject).to respond_to(:warn)
+  end
+
+  specify :responds_to_error do
+    expect(subject).to respond_to(:error)
+  end
+
+  specify :responds_to_fatal do
+    expect(subject).to respond_to(:fatal)
+  end
 end
 
 shared_examples_for "it has a logger" do
   describe "#logger" do
-
     let(:logger)  { double("logger") }
 
     it "defaults to a null logger" do
-      subject.logger.should be_instance_of(Vend::NullLogger)
+      expect(subject.logger).to be_instance_of(Vend::NullLogger)
     end
 
     it "allows the logger to be set" do
       subject.logger = logger
-      subject.logger.should == logger
+      expect(subject.logger).to eq logger
     end
-
   end
-
 end

data/spec/vend/base_factory_spec.rb

@@ -7,42 +7,41 @@ describe Vend::BaseFactory do
   class Vend::Resource::Foo < Vend::Base #:nodoc:
   end
 
-  let(:client) { double() }
+  let(:client) { double }
   subject { Vend::Resource::FooFactory.new(client, Vend::Resource::Foo) }
 
   it "initializes correctly" do
-    subject.should be_instance_of(Vend::Resource::FooFactory)
-    subject.client.should == client
-    subject.target_class.should == Vend::Resource::Foo
+    expect(subject).to be_instance_of(Vend::Resource::FooFactory)
+    expect(subject.client).to eq client
+    expect(subject.target_class).to eq Vend::Resource::Foo
   end
 
   it "proxies 'find' to the target class" do
-    Vend::Resource::Foo.should_receive(:find)
+    expect(Vend::Resource::Foo).to receive(:find)
     subject.find
   end
 
   it "proxies 'all' to the target class" do
-    Vend::Resource::Foo.should_receive(:all)
+    expect(Vend::Resource::Foo).to receive(:all)
     subject.all
   end
 
   it "proxies 'since' to the target class" do
-    Vend::Resource::Foo.should_receive(:since)
+    expect(Vend::Resource::Foo).to receive(:since)
     subject.since
   end
-  
+
   it "proxies 'outlet_id' to the target class" do
-    Vend::Resource::Foo.should_receive(:outlet_id)
+    expect(Vend::Resource::Foo).to receive(:outlet_id)
     subject.outlet_id
   end
 
   it "proxies 'build' to the target class" do
-    Vend::Resource::Foo.should_receive(:build)
+    expect(Vend::Resource::Foo).to receive(:build)
     subject.build
   end
 
   it "returns the target class" do
-    subject.target_class.should == Vend::Resource::Foo
+    expect(subject.target_class).to eq Vend::Resource::Foo
   end
-
 end

data/spec/vend/base_spec.rb

@@ -7,16 +7,16 @@ describe Vend::Base do
 
   let(:client) { double(:client) }
   let(:attribute_hash) { { key: 'value', 'id' => 1} }
-  let(:mock_response) {
+  let(:mock_response) do
     {
-      'foos'=>[
-        {'id'=>'1','bar'=>'baz'},
-        {'id'=>'2','flar'=>'flum'}
+      'foos' => [
+        {'id' => '1', 'bar' => 'baz'},
+        {'id' => '2', 'flar' => 'flum'}
       ]
     }
-  }
+  end
 
-  subject { Vend::Resource::Foo.new(client, :attrs => attribute_hash) }
+  subject { Vend::Resource::Foo.new(client, attrs: attribute_hash) }
 
   it 'creates an instance of Foo' do
     expect(subject).to be_instance_of(Vend::Resource::Foo)
@@ -42,7 +42,6 @@ describe Vend::Base do
       expect(resource).to be_a Vend::Resource::Foo
       expect(resource.bar).to eq 'baz'
     end
-
   end
 
   describe '.initialize_collection' do
@@ -85,7 +84,7 @@ describe Vend::Base do
   end
 
   describe '#singular_name' do
-    it :singular_name do
+    specify :singular_name do
       expect(subject.singular_name).to eq "foos/#{subject.id}"
     end
   end
@@ -114,7 +113,7 @@ describe Vend::Base do
     let(:resource_collection) { double('resource_collection') }
 
     before do
-      subject.stub(:collection_name => collection_name)
+      subject.stub(collection_name: collection_name)
     end
 
     it 'calls initialize_collection with the collection_name' do
@@ -133,7 +132,7 @@ describe Vend::Base do
     let(:bar)                 { double('bar') }
 
     before do
-      subject.stub(:collection_name => collection_name)
+      subject.stub(collection_name: collection_name)
     end
 
     it 'calls initialize_collection with collection_name and :bar arg' do
@@ -156,12 +155,12 @@ describe Vend::Base do
     let(:query)               { 'query' }
 
     before do
-      subject.stub(:collection_name => collection_name)
+      subject.stub(collection_name: collection_name)
     end
 
     it 'calls initialize_collection with collection_name and :outlet_id arg' do
       expect(subject).to receive(:initialize_collection).with(
-        client, collection_name, :url_params => { field.to_sym => query }
+        client, collection_name, url_params: { field.to_sym => query }
       ) { resource_collection }
       expect(subject.search(client, field, query)).to eq resource_collection
     end
@@ -188,7 +187,7 @@ describe Vend::Base do
 
   describe 'dynamic instance methods' do
     let(:attrs) { { 'one' => 'foo', 'two' => 'bar', 'object_id' => 'fail' } }
-    subject { Vend::Resource::Foo.new(client, :attrs => attrs) }
+    subject { Vend::Resource::Foo.new(client, attrs: attrs) }
 
     it 'responds to top level attributes' do
       expect(subject).to respond_to(:one)
@@ -203,12 +202,12 @@ describe Vend::Base do
 
   describe 'delete!' do
     context 'when id is present' do
-      subject { Vend::Resource::Foo.new(client, :attrs => {'id' => 1}) }
+      subject { Vend::Resource::Foo.new(client, attrs: {'id' => 1}) }
 
-      let(:singular_name) { double('singular_name')}
+      let(:singular_name) { double('singular_name') }
 
       before do
-        subject.stub(:singular_name => singular_name)
+        subject.stub(singular_name: singular_name)
       end
 
       it 'deletes the object' do
@@ -218,20 +217,20 @@ describe Vend::Base do
     end
 
     context 'when id is absent' do
-      subject { Vend::Resource::Foo.new(client, :attrs => {:foo => 'bar'}) }
+      subject { Vend::Resource::Foo.new(client, attrs: {foo: 'bar'}) }
 
       it 'raises Vend::Resource::IllegalAction' do
         expect(client).to_not receive(:request)
-        expect {
+        expect do
           subject.delete!
-        }.to raise_error(Vend::Resource::IllegalAction, 'Vend::Resource::Foo has no unique ID')
+        end.to raise_error(Vend::Resource::IllegalAction, 'Vend::Resource::Foo has no unique ID')
       end
     end
   end
 
   describe 'delete' do
     it 'returns false when no id is present' do
-      subject = Vend::Resource::Foo.new(client, :attrs => {:foo => 'bar'})
+      subject = Vend::Resource::Foo.new(client, attrs: {foo: 'bar'})
       expect(client).to_not receive(:request)
       expect(subject.delete).to be_falsey
     end
@@ -239,7 +238,7 @@ describe Vend::Base do
 
   describe '.default_collection_request_args' do
     subject { Vend::Resource::Foo }
-    it :default_collection_request_args do
+    specify :default_collection_request_args do
       expect(subject.default_collection_request_args).to eq({})
     end
   end
@@ -254,13 +253,13 @@ describe Vend::Base do
 
   describe '.available_scopes' do
     subject { Vend::Resource::Foo }
-    it :available_scopes do
+    specify :available_scopes do
       expect(subject.available_scopes).to eq [:bar]
     end
   end
 
   describe '.accepts_scope?' do
-    let(:scope_name) {:scope_name}
+    let(:scope_name) { :scope_name }
     subject { Vend::Resource::Foo }
 
     context 'when scope is accepted' do

data/spec/vend/client_spec.rb

@@ -1,93 +1,94 @@
 require 'spec_helper'
 
 describe Vend::Client do
+  subject { Vend::Client.new('store', 'user', 'password') }
+  it_behaves_like "it has a logger"
 
-  subject { Vend::Client.new('store','user','password') }
+  specify :store do
+    expect(subject.store).to eq 'store'
+  end
 
-  it_should_behave_like "it has a logger"
+  specify :username do
+    expect(subject.username).to eq 'user'
+  end
 
-  its(:store) { should == 'store' }
-  its(:username) { should == 'user' }
-  its(:password) { should == 'password' }
+  specify :password do
+    expect(subject.password).to eq 'password'
+  end
 
   it "creates an instance of Client" do
-    subject.should be_instance_of(Vend::Client)
+    expect(subject).to be_instance_of(Vend::Client)
   end
 
   it "returns the API base url" do
-    subject.base_url.should == "https://store.vendhq.com/api/"
+    expect(subject.base_url).to eq "https://store.vendhq.com/api/"
   end
 
-  it "should set options" do
-    options = { :key => :value }
-    client = Vend::Client.new('store','user','password', options)
+  it "sets options" do
+    options = { key: :value }
+    client = Vend::Client.new('store', 'user', 'password', options)
     options.each do |key, value|
-      client.options[key].should == value
+      expect(client.options[key]).to eq value
     end
   end
 
   describe "resource factories" do
     it "gets all products" do
-      Vend::Resource::Product.should_receive(:all).and_return([])
-      subject.Product.all.should == []
+      expect(Vend::Resource::Product).to receive(:all).and_return([])
+      expect(subject.Product.all).to eq []
     end
   end
 
   describe "#http_client" do
-
     let(:http_client)         { double("http_client") }
     let(:http_client_options) { double("http_client_options") }
 
     before do
-      subject.stub(:http_client_options => http_client_options)
-      Vend::HttpClient.should_receive(:new).with(http_client_options) { http_client }
+      subject.stub(http_client_options: http_client_options)
+      expect(Vend::HttpClient).to receive(:new).with(http_client_options) { http_client }
     end
 
-    it "should return a memoized HttpClient instance" do
-      subject.http_client.should == http_client
-      subject.http_client.should == http_client
+    it "returns a memoized HttpClient instance" do
+      expect(subject.http_client).to eq http_client
+      expect(subject.http_client).to eq http_client
     end
-
   end
 
   describe "#http_client_options" do
-
-    let(:options)   { {:foo => 'bar'} }
+    let(:options)   { {foo: 'bar'} }
     let(:base_url)  { "http://foo/" }
     let(:username)  { "username" }
     let(:password)  { "password" }
 
     before do
       subject.stub(
-        :options => options,
-        :base_url => base_url,
-        :username => username,
-        :password => password
+        options: options,
+        base_url: base_url,
+        username: username,
+        password: password
       )
     end
-
-    its(:http_client_options) {
-      should == {
-        :foo => 'bar',
-        :base_url => base_url,
-        :username => username,
-        :password => password
-      }
-    }
+    specify :http_client_options do
+      expect(subject.http_client_options).to eq({
+        foo: 'bar',
+        base_url: base_url,
+        username: username,
+        password: password
+      })
+    end
   end
 
   describe "#request" do
-
     let(:response)    { double("response") }
     let(:http_client) { double("http_client") }
 
     before do
-      subject.stub(:http_client => http_client)
-      http_client.should_receive(:request).with("foo", "bar") { response }
+      subject.stub(http_client: http_client)
+      expect(http_client).to receive(:request).with("foo", "bar") { response }
     end
 
     it "delegates to the http_client" do
-      subject.request("foo", "bar").should == response
+      expect(subject.request("foo", "bar")).to eq response
     end
   end
 end