vehicle_coding_ph 1.1.1 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c5c4f4e63a646bcb16fe9a50366e1438e8465939b815a376192c857fdc0aac31
-  data.tar.gz: 6f71b895af80dde97f34114daaa78d1cd529f6fb8a94f4429225b83c115d84a9
+  metadata.gz: bfabb96edaefb820f72fb034babb4580eceb44c4b385a68d63299bc1beedcdf9
+  data.tar.gz: d28debcd5713a9cfdbbcb335fb306ccae601ba364fd142003f30424d5539a1d0
 SHA512:
-  metadata.gz: 1cf62292fc9e3bc19b52236f14355637d1a7be5cde2d131162e7d2959d8881b8bbecd9555c6e093e0227a94ec3d708e4558b135a8ddc3370eda0bdd0bb4a7057
-  data.tar.gz: 573fbfe693699c44ba9d4e8ecd038e205c33d21dc215aae6d6f574661e89329eca94e57ea64f390f38f45120b5efb89abc6f33fca7c0108c541ec1d62327cf70
+  metadata.gz: f3fd45fbb2083812c8fc3c987c7063d39576ef853dce6603c66e1803ceb7c2d65303f29704ac84f881d065d3e2ccad629dd680b54dcc2eb197cde6e68dff5b21
+  data.tar.gz: 380a4bd8ee6c04567112af7db46164a0eba4d4a1cb988f0986f1044d12c08b51290822a260a8330097fb998a502a7efa9098591eb67af7c73f52f2990b6224af

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    vehicle_coding_ph (1.1.1)
+    vehicle_coding_ph (1.2.0)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -4,11 +4,6 @@
 
 Helps you figure out if your car is legally okay to drive on a given date in the Philippines.
 
-## Version 1.0 roadmap
-
-- [x] Response object
-- [x] Consider window hours
-
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -33,6 +28,11 @@ VehicleCodingPh::Checker.(
   plate_number_of_your_vehicle, 
   datetime # if not passed, defaults to datetime today
 )
+
+# VehicleCodingPh::Response object returns:
+- coding: boolean
+- allowed: array of areas allowed to go
+- not_allowed: array of areas not allowed to go
 ```
 
 ## Development
@@ -43,7 +43,7 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/vehicle_coding_ph. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+Bug reports and pull requests are welcome on GitHub at https://github.com/MarkFChavez/vehicle_coding_ph. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
 
 ## License
 
@@ -51,4 +51,4 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## Code of Conduct
 
-Everyone interacting in the CodingPh project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/[USERNAME]/vehicle_coding_ph/blob/master/CODE_OF_CONDUCT.md).
+Everyone interacting in the CodingPh project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/MarkFChavez/vehicle_coding_ph/blob/master/CODE_OF_CONDUCT.md).

data/lib/vehicle_coding_ph/checker.rb

@@ -5,22 +5,19 @@ module VehicleCodingPh
       return allowed_anywhere if weekend?(datetime)
       return allowed_anywhere if not coding?(plate_no, datetime)
 
-      hour_of_the_day = datetime.hour
-
-      allowed_areas = VehicleCodingPh::AREA_TO_HOUR_MAPPING.reduce([]) do |areas, mapping|
-        areas ||= []
-
-        name_of_area = mapping[0]
-        coding_hours = mapping[1]
-
-        if coding_hours.empty? || !coding_hours.include?(hour_of_the_day)
-          areas << name_of_area
+      allowed_areas     = []
+      not_allowed_areas = []
+      hour_of_the_day   = datetime.hour
+
+      VehicleCodingPh::AREA_TO_HOUR_MAPPING.each do |area, hours|
+        if hours.empty? || !hours.include?(hour_of_the_day)
+          allowed_areas << area
+        else
+          not_allowed_areas << area
         end
-
-        areas
       end
 
-      Response.new(true, allowed_areas)
+      Response.new(true, allowed_areas, not_allowed_areas)
     end
 
     def self.weekend?(datetime)
@@ -40,7 +37,7 @@ module VehicleCodingPh
     private_class_method :coding?
 
     def self.allowed_anywhere
-      Response.new(false, [:anywhere])
+      Response.new(false, [:anywhere], [])
     end
     private_class_method :allowed_anywhere
 

data/lib/vehicle_coding_ph/response.rb

@@ -1,11 +1,12 @@
 module VehicleCodingPh
   class Response
 
-    attr_reader :coding, :allowed_areas
+    attr_reader :coding, :allowed, :not_allowed
 
-    def initialize(coding, areas)
+    def initialize(coding, allowed, not_allowed)
       @coding = coding
-      @allowed_areas = areas
+      @allowed = allowed
+      @not_allowed = not_allowed
     end
 
   end

data/lib/vehicle_coding_ph/version.rb

@@ -1,3 +1,3 @@
 module VehicleCodingPh
-  VERSION = "1.1.1"
+  VERSION = "1.2.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: vehicle_coding_ph
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.0
 platform: ruby
 authors:
 - Mark Chavez
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-12-14 00:00:00.000000000 Z
+date: 2020-01-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler