vectory 0.7.8 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ccf79449f78b1e3df6ed0792a5ef740e96da77d0e38f7e9ab4bf4d47d9b31334
-  data.tar.gz: 16aec00dcfcd5c3bc9caf81796bbc93665987927dc8e320aaee607d2fe5aaaa8
+  metadata.gz: d7ebbb9e4146780f1f9d42e0dee106494c251eb27b7d3f52d69f172da0a0d2e7
+  data.tar.gz: 132e451c7c1e9298f305f67a7103f8da8b7d5af3df371f5705e8a2eb95b59991
 SHA512:
-  metadata.gz: b87eeaf37029993930140bba471b9bd677465002e0bf5c7eb91ef2550d56d3c3456a3ab02e4e2a5d3db0b403cc129f7f68d1ec8f9dcd02bcd1a3afd2b7f3aad3
-  data.tar.gz: 20bbd0ff186b26123d676cad1ffdf2f46ff49c383b728e21be6c14a3287af120cb5a0578b4762a1cdf2b5eca37c4afeccc712b831454daf83217a9c8e82c7724
+  metadata.gz: 33a7acbdacd776a6627d30a2641123743d325b3c5f89b3f1f40a244556b4f363c1c2a4b49458d2260014c53004a2d06a9c8d7f617e732f82457c30576e9c6085
+  data.tar.gz: 4a243d964fcda1b2d7e8dab7ef9bea706265c646d168d70df847bc6fd4d4e6c9f3453334adf4b0824670a59c029e4fa8a5812d4aecb4714298dfaa3425e1010a

data/lib/vectory/image_resize.rb

@@ -6,6 +6,7 @@ module Vectory
 
     def call(img, path, maxheight, maxwidth)
       s, realsize = get_image_size(img, path)
+      # Ensure s[0] and s[1] are not nil before setting viewBox
       img.name == "svg" && !img["viewBox"] && s[0] && s[1] and
         img["viewBox"] = viewbox(s)
       s, skip = image_dont_resize(s, realsize)
@@ -18,7 +19,8 @@ module Vectory
       detected = detect_size(path)
       realsize = detected if detected
       s = image_size_interpret(img, realsize || [nil, nil])
-      image_size_zeroes_complete(s, realsize)
+      # No call to image_size_zeroes_complete here
+      [s, realsize] # s should now be correctly populated
     end
 
     private
@@ -53,7 +55,11 @@ module Vectory
     end
 
     def fill_size(current, another, real_current, real_another)
-      return current unless current.zero? && !another.zero?
+      # Ensure 'current' and 'another' are not nil before calling zero?
+      # Also ensure real_another is not nil or zero to prevent division by zero
+      return current unless (current.nil? || current.zero?) &&
+        !(another.nil? || another.zero?) &&
+        !(real_another.nil? || real_another.zero?)
 
       another * real_current / real_another
     end
@@ -67,22 +73,102 @@ module Vectory
     end
 
     def image_size_interpret(img, realsize)
-      w = image_size_percent(img["width"], realsize[0])
-      h = image_size_percent(img["height"], realsize[1])
+      # Extract parent dimensions for percentage calculations
+      parent_w_px = realsize.is_a?(Array) && realsize.length > 0 ? realsize[0] : nil
+      parent_h_px = realsize.is_a?(Array) && realsize.length > 1 ? realsize[1] : nil
+
+      # Process width and height using the original css_size_to_px signature
+      w = css_size_to_px(img["width"], parent_w_px)
+      h = css_size_to_px(img["height"], parent_h_px)
+
+      # If attributes resulted in no dimensions, but realsize exists, use realsize.
+      # This brings back some of the logic from the removed image_size_zeroes_complete.
+      if w.nil? && h.nil? && realsize && !(realsize[0].nil? && realsize[1].nil?)
+        w = realsize[0]
+        h = realsize[1]
+      end
+
+      # If a dimension attribute led to a nil value (e.g. "auto", or "%" of nil parent)
+      # and the other dimension is resolved, default the nil dimension to 0.
+      if img["width"] && w.nil? && !h.nil? 
+        w = 0
+      end
+      if img["height"] && h.nil? && !w.nil?
+        h = 0
+      end
+
       [w, h]
     end
 
-    def image_size_percent(value, real)
-      /%$/.match?(value) && !real.nil? and
-        value = real * (value.sub(/%$/, "").to_f / 100)
-      value.to_i
+    # Enhanced version of image_size_percent that handles percentage calculations
+    # This is now a helper method for css_size_to_px
+    def image_size_percent(percentage_numeric_value, real_dimension)
+      return nil if real_dimension.nil? || percentage_numeric_value.nil?
+
+      # Calculates the dimension in pixels. The result is a float.
+      (real_dimension * (percentage_numeric_value / 100.0))
     end
 
-    def image_size_zeroes_complete(dim, realsize)
-      if dim[0].zero? && dim[1].zero?
-        dim = realsize
+    # New method from image_sizer.rb, incorporated directly into ImageResize
+    # Converts CSS length string to pixels.
+    def css_size_to_px(size_str, real_dimension_for_percentage, dpi: 96)
+      return nil unless size_str.is_a?(String)
+
+      cleaned_size_str = size_str.strip.downcase
+
+      # Handle keywords like "auto" which don't resolve to a numeric pixel value.
+      return nil if cleaned_size_str == "auto"
+
+      # Handle plain numbers (e.g., "150") as pixels.
+      if cleaned_size_str.match?(/^\d+(\.\d+)?$/)
+        return cleaned_size_str.to_f.to_i
+      end
+
+      # Match numeric value and unit (e.g., "10.5cm", "50%", "-5px").
+      match = cleaned_size_str.match(/^([-+]?[0-9]*\.?[0-9]+)([a-z%]+)$/)
+      unless match
+        # Not a plain number and not in "valueUnit" format
+        return nil
+      end
+
+      value = match[1].to_f
+      unit = match[2]
+      px_value = nil # This will store the calculated pixel value as a float.
+
+      case unit
+      when "px"
+        px_value = value
+      when "in"
+        px_value = value * dpi
+      when "cm"
+        px_value = value * dpi / 2.54
+      when "mm"
+        px_value = value * dpi / 25.4
+      when "pt" # 1 point = 1/72 inch
+        px_value = value * dpi / 72.0
+      when "pc" # 1 pica = 12 points
+        px_value = value * 12.0 * dpi / 72.0
+      when "%"
+        # Use the enhanced image_size_percent method
+        px_value = image_size_percent(value, real_dimension_for_percentage)
+      else
+        return nil # Unknown unit
+      end
+
+      return nil if px_value.nil?
+
+      # For 'px' and '%' units, truncate to match "integer conversion" expectation.
+      # For physical units, round to handle floating point inaccuracies correctly.
+      if ["px", "%"].include?(unit)
+        px_value.to_i
+      else
+        px_value.round
       end
-      [dim, realsize]
     end
+
+    # REMOVE the image_size_zeroes_complete method entirely if it's still present
+    # def image_size_zeroes_complete(dim, realsize)
+    #   ...
+    # end
   end
 end

data/lib/vectory/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Vectory
-  VERSION = "0.7.8"
+  VERSION = "0.8.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: vectory
 version: !ruby/object:Gem::Version
-  version: 0.7.8
+  version: 0.8.0
 platform: ruby
 authors:
 - Ribose Inc.
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-04-26 00:00:00.000000000 Z
+date: 2025-06-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: base64