vector_embed 0.2.0 → 0.3.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YWJmNzczYzU1MjZlODE4NzcxZGMxZTc0MTgzNjdkNjFjYzc5MjRjNA==
+    ZjYyYTk3OTE0NmEwYzMwMGE3ZDk5YTZmODA5NmUzOGM1YTlkMDAwNA==
   data.tar.gz: !binary |-
-    NDNhZmQwZDNjOWMwNWJlOGM3NTBiOTVmNjIwZGJjM2EzYjdlZWZiMA==
+    OGJjODkwMTM3NWY5NWE3ZTUyNzQ2YjQxOTgwODVkNWVlMjc0NTVkZQ==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    MDc4NjE0YWQ4ZmYzZWZmNTdhOTM3ZTkxODI0Y2RjNjU4YTAxMjMzMjdlZWQx
-    OTUzMDY4NGE4YjFkOWY1OWJiNTVjNWJmYTFkN2I1ZDdhZTY1OWQ0YzRkYjE3
-    MDkxZWYzYmQ2NDMyOTIxMzEyZDBkNGMwMjdkNDY1Yzc2YTMyNzk=
+    ZTgxMWNkODk4NjYyMTU3Mzk0YTM1YWMxMjU4YzJkODU2MWIzNTllYjdhYmZk
+    ZjYyN2Q5ZTExMDAxYTVhMzZkODRlMmFmMzljOGY2YjkyMzhmNmViMTJkNWM1
+    ZmEzNTk3Y2QzZGMwOGNjNjFjY2RmMjFkNjEyOTVhMjEyOWJjNGI=
   data.tar.gz: !binary |-
-    ZmI5MzkzYWRmNzY2NjA0ZjBhY2NmNWIzMWMxZmM3OTU3MTVlY2Q5ZTg0YzJi
-    NzUyZDI3MjgzNmJhNDFiYTY0YjRlOTNlNzE4NjYyYjZlMTI5ZDFhMGZhMmY2
-    ZmYyZmU5Nzc1NzBmYjhkMmFmMDkxYzdkZjM0NTY2OTZmY2U0ODU=
+    ODI3MjU1YTBlMTc5NGZkNTliY2RkNDcwZmMyNGI2YTIyNmI4MTA4NDNmMGI1
+    YTlhMjJlYmEzY2M0ZmI5NTYwZWNlY2UxYzM4YTc4OGY1MmUwZGZiZmU2ODIz
+    ZjA5ZGQ0YmM1MmZiNmE5NTRlZGQ4ZTE4OGZkODgyNWU2Yzc5OGM=

data/CHANGELOG

@@ -1,3 +1,9 @@
+0.3.0 / 2013-05-14
+
+* Breaking changes
+
+  * If a value is nil, assume it's a number field (not a boolean field as before). Just a better assumption.
+
 0.2.0 / 2013-05-14
 
 * Breaking changes

data/lib/vector_embed/maker/boolean.rb

@@ -6,7 +6,7 @@ class VectorEmbed
       class << self
         def want?(v, parent)
           case v
-          when NilClass, TrueClass, FalseClass, TRUE, FALSE, T, F, NULL, SLASH_N
+          when TrueClass, FalseClass, TRUE, FALSE, T, F
             true
           else
             false

data/lib/vector_embed/maker/number.rb

@@ -5,7 +5,12 @@ class VectorEmbed
     class Number < Maker
       class << self
         def want?(v, parent)
-          v.is_a?(::Numeric) or v =~ JUST_A_NUMBER
+          case v
+          when Numeric, NilClass, NULL, SLASH_N
+            true
+          else
+            v =~ JUST_A_NUMBER
+          end
         end
 
         def numify(v)

data/lib/vector_embed/version.rb

@@ -1,3 +1,3 @@
 class VectorEmbed
-  VERSION = "0.2.0"
+  VERSION = '0.3.0'
 end

data/spec/vector_embed_spec.rb

@@ -98,22 +98,24 @@ describe VectorEmbed do
   end
 
   describe 'feature values' do
-    it "stores true/false/nil as (1,0,0)/(0,1,0)/(0,0,1)" do
-      v = VectorEmbed.new
-      v.line(1, 1 => true).should == "1 #{l_h("1\x00true")}:1"
-      v.line(1, 1 => 'true').should == "1 #{l_h("1\x00true")}:1"
-      v.line(1, 1 => 'TRUE').should == "1 #{l_h("1\x00true")}:1"
-      v.line(1, 1 => 't').should == "1 #{l_h("1\x00true")}:1"
-      v.line(1, 1 => 'T').should == "1 #{l_h("1\x00true")}:1"
-      v.line(1, 1 => false).should == "1 #{l_h("1\x00false")}:1"
-      v.line(1, 1 => 'false').should == "1 #{l_h("1\x00false")}:1"
-      v.line(1, 1 => 'FALSE').should == "1 #{l_h("1\x00false")}:1"
-      v.line(1, 1 => 'f').should == "1 #{l_h("1\x00false")}:1"
-      v.line(1, 1 => 'F').should == "1 #{l_h("1\x00false")}:1"
-      v.line(1, 1 => nil).should == "1 #{l_h("1\x00null")}:1"
-      v.line(1, 1 => 'null').should == "1 #{l_h("1\x00null")}:1"
-      v.line(1, 1 => 'NULL').should == "1 #{l_h("1\x00null")}:1"
-      v.line(1, 1 => '\N').should == "1 #{l_h("1\x00null")}:1"
+    describe 'in boolean attributes' do
+      it "stores true/false/nil as (1,0,0)/(0,1,0)/(0,0,1)" do
+        v = VectorEmbed.new
+        v.line(1, 1 => true).should == "1 #{l_h("1\x00true")}:1"
+        v.line(1, 1 => 'true').should == "1 #{l_h("1\x00true")}:1"
+        v.line(1, 1 => 'TRUE').should == "1 #{l_h("1\x00true")}:1"
+        v.line(1, 1 => 't').should == "1 #{l_h("1\x00true")}:1"
+        v.line(1, 1 => 'T').should == "1 #{l_h("1\x00true")}:1"
+        v.line(1, 1 => false).should == "1 #{l_h("1\x00false")}:1"
+        v.line(1, 1 => 'false').should == "1 #{l_h("1\x00false")}:1"
+        v.line(1, 1 => 'FALSE').should == "1 #{l_h("1\x00false")}:1"
+        v.line(1, 1 => 'f').should == "1 #{l_h("1\x00false")}:1"
+        v.line(1, 1 => 'F').should == "1 #{l_h("1\x00false")}:1"
+        v.line(1, 1 => nil).should == "1 #{l_h("1\x00null")}:1"
+        v.line(1, 1 => 'null').should == "1 #{l_h("1\x00null")}:1"
+        v.line(1, 1 => 'NULL').should == "1 #{l_h("1\x00null")}:1"
+        v.line(1, 1 => '\N').should == "1 #{l_h("1\x00null")}:1"
+      end
     end
 
     it "stores numbers as numbers" do
@@ -135,10 +137,19 @@ describe VectorEmbed do
 
     it "treats nil like zero in number attributes" do
       v = VectorEmbed.new
-      v.line(1, 1 => 1)
+      v.line(1, 1 => 1) # establish it's a number
       v.line(1, 1 => nil).should == v.line(1, 1 => 0)
     end
 
+    it "assumes nil value means a number field" do
+      v = VectorEmbed.new
+      v.line(3, 1 => nil) # don't establish it's a number
+      v.line(3, 1 => nil).should == v.line(3, 1 => 0)
+      v.line(3, 1 => 'null').should == v.line(3, 1 => 0)
+      v.line(3, 1 => 'NULL').should == v.line(3, 1 => 0)
+      v.line(3, 1 => '\N').should == v.line(3, 1 => 0)
+    end
+
     it "stores strings as m-category attributes" do
       v = VectorEmbed.new
       v.line(1, 1 => 'sfh').should == "1 #{l_h("1\x00sfh")}:1"
@@ -170,6 +181,17 @@ describe VectorEmbed do
       v.line(1, 'bar' => ['a','b','c']).should == sortme("1 #{l_h("bar\x001\x00b")}:1 #{l_h("bar\x000\x00a")}:1 #{l_h("bar\x002\x00c")}:1")
     end
 
+    it "stores arrays with proper indices even if some values are zero" do
+      v = VectorEmbed.new
+      v.line(1, 'foo' => [0,99]).should == sortme("1 #{l_h("foo\x001")}:99")
+      v.line(1, 'foo' => [45,0]).should == sortme("1 #{l_h("foo\x000")}:45")
+      v.line(1, 'foo' => [45,99]).should == sortme("1 #{l_h("foo\x000")}:45 #{l_h("foo\x001")}:99")
+      v = VectorEmbed.new
+      v.line(1, 'foo' => [45,0,99]).should == sortme("1 #{l_h("foo\x000")}:45 #{l_h("foo\x002")}:99")
+      v.line(1, 'foo' => [45,0]).should == sortme("1 #{l_h("foo\x000")}:45")
+      v.line(1, 'foo' => [45,33,99]).should == sortme("1 #{l_h("foo\x000")}:45 #{l_h("foo\x001")}:33 #{l_h("foo\x002")}:99")
+    end
+
     it "in number mode, treats null as 0" do
       v = VectorEmbed.new
       v.line(1, 1 => 9).should == "1 #{l_h('1')}:9"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vector_embed
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Seamus Abshere