vcardigan 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fecc595fa698e75daf5a8fa962f921ca403a7bb1
-  data.tar.gz: 42aca309a5059eb66eaf3f4c2c879c01f76955ee
+  metadata.gz: 5ccf24ad70c7e77507a727fc711161d1b9a49914
+  data.tar.gz: ebf00bb504baef0a007c94f8982874ebf9a7cb1c
 SHA512:
-  metadata.gz: 47f0e8c1ff8ad181d2eed402c87d2d21059b28e6fcad55e8fa5656745099f0af9c6e611640292c21e3911432e34f4beb96ca93f0fbccb3c33a96257de466d27b
-  data.tar.gz: 1377d0431be7981ccf7270cc7130c25f01612b04319e45e7659732eecaf1c871c93400edf9429493462bec3b8d37a0e27c4b0d0672831d50f33fb070f59d3f73
+  metadata.gz: c1aff52e87d131553450fc836f2d6de3728f4e2f0cd4ac871f6cfc39eaad4c6bc089856d957a64787fb9ca42ba5de07690e323b7292010d7514903822ecd3056
+  data.tar.gz: 62e2de500251985a05245a4937c23124324bcf097dbb52b60d67fcec40034c187e70f3188683e20247d70a18332bf91da75bae12565ba0734067b36377f8d680

data/lib/vcardigan/vcard.rb

@@ -65,9 +65,6 @@ module VCardigan
         @group = nil
       end
 
-      args.reject!(&:nil?)
-
-      # Build the property and add it to the vCard
       if args.any?
         property = build_prop(name, *args)
         add_prop(property)

data/lib/vcardigan/version.rb

@@ -1,5 +1,5 @@
 module VCardigan
 
-  VERSION = '0.0.7'
+  VERSION = '0.0.8'
 
 end

data/spec/examples/vcard_spec.rb

@@ -110,25 +110,14 @@ describe VCardigan::VCard do
     end
 
     context 'regardless of group' do
-
       before do
         vcard.add(name, *values)
       end
 
-      context 'some args are nil' do
-
-        let(:values) { [nil, 'joe@strummer.com'] }
-
-        it 'should not build properties from nil args' do
-          fields[name.to_s].first.values.should == [values.last]
-        end
-      end
-
-      context 'all args are nil' do
-
+      context 'when all of the given values are nil' do
         let(:values) { [nil, nil] }
 
-        it 'should not build properties' do
+        it 'should not add anything to the fields hash' do
           fields[name.to_s].should be_nil
         end
       end
@@ -302,16 +291,23 @@ describe VCardigan::VCard do
   describe "#valid?" do
     let(:vcard) { VCardigan.create }
 
-    context 'with no FN' do
-      it 'it should return false' do
-        expect( vcard.valid? ).to be_false
+    context 'when full name has not been set' do
+      it 'should return false' do
+        expect(vcard).not_to be_valid
       end
     end
 
-    context 'with FN' do
-      it 'it should return true' do
+    context 'when full name has been set' do
+      it 'should return true' do
         vcard.fullname("My Name")
-        expect( vcard.valid? ).to be_true
+        expect(vcard).to be_valid
+      end
+    end
+
+    context 'when full name has been set to nil' do
+      it 'should return false' do
+        vcard.fullname(nil)
+        expect(vcard).not_to be_valid
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: vcardigan
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Matt Morgan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-18 00:00:00.000000000 Z
+date: 2015-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec