vaultez-cli 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 824ab321c6ff7b03bd1495461f6c545bc15aa07d596c863e3388fc5d8383622f
-  data.tar.gz: 5417e6a9394622242c58608eddd1186629dc63586fc9ba4545702e1168e8f5f3
+  metadata.gz: 78043da2b439dff80b3ed04f33ee62a77936276e5bd60935be94d2eca29592f0
+  data.tar.gz: aa76a4503506bd47d5e5b8a582725fbcee604bfdd0b23976e868e13bb7af2240
 SHA512:
-  metadata.gz: 4d06a027b38872fb4b9e02ee827b03589d4ddffa9d8a0fbfca87fe00e71a5e7b64eedd63d48b5dbfcd9f4c5d195f3628bfaec74b4846a463a7b675721695e9e5
-  data.tar.gz: 7808de1486e94c49eb163317f1d488de5e581fe83b1fc5dd9bf804d9d12d7a103401f2a59e6ad6c0ebb68f3b514f8539b4daf05dd7e143f63e905cf1fa435dea
+  metadata.gz: 1214dc2431ac95bac73be69ce5ed35a6bb1f854ebbdede1e011954bf6161e3031ef1a628f810ff531284fb228808a86f4d8a33df8bfab776c6d756d87c3dec5f
+  data.tar.gz: 1c9dcf449a65eeba1412ecae189f4d00cbae4cfe98437c7ed649a559b0868ad4f17e09090d92b6483a4d62c35154918dc738ae0695f4db8465cb251b1b62c8c9

data/lib/vaultez/client.rb

@@ -4,6 +4,14 @@ require "uri"
 
 module Vaultez
   class Client
+    # A legitimate response (companies/projects/secrets, all short strings)
+    # is a handful of KB at most. This bounds how much of a compromised or
+    # malicious response - a compromised API backend, a MITM'd/redirected
+    # api_url, or a compromised account crafting an oversized payload - this
+    # process will hold in memory, independent of any size limit a caller
+    # (e.g. the oma-vaultez plugin) enforces on this CLI's own stdout.
+    MAX_RESPONSE_BYTES = 4 * 1024 * 1024
+
     def initialize
       @api_url       = Vaultez::Config.api_url
       @token         = Vaultez::Config.token
@@ -68,7 +76,9 @@ module Vaultez
       req.body = body.to_json if body
 
       begin
-        response = http.request(req)
+        response = fetch_bounded(http, req)
+      rescue Vaultez::Error
+        raise
       rescue StandardError => error
         raise Vaultez::ApiError, "Could not reach the Vaultez API: #{error.message}"
       end
@@ -76,6 +86,27 @@ module Vaultez
       parse_response(response)
     end
 
+    # Reads the response body incrementally instead of Net::HTTP's default
+    # #request behavior, which fully buffers the entire body in memory
+    # before returning with no size limit at all. Aborts (closing the
+    # connection) the moment the body crosses MAX_RESPONSE_BYTES, rather
+    # than finishing the download and only noticing afterward.
+    def fetch_bounded(http, req)
+      response = nil
+      body = +""
+      http.request(req) do |res|
+        response = res
+        res.read_body do |chunk|
+          body << chunk
+          if body.bytesize > MAX_RESPONSE_BYTES
+            raise Vaultez::ApiError, "Vaultez API response exceeded the maximum allowed size"
+          end
+        end
+      end
+      response.body = body
+      response
+    end
+
     def build_request(method, uri)
       case method
       when :get    then Net::HTTP::Get.new(uri)

data/lib/vaultez/version.rb

@@ -1,3 +1,3 @@
 module Vaultez
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vaultez-cli
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Nur Ketene
@@ -58,7 +58,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.16
 specification_version: 4
 summary: CLI tool for Vaultez — manage your secrets from the terminal
 test_files: []