vaulted_billing 0.0.4 → 0.0.5

data/lib/vaulted_billing/core_ext/hash.rb

@@ -9,6 +9,7 @@ module VaultedBilling
 
       module ClassMethods
         def from_querystring(string)
+          return {} if string.nil?
           ::Hash[*(string.split(/&/).
             collect { |i| i.split(/=/) }.
             collect { |e| e.size == 1 ? (e << '') : e }.flatten)]

data/lib/vaulted_billing/gateways/authorize_net_cim.rb

@@ -149,12 +149,21 @@ module VaultedBilling
         super(data, {'Content-Type' => 'text/xml'}.merge(headers))
       end
 
-      def before_post(data)
-        VaultedBilling.logger.debug { "Posting: %s to %s" % [data.inspect, uri.inspect] } if VaultedBilling.logger?
+      def after_post_on_exception(response, exception)
+        response.body = {
+          'ErrorResponse' => {
+            'directResponse' => ',,,There was a problem communicating with the card processor.,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,',
+            'messages' => {
+              'resultCode' => 'Error',
+              'text' => 'A communication problem has occurred.',
+              'code' => 'E00000'
+            }
+          }
+        }
+        response.success = false
       end
 
-      def after_post(response)
-        VaultedBilling.logger.info { "Response code %s (HTTP %d), %s" % [response.message, response.code, response.body.inspect] } if VaultedBilling.logger?
+      def after_post_on_success(response)
         response.body = Hash.from_xml(response.body)
         response.success = response.body[response.body.keys.first]['messages']['resultCode'] == 'Ok'
       end
@@ -200,23 +209,20 @@ module VaultedBilling
 
       def new_transaction_from_response(response)
         root = response.keys.first
-        if root == 'ErrorResponse'
-          Transaction.new
-        else
-          direct_response = parse_direct_response(response[root]['directResponse'])
-          Transaction.new({
-            :id => direct_response['transaction_id'],
-            :avs_response => direct_response['avs_response'],
-            :cvv_response => direct_response['cvv_response'],
-            :authcode => direct_response['approval_code'],
-            :message => response[root]['messages']['text'],
-            :code => response[root]['messages']['code']
-          })
-        end
+        direct_response = parse_direct_response(response[root]['directResponse'])
+        Transaction.new({
+          :id => direct_response['transaction_id'],
+          :avs_response => direct_response['avs_response'],
+          :cvv_response => direct_response['cvv_response'],
+          :authcode => direct_response['approval_code'],
+          :message => direct_response['message'] || response[root]['messages']['text'],
+          :code => response[root]['messages']['code']
+        })
       end
 
       def parse_direct_response(string)
-        fields = string.split(',')
+        return {} unless string
+        fields = string.split(',', 100).collect { |v| v == '' ? nil : v }
         {
           'message' => fields[3],
           'approval_code' => fields[4],

data/lib/vaulted_billing/gateways/nmi_customer_vault.rb

@@ -111,12 +111,7 @@ module VaultedBilling
       protected
 
 
-      def before_post(data)
-        VaultedBilling.logger.debug { "Posting %s to %s" % [data.inspect, uri.to_s] } if VaultedBilling.logger?
-      end
-
       def after_post(response)
-        VaultedBilling.logger.info { "Response code %s (HTTP %d), %s" % [response.message, response.code, response.body.inspect] } if VaultedBilling.logger?
         response.body = Hash.from_querystring(response.body)
         response.success = response.body['response'] == '1'
       end

data/lib/vaulted_billing/https_interface.rb

@@ -73,17 +73,19 @@ module VaultedBilling
         end
       end
 
-      before_post(data)
+      before_post_caller(data)
 
       begin
         PostResponse.new(response.request(request)).tap do |post_response|
-          after_post(post_response)
+          after_post_caller(post_response)
+          after_post_on_success(post_response)
         end
       rescue *HTTP_ERRORS
         PostResponse.new(nil).tap do |post_response|
           post_response.success = false
           post_response.message = "%s - %s" % [$!.class.name, $!.message]
           after_post(post_response)
+          after_post_on_exception(post_response, $!)
         end
       end
     end
@@ -93,8 +95,32 @@ module VaultedBilling
     end
     protected :before_post
 
+    def before_post_caller(data)
+      if VaultedBilling.logger?
+        VaultedBilling.logger.debug { "Posting %s to %s" % [data.inspect, uri.to_s] }
+      end
+      before_post(data)
+    end
+    private :before_post_caller
+
     def after_post(response)
     end
     protected :after_post
+
+    def after_post_caller(response)
+      if VaultedBilling.logger?
+        VaultedBilling.logger.info { "Response code %s (HTTP %d), %s" % [response.message, response.code, response.body.inspect] }
+      end
+      after_post(response)
+    end
+    private :after_post_caller
+
+    def after_post_on_success(response)
+    end
+    protected :after_post_on_success
+
+    def after_post_on_exception(response, exception)
+    end
+    protected :after_post_on_exception
   end
 end

data/lib/vaulted_billing/version.rb

@@ -1,3 +1,3 @@
 module VaultedBilling
-  Version = '0.0.4'
+  Version = '0.0.5'
 end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 0
-  - 4
-  version: 0.0.4
+  - 5
+  version: 0.0.5
 platform: ruby
 authors: 
 - Nathaniel Bibler
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-08-30 00:00:00 -04:00
+date: 2010-08-31 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency