vantiv_lite 0.1.1 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4782fb49b793badc095bdf9acdaa35986031dabc
-  data.tar.gz: ee000b2ae92a4a05b5e346ec6fcf3a83c06f1f07
+  metadata.gz: 8080d049a1f8aca2371ce07c68fbc083ee47428b
+  data.tar.gz: adc5095ae85b88ebd911e78e7e8ed3757d812f90
 SHA512:
-  metadata.gz: fa12d86c48824f7eda942471835f5d7694e94d89c9a6587b1bc759309aa04ae481175df1fd2e575fd8f62b1573c234e139632aa2219a05ec0804cc2eb4ffd9bd
-  data.tar.gz: 29f88adb3311a7c7ee1f7401a095457fbaed8b9b3c77f9f481ead4e1e4e4914ab02a0109fd4418188cabfd0c788a7736f32d7550cb43226dbcab78762baf507d
+  metadata.gz: 8f166190f82ed119ed98d2be5a61fd78af51694b93f39c28b55e8f2caf1ae5513bd47e07cf43b7acafb3d9704076f3bb64d6bd1a76a763dc45e324a52e82bc72
+  data.tar.gz: 1b19fa30722127f0b2b5350730b0b59bde2b20829d717840e2778c9d45a87445157291f265dc6bc906fc4b18ec82b4bb62762b7c769d498fc0cb2cf17185ca51

data/README.md

@@ -19,9 +19,9 @@ Pretty standard gem stuff.
 
     $ gem install vantiv_lite
 
-When using [Bundler](https://bundler.io) or requiring this library in general, it's important to note that it will attempt to load it's XML add-ons by default If Nokogiri or Ox is already defined, it will use them in that order. Otherwise, it will use the default of REXML. The only consideration is that REXML will get required if neither optional library is already required.
+When using [Bundler](https://bundler.io) or requiring this library in general, it's important to note that this gem will attempt to load its XML add-ons by default if `Ox` or `Nokogiri` is already defined, it will use them in that order. Otherwise, it will use the default of `REXML`. The only consideration is that `REXML` will get required if neither optional library is already required.
 
-So, ensure your XML libs load first or just manually load it after the fact.
+So, ensure you load your project's XML libs (if you're using them) first.
 
 ## Configuration
 
@@ -95,9 +95,9 @@ A basic request can be made using `VantivLite.request`. This uses the global con
 
 ```ruby
 params = {
-  register_token_request: {
-    order_id: '50',
-    account_number: '4457119922390123'
+  'registerTokenRequest' => {
+    'orderId' => '50',
+    'accountNumber' => '4457119922390123'
   }
 }
 
@@ -107,18 +107,18 @@ response = VantivLite.request(params) # => #
 This will return a `VantivLite::Response` which itself operates much like a hash:
 
 ```ruby
-response.dig(:register_token_response, :litle_token) # => "1111222233330123"
+response.dig('registerTokenResponse', 'litleToken') # => "1111222233330123"
 ```
 
-For many simple transactions the `*_request` and `*_response` keys get a little tedious. So, this can be abreviated to the following:
+For many simple transactions the `*_request` and `*_response` keys get a little tedious. So, this can be abbreviated to the following:
 
 ```ruby
 params = {
-  order_id: '50',
-  account_number: '4457119922390123'
+  'orderId' => '50',
+  'accountNumber' => '4457119922390123'
 }
 
-response = VantivLite.register_token(params).dig(:litle_token) # => "1111222233330123"
+response = VantivLite.register_token(params).dig('litleToken') # => "1111222233330123"
 ```
 
 There are shortcuts for the requests:
@@ -131,17 +131,15 @@ There are shortcuts for the requests:
   * `sale`
   * `void`
 
-Note that the only transformation that is done is underscoring and symbolizing keys. No other mapping is done.
-
 ### Requests With Multiple Configurations
 
 `VantiveLite.request` (and the various convenience versions) simply uses `Vantiv.default_request` which is just an instance of `VantivLite::Request`. The request object itself can be used similarly with the methods by invoking `#call`:
 
 ```ruby
 params = {
-  register_token_request: {
-    order_id: '50',
-    account_number: '4457119922390123'
+  'registerTokenRequest' => {
+    'orderId' => '50',
+    'accountNumber' => '4457119922390123'
   }
 }
 
@@ -150,8 +148,8 @@ response = VantivLite::Request.new(custom_config).(params) # => #
 # Shortcut methods also work:
 
 params = {
-  order_id: '50',
-  account_number: '4457119922390123'
+  'orderId' => '50',
+  'accountNumber' => '4457119922390123'
 }
 
 response = VantivLite::Request.new(custom_config).register_token(params)
@@ -163,10 +161,10 @@ Obviously, XML doesn't map nice and neat to a hash and vice-versa. However, Vant
 
 ```ruby
 params = {
-  register_token_request: {
-    id: 'abcdef',
-    order_id: '50',
-    account_number: '4457119922390123'
+  'registerTokenRequest' => {
+    'id' => 'abcdef',
+    'orderId' => '50',
+    'accountNumber' => '4457119922390123'
   }
 }
 ```
@@ -197,11 +195,15 @@ Valid environments are:
 
 This configures the API url. At the moment, that's really all it does.
 
+## Reports
+
+Need access to reports? Turns out, there's a [separate gem for that](https://github.com/binarypaladin/vantiv_sftp_reports).
+
 ## Contributing
 
 ### Issue Guidelines
 
-GitHub issues are for bugs, not support. As of right now, there is no official support for this gem. You can try reaching out to the author, [Joshua Hansen](mailto:joshua@epicbanality.com?subject=VantiveLite) if you're really stuck, but there's a pretty high chance that won't go anywhere at the moment or you'll get a response like this:
+GitHub issues are for bugs, not support. As of right now, there is no official support for this gem. You can try reaching out to the author, [Joshua Hansen](mailto:joshua@epicbanality.com?subject=VantivLite) if you're really stuck, but there's a pretty high chance that won't go anywhere at the moment or you'll get a response like this:
 
 > Hi. I'm super busy. It's nothing personal. Check the README first if you haven't already. If you don 't find your answer there, it's time to start reading the source. Have fun! Let me know if I screwed something up.
 

data/lib/vantiv_lite.rb

@@ -8,15 +8,16 @@ module VantivLite
     attr_reader :default_config, :default_request
 
     def configure(config = env_config, &blk)
-      @default_config = block_given? ? Config.build(&blk) : Config.new(config)
+      @default_config = block_given? ? Config.build(&blk) : Config.with_obj(config)
       @default_request = Request.new(@default_config)
     end
 
     def env_config
-      Config::OPTS.each_with_object({}) do |k, h|
-        env_key = "vaniv_#{k}"
+      opts = Config::OPTS.each_with_object({}) do |k, h|
+        env_key = "vantiv_#{k}"
         h[k] = ENV[env_key] if ENV.key?(env_key)
       end
+      Config.new(opts)
     end
 
     def request(request_hash)

data/lib/vantiv_lite/config.rb

@@ -32,8 +32,14 @@ module VantivLite
       end
     end
 
-    def self.build(&blk)
-      Config::Builder.(&blk)
+    class << self
+      def build(&blk)
+        Config::Builder.(&blk)
+      end
+
+      def with_obj(config)
+        config.is_a?(self) ? config : new(config)
+      end
     end
 
     attr_reader :proxy_uri, :sandbox, :uri

data/lib/vantiv_lite/request.rb

@@ -6,13 +6,13 @@ require 'vantiv_lite/xml'
 
 module VantivLite
   TRANSACTIONS = {
-    auth_reversal: :auth_reversal,
-    authorization: :authorization,
-    capture: :capture,
-    credit: :credit,
-    register_token: :register_token_request,
-    sale: :sale,
-    void: :void
+    auth_reversal: 'authReversal',
+    authorization: 'authorization',
+    capture: 'capture',
+    credit: 'credit',
+    register_token: 'registerTokenRequest',
+    sale: 'sale',
+    void: 'void'
   }.freeze
 
   class Request
@@ -34,11 +34,13 @@ module VantivLite
     end
 
     def post(xml)
-      http.start { |h| h.request(post_request(xml)) }
+      http.dup.start { |h| h.request(post_request(xml)) }
     end
 
-    TRANSACTIONS.each do |name, request_name|
-      define_method(name) { |hash| call({ request_name => hash }, :"#{name}_response") }
+    TRANSACTIONS.each do |name, request_key|
+      define_method(name) do |hash|
+        call({ request_key => hash }, "#{request_key.sub(/Request$/, '')}Response")
+      end
     end
 
     private
@@ -50,7 +52,7 @@ module VantivLite
     end
 
     def default_attributes_with(hash)
-      hash['id'] ||= SecureRandom.hex(12)
+      hash['id'] ||= '0'
       hash['reportGroup'] ||= config.report_group
       hash
     end
@@ -62,7 +64,7 @@ module VantivLite
           'version' => config.version,
           'merchantId' => config.merchant_id,
           'authentication' => { 'user' => config.username, 'password' => config.password }
-        }.merge(insert_default_attributes(lower_camelize_keys(request_hash)))
+        }.merge(insert_default_attributes(request_hash))
       }
     end
 
@@ -72,16 +74,6 @@ module VantivLite
       end
     end
 
-    def lower_camelize_keys(hash)
-      XML.transform_keys(hash) do |k|
-        if k.is_a?(String)
-          k
-        else
-          k.to_s.gsub(/_[a-z]/i) { |m| m[1].upcase }.tap { |s| s[0] = s[0].downcase }
-        end
-      end
-    end
-
     def post_request(xml)
       Net::HTTP::Post.new(config.uri.path).tap do |r|
         r['Content-Type'] ||= 'text/xml; charset=UTF-8'

data/lib/vantiv_lite/response.rb

@@ -5,7 +5,7 @@ require 'vantiv_lite/xml'
 module VantivLite
   class Response
     ServerError = Class.new(StandardError)
-    ROOT_KEY = :litle_online_response
+    ROOT_KEY = 'litleOnlineResponse'.freeze
 
     module Refinements
       [Array, Hash].each do |klass|
@@ -59,14 +59,9 @@ module VantivLite
     end
 
     def response_hash_with(response_hash, dig_keys)
-      response_hash = underscore_symbolize_keys(response_hash)
       raise ServerError, "missing root :#{ROOT_KEY}" unless (root_hash = response_hash[ROOT_KEY])
-      raise ServerError, root_hash[:message] unless root_hash[:response] == '0'
+      raise ServerError, root_hash['message'] unless root_hash['response'] == '0'
       dig_keys.any? ? root_hash.dig(*dig_keys) : root_hash
     end
-
-    def underscore_symbolize_keys(hash)
-      XML.transform_keys(hash) { |k| k.gsub(/[A-Z]/) { |m| "_#{m.downcase}" }.to_sym }
-    end
   end
 end

data/lib/vantiv_lite/version.rb

@@ -3,7 +3,7 @@
 module VantivLite
   MAJOR = 0
   MINOR = 1
-  TINY  = 1
+  TINY  = 6
   VERSION = [MAJOR, MINOR, TINY].join('.').freeze
 
   def self.version

data/lib/vantiv_lite/xml.rb

@@ -24,13 +24,6 @@ module VantivLite
       def serializer_with(name, attributes: Serializer::ATTRIBUTES)
         const_get(name)::Serializer.new(attributes: attributes)
       end
-
-      def transform_keys(hash, &blk)
-        return hash unless hash.is_a?(Hash)
-        hash.each_with_object({}) do |(k, obj), h|
-          h[yield(k)] = XML.hash_or_array(obj) { |o| transform_keys(o, &blk) }
-        end
-      end
     end
   end
 end

data/lib/vantiv_lite/xml/serializer.rb

@@ -3,13 +3,15 @@
 module VantivLite
   module XML
     module Serializer
-      ATTRIBUTES = %w[id merchantId reportGroup version xmlns].freeze
+      ATTRIBUTES = %w[customerId id merchantId reportGroup version xmlns].freeze
 
       @@type_coercions = {}
       def self.coerce(type, obj = nil, &blk)
         raise TypeError, '`type` must be a `Class`' unless type.is_a?(Class)
+
         obj ||= blk
         raise TypeError, '`obj` must respond to `call`' unless obj.respond_to?(:call)
+
         @@type_coercions[type] = obj
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vantiv_lite
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.6
 platform: ruby
 authors:
 - Joshua
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-16 00:00:00.000000000 Z
+date: 2020-07-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -31,56 +31,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '1'
 - !ruby/object:Gem::Dependency
   name: ox
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.9'
+        version: '2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.9'
+        version: '2'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.3'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -135,7 +135,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.4
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: A Simplified Vanitiv/WorldPay (LitleOnline) API Library