vantiv_lite 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4782fb49b793badc095bdf9acdaa35986031dabc
-  data.tar.gz: ee000b2ae92a4a05b5e346ec6fcf3a83c06f1f07
+  metadata.gz: 8c91c1fa1527e5eaa1e94d100c3e3bf4e56b806c
+  data.tar.gz: 1bd58157041ce8fb7a6215587f8129bf9f07d9e5
 SHA512:
-  metadata.gz: fa12d86c48824f7eda942471835f5d7694e94d89c9a6587b1bc759309aa04ae481175df1fd2e575fd8f62b1573c234e139632aa2219a05ec0804cc2eb4ffd9bd
-  data.tar.gz: 29f88adb3311a7c7ee1f7401a095457fbaed8b9b3c77f9f481ead4e1e4e4914ab02a0109fd4418188cabfd0c788a7736f32d7550cb43226dbcab78762baf507d
+  metadata.gz: d1e0c35fb1d8cdd08f16da4ae9ff1a12db86344ec6ecb0f5b431897fd65674f02523e3bb9bb41c2d7aeb233303ee2b99e5bab2ca7178802e36f35af732631e56
+  data.tar.gz: f6ba9b13570f4395d3fb40c3f69025d94a5ec75bfc550cc86eaf9daa3641266e3df4e80d3233d9517f32eb7de2d74d690fd85e83a03a26d5f32bb43d1e07a5da

data/README.md

@@ -95,9 +95,9 @@ A basic request can be made using `VantivLite.request`. This uses the global con
 
 ```ruby
 params = {
-  register_token_request: {
-    order_id: '50',
-    account_number: '4457119922390123'
+  'registerTokenRequest' => {
+    'orderId' => '50',
+    'accountNumber' => '4457119922390123'
   }
 }
 
@@ -107,18 +107,18 @@ response = VantivLite.request(params) # => #<VantivLite::Response>
 This will return a `VantivLite::Response` which itself operates much like a hash:
 
 ```ruby
-response.dig(:register_token_response, :litle_token) # => "1111222233330123"
+response.dig('registerTokenResponse', 'litleToken') # => "1111222233330123"
 ```
 
 For many simple transactions the `*_request` and `*_response` keys get a little tedious. So, this can be abreviated to the following:
 
 ```ruby
 params = {
-  order_id: '50',
-  account_number: '4457119922390123'
+  'orderId' => '50',
+  'accountNumber' => '4457119922390123'
 }
 
-response = VantivLite.register_token(params).dig(:litle_token) # => "1111222233330123"
+response = VantivLite.register_token(params).dig('litleToken') # => "1111222233330123"
 ```
 
 There are shortcuts for the requests:
@@ -131,17 +131,15 @@ There are shortcuts for the requests:
   * `sale`
   * `void`
 
-Note that the only transformation that is done is underscoring and symbolizing keys. No other mapping is done.
-
 ### Requests With Multiple Configurations
 
 `VantiveLite.request` (and the various convenience versions) simply uses `Vantiv.default_request` which is just an instance of `VantivLite::Request`. The request object itself can be used similarly with the methods by invoking `#call`:
 
 ```ruby
 params = {
-  register_token_request: {
-    order_id: '50',
-    account_number: '4457119922390123'
+  'registerTokenRequest' => {
+    'orderId' => '50',
+    'accountNumber' => '4457119922390123'
   }
 }
 
@@ -150,8 +148,8 @@ response = VantivLite::Request.new(custom_config).(params) # => #<VantivLite::Re
 # Shortcut methods also work:
 
 params = {
-  order_id: '50',
-  account_number: '4457119922390123'
+  'orderId' => '50',
+  'accountNumber' => '4457119922390123'
 }
 
 response = VantivLite::Request.new(custom_config).register_token(params)
@@ -163,10 +161,10 @@ Obviously, XML doesn't map nice and neat to a hash and vice-versa. However, Vant
 
 ```ruby
 params = {
-  register_token_request: {
-    id: 'abcdef',
-    order_id: '50',
-    account_number: '4457119922390123'
+  'registerTokenRequest' => {
+    'id' => 'abcdef',
+    'orderId' => '50',
+    'accountNumber' => '4457119922390123'
   }
 }
 ```

data/lib/vantiv_lite/request.rb

@@ -6,13 +6,13 @@ require 'vantiv_lite/xml'
 
 module VantivLite
   TRANSACTIONS = {
-    auth_reversal: :auth_reversal,
-    authorization: :authorization,
-    capture: :capture,
-    credit: :credit,
-    register_token: :register_token_request,
-    sale: :sale,
-    void: :void
+    auth_reversal: 'authReversal',
+    authorization: 'authorization',
+    capture: 'capture',
+    credit: 'credit',
+    register_token: 'registerTokenRequest',
+    sale: 'sale',
+    void: 'void'
   }.freeze
 
   class Request
@@ -37,8 +37,10 @@ module VantivLite
       http.start { |h| h.request(post_request(xml)) }
     end
 
-    TRANSACTIONS.each do |name, request_name|
-      define_method(name) { |hash| call({ request_name => hash }, :"#{name}_response") }
+    TRANSACTIONS.each do |name, request_key|
+      define_method(name) do |hash|
+        call({ request_key => hash }, "#{request_key.sub(/Request$/, '')}Response")
+      end
     end
 
     private
@@ -62,7 +64,7 @@ module VantivLite
           'version' => config.version,
           'merchantId' => config.merchant_id,
           'authentication' => { 'user' => config.username, 'password' => config.password }
-        }.merge(insert_default_attributes(lower_camelize_keys(request_hash)))
+        }.merge(insert_default_attributes(request_hash))
       }
     end
 
@@ -72,16 +74,6 @@ module VantivLite
       end
     end
 
-    def lower_camelize_keys(hash)
-      XML.transform_keys(hash) do |k|
-        if k.is_a?(String)
-          k
-        else
-          k.to_s.gsub(/_[a-z]/i) { |m| m[1].upcase }.tap { |s| s[0] = s[0].downcase }
-        end
-      end
-    end
-
     def post_request(xml)
       Net::HTTP::Post.new(config.uri.path).tap do |r|
         r['Content-Type'] ||= 'text/xml; charset=UTF-8'

data/lib/vantiv_lite/response.rb

@@ -5,7 +5,7 @@ require 'vantiv_lite/xml'
 module VantivLite
   class Response
     ServerError = Class.new(StandardError)
-    ROOT_KEY = :litle_online_response
+    ROOT_KEY = 'litleOnlineResponse'.freeze
 
     module Refinements
       [Array, Hash].each do |klass|
@@ -59,14 +59,9 @@ module VantivLite
     end
 
     def response_hash_with(response_hash, dig_keys)
-      response_hash = underscore_symbolize_keys(response_hash)
       raise ServerError, "missing root :#{ROOT_KEY}" unless (root_hash = response_hash[ROOT_KEY])
-      raise ServerError, root_hash[:message] unless root_hash[:response] == '0'
+      raise ServerError, root_hash['message'] unless root_hash['response'] == '0'
       dig_keys.any? ? root_hash.dig(*dig_keys) : root_hash
     end
-
-    def underscore_symbolize_keys(hash)
-      XML.transform_keys(hash) { |k| k.gsub(/[A-Z]/) { |m| "_#{m.downcase}" }.to_sym }
-    end
   end
 end

data/lib/vantiv_lite/version.rb

@@ -3,7 +3,7 @@
 module VantivLite
   MAJOR = 0
   MINOR = 1
-  TINY  = 1
+  TINY  = 2
   VERSION = [MAJOR, MINOR, TINY].join('.').freeze
 
   def self.version

data/lib/vantiv_lite/xml.rb

@@ -24,13 +24,6 @@ module VantivLite
       def serializer_with(name, attributes: Serializer::ATTRIBUTES)
         const_get(name)::Serializer.new(attributes: attributes)
       end
-
-      def transform_keys(hash, &blk)
-        return hash unless hash.is_a?(Hash)
-        hash.each_with_object({}) do |(k, obj), h|
-          h[yield(k)] = XML.hash_or_array(obj) { |o| transform_keys(o, &blk) }
-        end
-      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vantiv_lite
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Joshua
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-16 00:00:00.000000000 Z
+date: 2018-05-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler