vanilla_nested 1.2.2 → 1.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4a6640e42d6a7195a2266b57ce2c77d3edffb1a1de0662ede0b6d19aa4b126bf
-  data.tar.gz: 1b74a76aed703a1a2019f2b98d24ba6595f7faf72ac52acc22f8470b43204fc3
+  metadata.gz: 62b2d8f1c6e1c74ee3ade42bc1a96b311b008773cf2817742d3d859d255e256a
+  data.tar.gz: 52d1585917b4858208409fdf4c2c65d591ee8da58c823d56b57b83eb87d42f5e
 SHA512:
-  metadata.gz: 536f8c0238182518afda5f82662a90a8695d0324f526d2666b69235c5e482275f3d95b4a77e8e519d523c208a81beb4fcfa776dceded510187052ce97f384b5d
-  data.tar.gz: 50775a3000f06c76bc2e99c53669ded2a26c7c92775438b4ef4400f905835c60028a947f47c74c7b6853474926efdf669e2ff724e08ac5e7049b203e427759de
+  metadata.gz: d33496672d2818c8d9ae85503dfa136289ef1e709f3403e005313628cdd774d0af52182c02a5f22f6893e0e96de3846e8e9d3b928955ddbb5ee532c474bce1be
+  data.tar.gz: 1766822ad50b0046cc023d999d6f441f0cea3b15c3ecebcd0ffff5b9387c6d8aef2b959a5cbe84c1a674c4de88afff71d5dfb1ee2578b6bca1b72a1215c48a99

data/app/assets/javascripts/vanilla_nested.js

@@ -4,11 +4,15 @@
   window.addVanillaNestedFields = function(event) {
     event.preventDefault();
 
-    const element = event.target;
+    let element = event.target;
+    if (!element.classList.contains('vanilla-nested-add'))
+      element = element.closest('.vanilla-nested-add')
+
     const data = element.dataset;
     const container = document.querySelector(data.containerSelector);
     const newHtml = data.html.replace(/_idx_placeholder_/g, Date.now());
 
+    // insert and store reference
     let inserted;
     switch (data.methodForInsert) {
       case ('append'):
@@ -21,15 +25,18 @@
         break;
     }
 
+    // add a class to show it was added dynamically
+    inserted.classList.add('added-by-vanilla-nested');
+
     _dispatchEvent(container, 'vanilla-nested:fields-added', element, {added: inserted})
 
     let removeLink = inserted.querySelector('.vanilla-nested-remove');
     if (removeLink)
-      removeLink.addEventListener('click', removeVanillaNestedFields);
+      removeLink.addEventListener('click', removeVanillaNestedFields, true);
 
     // dispatch an event if we reached the limit configured on the model
     if (data.limit) {
-      let nestedElements = container.children.length;
+      let nestedElements = container.querySelectorAll('[name$="[_destroy]"][value="0"]').length;
       if (nestedElements >= data.limit)
         _dispatchEvent(container, 'vanilla-nested:fields-limit-reached', element)
     }
@@ -40,7 +47,10 @@
   window.removeVanillaNestedFields = function(event) {
     event.preventDefault();
 
-    const element = event.target;
+    let element = event.target;
+    if (!element.classList.contains('vanilla-nested-remove'))
+      element = element.closest('.vanilla-nested-remove')
+
     const data = element.dataset;
     let wrapper = element.parentElement;
     if (sel = data.fieldsWrapperSelector) wrapper = element.closest(sel);
@@ -59,7 +69,13 @@
   // Hides an element, mainly the wrapper of a group of fields
   // "wrapper" is the wrapper of the link to remove fields
   function hideWrapper(wrapper) {
-    wrapper.style.display = 'none';
+    if (wrapper.classList.contains('added-by-vanilla-nested')) {
+      wrapper.remove();
+    } else {
+      const destroyInput = wrapper.querySelector('[name$="[_destroy]"');
+      wrapper.innerHTML = '';
+      wrapper.insertAdjacentElement('afterbegin', destroyInput);
+    }
   }
 
   // Unhides the children given a fields wrapper
@@ -121,13 +137,28 @@
     return undo;
   }
 
-  document.addEventListener('DOMContentLoaded', function(){
+  function initVanillaNested() {
     document.querySelectorAll('.vanilla-nested-add').forEach(el => {
-      el.addEventListener('click', addVanillaNestedFields);
+      el.addEventListener('click', addVanillaNestedFields, true);
     })
 
     document.querySelectorAll('.vanilla-nested-remove').forEach(el => {
-      el.addEventListener('click', removeVanillaNestedFields);
+      el.addEventListener('click', removeVanillaNestedFields, true);
     })
+  }
+
+  document.addEventListener('DOMContentLoaded', function(){
+    initVanillaNested();
+  })
+
+  // Don't run turbolinks/turbo event callback for first load, we already do it with DOMContentLoaded
+  const notEmpty = (obj) => Object.keys(obj).length;
+
+  document.addEventListener('turbolinks:load', function(e){
+    if (notEmpty(e.data.timing)) initVanillaNested();
+  })
+
+  document.addEventListener('turbo:load', function(e){
+    if (notEmpty(e.detail.timing)) initVanillaNested();
   })
 })()

data/lib/vanilla_nested/view_helpers.rb

@@ -4,14 +4,16 @@ module VanillaNested
   module ViewHelpers
     # @param form [FormBuild] builder on a "form_for" block
     # @param association [Symbol] name of the association
-    # @param container_selector [String] selector of the element to inser the fields
+    # @param container_selector [String] selector of the element to insert the fields
     # @param link_text [String, nil] text to use for the link tag
     # @param link_classes [String] space separated classes for the link tag
     # @param insert_method [:append, :prepend] tells javascript if the new fields should be appended or prepended to the container
     # @param partial_form_variable [String, Symbol] name of the variable that represents the form builder inside the fields partial
+    # @param tag [String] HTML tag to use for the html generated, defaults to and `a` tag
     # @param link_content [Block] block of code for the link content
+    # @param tag_attributes [Hash<attribute, value>] hash with attribute,value pairs for the html tag
     # @return [String] link tag
-    def link_to_add_nested(form, association, container_selector, link_text: nil, link_classes: '', insert_method: :append, partial: nil, partial_form_variable: :form, &link_content)
+    def link_to_add_nested(form, association, container_selector, link_text: nil, link_classes: '', insert_method: :append, partial: nil, partial_form_variable: :form, tag: 'a', tag_attributes: {}, &link_content)
       association_class = form.object.class.reflections[association.to_s].klass
       object = association_class.new
 
@@ -35,11 +37,16 @@ module VanillaNested
       nested_options = form.object.class.nested_attributes_options[association.to_sym]
       data['limit'] = nested_options[:limit] if nested_options[:limit]
 
-      if block_given?
-        link_to '#', class: classes, data: data, &link_content
-      else
-        text = link_text || "Add #{association_class.model_name}"
-        link_to text, '#', class: classes, data: data
+      attributes = tag_attributes
+      attributes[:class] = "#{attributes.fetch(:class, '')} #{classes}"
+      attributes[:data] = attributes.fetch(:data, {}).merge(data)
+
+      content_tag(tag, attributes) do
+        if block_given?
+          yield link_content
+        else
+          link_text || "Add #{association_class.model_name}"
+        end
       end
     end
 
@@ -50,9 +57,11 @@ module VanillaNested
     # @param undo_link_text [String] text to show as "undo"
     # @param undo_link_classes [String] space separated list of classes for the "undo" link
     # @param ulink_classes [String] space separated list of classes for the "x" link
+    # @param tag [String] HTML tag to use for the html generated, defaults to and `a` tag
     # @param link_content [Block] block of code for the link content
+    # @param tag_attributes [Hash<attribute, value>] hash with attribute,value pairs for the html tag
     # @return [String] hidden field and link tag
-    def link_to_remove_nested(form, link_text: 'X', fields_wrapper_selector: nil, undo_link_timeout: nil, undo_link_text: 'Undo', undo_link_classes: '', link_classes: '', &link_content)
+    def link_to_remove_nested(form, link_text: 'X', fields_wrapper_selector: nil, undo_link_timeout: nil, undo_link_text: 'Undo', undo_link_classes: '', link_classes: '', tag: 'a', tag_attributes: {}, &link_content)
       data = {
         'fields-wrapper-selector': fields_wrapper_selector,
         'undo-timeout': undo_link_timeout,
@@ -62,13 +71,19 @@ module VanillaNested
 
       classes = "vanilla-nested-remove #{link_classes}"
 
+      attributes = tag_attributes
+      attributes[:class] = "#{attributes.fetch(:class, '')} #{classes}"
+      attributes[:data] = attributes.fetch(:data, {}).merge(data)
+
       capture do
         concat form.hidden_field(:_destroy, value: 0)
         concat(
-          if block_given?
-            link_to('#', class: classes, data: data, &link_content)
-          else
-            link_to(link_text.html_safe, '#', class: classes, data: data)
+          content_tag(tag, attributes) do
+            if block_given?
+              yield link_content
+            else
+              link_text.html_safe
+            end
           end
         )
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: vanilla_nested
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 1.5.1
 platform: ruby
 authors:
 - Ariel Juodziukynas <arieljuod@gmail.com>
@@ -21,7 +21,7 @@ files:
 - lib/vanilla_nested/view_helpers.rb
 homepage: https://github.com/arielj/vanilla-nested
 licenses:
-- GPL-3.0
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -38,7 +38,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.0.9
 signing_key: 
 specification_version: 4
 summary: Dynamic nested forms using vanilla javascript