vanagon 0.18.0 → 0.20.1

data/spec/lib/vanagon/component/source/git_spec.rb

@@ -14,8 +14,8 @@ describe "Vanagon::Component::Source::Git" do
 
   # before(:each) blocks are run before each example
   before :each do
-    allow(Git)
-      .to receive(:ls_remote)
+    allow(Vanagon::Component::Source::Git)
+      .to receive(:valid_remote?)
             .and_return(true)
 
     allow(File).to receive(:realpath).and_return(@workdir)
@@ -24,8 +24,8 @@ describe "Vanagon::Component::Source::Git" do
   describe "#initialize" do
     it "raises error on initialization with an invalid repo" do
       # Ensure initializing a repo fails without calling over the network
-      allow(Git)
-        .to receive(:ls_remote)
+      allow(Vanagon::Component::Source::Git)
+        .to receive(:valid_remote?)
               .and_return(false)
 
       expect { @klass.new(@url, ref: @ref_tag, workdir: @workdir) }

data/spec/lib/vanagon/component_spec.rb

@@ -5,8 +5,9 @@ describe "Vanagon::Component" do
   describe "#get_environment" do
     subject { Vanagon::Component.new('env-test', {}, {}) }
 
-    it "prints a deprecation warning to STDERR" do
-      expect { subject.get_environment }.to output(/deprecated/).to_stderr
+    it "logs a deprecation warning with VanagonLogger.info" do
+      expect(VanagonLogger).to receive(:info).with(/deprecated/)
+      subject.get_environment
     end
 
     it "returns a makefile compatible environment" do
@@ -107,6 +108,18 @@ describe "Vanagon::Component" do
       expect(subject).to receive(:fetch_url)
       subject.get_source(@workdir)
     end
+
+    it 'retrieves from a canonical URI if VANAGON_USE_MIRRORS is set to "false"' do
+      allow(ENV).to receive(:[]).with('VANAGON_USE_MIRRORS').and_return('false')
+      allow(subject)
+        .to receive(:fetch_url)
+        .and_return(true)
+
+      # We expect #get_source to skip mirrors
+      expect(subject).not_to receive(:fetch_mirrors)
+      expect(subject).to receive(:fetch_url)
+      subject.get_source(@workdir)
+    end
   end
 
   describe "#get_sources" do

data/spec/lib/vanagon/engine/always_be_scheduling_spec.rb

@@ -174,8 +174,8 @@ describe 'Vanagon::Engine::AlwaysBeScheduling' do
       hostname = 'fainter-whirlwind.puppet.com'
       stub_request(:post, "https://foobar/request").
           to_return({status: 404, body: "", headers: {}},{status: 200, body: '[{"hostname":"'+hostname+'","type":"aix-6.1-ppc","engine":"nspooler"}]', headers: {}})
-      allow_any_instance_of(Object).to receive(:warn)
-      expect_any_instance_of(Object).to receive(:warn).with("failed to request ABS with code 404")
+      allow_any_instance_of(VanagonLogger).to receive(:info)
+      expect_any_instance_of(VanagonLogger).to receive(:info).with("failed to request ABS with code 404")
       abs_service = Vanagon::Engine::AlwaysBeScheduling.new(platform, nil)
       pooler = abs_service.select_target_from("https://foobar")
       expect(pooler).to eq('')
@@ -186,8 +186,8 @@ describe 'Vanagon::Engine::AlwaysBeScheduling' do
           to_return({status: 202, body: "", headers: {}},
                     {status: 503, body: "", headers: {}},
                     {status: 200, body: '[{"hostname":"'+hostname+'","type":"aix-6.1-ppc","engine":"nspooler"}]', headers: {}})
-      allow_any_instance_of(Object).to receive(:warn)
-      expect_any_instance_of(Object).to receive(:warn).with(/Waiting 1 seconds to check if ABS request has been filled/)
+      allow_any_instance_of(VanagonLogger).to receive(:info)
+      expect_any_instance_of(VanagonLogger).to receive(:info).with(/Waiting 1 seconds to check if ABS request has been filled/)
       abs_service = Vanagon::Engine::AlwaysBeScheduling.new(platform, nil)
       abs_service.select_target_from("https://foobar")
       expect(abs_service.target).to eq(hostname)

data/spec/lib/vanagon/platform_spec.rb

@@ -1,6 +1,33 @@
 require 'vanagon/platform'
 
 describe "Vanagon::Platform" do
+  let(:deb_platform_just_servicedir) { "platform 'debian-test-fixture' do |plat|
+                                       plat.servicedir '/etc/init.d'
+                                       end
+                                       "}
+  let(:deb_platform_just_servicetype) { "platform 'debian-test-fixture' do |plat|
+                                       plat.servicetype 'sysv'
+                                       end
+                                       "}
+  let(:deb_platform_multi_servicetypes) { "platform 'debian-test-fixture' do |plat|
+                                       plat.servicetype 'sysv', servicedir: '/etc/init.d'
+                                       plat.servicetype 'systemd', servicedir: '/lib/systemd/system'
+                                       end
+                                       "}
+  let(:deb_platform_no_service) { "platform 'debian-test-fixture' do |plat|
+                                       end
+                                       "}
+  let(:deb_platform_servicetype) { "platform 'debian-test-fixture' do |plat|
+                                       plat.servicetype 'sysv'
+                                       plat.servicedir '/etc/init.d'
+                                       end
+                                       "}
+  let(:deb_platform_bad_servicedir_block) { "platform 'debian-test-fixture' do |plat|
+                                            plat.servicetype 'sysv', servicedir: '/etc/init.d'
+                                            plat.servicetype 'sysv', servicedir: '/etc/rc.d'
+                                            end
+                                            "}
+
   let(:platforms) do
     [
       {
@@ -172,4 +199,57 @@ describe "Vanagon::Platform" do
       end
     end
   end
+
+  describe "#get_service_type" do
+    it "returns plat.servicetype if that's the only thing set" do
+      plat = Vanagon::Platform::DSL.new('debian-8-x86_64')
+      plat.instance_eval(deb_platform_just_servicetype)
+      expect(plat._platform.get_service_types).to include('sysv')
+    end
+
+    it "returns from servicetypes if that's set" do
+      plat = Vanagon::Platform::DSL.new('debian-8-x86_64')
+      plat.instance_eval(deb_platform_servicetype)
+      expect(plat._platform.get_service_types).to include('sysv')
+    end
+
+    it "returns multiples if there's more than one" do
+      plat = Vanagon::Platform::DSL.new('debian-8-x86_64')
+      plat.instance_eval(deb_platform_multi_servicetypes)
+      expect(plat._platform.get_service_types).to include('sysv')
+      expect(plat._platform.get_service_types).to include('systemd')
+    end
+
+    it "returns an empty array if nothing is set" do
+      plat = Vanagon::Platform::DSL.new('debian-8-x86_64')
+      plat.instance_eval(deb_platform_no_service)
+      expect(plat._platform.get_service_types.size).to eq(0)
+    end
+  end
+
+  describe "#get_service_dir" do
+    it "returns plat.servicedir if that's the only thing set" do
+      plat = Vanagon::Platform::DSL.new('debian-8-x86_64')
+      plat.instance_eval(deb_platform_just_servicedir)
+      expect(plat._platform.get_service_dir).to eq('/etc/init.d')
+    end
+
+    it "returns servicedirs set via servicetype" do
+      plat = Vanagon::Platform::DSL.new('debian-8-x86_64')
+      plat.instance_eval(deb_platform_servicetype)
+      expect(plat._platform.get_service_dir).to eq('/etc/init.d')
+    end
+
+    it "returns the servicedir based on servicetype" do
+      plat = Vanagon::Platform::DSL.new('debian-8-x86_64')
+      plat.instance_eval(deb_platform_multi_servicetypes)
+      expect(plat._platform.get_service_dir('systemd')).to eq('/lib/systemd/system')
+    end
+
+    it "fails if there are >1 servicedir for a service type" do
+      plat = Vanagon::Platform::DSL.new('debian-8-x86_64')
+      plat.instance_eval(deb_platform_bad_servicedir_block)
+      expect { plat._platform.get_service_dir('sysv') }.to raise_error(Vanagon::Error)
+    end
+  end
 end

data/spec/lib/vanagon/utilities_spec.rb

@@ -72,12 +72,15 @@ describe "Vanagon::Utilities" do
   describe '#local_command' do
     it 'runs commands in an unpolluted environment' do
       cmd = lambda { |arg| %(echo 'if [ "$#{arg}" = "" ]; then exit 0; else exit 1; fi' | /bin/sh) }
-      vars = %w(BUNDLE_BIN_PATH BUNDLE_GEMFILE)
+      vars = %w[BUNDLE_BIN_PATH BUNDLE_GEMFILE]
       vars.each do |var|
         Vanagon::Utilities.local_command(cmd.call(var))
         expect($?.exitstatus).to eq(0)
       end
     end
+    it 'raises a RuntimeError when given a bad thing' do
+      expect { Vanagon::Utilities.local_command('__bogus__comand__') }.to raise_error(RuntimeError)
+    end
   end
 
   describe '#ssh_command' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: vanagon
 version: !ruby/object:Gem::Version
-  version: 0.18.0
+  version: 0.20.1
 platform: ruby
 authors:
 - Puppet Labs
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-12-08 00:00:00.000000000 Z
+date: 2021-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: docopt
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.0
+        version: 1.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.0
+        version: 1.8.0
 - !ruby/object:Gem::Dependency
   name: fustigit
   requirement: !ruby/object:Gem::Requirement
@@ -148,6 +148,7 @@ files:
 - lib/vanagon/extensions/ostruct/json.rb
 - lib/vanagon/extensions/set/json.rb
 - lib/vanagon/extensions/string.rb
+- lib/vanagon/logger.rb
 - lib/vanagon/patch.rb
 - lib/vanagon/platform.rb
 - lib/vanagon/platform/deb.rb
@@ -292,41 +293,41 @@ signing_key:
 specification_version: 3
 summary: All of your packages will fit into this van with this one simple trick.
 test_files:
-- spec/lib/git/rev_list_spec.rb
-- spec/lib/makefile_spec.rb
+- spec/lib/vanagon/extensions/ostruct/json_spec.rb
+- spec/lib/vanagon/extensions/string_spec.rb
+- spec/lib/vanagon/extensions/set/json_spec.rb
+- spec/lib/vanagon/platform/rpm_spec.rb
+- spec/lib/vanagon/platform/rpm/aix_spec.rb
+- spec/lib/vanagon/platform/windows_spec.rb
+- spec/lib/vanagon/platform/osx_spec.rb
+- spec/lib/vanagon/platform/solaris_10_spec.rb
+- spec/lib/vanagon/platform/dsl_spec.rb
+- spec/lib/vanagon/platform/deb_spec.rb
+- spec/lib/vanagon/platform/solaris_11_spec.rb
+- spec/lib/vanagon/project/dsl_spec.rb
 - spec/lib/vanagon/environment_spec.rb
-- spec/lib/vanagon/engine/pooler_spec.rb
+- spec/lib/vanagon/engine/ec2_spec.rb
+- spec/lib/vanagon/engine/local_spec.rb
 - spec/lib/vanagon/engine/docker_spec.rb
+- spec/lib/vanagon/engine/base_spec.rb
 - spec/lib/vanagon/engine/hardware_spec.rb
 - spec/lib/vanagon/engine/always_be_scheduling_spec.rb
-- spec/lib/vanagon/engine/base_spec.rb
-- spec/lib/vanagon/engine/local_spec.rb
-- spec/lib/vanagon/engine/ec2_spec.rb
-- spec/lib/vanagon/extensions/string_spec.rb
-- spec/lib/vanagon/extensions/set/json_spec.rb
-- spec/lib/vanagon/extensions/ostruct/json_spec.rb
-- spec/lib/vanagon/project_spec.rb
-- spec/lib/vanagon/common/pathname_spec.rb
-- spec/lib/vanagon/common/user_spec.rb
-- spec/lib/vanagon/component/source/git_spec.rb
+- spec/lib/vanagon/engine/pooler_spec.rb
+- spec/lib/vanagon/component_spec.rb
+- spec/lib/vanagon/component/rules_spec.rb
 - spec/lib/vanagon/component/source/http_spec.rb
 - spec/lib/vanagon/component/source/local_spec.rb
 - spec/lib/vanagon/component/source/rewrite_spec.rb
-- spec/lib/vanagon/component/source_spec.rb
-- spec/lib/vanagon/component/rules_spec.rb
+- spec/lib/vanagon/component/source/git_spec.rb
 - spec/lib/vanagon/component/dsl_spec.rb
-- spec/lib/vanagon/component_spec.rb
-- spec/lib/vanagon/project/dsl_spec.rb
-- spec/lib/vanagon/platform/rpm/aix_spec.rb
-- spec/lib/vanagon/platform/deb_spec.rb
-- spec/lib/vanagon/platform/rpm_spec.rb
-- spec/lib/vanagon/platform/solaris_10_spec.rb
-- spec/lib/vanagon/platform/osx_spec.rb
-- spec/lib/vanagon/platform/windows_spec.rb
-- spec/lib/vanagon/platform/solaris_11_spec.rb
-- spec/lib/vanagon/platform/dsl_spec.rb
-- spec/lib/vanagon/cli_spec.rb
+- spec/lib/vanagon/component/source_spec.rb
 - spec/lib/vanagon/platform_spec.rb
-- spec/lib/vanagon/utilities/shell_utilities_spec.rb
+- spec/lib/vanagon/cli_spec.rb
 - spec/lib/vanagon/utilities_spec.rb
+- spec/lib/vanagon/common/user_spec.rb
+- spec/lib/vanagon/common/pathname_spec.rb
 - spec/lib/vanagon/driver_spec.rb
+- spec/lib/vanagon/project_spec.rb
+- spec/lib/vanagon/utilities/shell_utilities_spec.rb
+- spec/lib/makefile_spec.rb
+- spec/lib/git/rev_list_spec.rb