vanagon 0.17.0 → 0.20.0

data/resources/deb/prerm.erb

@@ -13,15 +13,25 @@ fi
 <%- get_services.each do |service| -%>
   # switch based on systemd vs systemv
   #
-  <%- if @platform.servicetype == "systemd" -%>
-if [ "$1" = remove ]; then
-  systemctl --no-reload disable <%= service.name %>.service > /dev/null 2>&1 || :
-  systemctl stop <%= service.name %>.service > /dev/null 2>&1 || :
+  <%- if service.init_system.nil? || service.init_system.eql?('systemd') -%>
+if [ -f '/proc/1/comm' ]; then
+  init_comm=`cat /proc/1/comm`
+  if [ "$init_comm" = "systemd" ]; then
+    if [ "$1" = remove ]; then
+      systemctl --no-reload disable <%= service.name %>.service > /dev/null 2>&1 || :
+      systemctl stop <%= service.name %>.service > /dev/null 2>&1 || :
+    fi
+  fi
 fi
-
-  <%- elsif @platform.servicetype == "sysv" -%>
-if [ -x "<%= service.service_file %>" ] && [ "$1" = remove ]; then
-  invoke-rc.d <%= service.name %> stop || true
+  <%- end -%>
+  <%- if service.init_system.nil? || service.init_system.eql?('sysv') -%>
+if [ -f '/proc/1/comm' ]; then
+  init_comm=`cat /proc/1/comm`
+  if [ "$init_comm" = "init" ]; then
+    if [ -x "<%= service.service_file %>" ] && [ "$1" = remove ]; then
+      invoke-rc.d <%= service.name %> stop || true
+    fi
+  fi
 fi
   <%- end -%>
 <%- end -%>

data/resources/osx/postinstall.erb

@@ -6,7 +6,11 @@
 dest_file = config.path.gsub(/\.pristine$/, '') -%>
 
 if [ -f "<%= dest_file %>" ]; then
-  echo "Detected file at '<%= dest_file %>'; updated file at '<%= config.path %>'."
+  if diff "<%= config.path %>" "<%= dest_file %>" > /dev/null; then
+    rm -f "<%= config.path %>"
+  else
+    echo "Detected file at '<%= dest_file %>'; updated file at '<%= config.path %>'."
+  fi
 else
   mv '<%= config.path %>' '<%= dest_file %>'
 fi

data/resources/rpm/project.spec.erb

@@ -77,7 +77,7 @@ Source1:        file-list-for-rpm
 Autoprov: 0
 Autoreq: 0
 <%- get_requires.each do |requires| -%>
-Requires:  <%= requires %>
+Requires:  <%= requires.requirement %><%= requires.version ? " #{requires.version}" : "" %>
 <%- end -%>
 
 # All rpm packages built by vanagon have the pre-/post-install script
@@ -98,7 +98,7 @@ Requires(post): /bin/touch
 <%- end -%>
 
 <%- if has_services? -%>
-  <%- if @platform.servicetype == "systemd" -%>
+  <%- if @platform.get_service_types.include?("systemd") -%>
     <%- if @platform.is_sles? -%>
 BuildRequires:    systemd
 %{?systemd_requires}
@@ -108,7 +108,7 @@ Requires(post):   systemd
 Requires(preun):  systemd
 Requires(postun): systemd
     <%- end -%>
-  <%- elsif @platform.servicetype == "sysv" -%>
+  <%- elsif @platform.get_service_types.include?("sysv") -%>
     <%- if @platform.is_sles? -%>
 Requires: aaa_base
     <%- elsif @platform.is_linux? -%>
@@ -256,15 +256,15 @@ fi
 <%- get_services.each do |service| -%>
   # switch based on systemd vs systemv vs smf vs aix
   #
-  <%- if @platform.servicetype == "systemd" -%>
+  <%- if @platform.get_service_types.include?("systemd") -%>
     <%- if @platform.is_sles? -%>
       %service_add_post <%= service.name %>.service
     <%- else -%>
       %systemd_post <%= service.name %>.service
     <%- end -%>
-  <%- elsif @platform.servicetype == "sysv" -%>
+  <%- elsif @platform.get_service_types.include?("sysv") -%>
     chkconfig --add <%= service.name %> >/dev/null 2>&1 || :
-  <%- elsif @platform.servicetype == "aix" -%>
+  <%- elsif @platform.get_service_types.include?("aix") -%>
     if /usr/bin/lssrc -s <%= service.name -%> > /dev/null 2>&1; then
       /usr/bin/chssys -s <%= service.name -%> -p <%= service.service_command -%> -w 7 -S -n 15 -f 9 > /dev/null 2>&1 || :
     else
@@ -305,17 +305,17 @@ fi
 <%- get_services.each do |service| -%>
   # switch based on systemd vs systemv vs smf vs aix
   #
-  <%- if @platform.servicetype == "systemd" -%>
+  <%- if @platform.get_service_types.include?("systemd") -%>
     <%- if @platform.is_sles? -%>
       %service_del_postun <%= service.name %>.service
     <%- else -%>
       %systemd_postun_with_restart <%= service.name %>.service
     <%- end -%>
-  <%- elsif @platform.servicetype == "sysv" -%>
+  <%- elsif @platform.get_service_types.include?("sysv") -%>
     if [ "$1" -eq 1 ]; then
       /sbin/service <%= service.name %> condrestart || :
     fi
-  <%- elsif @platform.servicetype == "aix" -%>
+  <%- elsif @platform.get_service_types.include?("aix") -%>
     if  [ "$1" -eq 0 ]; then
       /usr/bin/rmssys -s <%= service.name -%> > /dev/null 2>&1 || :
       /usr/sbin/rmitab <%= service.name -%> > /dev/null 2>&1 || :
@@ -336,18 +336,18 @@ if [ "$1" -eq 0 ] ; then
 fi
 
 <%- get_services.each do |service| -%>
-  <%- if @platform.servicetype == "systemd" -%>
+  <%- if @platform.get_service_types.include?("systemd") -%>
     <%- if @platform.is_sles? -%>
       %service_del_preun <%= service.name %>.service
     <%- else -%>
       %systemd_preun <%= service.name %>.service
     <%- end -%>
-  <%- elsif @platform.servicetype == "sysv" -%>
+  <%- elsif @platform.get_service_types.include?("sysv") -%>
     if [ "$1" -eq 0 ]; then
       /sbin/service <%= service.name %> stop >/dev/null 2>&1 || :
       chkconfig --del <%= service.name %> || :
     fi
-  <%- elsif @platform.servicetype == "aix" -%>
+  <%- elsif @platform.get_service_types.include?("aix") -%>
       # stop the service only on a real uninstall, not on upgrades
       if [ "$1" -eq 0 ] ; then
           /usr/bin/stopsrc -s <%= service.name -%> > /dev/null 2>&1 || :

data/resources/solaris/10/depend.erb

@@ -1,3 +1,3 @@
-<%- get_requires.each do |requirement| -%>
-P <%= requirement %>
+<%- get_requires.each do |requires| -%>
+P <%= requires.requirement %>
 <%- end -%>

data/resources/solaris/10/postinstall.erb

@@ -10,7 +10,11 @@
 dest_file = config.path.gsub(/\.pristine$/, '') -%>
 
 if [ -f "<%= dest_file %>" ]; then
-  echo "Detected file at '<%= dest_file %>'; updated file at '<%= config.path %>'."
+  if diff "<%= config.path %>" "<%= dest_file %>" > /dev/null; then
+    rm -f "<%= config.path %>"
+  else
+    echo "Detected file at '<%= dest_file %>'; updated file at '<%= config.path %>'."
+  fi
 else
   cp -pr '<%= config.path %>' '<%= dest_file %>'
 fi
@@ -19,7 +23,11 @@ fi
 
 # Set up any specific permissions needed...
 <%- (get_directories + get_configfiles + get_files).select { |pathname| pathname.has_overrides? }.uniq.each do |file_or_directory| -%>
-  <%= "chmod '#{file_or_directory.mode}' '#{file_or_directory.path}'" if file_or_directory.mode %>
+  <%- if file_or_directory.mode -%>
+  if [ -f "<%= file_or_directory.path %>" ] || [ -d "<%= file_or_directory.path %>" ]; then
+    chmod '<%= file_or_directory.mode %>' '<%= file_or_directory.path %>'
+  fi
+  <%- end -%>
   <%- if file_or_directory.owner -%>
     if getent passwd '<%= file_or_directory.owner %>' &> /dev/null; then
       chown '<%= file_or_directory.owner %>' '<%= file_or_directory.path %>'

data/resources/solaris/11/p5m.erb

@@ -17,8 +17,8 @@ set name=variant.opensolaris.zone value=global value=nonglobal
 %>
 
 # Add any needed dependencies
-<%- get_requires.each do |requirement| -%>
-depend fmri=pkg:/<%= requirement %> type=require
+<%- get_requires.each do |requires| -%>
+depend fmri=pkg:/<%= requires.requirement %> type=require
 <%- end -%>
 
 # Always drop /etc, /usr, and /var, it will cause conflicts with other system packages

data/spec/lib/vanagon/cli_spec.rb

@@ -78,3 +78,146 @@ describe Vanagon::CLI do
     end
   end
 end
+
+describe Vanagon::CLI::List do 
+  let(:cli) { Vanagon::CLI::List.new }
+  
+  describe "#output" do 
+      let(:list) { ['a', 'b', 'c']}
+      it "returns an array if space is false" do 
+          expect(cli.output(list, false)).to eq(list)
+      end 
+      it "returns space separated if space is true" do 
+          expect(cli.output(list, true)).to eq('a b c')
+      end 
+  end
+
+  describe "#run" do 
+    let(:projects){ ['foo', 'bar', 'baz'] }
+    let(:platforms){ ['1', '2', '3'] }
+    let(:output_both){
+"- Projects
+foo
+bar
+baz
+
+- Platforms
+1
+2
+3
+"
+}
+    context "specs with standard config path" do
+      before(:each) do
+        expect(Dir).to receive(:exist?)
+          .with("#{File.join(Dir.pwd, 'configs', 'platforms')}")
+          .and_return(true)
+        expect(Dir).to receive(:exist?)
+          .with("#{File.join(Dir.pwd, 'configs', 'projects')}")
+          .and_return(true)
+        expect(Dir).to receive(:children)
+          .with("#{File.join(Dir.pwd, 'configs', 'projects')}")
+          .and_return(projects)
+        expect(Dir).to receive(:children)
+          .with("#{File.join(Dir.pwd, 'configs', 'platforms')}")
+          .and_return(platforms)
+      end
+      let(:options_empty) { {
+        nil=>false, 
+        :configdir=>"#{Dir.pwd}/configs", 
+        :platforms=>false, 
+        :projects=>false, 
+        :use_spaces=>false
+      } }
+      let(:options_platforms_only) { {
+        nil=>false, 
+        :configdir=>"#{Dir.pwd}/configs", 
+        :platforms=>true, 
+        :projects=>false, 
+        :use_spaces=>false
+      } }
+      let(:options_projects_only) { {
+        nil=>false, 
+        :configdir=>"#{Dir.pwd}/configs", 
+        :platforms=>false, 
+        :projects=>true, 
+        :use_spaces=>false
+      } }
+      let(:options_space_only) { {
+        nil=>false, 
+        :configdir=>"#{Dir.pwd}/configs", 
+        :platforms=>false, 
+        :projects=>false, 
+        :use_spaces=>true
+      } }
+
+      it "outputs projects and platforms with no options passed" do 
+        expect do
+          cli.run(options_empty)
+        end.to output(output_both).to_stdout
+      end
+      
+      let(:output_both_space){
+"- Projects
+foo bar baz
+
+- Platforms
+1 2 3
+"
+}
+      it "outputs projects and platforms space separated" do 
+        expect do
+          cli.run(options_space_only)
+        end.to output(output_both_space).to_stdout
+      end
+
+      let(:output_platforms){
+"- Platforms
+1
+2
+3
+"
+}
+      it "outputs only platforms when platforms is passed" do 
+        expect do
+          cli.run(options_platforms_only)
+        end.to output(output_platforms).to_stdout
+      end
+
+      let(:output_projects){
+"- Projects
+foo
+bar
+baz
+"
+}
+      it "outputs only projects when projects is passed" do 
+        expect do
+          cli.run(options_projects_only)
+        end.to output(output_projects).to_stdout
+      end
+    end
+
+    context "spec with a configdir specified" do
+      let(:options_configdir) { {
+        nil=>false, 
+        :configdir=> '/configs', 
+        :platforms=>false, 
+        :projects=>false, 
+        :use_spaces=>false} }
+      it "it successfully takes the configs directory" do 
+        expect(Dir).to receive(:exist?).with('/configs' + '/platforms')
+          .and_return(true)
+        expect(Dir).to receive(:exist?).with('/configs' + '/projects')
+          .and_return(true)
+        expect(Dir).to receive(:children).with('/configs' + '/projects')
+          .and_return(projects)
+        expect(Dir).to receive(:children).with('/configs' + '/platforms')
+          .and_return(platforms)
+        expect do
+          cli.run(options_configdir)
+        end.to output(output_both).to_stdout
+      end
+    end
+  end
+end

data/spec/lib/vanagon/component/dsl_spec.rb

@@ -34,6 +34,16 @@ end" }
     plat._platform
   }
 
+  let (:dummy_platform_sysv_or_systemd) {
+    plat = Vanagon::Platform::DSL.new('debian-8-x86_64')
+    plat.instance_eval("platform 'debian-8-x86_64' do |plat|
+                       plat.servicetype 'sysv', servicedir: '/etc/init.d'
+                       plat.servicetype 'systemd', servicedir: '/usr/lib/systemd/system'
+                       plat.defaultdir '/etc/default'
+                       end")
+    plat._platform
+  }
+
   let (:dummy_platform_smf) {
     plat = Vanagon::Platform::DSL.new('debian-11-i386')
     plat.instance_eval("platform 'debian-11-i386' do |plat|
@@ -313,11 +323,18 @@ end" }
       comp = Vanagon::Component::DSL.new('requires-test', {}, {})
       comp.requires('library1')
       comp.requires('library2')
-      expect(comp._component.requires).to include('library1')
-      expect(comp._component.requires).to include('library2')
+      expect(comp._component.requires.first.requirement).to include('library1')
+      expect(comp._component.requires.last.requirement).to include('library2')
     end
   end
 
+    it 'supports versioned requires' do
+      comp = Vanagon::Component::DSL.new('requires-test', {}, {})
+      comp.requires('library1', '1.2.3')
+      expect(comp._component.requires.first.requirement).to eq('library1')
+      expect(comp._component.requires.first.version).to eq('1.2.3')
+    end
+
   describe '#provides' do
     it 'adds the package provide to the list of provides' do
       comp = Vanagon::Component::DSL.new('provides-test', {}, {})
@@ -568,15 +585,15 @@ end" }
       expect(comp._component.files).to include(Vanagon::Common::Pathname.file('/etc/init.d/service-test', mode: '0755'))
 
       # The component should now have a service registered
-      expect(comp._component.service.name).to eq('service-test')
+      expect(comp._component.service.flat_map(&:name).compact).to include('service-test')
     end
 
     it 'reads from a file when the OS is AIX for services' do
       comp = Vanagon::Component::DSL.new('service-test', {}, dummy_platform_aix)
       comp.install_service('spec/fixtures/component/mcollective.service', nil, 'mcollective')
-      expect(comp._component.service.name).to eq('mcollective')
-      expect(comp._component.service.service_command).to include('/opt/puppetlabs/puppet/bin/ruby')
-      expect(comp._component.service.service_command).not_to include("\n")
+      expect(comp._component.service.flat_map(&:name).compact).to include('mcollective')
+      expect(comp._component.service.flat_map(&:service_command).compact.first).to include('/opt/puppetlabs/puppet/bin/ruby')
+      expect(comp._component.service.flat_map(&:service_command).compact.first).not_to include("\n")
     end
 
     it 'adds the correct command to the install for the component for systemd platforms' do
@@ -595,7 +612,34 @@ end" }
       expect(comp._component.files).to include(Vanagon::Common::Pathname.file('/usr/lib/systemd/system/service-test.service', mode: '0644'))
 
       # The component should now have a service registered
-      expect(comp._component.service.name).to eq('service-test')
+      expect(comp._component.service.flat_map(&:name).compact).to include('service-test')
+    end
+
+    it 'adds the correct command when installing both systemd and sysv' do
+      comp = Vanagon::Component::DSL.new('service-test', {}, dummy_platform_sysv_or_systemd)
+      comp.install_service('component-client.init', 'component-client.sysconfig', init_system: 'sysv')
+      comp.install_service('component-client.service', 'component-client.sysconfig', init_system: 'systemd')
+      # Look for servicedir creation and copy - sysv
+      expect(comp._component.install).to include("install -d '/etc/init.d'")
+      expect(comp._component.install).to include("cp -p 'component-client.init' '/etc/init.d/service-test'")
+
+      # Look for servicedir creation and copy - systemd
+      expect(comp._component.install).to include("install -d '/usr/lib/systemd/system'")
+      expect(comp._component.install).to include("cp -p 'component-client.service' '/usr/lib/systemd/system/service-test.service'")
+
+      # Look for defaultdir creation and copy
+      expect(comp._component.install).to include("install -d '/etc/default'")
+      expect(comp._component.install).to include("cp -p 'component-client.sysconfig' '/etc/default/service-test'")
+
+      # Look for files and configfiles - sysv
+      expect(comp._component.configfiles).to include(Vanagon::Common::Pathname.configfile('/etc/default/service-test'))
+      expect(comp._component.files).to include(Vanagon::Common::Pathname.file('/etc/init.d/service-test', mode: '0755'))
+
+      # Look for files and configfiles - systemd
+      expect(comp._component.files).to include(Vanagon::Common::Pathname.file('/usr/lib/systemd/system/service-test.service', mode: '0644'))
+
+      # The component should now have a service registered
+      expect(comp._component.service.flat_map(&:name).compact).to include('service-test')
     end
 
     it 'adds the correct command to the install for smf services using a service_type' do
@@ -614,7 +658,7 @@ end" }
       expect(comp._component.files).to include(Vanagon::Common::Pathname.file('/var/svc/manifest/network/service-test.xml', mode: '0644'))
 
       # The component should now have a service registered
-      expect(comp._component.service.name).to eq('service-test')
+      expect(comp._component.service.flat_map(&:name).compact).to include('service-test')
     end
 
     it 'adds the correct command to the install for smf services' do
@@ -633,7 +677,7 @@ end" }
       expect(comp._component.files).to include(Vanagon::Common::Pathname.file('/var/svc/manifest/service-test.xml', mode: '0644'))
 
       # The component should now have a service registered
-      expect(comp._component.service.name).to eq('service-test')
+      expect(comp._component.service.flat_map(&:name).compact).to include('service-test')
     end
 
     it 'installs the file as a link when link_target is specified' do
@@ -654,7 +698,7 @@ end" }
       expect(comp._component.files).to include(Vanagon::Common::Pathname.file('/etc/init.d/service-test'))
 
       # The component should now have a service registered
-      expect(comp._component.service.name).to eq('service-test')
+      expect(comp._component.service.flat_map(&:name).compact).to include('service-test')
     end
   end
 

data/spec/lib/vanagon/component/source/git_spec.rb

@@ -14,8 +14,8 @@ describe "Vanagon::Component::Source::Git" do
 
   # before(:each) blocks are run before each example
   before :each do
-    allow(Git)
-      .to receive(:ls_remote)
+    allow(Vanagon::Component::Source::Git)
+      .to receive(:valid_remote?)
             .and_return(true)
 
     allow(File).to receive(:realpath).and_return(@workdir)
@@ -24,8 +24,8 @@ describe "Vanagon::Component::Source::Git" do
   describe "#initialize" do
     it "raises error on initialization with an invalid repo" do
       # Ensure initializing a repo fails without calling over the network
-      allow(Git)
-        .to receive(:ls_remote)
+      allow(Vanagon::Component::Source::Git)
+        .to receive(:valid_remote?)
               .and_return(false)
 
       expect { @klass.new(@url, ref: @ref_tag, workdir: @workdir) }