valvat 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ddc578b98f0c869566769b5588b5768bbdcc5ba4901ab97227c7908502a7b5c9
-  data.tar.gz: f7bfc69d3cd2983bb3d306d0932ef6d436890850bc67f6c63e639d2c666dc1ac
+  metadata.gz: a46ea169067e8ad3077440f355850677b7da8d8a2ce4cf64f66f6ab00f53094d
+  data.tar.gz: e3e3155fc732de64002519b5b542f4f9d663f0d8fa868c4233aa03ad90e1cb65
 SHA512:
-  metadata.gz: 910d4c387c6e82adeee3146b54e928b253fcd4aae6873ae438a575612b72a136459d50411c565ba47683b1b8f325f90771774add2b7110b1c4a6c4e880ba0999
-  data.tar.gz: a93a4d12a53fe3601525a153c6f2ae042259371f1775c05fb27ada151e91f3ff0325f794332797eb31ff502606dd31edee502d910866e8c76feeb6613cb3b95e
+  metadata.gz: 4ddb01f926a6d1c6e05e653aff20e81eaaa9249e70ea63fbd6a06f0519863ae410e6873a1948947c90bf4ad64787478a0f8c3ff74ffb0f16fe08705a1e5d5c3b
+  data.tar.gz: 9a1dd08067a21ce1f0b1663a4cdc8e92cc91a2edc9bf959c294674f5a97dc1bd87375ca27c0f88330bedaf628886cc2cfc27ae3ec71c74e2077068d3db7e1052

data/.github/workflows/ruby.yml

@@ -17,7 +17,7 @@ jobs:
       BUNDLE_GEMFILE: gemfiles/${{ matrix.gemfile }}
     strategy:
       matrix:
-        ruby-version: ['2.5', '2.6', '2.7', '3.0', 'jruby-head']
+        ruby-version: ['2.5', '2.6', '2.7', '3.0', 'jruby-head', 'truffleruby-head']
         gemfile: [ 'standalone', 'activemodel-5', 'activemodel-6' ]
         exclude:
           - ruby-version: '3.0'

data/CHANGES.md

@@ -1,7 +1,13 @@
 
 ### dev
 
-[full changelog](http://github.com/yolk/valvat/compare/v1.1.0...master)
+[full changelog](http://github.com/yolk/valvat/compare/v1.1.1...master)
+
+### 1.1.0 / 2021-07-15
+
+[full changelog](http://github.com/yolk/valvat/compare/v1.1.0...v1.1.1)
+
+* Added support for italian VAT numbers with special province part (#104)
 
 ### 1.1.0 / 2021-01-15
 

data/README.md

@@ -20,7 +20,7 @@ Northern Ireland received its own VAT number prefix - XI which is supported by V
 * I18n locales for language specific error messages in English, German, French, Spanish, Italian, Portuguese, Polish, Swedish, Dutch, Danish, Czech, Slovakian, Hungarian, Bulgarian, Romanian, Latvian, Catalan, Norwegian, and Finnish.
 * *Experimental* checksum verification
 
-valvat is tested and works with ruby MRI 2.5/2.6/2.7/3.0, jruby-head and ActiveModel 5/6. If you need support for ruby down to 1.9.3 and ActiveModel 3 and 4 use [v1.0.1](https://github.com/yolk/valvat/tree/v1.0.1).
+valvat is tested and works with ruby MRI 2.5/2.6/2.7/3.0, jruby-head, truffleruby-head and ActiveModel 5/6. If you need support for ruby down to 1.9.3 and ActiveModel 3 and 4 use [v1.0.1](https://github.com/yolk/valvat/tree/v1.0.1).
 
 ## Installation
 

data/lib/valvat/checksum.rb

@@ -2,20 +2,7 @@
 
 class Valvat
   module Checksum
-    ALGORITHMS = {} # rubocop:disable Style/MutableConstant
-
-    def self.validate(vat)
-      vat = Valvat(vat)
-      algo = ALGORITHMS[vat.iso_country_code]
-      Valvat::Syntax.validate(vat) && !!(algo.nil? || algo.new(vat).validate)
-    end
-
     class Base
-      def self.inherited(klass)
-        ALGORITHMS[klass.name.split(/::/).last] = klass
-        super
-      end
-
       attr_reader :vat
 
       def self.check_digit_length(len = nil)
@@ -74,10 +61,18 @@ class Valvat
         end.modulo(11)
       end
     end
-  end
-end
 
-Dir[File.join(File.dirname(__FILE__), 'checksum', '*.rb')].each do |path|
-  # On Ruby 2.1.0 ActiveSupport goes mad if you pass it paths with .rb at the end
-  require path.gsub(/\.rb$/, '')
+    def self.validate(vat)
+      vat = Valvat(vat)
+      algo = ALGORITHMS[vat.iso_country_code]
+      Valvat::Syntax.validate(vat) && !!(algo.nil? || algo.new(vat).validate)
+    end
+
+    ALGORITHMS = Dir[File.join(__dir__, 'checksum', '*.rb')].each_with_object({}) do |path, algos|
+      require path.gsub(/\.rb$/, '')
+
+      classname = File.basename(path, '.rb').upcase
+      algos[classname] = ['Valvat', 'Checksum', classname].inject(Object, :const_get)
+    end.freeze
+  end
 end

data/lib/valvat/checksum/it.rb

@@ -5,7 +5,7 @@ class Valvat
     class IT < Base
       def validate
         y = figures_str[7..9].to_i
-        y >= 1 && (y <= 100 || [120, 121].include?(y)) &&
+        y >= 1 && (y <= 100 || [120, 121, 999].include?(y)) &&
           figures_str[0..6] != '0000000' &&
           super
       end

data/lib/valvat/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Valvat
-  VERSION = '1.1.0'
+  VERSION = '1.1.1'
 end

data/spec/valvat/checksum/it_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe Valvat::Checksum::IT do
-  %w[IT12345670785 IT01897810162 IT00197200132 IT02762750210].each do |valid_vat|
+  %w[IT12345670785 IT01897810162 IT00197200132 IT02762750210 IT00146089990].each do |valid_vat|
     it "returns true on valid VAT #{valid_vat}" do
       expect(Valvat::Checksum.validate(valid_vat)).to be(true)
     end

data/spec/valvat/checksum_spec.rb

@@ -8,6 +8,13 @@ rescue LoadError
   VALID_VAT_NUMBERS = [].freeze
 end
 
+# Syntax is correct, but checksum invalid
+INVALID_VAT_NUMBERS = %w[
+  DE002768611 DE161216774 DE192970834 DE223361232 DE226095231
+  DE227411313 DE230928917 DE232123248 DE267748405 DE275615509
+  DE311927825 DE329214395 DE815842425 DE821530465 DE999999999
+].freeze
+
 describe Valvat::Checksum do
   describe '#validate' do
     it 'returns true on VAT number with unknown checksum algorithm' do
@@ -23,5 +30,11 @@ describe Valvat::Checksum do
         expect(described_class.validate(valid_vat)).to be(true)
       end
     end
+
+    INVALID_VAT_NUMBERS.each do |invalid_vat|
+      it "returns false on invalid VAT number #{invalid_vat}" do
+        expect(described_class.validate(invalid_vat)).to be(false)
+      end
+    end
   end
 end

data/spec/valvat/syntax_spec.rb

@@ -36,7 +36,7 @@ describe Valvat::Syntax do
     it_validates(%w[HR12345678912], %w[HR6789459 HR67894595L HR6789459J])
     it_validates(%w[HU67894595], %w[HU6789459 HU67894595L HU6789459J])
     it_validates(%w[IE1B12345J IE1234567B IE1234567XX], %w[IE1B123459 IE19123450 IEA9123450 IE1B12345XX IE1X34567XX])
-    it_validates(%w[IT45875359285], %w[IT458753592859 IT4587535928G IT4587535928])
+    it_validates(%w[IT45875359285 IT00146089990], %w[IT458753592859 IT4587535928G IT4587535928])
     it_validates(%w[LT213179412 LT290061371314],
                  %w[LT21317942 LT213179422 LT2131794120 LT213179412K LT29006137132 LT290061371324 LT29006137131C
                     LT290061371314H])

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: valvat
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Sebastian Munz
@@ -34,7 +34,7 @@ cert_chain:
   KzzULF0bF9oNpXwBEamlH2myNb19u1W8ijobQ7Y19ca8UFHr5LI32ZW5Zlmep8je
   vb+o07oLRx3t2T/EO4DZ1w==
   -----END CERTIFICATE-----
-date: 2021-01-15 00:00:00.000000000 Z
+date: 2021-07-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon