valvat 1.0.1 → 1.1.0

data/lib/valvat/checksum/cy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class CY < Base

data/lib/valvat/checksum/de.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class DE < Base
@@ -8,12 +10,12 @@ class Valvat
         prod = M
         figures.each do |fig|
           sum = (prod + fig).modulo(M)
-          sum = M if sum == 0
-          prod = (2*sum).modulo(N)
+          sum = M if sum.zero?
+          prod = (2 * sum).modulo(N)
         end
         chk = N - prod
         chk == 10 ? 0 : chk
       end
     end
   end
-end
+end

data/lib/valvat/checksum/dk.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class DK < Base
@@ -15,4 +17,4 @@ class Valvat
       end
     end
   end
-end
+end

data/lib/valvat/checksum/ee.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class EE < Base

data/lib/valvat/checksum/es.rb

@@ -1,33 +1,31 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class ES < Base
-      NATURAL_PERSON_CHARS       = %w(T R W A G M Y F P D X B N J Z S Q V H L C K E)
-      NATURAL_PERSON_EXP         = /\A([\d]{8}[ABCDEFGHJKLMNPQRSTVWXYZ]|[KLMXYZ][\d]{7}[ABCDEFGHJKLMNPQRSTVWXYZ])\Z/
-      LEGAL_PERSON_CHARS = [false] + %w(A B C D E F G H I J)
-      LEGAL_PERSON_EXP   = /\A[NPQRSW][\d]{7}[ABCDEFGHIJ]\Z/
+      NATURAL_PERSON_CHARS       = %w[T R W A G M Y F P D X B N J Z S Q V H L C K E].freeze
+      NATURAL_PERSON_EXP         = /\A(\d{8}[ABCDEFGHJKLMNPQRSTVWXYZ]|[KLMXYZ]\d{7}[ABCDEFGHJKLMNPQRSTVWXYZ])\Z/.freeze
+      LEGAL_PERSON_CHARS = [false] + %w[A B C D E F G H I J]
+      LEGAL_PERSON_EXP   = /\A[NPQRSW]\d{7}[ABCDEFGHIJ]\Z/.freeze
+      NIE_DIGIT_BY_LETTER = %w[X Y Z].freeze
 
       def check_digit
         natural_person? ? check_digit_natural_person : check_digit_legal_person
       end
 
       def check_digit_natural_person
-        nie_digit = nil
         letter = vat.to_s_wo_country[0]
-        if letter == 'X'
-          nie_digit = 0
-        elsif letter == 'Y'
-          nie_digit = 1
-        elsif letter == 'Z'
-          nie_digit = 2
-        end
+        nie_digit = NIE_DIGIT_BY_LETTER.index(letter)
         NATURAL_PERSON_CHARS["#{nie_digit}#{figures_str}".to_i.modulo(23)]
       end
 
       def check_digit_legal_person
-        chk = 10 - sum_of_figures_for_at_es_it_se(true).modulo(10)
-        legal_foreign_person? ?
-          LEGAL_PERSON_CHARS[chk] :
+        chk = 10 - sum_of_figures_for_at_es_it_se(reverse_ints: true).modulo(10)
+        if legal_foreign_person?
+          LEGAL_PERSON_CHARS[chk]
+        else
           (chk == 10 ? 0 : chk)
+        end
       end
 
       def given_check_digit
@@ -52,4 +50,4 @@ class Valvat
       end
     end
   end
-end
+end

data/lib/valvat/checksum/fi.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class FI < Base
@@ -10,4 +12,4 @@ class Valvat
       end
     end
   end
-end
+end

data/lib/valvat/checksum/fr.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class FR < Base
@@ -5,10 +7,10 @@ class Valvat
         siren = str_wo_country[2..-1].to_i
         (12 + (3 * siren) % 97) % 97
       end
-      
+
       def given_check_digit
         str_wo_country[0..1].to_i
       end
     end
   end
-end
+end

data/lib/valvat/checksum/gb.rb

@@ -1,51 +1,66 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class GB < Base
-      OLD_FORMAT_FORBIDDEN_RANGES = [(100_000..999_999), (9_490_001..9_700_000), (9_990_001..9_999_999)]
-      NEW_FORMAT_FORBIDDEN_RANGES = [(1..100_000), (100_001..1_000_000)]
-      GOV_NUMBER = /\A(GD[0-4]{1}\d{2})\Z/
-      HEALTH_NUMBER = /\A(HA[5-9]{1}\d{2})\Z/
-
-      def validate
-        vat_number = vat.to_s_wo_country
+      OLD_FORMAT_FORBIDDEN_RANGES = [(100_000..999_999), (9_490_001..9_700_000), (9_990_001..9_999_999)].freeze
+      NEW_FORMAT_FORBIDDEN_RANGES = [(1..100_000), (100_001..1_000_000)].freeze
+      GOV_NUMBER = /\A(GD[0-4]{1}\d{2})\Z/.freeze
+      HEALTH_NUMBER = /\A(HA[5-9]{1}\d{2})\Z/.freeze
 
+      def validate # rubocop:disable Metrics/CyclomaticComplexity
         # government departments and health authorities, so no checksum
-        return true if gov_or_health?(vat_number)
-        return false if all_zero?(vat_number)
+        return true if gov_or_health?
+        return false if all_zero?
 
-        checksum  = vat_number[7..8].to_i
-        vat_base = vat_number[0..6]
-        vat_base_int = vat_base.to_i
-        vat_base_sum = generate_vat_base_sum(vat_base)
+        return false if old_format_remainder.zero? && fobidden_in_old_format?
+        return false if new_format_remainder.zero? && fobidden_in_new_format?
 
-        old_format_remainder = (vat_base_sum + checksum).modulo(97)
-        new_format_remainder = (vat_base_sum + 55 + checksum).modulo(97)
+        old_format_remainder.zero? || new_format_remainder.zero?
+      end
 
-        return false if old_format_remainder == 0 &&
-          OLD_FORMAT_FORBIDDEN_RANGES.any? { |range| range.include? vat_base_int }
+      private
 
-        return false if new_format_remainder == 0 &&
-          NEW_FORMAT_FORBIDDEN_RANGES.any? { |range| range.include? vat_base_int }
+      def checksum
+        @checksum ||= str_wo_country[7..8].to_i
+      end
 
-        old_format_remainder == 0 || new_format_remainder == 0
+      def vat_base
+        @vat_base ||= str_wo_country[0..6]
       end
 
-      private
+      def gov_or_health?
+        str_wo_country =~ GOV_NUMBER || str_wo_country =~ HEALTH_NUMBER
+      end
 
-      def gov_or_health?(vat_number)
-        vat_number =~ GOV_NUMBER || vat_number =~ HEALTH_NUMBER
+      def all_zero?
+        str_wo_country =~ /\A0{9}\Z/ || str_wo_country =~ /\A0{12}\Z/
       end
 
-      def all_zero?(vat_number)
-        vat_number =~ /\A0{9}\Z/ || vat_number =~ /\A0{12}\Z/
+      def vat_base_sum
+        @vat_base_sum ||= vat_base.split('')
+                                  .map(&:to_i)
+                                  .zip([8, 7, 6, 5, 4, 3, 2])
+                                  .map { |vat_number_digit, multiplier| vat_number_digit * multiplier }
+                                  .inject(:+)
       end
 
-      def generate_vat_base_sum(vat_base)
-        vat_base.split('').
-          map(&:to_i).
-          zip([8, 7, 6, 5, 4, 3, 2]).
-          map { |vat_number_digit, multiplier| vat_number_digit * multiplier }.
-          inject(:+)
+      def old_format_remainder
+        @old_format_remainder ||= (vat_base_sum + checksum).modulo(97)
+      end
+
+      def new_format_remainder
+        @new_format_remainder ||= (vat_base_sum + 55 + checksum).modulo(97)
+      end
+
+      def fobidden_in_new_format?
+        vat_base_int = vat_base.to_i
+        NEW_FORMAT_FORBIDDEN_RANGES.any? { |range| range.include?(vat_base_int) }
+      end
+
+      def fobidden_in_old_format?
+        vat_base_int = vat_base.to_i
+        OLD_FORMAT_FORBIDDEN_RANGES.any? { |range| range.include?(vat_base_int) }
       end
     end
   end

data/lib/valvat/checksum/gr.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class GR < Base
       def check_digit
         chk = sum_figures_by do |fig, i|
-          fig*(2**(i+1))
+          fig * (2**(i + 1))
         end.modulo(11)
         chk > 9 ? 0 : chk
       end
     end
   end
-end
+end

data/lib/valvat/checksum/hr.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class HR < Base

data/lib/valvat/checksum/hu.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class HU < Base

data/lib/valvat/checksum/ie.rb

@@ -1,17 +1,17 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class IE < Base
       def check_digit
         total = sum_figures_by do |fig, i|
-          fig*(i+2)
-        end
-        if str_wo_country.size == 9
-          total += ((CHARS.index(str_wo_country[8]) || 0)  * 9)
+          fig * (i + 2)
         end
+        total += ((CHARS.index(str_wo_country[8]) || 0) * 9) if str_wo_country.size == 9
         total.modulo(23)
       end
 
-      CHARS = "WABCDEFGHIJKLMNOPQRSTUV".split("")
+      CHARS = 'WABCDEFGHIJKLMNOPQRSTUV'.split('')
 
       def given_check_digit
         if str_wo_country.size == 9
@@ -38,7 +38,6 @@ class Valvat
           super
         end
       end
-
     end
   end
 end

data/lib/valvat/checksum/it.rb

@@ -1,17 +1,19 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class IT < Base
       def validate
         y = figures_str[7..9].to_i
         y >= 1 && (y <= 100 || [120, 121].include?(y)) &&
-        figures_str[0..6] != "0000000" &&
-        super
+          figures_str[0..6] != '0000000' &&
+          super
       end
 
       def check_digit
-        chk = 10 - sum_of_figures_for_at_es_it_se(true).modulo(10)
+        chk = 10 - sum_of_figures_for_at_es_it_se(reverse_ints: true).modulo(10)
         chk == 10 ? 0 : chk
       end
     end
   end
-end
+end

data/lib/valvat/checksum/lt.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class LT < Base

data/lib/valvat/checksum/lu.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class LU < Base
@@ -8,4 +10,4 @@ class Valvat
       end
     end
   end
-end
+end

data/lib/valvat/checksum/mt.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class MT < Base

data/lib/valvat/checksum/nl.rb

@@ -1,14 +1,16 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class NL < Base
       def validate
         vat.to_s.gsub(/[A-Z]/) { |let| (let.ord - 55).to_s }.to_i % 97 == 1 ||
-        super
+          super
       end
 
       def check_digit
         sum_figures_by do |fig, i|
-          fig*(i+2)
+          fig * (i + 2)
         end.modulo(11)
       end
 
@@ -17,4 +19,4 @@ class Valvat
       end
     end
   end
-end
+end

data/lib/valvat/checksum/pl.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class PL < Base
@@ -9,4 +11,4 @@ class Valvat
       end
     end
   end
-end
+end

data/lib/valvat/checksum/pt.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class PT < Base
@@ -7,4 +9,4 @@ class Valvat
       end
     end
   end
-end
+end

data/lib/valvat/checksum/ro.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class RO < Base

data/lib/valvat/checksum/se.rb

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class SE < Base
       check_digit_length 0
 
       def validate
-        vat.to_s_wo_country[-2..-1].to_i > 0 &&
-        super
+        vat.to_s_wo_country[-2..-1].to_i.positive? &&
+          super
       end
 
       private
@@ -23,4 +25,4 @@ class Valvat
       end
     end
   end
-end
+end

data/lib/valvat/checksum/si.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 class Valvat
   module Checksum
     class SI < Base
       def validate
-        figures_str.to_i > 999999 &&
-        super
+        figures_str.to_i > 999_999 &&
+          super
       end
 
       def check_digit

data/lib/valvat/error.rb

@@ -1,9 +1,12 @@
+# frozen_string_literal: true
+
 class Valvat
   Error = Class.new(RuntimeError)
 
   class ViesError < Error
-    def initialize(faultstring='UNKNOWN')
+    def initialize(faultstring = 'UNKNOWN')
       @faultstring = faultstring
+      super
     end
 
     def to_s