valvat 0.8.1 → 1.0.1

data/spec/valvat/utils_spec.rb

@@ -1,8 +1,9 @@
+# encoding: utf-8
 require 'spec_helper'
 
 describe Valvat::Utils do
   describe "#split" do
-    it "returns country and rest on vat number as array" do
+    it "returns country and rest on VAT number as array" do
       expect(Valvat::Utils.split("DE345889003")).to eql(["DE", "345889003"])
       expect(Valvat::Utils.split("ESX4588900X")).to eql(["ES", "X4588900X"])
     end
@@ -26,18 +27,18 @@ describe Valvat::Utils do
   end
 
   describe "#normalize" do
-    it "returns vat number with upcase chars" do
+    it "returns VAT number with upcase chars" do
       expect(Valvat::Utils.normalize("de345889003")).to eql("DE345889003")
       expect(Valvat::Utils.normalize("EsX4588900y")).to eql("ESX4588900Y")
     end
 
-    it "returns trimmed vat number" do
+    it "returns trimmed VAT number" do
       expect(Valvat::Utils.normalize(" DE345889003")).to eql("DE345889003")
       expect(Valvat::Utils.normalize("  DE345889003  ")).to eql("DE345889003")
       expect(Valvat::Utils.normalize("DE345889003 ")).to eql("DE345889003")
     end
 
-    it "does not change already normalized vat numbers" do
+    it "does not change already normalized VAT numbers" do
       expect(Valvat::Utils.normalize("DE345889003")).to eql("DE345889003")
       expect(Valvat::Utils.normalize("ESX4588900X")).to eql("ESX4588900X")
     end
@@ -49,6 +50,7 @@ describe Valvat::Utils do
 
     it "removes special chars" do
       expect(Valvat::Utils.normalize("DE.345-889_00:3,;")).to eql("DE345889003")
+      expect(Valvat::Utils.normalize("→ DE·Ö34588 9003\0 ☺")).to eql("→DEÖ345889003☺")
     end
   end
 
@@ -57,7 +59,7 @@ describe Valvat::Utils do
       expect(Valvat::Utils.vat_country_to_iso_country("EL")).to eql("GR")
     end
 
-    Valvat::Utils::EU_COUNTRIES.each do |iso|
+    Valvat::Utils::EU_MEMBER_STATES.each do |iso|
       it "returns unchanged iso country code '#{iso}'" do
         expect(Valvat::Utils.vat_country_to_iso_country(iso)).to eql(iso)
       end
@@ -65,13 +67,31 @@ describe Valvat::Utils do
   end
 
   describe "#iso_country_to_vat_country" do
-    it "returns vat country on greek iso country code 'GR'" do
+    it "returns VAT country on greek iso country code 'GR'" do
       expect(Valvat::Utils.iso_country_to_vat_country("GR")).to eql("EL")
     end
 
-    Valvat::Utils::EU_COUNTRIES.reject{|c| c == "GR"}.each do |c|
-      it "returns unchanged vat country code '#{c}'" do
+    Valvat::Utils::EU_MEMBER_STATES.each do |c|
+      it "returns unchanged VAT country code '#{c}'" do
         expect(Valvat::Utils.iso_country_to_vat_country(c)).to eql(c)
+      end unless c == "GR"
+    end
+  end
+
+  describe "#country_is_supported?" do
+    Valvat::Utils::EU_MEMBER_STATES.each do |code|
+      it "returns true on #{code}" do
+        expect(Valvat::Utils.country_is_supported?(code)).to eql(true)
+      end
+    end
+
+    it "returns true on GB" do
+      expect(Valvat::Utils.country_is_supported?("GB")).to eql(true)
+    end
+
+    ["US", "AE", "CA", "CN", "BR", "AU", "NO", "ML"].each do |code|
+      it "returns false on #{code}" do
+        expect(Valvat::Utils.country_is_supported?(code)).to eql(false)
       end
     end
   end

data/spec/valvat_spec.rb

@@ -44,7 +44,7 @@ describe Valvat do
     end
   end
 
-  context "on european vat number" do
+  context "on european VAT number" do
     let(:de_vat) { Valvat.new("DE259597697") } # valid & exists
     let(:invalid_checksum) { Valvat.new("DE259597687") } # valid & invalid checksum
     let(:at_vat) { Valvat.new("ATU458890031") } # invalid
@@ -74,9 +74,9 @@ describe Valvat do
     end
 
     describe "#exist(s)?" do
-      context "on existing vat numbers" do
+      context "on existing VAT numbers" do
         before do
-          allow(Valvat::Lookup).to receive_messages(:validate => true)
+          allow(Valvat::Lookup).to receive_messages(validate: true)
         end
 
         it "returns true" do
@@ -87,9 +87,9 @@ describe Valvat do
         end
       end
 
-      context "on not existing vat numbers" do
+      context "on not existing VAT numbers" do
         before do
-          allow(Valvat::Lookup).to receive_messages(:validate => false)
+          allow(Valvat::Lookup).to receive_messages(validate: false)
         end
 
         it "returns false" do
@@ -100,8 +100,8 @@ describe Valvat do
 
       context "with options" do
         it "calls Valvat::Lookup.validate with options" do
-          expect(Valvat::Lookup).to receive(:validate).once.with(de_vat, :detail => true, :bla => 'blupp').and_return(true)
-          expect(de_vat.exists?(:detail => true, :bla => 'blupp')).to eql(true)
+          expect(Valvat::Lookup).to receive(:validate).once.with(de_vat, detail: true, bla: 'blupp').and_return(true)
+          expect(de_vat.exists?(detail: true, bla: 'blupp')).to eql(true)
         end
       end
     end
@@ -112,7 +112,7 @@ describe Valvat do
         expect(at_vat.iso_country_code).to eql("AT")
       end
 
-      it "returns GR iso country code on greek vat number" do
+      it "returns GR iso country code on greek VAT number" do
         expect(gr_vat.iso_country_code).to eql("GR")
       end
     end
@@ -123,7 +123,7 @@ describe Valvat do
         expect(at_vat.vat_country_code).to eql("AT")
       end
 
-      it "returns EL iso language code on greek vat number" do
+      it "returns EL iso language code on greek VAT number" do
         expect(gr_vat.vat_country_code).to eql("EL")
       end
     end
@@ -137,7 +137,7 @@ describe Valvat do
     end
 
     describe "#to_s" do
-      it "returns full vat number" do
+      it "returns full VAT number" do
         expect(de_vat.to_s).to eql("DE259597697")
         expect(at_vat.to_s).to eql("ATU458890031")
         expect(gr_vat.to_s).to eql("EL999943280")
@@ -145,7 +145,7 @@ describe Valvat do
     end
 
     describe "#inspect" do
-      it "returns vat number with iso country code" do
+      it "returns VAT number with iso country code" do
         expect(de_vat.inspect).to eql("#<Valvat DE259597697 DE>")
         expect(at_vat.inspect).to eql("#<Valvat ATU458890031 AT>")
         expect(gr_vat.inspect).to eql("#<Valvat EL999943280 GR>")
@@ -153,7 +153,7 @@ describe Valvat do
     end
 
     describe "#to_a" do
-      it "calls Valvat::Utils.split with raw vat number and returns result" do
+      it "calls Valvat::Utils.split with raw VAT number and returns result" do
         de_vat # initialize
         expect(Valvat::Utils).to receive(:split).once.with("DE259597697").and_return(["a", "b"])
         expect(de_vat.to_a).to eql(["a", "b"])
@@ -161,7 +161,7 @@ describe Valvat do
     end
   end
 
-  context "on vat number from outside of europe" do
+  context "on VAT number from outside of europe" do
     let(:us_vat) { Valvat.new("US345889003") }
     let(:ch_vat) { Valvat.new("CH445889003") }
 
@@ -201,14 +201,14 @@ describe Valvat do
     end
 
     describe "#to_s" do
-      it "returns full given vat number" do
+      it "returns full given VAT number" do
         expect(us_vat.to_s).to eql("US345889003")
         expect(ch_vat.to_s).to eql("CH445889003")
       end
     end
 
     describe "#inspect" do
-      it "returns vat number without iso country code" do
+      it "returns VAT number without iso country code" do
         expect(us_vat.inspect).to eql("#<Valvat US345889003>")
         expect(ch_vat.inspect).to eql("#<Valvat CH445889003>")
       end
@@ -216,7 +216,7 @@ describe Valvat do
 
   end
 
-  context "on non-sense/empty vat number" do
+  context "on non-sense/empty VAT number" do
     let(:only_iso_vat) { Valvat.new("DE") }
     let(:num_vat) { Valvat.new("12445889003") }
     let(:empty_vat) { Valvat.new("") }
@@ -268,7 +268,7 @@ describe Valvat do
     end
 
     describe "#to_s" do
-      it "returns full given vat number" do
+      it "returns full given VAT number" do
         expect(only_iso_vat.to_s).to eql("DE")
         expect(num_vat.to_s).to eql("12445889003")
         expect(empty_vat.to_s).to eql("")
@@ -277,7 +277,7 @@ describe Valvat do
     end
 
     describe "#inspect" do
-      it "returns vat number without iso country code" do
+      it "returns VAT number without iso country code" do
         expect(only_iso_vat.inspect).to eql("#<Valvat DE>")
         expect(num_vat.inspect).to eql("#<Valvat 12445889003>")
         expect(empty_vat.inspect).to eql("#<Valvat >")

data/valvat.gemspec

@@ -22,6 +22,7 @@ Gem::Specification.new do |s|
 
   s.add_dependency             'savon',       '>= 2.3.0'
 
+  s.add_development_dependency 'rake'
   s.add_development_dependency 'rspec',       '~> 3.0'
   s.add_development_dependency 'activemodel', '>= 3.0'
 end

metadata

@@ -1,36 +1,40 @@
 --- !ruby/object:Gem::Specification
 name: valvat
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 1.0.1
 platform: ruby
 authors:
 - Sebastian Munz
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain:
 - |
   -----BEGIN CERTIFICATE-----
-  MIIDZDCCAkygAwIBAgIBATANBgkqhkiG9w0BAQUFADA8MRIwEAYDVQQDDAlzZWJh
-  c3RpYW4xEjAQBgoJkiaJk/IsZAEZFgJ5bzESMBAGCgmSJomT8ixkARkWAmxrMB4X
-  DTE4MTEyMjEyMjEwMFoXDTE5MTEyMjEyMjEwMFowPDESMBAGA1UEAwwJc2ViYXN0
-  aWFuMRIwEAYKCZImiZPyLGQBGRYCeW8xEjAQBgoJkiaJk/IsZAEZFgJsazCCASIw
-  DQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAL2dehu5l3s+mT/kF7kaoyux9EmA
-  RjpKifWtVP4NWieXHDZN2mV5dkUdw5TwKDL0IrKtp58ou0AzbEl8LLB7OsiRcOLf
-  po5wt3ABCYkxUr+4tr5HfqmaUCPDTuE/5EF4uFVxLbL3Z6+5WLk21/tFNVyrjctc
-  zaxqAt/VckFF+AFRI/vN2F+mrazeZZjLw1cBtw5YuJmorQv+VxAaZN+MbfLUL9WN
-  fJegLqFjc2aCLsPa06YmveMvyr4p1e9VO10FkWeq+vuN66Sl16crr3wQusB1Yage
-  aSwZQqDIfKnk9kxFtP1MrKnApTW1jmUahIcgv0j+yUCdnif6iy6qhvFI5ykCAwEA
-  AaNxMG8wCQYDVR0TBAIwADALBgNVHQ8EBAMCBLAwHQYDVR0OBBYEFGb0li8clZTq
-  LPyyofxEpfcs8zy0MBoGA1UdEQQTMBGBD3NlYmFzdGlhbkB5by5sazAaBgNVHRIE
-  EzARgQ9zZWJhc3RpYW5AeW8ubGswDQYJKoZIhvcNAQEFBQADggEBAKphMHnJlbY9
-  X3wx4tAeHj7Sp072LQW96Ha5D6/erDyBMjsZFTauN6lAVFVc2RVYPDzI46IvjsfE
-  k9XrqHv9/RrBE8ERDPonMVqE/wX0eSwuzgfJ96ffqMpqj8mxblL9spNdXwN+ypdO
-  mzAu65fwju+rdBVhtGdihBaDyUjovHGFh9xBjG9zJJBWvJX2JLhaCAP8erwQXLaw
-  3zA2biZvwNLu8LJa7GvkENVbvSyMmUBobmT+cj0PhHyc4XNWd6W86R1YiJTu/upo
-  +geYZL6mqiC8PV6OizVNrC3Y9HZVdmsF/le1wG2TOTPRwJwzazvHtiFR3ZQhWjNP
-  wsi9UxM8N9c=
+  MIIELDCCApSgAwIBAgIBATANBgkqhkiG9w0BAQsFADAgMR4wHAYDVQQDDBVzZWJh
+  c3RpYW4vREM9eW8vREM9bGswHhcNMjEwMTA2MTAzMDU3WhcNMjIwMTA2MTAzMDU3
+  WjAgMR4wHAYDVQQDDBVzZWJhc3RpYW4vREM9eW8vREM9bGswggGiMA0GCSqGSIb3
+  DQEBAQUAA4IBjwAwggGKAoIBgQC1KB7VOGa6pr926eaL2xCrnbnTxadpjq+6JoFj
+  6rvDpmgD8wkdfU7aFTwBiEK9JKzhqCoW86Rt/8wOrEJRMXz1QBbpMBSrubtMB+0/
+  N59hKPLwgBkhbxY7BwGnujxnTICgiGzkhjlgBe/MisoabfK5Tn84GWVk5e0/LUp1
+  qTRkSgcaDlnKs2/dAUo1lXHa13TJeemgz76TYx4p4J2w7VGh7WS2ax5SNWKw+J+q
+  HVSHT2Chc+a7As2cJyU/r2jX0oqSfvyg09CmF0inUBykeiuB9aeP/Me29hvg13/D
+  r1gaQ3/Vyfuqjs8lrwIZCWLU607g5q3+UM884WWpvApsZwzajNM2+9l5jay7Dnan
+  m05PcDtMYbPHiMyvuN9Vp4YIRqSBXP/DPGMnIYXbpzAQgtZymPQ8I3k8doj9q4+E
+  2Cf+x/nqvF09r/+gJj4ybzNW23zU6mhZ+xzBTDWrWBDetz+Y3wdbU5X6j08jLuEg
+  mMHmtgFdr/4VQxeaon7kHPR3DUsCAwEAAaNxMG8wCQYDVR0TBAIwADALBgNVHQ8E
+  BAMCBLAwHQYDVR0OBBYEFG8VE8+yijOldghb3w0MpSQnrslxMBoGA1UdEQQTMBGB
+  D3NlYmFzdGlhbkB5by5sazAaBgNVHRIEEzARgQ9zZWJhc3RpYW5AeW8ubGswDQYJ
+  KoZIhvcNAQELBQADggGBAIky67U9hnB8d4qMKwXHGb3Ne7JLvEigtEhjqGlDVecb
+  C94vQ8Jg7lYB3kKVjvFN2drptq/JUpxmAxPQIqfx39gKcKyv0BjkroVFE8MS1324
+  khMOZFOoSPMd9pkpm7oJ1M+sCYcUM+tPKnU8Ojq6r9j5b5XrbxG8YSpwahva3Vap
+  1g0+3KzuWPpFjFen1VbS/Sb1cyE5uQtUj7lVcdhF3EFvzXkUMUUtJ4xsk114znFO
+  986sKab5AjlJ7TnsmPphCv/UXans7rAVB2lnozlt/kw6dcct5JD4kz1tD6AmO5Qd
+  jWRuKNZs66GBglRvseKoypXz1XDCCu1m/uI1IGmKnq8Ry+IeRq9RnlvbfPvSxRIx
+  9aowoL79T9plhcEcEX/KYRp8ht1z+3Vyk2UVZP8Xl5x+K44co5xdhljYi1gtw0w8
+  KzzULF0bF9oNpXwBEamlH2myNb19u1W8ijobQ7Y19ca8UFHr5LI32ZW5Zlmep8je
+  vb+o07oLRx3t2T/EO4DZ1w==
   -----END CERTIFICATE-----
-date: 2019-07-30 00:00:00.000000000 Z
+date: 2021-01-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -46,6 +50,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.0
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -94,6 +112,7 @@ files:
 - gemfiles/activemodel-3-2
 - gemfiles/activemodel-4
 - gemfiles/activemodel-5
+- gemfiles/activemodel-6
 - gemfiles/before-ruby21/activemodel-3-2
 - gemfiles/before-ruby21/activemodel-4
 - gemfiles/before-ruby21/standalone
@@ -126,6 +145,7 @@ files:
 - lib/valvat/checksum/ro.rb
 - lib/valvat/checksum/se.rb
 - lib/valvat/checksum/si.rb
+- lib/valvat/error.rb
 - lib/valvat/local.rb
 - lib/valvat/locales/bg.yml
 - lib/valvat/locales/ca.yml
@@ -148,8 +168,9 @@ files:
 - lib/valvat/locales/sv.yml
 - lib/valvat/locales/tr.yml
 - lib/valvat/lookup.rb
+- lib/valvat/lookup/fault.rb
 - lib/valvat/lookup/request.rb
-- lib/valvat/lookup/request_with_id.rb
+- lib/valvat/lookup/response.rb
 - lib/valvat/syntax.rb
 - lib/valvat/utils.rb
 - lib/valvat/version.rb
@@ -181,6 +202,9 @@ files:
 - spec/valvat/checksum/se_spec.rb
 - spec/valvat/checksum/si_spec.rb
 - spec/valvat/checksum_spec.rb
+- spec/valvat/lockup/fault_spec.rb
+- spec/valvat/lockup/request_spec.rb
+- spec/valvat/lockup/response_spec.rb
 - spec/valvat/lookup_spec.rb
 - spec/valvat/syntax_spec.rb
 - spec/valvat/utils_spec.rb
@@ -190,7 +214,7 @@ homepage: https://github.com/yolk/valvat
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -206,7 +230,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.0.3
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Validates european vat numbers. Standalone or as a ActiveModel validator.
 test_files:
@@ -238,6 +262,9 @@ test_files:
 - spec/valvat/checksum/se_spec.rb
 - spec/valvat/checksum/si_spec.rb
 - spec/valvat/checksum_spec.rb
+- spec/valvat/lockup/fault_spec.rb
+- spec/valvat/lockup/request_spec.rb
+- spec/valvat/lockup/response_spec.rb
 - spec/valvat/lookup_spec.rb
 - spec/valvat/syntax_spec.rb
 - spec/valvat/utils_spec.rb

data/lib/valvat/lookup/request_with_id.rb

@@ -1,31 +0,0 @@
-class Valvat
-  class Lookup
-    class RequestWithId < Request
-      def initialize(vat, requester_vat)
-        @vat = vat
-        @requester_vat = requester_vat
-      end
-
-      private
-
-      def body
-        super.merge(
-          :requester_country_code => @requester_vat.vat_country_code,
-          :requester_vat_number => @requester_vat.to_s_wo_country
-        )
-      end
-
-      def message_tag
-        :checkVatApprox
-      end
-
-      def action
-        :check_vat_approx
-      end
-
-      def response_key
-        :check_vat_approx_response
-      end
-    end
-  end
-end