valvat 0.6.8 → 0.6.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bd8d2d5619d96c0f8a269bba25df839e3a4b2434
-  data.tar.gz: 76a5d6620d2a4a9009290d19847b9c49f5b669bc
+  metadata.gz: cbfcb15db4a635bac6916984c415c20bfcbdf89c
+  data.tar.gz: 7c72a583b3a5a9b3b001da112656c1d25a92c7e9
 SHA512:
-  metadata.gz: 441fb0184697917540c6e0227df53e8cfef1e2b83c3f3e1fe0c278c380dc8454f669bd2e3b368c25e92931935dfbc45678f221204bec76009dd3f2df8fe3976c
-  data.tar.gz: 51e211a97ad8a9e8fd13e0e5bbde19e655f87eed8c14ca1e84ac943b3ddfce2b30ac6703f3b8e74180bfd32b26ac3643cf29994810424d7b6287c502c6850343
+  metadata.gz: 2ca1eb637a48062b27b3f6302bffc5fbc4d41c8b6060acf6d1b9925cbfb8114e377dff4bc2932ff5c8e8384557cfbe3b6fa3c08338095639307745f9eab823d9
+  data.tar.gz: adc20d41241cbbbe53133bf710b5bd24335b27f96dd57ad04decd73beb19b3438304485c21e9c79928764bb16df2fb01ccc20258304c821371b8740403eedf37

data/.gitignore

@@ -2,4 +2,6 @@ pkg/*
 *.gem
 .bundle
 Gemfile.lock
-tmp
+tmp
+.rbenv-*
+.ruby-version

data/CHANGES.md

@@ -1,6 +1,14 @@
 ### dev
 
-[full changelog](http://github.com/yolk/valvat/compare/v0.6.8...master)
+[full changelog](http://github.com/yolk/valvat/compare/v0.6.9...master)
+
+### 0.6.9 / 2015-03-19
+
+[full changelog](http://github.com/yolk/valvat/compare/v0.6.8...v0.6.9)
+
+* Added catalan translations (by [descala](https://github.com/descala))
+* Added support for spanish NIE Y and Z (by [descala](https://github.com/descala))
+* Fixed spanish translations (by [Carlos Hernández Medina](https://github.com/polimorfico))
 
 ### 0.6.8 / 2014-12-18
 

data/README.md

@@ -11,7 +11,7 @@ Validates european vat numbers. Standalone or as a ActiveModel validator.
 * Lookup via the VIES web service
 * (Optional) ActiveModel/Rails3 integration
 * Works standalone without ActiveModel
-* I18n locales for country specific error messages in English, German, French, Spanish, Italian, Portuguese, Polish, Swedish, Dutch, Danish, Bulgarian, Romanian and Latvian.
+* I18n locales for country specific error messages in English, German, French, Spanish, Italian, Portuguese, Polish, Swedish, Dutch, Danish, Bulgarian, Romanian, Latvian and Catalan.
 * *Experimental* checksum verification
 
 valvat is tested and works with ruby MRI 1.9.3/2.0/2.1, jruby (in 1.9 mode) and ActiveModel 3.2/4.1
@@ -188,6 +188,8 @@ There seems to be a problem when using the VIES service over IPv6. Sadly this is
 
 ## Contributions by
 
+* [descala](https://github.com/descala)
+* [Carlos Hernández Medina](https://github.com/polimorfico)
 * [Julik Tarkhanov](https://github.com/julik)
 * [Roman Lehnert](https://github.com/romanlehnert)
 * [0scarius](https://github.com/0scarius)
@@ -207,6 +209,6 @@ There seems to be a problem when using the VIES service over IPv6. Sadly this is
 
 ## BlaBla
 
-Copyright (c) 2011-2014 Yolk Sebastian Munz & Julia Soergel GbR
+Copyright (c) 2011-2015 Yolk Sebastian Munz & Julia Soergel GbR
 
 Beyond that, the implementation is licensed under the MIT License.

data/lib/valvat/checksum/es.rb

@@ -2,22 +2,31 @@ class Valvat
   module Checksum
     class ES < Base
       NATURAL_PERSON_CHARS       = %w(T R W A G M Y F P D X B N J Z S Q V H L C K E)
-      NATURAL_PERSON_EXP         = /\A([\d]{8}[ABCDEFGHJKLMNPQRSTVWXYZ]|[KLMX][\d]{7}[ABCDEFGHJKLMNPQRSTVWXYZ])\Z/
-      LEGAL_FOREIGN_PERSON_CHARS = [false] + %w(A B C D E F G H I J)
-      LEGAL_FOREIGN_PERSON_EXP   = /\A[NPQRSW][\d]{7}[ABCDEFGHIJ]\Z/
+      NATURAL_PERSON_EXP         = /\A([\d]{8}[ABCDEFGHJKLMNPQRSTVWXYZ]|[KLMXYZ][\d]{7}[ABCDEFGHJKLMNPQRSTVWXYZ])\Z/
+      LEGAL_PERSON_CHARS = [false] + %w(A B C D E F G H I J)
+      LEGAL_PERSON_EXP   = /\A[NPQRSW][\d]{7}[ABCDEFGHIJ]\Z/
 
       def check_digit
         natural_person? ? check_digit_natural_person : check_digit_legal_person
       end
 
       def check_digit_natural_person
-        NATURAL_PERSON_CHARS[figures_str.to_i.modulo(23)]
+        nie_digit = nil
+        letter = vat.to_s_wo_country[0]
+        if letter == 'X'
+          nie_digit = 0
+        elsif letter == 'Y'
+          nie_digit = 1
+        elsif letter == 'Z'
+          nie_digit = 2
+        end
+        NATURAL_PERSON_CHARS["#{nie_digit}#{figures_str}".to_i.modulo(23)]
       end
 
       def check_digit_legal_person
         chk = 10 - sum_of_figures_for_at_es_it_se(true).modulo(10)
         legal_foreign_person? ?
-          LEGAL_FOREIGN_PERSON_CHARS[chk] :
+          LEGAL_PERSON_CHARS[chk] :
           (chk == 10 ? 0 : chk)
       end
 
@@ -39,7 +48,7 @@ class Valvat
       end
 
       def legal_foreign_person?
-        !!(vat.to_s_wo_country =~ LEGAL_FOREIGN_PERSON_EXP)
+        !!(vat.to_s_wo_country =~ LEGAL_PERSON_EXP)
       end
     end
   end

data/lib/valvat/locales/ca.yml

@@ -0,0 +1,34 @@
+ca:
+  errors:
+    messages:
+      invalid_vat: no és un número d'IVA intracomunitari %{country_adjective} vàlid
+  valvat:
+    country_adjectives:
+      eu: europeu
+      at: austríac
+      be: belga
+      bg: búlgar
+      cy: xipriota
+      cz: txec
+      de: alemany
+      dk: danès
+      ee: estoni
+      es: espanyol
+      fi: finlandés
+      fr: francès
+      gb: britànic
+      gr: grec
+      hu: hungarès
+      ie: irlandès
+      it: italià
+      lt: lituà
+      lu: luxemburguès
+      lv: letó
+      mt: maltès
+      nl: holandès
+      pl: polac
+      pt: portuguès
+      ro: rumanès
+      se: suec
+      si: eslovec
+      sk: eslovac

data/lib/valvat/locales/es.yml

@@ -1,7 +1,7 @@
 es:
   errors:
     messages:
-      invalid_vat: el impuesto sobre el valor añadido %{country_adjective} no es válido 
+      invalid_vat: el número de IVA intracomunitario %{country_adjective} no es válido 
   valvat:
     country_adjectives:
       eu: europeo
@@ -18,7 +18,7 @@ es:
       fr: francés
       gb: británico
       gr: griego
-      hu: úngaro
+      hu: húngaro
       ie: irlandés
       it: italiano
       lt: lituano
@@ -28,7 +28,7 @@ es:
       nl: holandés
       pl: polaco
       pt: portugués
-      ro: romano
+      ro: rumano
       se: sueco
-      si: eslovenio
+      si: esloveno
       sk: eslovaco

data/lib/valvat/version.rb

@@ -1,3 +1,3 @@
 class Valvat
-  VERSION = "0.6.8"
+  VERSION = "0.6.9"
 end

data/spec/valvat/checksum/es_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe Valvat::Checksum::ES do
-  %w(ESA13585625 ESB83871236 ESE54507058 ES25139013J ESQ1518001A ESQ5018001G ESX4942978W ESX7676464F ESB10317980).each do |valid_vat|
+  %w(ESA13585625 ESB83871236 ESE54507058 ES25139013J ESQ1518001A ESQ5018001G ESX4942978W ESX7676464F ESB10317980 ESY3860557K ESY2207765D).each do |valid_vat|
     it "returns true on valid vat #{valid_vat}" do
       expect(Valvat::Checksum.validate(valid_vat)).to eql(true)
     end

data/valvat.gemspec

@@ -18,6 +18,7 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
   s.cert_chain    = ['certs/yolk.pem']
   s.signing_key   = File.expand_path("~/.ssh/gem-private_key.pem") if $0 =~ /gem\z/
+  s.required_ruby_version = '>= 1.9.3'
 
   s.add_dependency             'savon',       '>= 2.3.0'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: valvat
 version: !ruby/object:Gem::Version
-  version: 0.6.8
+  version: 0.6.9
 platform: ruby
 authors:
 - Sebastian Munz
@@ -30,7 +30,7 @@ cert_chain:
   wV8oppYhH3tRwfGrXgETqok7yPVYTZFcjCW9s9snwVE/JA23z12g54jVnaAP8SQH
   L1HABGk4QCo=
   -----END CERTIFICATE-----
-date: 2014-12-18 00:00:00.000000000 Z
+date: 2015-03-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -96,8 +96,6 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
-- ".rbenv-gemsets"
-- ".ruby-version"
 - ".travis.yml"
 - CHANGES.md
 - Gemfile
@@ -129,6 +127,7 @@ files:
 - lib/valvat/checksum/se.rb
 - lib/valvat/checksum/si.rb
 - lib/valvat/locales/bg.yml
+- lib/valvat/locales/ca.yml
 - lib/valvat/locales/cs.yml
 - lib/valvat/locales/da.yml
 - lib/valvat/locales/de.yml
@@ -184,7 +183,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="

data/.rbenv-gemsets

@@ -1 +0,0 @@
-plugin

data/.ruby-version

@@ -1 +0,0 @@
-2.1.5