valvat 0.6.2 → 0.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a11112c9d6ba5fb3bf17de04d3e3a29e9d4396ae
-  data.tar.gz: be2eb43d47a2324b16a94f40dca2107a69617fd1
+  metadata.gz: f260253d1cce6ddf66bb80cc487645085d248e85
+  data.tar.gz: c696cc28bb9bd7b77858debbde44fe27402c1698
 SHA512:
-  metadata.gz: 53cd0859a466ace1cf8945c8851ec739cfec407c015594c3740d3b992d77bc7c41793945b0329e9653f7601b03803dd7c9edaf429f55504cc43e6a0b14b7ac01
-  data.tar.gz: 3ccb4b764b57374ff27424ba9414eaa2917101b5be24e27b4115d24e58eaf0a37bdc93c67beca0a94f78eb080e1ef3f3eea27c412f928d58f275b32ac148673a
+  metadata.gz: 1f9851b11d179fa9f8f3e544e4916b1f1edfd377c38ccd1ef0f2d7f43a342a1f07619fdcc96e1224fac67faae15962f4af8bb70a4f3078e13e85ff3fc7c4e523
+  data.tar.gz: c66a83b5b8f1fc1e16756b5b3efcabfde63abe5104443020002f41a899dbf53a03264b6ff61ddf12aace468f70b204087668e80e4dadaf0b1eeecb1cb59c3999

data/.rbenv-version

@@ -1 +1 @@
-2.0.0-p247
+2.1.0

data/.travis.yml

@@ -1,5 +1,6 @@
 language: ruby
 rvm:
+  - 2.1.0
   - 2.0.0
   - 1.9.3
   - jruby-19mode

data/CHANGES.md

@@ -1,6 +1,12 @@
 ### dev
 
-[full changelog](http://github.com/yolk/valvat/compare/v0.6.2...master)
+[full changelog](http://github.com/yolk/valvat/compare/v0.6.3...master)
+
+### 0.6.3 / 2014-04-05
+
+[full changelog](http://github.com/yolk/valvat/compare/v0.6.2...v0.6.3)
+
+* Fixed portuguese translations (by [Davidslv](https://github.com/Davidslv))
 
 ### 0.6.2 / 2013-11-10
 

data/README.md

@@ -176,6 +176,10 @@ To normalize a vat number:
 
 This basically just removes trailing spaces and ensures all chars are uppercase.
 
+## Usage with IPv6
+
+There seems to be a problem when using the VIES service over IPv6. Sadly this is nothing this gem can address. For details and proposed solutions have a look at [this question on StackOverflow](http://stackoverflow.com/questions/15616833/vies-vat-api-soap-error-ipv6). Thanks to George Palmer for bringing up this issue.
+
 ## Links
 
 * [VIES web service](http://ec.europa.eu/taxation_customs/vies)
@@ -184,6 +188,7 @@ This basically just removes trailing spaces and ensures all chars are uppercase.
 
 ## Contributions by
 
+* [Davidslv](https://github.com/Davidslv)
 * [brianphillips](https://github.com/brianphillips)
 * [wasi](https://github.com/wasi)
 * [liggitt](https://github.com/liggitt)
@@ -199,6 +204,6 @@ This basically just removes trailing spaces and ensures all chars are uppercase.
 
 ## BlaBla
 
-Copyright (c) 2011-2013 Yolk Sebastian Munz & Julia Soergel GbR
+Copyright (c) 2011-2014 Yolk Sebastian Munz & Julia Soergel GbR
 
 Beyond that, the implementation is licensed under the MIT License.

data/lib/valvat/locales/pt.yml

@@ -1,7 +1,7 @@
 pt:
   errors:
     messages:
-      invalid_vat: não é um NIF %{country_adjective} válido.
+      invalid_vat: O NIF %{country_adjective} não é válido.
   valvat:
     country_adjectives:
     eu: europeu
@@ -22,7 +22,7 @@ pt:
     ie: irlandês
     it: italiano
     lt: lituano
-    lu: luxemburguese
+    lu: luxemburguês
     lv: letão
     mt: maltês
     nl: holandês
@@ -31,4 +31,4 @@ pt:
     ro: romeno
     se: sueco
     si: esloveno
-    sk: eslovaco
+    sk: eslovaco

data/lib/valvat/version.rb

@@ -1,3 +1,3 @@
 class Valvat
-  VERSION = "0.6.2"
+  VERSION = "0.6.3"
 end

data/spec/valvat/checksum/pt_spec.rb

@@ -1,15 +1,31 @@
 require 'spec_helper'
 
 describe Valvat::Checksum::PT do
+
+  subject { Valvat::Checksum }
+
   %w(PT136695973 PT501413197 PT503037753 PT500243590 PT500100144 PT502921838).each do |valid_vat|
     it "returns true on valid vat #{valid_vat}" do
-      Valvat::Checksum.validate(valid_vat).should eql(true)
+      subject.validate(valid_vat).should be_true
     end
 
     invalid_vat = "#{valid_vat[0..-5]}#{valid_vat[-1]}#{valid_vat[-4]}#{valid_vat[-2]}#{valid_vat[-3]}"
 
     it "returns false on invalid vat #{invalid_vat}" do
-      Valvat::Checksum.validate(invalid_vat).should eql(false)
+      subject.validate(invalid_vat).should be_false
+    end
+  end
+
+  # Portuguese business VAT should start with the following numbers
+  # 1 or 2 (pessoa singular)                             - singular person
+  # 5 (pessoa colectiva)                                 - collective person
+  # 6 (pessoa colectiva pública)                         - public collective person
+  # 8 (empresário em nome individual)                    - individual enterpreneur
+  # 9 (pessoa colectiva irregular ou número provisório)  - provisional number
+  # http://www.nif.pt/nif-das-empresas/
+  %w(PT148166644 PT111623448 PT204874866 PT292261314 PT579104222 PT628910002 PT812627318 PT943935784).each do |number|
+    it "returns true on a valid number - #{number}" do
+      subject.validate(number).should be_true
     end
   end
-end
+end

data/spec/valvat/lookup_spec.rb

@@ -56,7 +56,7 @@ describe Valvat::Lookup do
             :country_code=>"IE",
             :vat_number=>"6388047V",
             :name=>"GOOGLE IRELAND LIMITED",
-            :address=>"1ST & 2ND FLOOR ,GORDON HOUSE ,BARROW STREET ,DUBLIN 4"
+            :address=>"3RD FLOOR ,GORDON HOUSE ,BARROW STREET ,DUBLIN 4"
           })
         else
           puts "Skipping IE vies lookup spec; result = #{result.inspect}"

metadata

@@ -1,69 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: valvat
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.6.3
 platform: ruby
 authors:
 - Sebastian Munz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-10 00:00:00.000000000 Z
+date: 2014-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.4.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.4.0
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: fakeweb
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.3.0
 description: Validates european vat numbers. Standalone or as a ActiveModel validator.
@@ -73,10 +73,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rbenv-gemsets
-- .rbenv-version
-- .travis.yml
+- ".gitignore"
+- ".rbenv-gemsets"
+- ".rbenv-version"
+- ".travis.yml"
 - CHANGES.md
 - Gemfile
 - Guardfile
@@ -154,17 +154,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
 summary: Validates european vat numbers. Standalone or as a ActiveModel validator.