valvat 0.6.11 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ea57455edd0e89dd9205647d6c640528d900c068
-  data.tar.gz: a2f2633b44ad25e899ef8992fc3a4682a61b0d3b
+  metadata.gz: 64381823f7e2709c5f0081eb33772f2a5a0e53d9
+  data.tar.gz: '0907da537a7050f749e55a9b75a0f7bf6d539ef0'
 SHA512:
-  metadata.gz: 99fbddf4276e0f01d5dedc79943e1f2d558e0eb2a97d75513342df7addb6082839a4c6e0ee9ede4b9bf70a93da57612f689e69eba109a4fb77ed0cead328002e
-  data.tar.gz: 1b89e31ad6915365cbf83ff0a2852df470419485a2919d323508f8a87b4740c3a665d132af574a90eb4b1cbb1c6e57287dd326e6b3e7d7a8d7474cddcb9ffc41
+  metadata.gz: 1729182d844d98ccdc4377582b03fcaf2a8c494c7c50828985b7fd02e9dd94045983e56b48510d3081f9843de6e40c4d5ef3492970e927c39bec4fbd04d54dec
+  data.tar.gz: c4e87f422914f632fa6ab88c059f0c650132c002c78e7fcf5536cff1dcc32e481c930e867e97a3b3f4e1e1dcd364e3c230369b6544ae3877fd61c9fb92eded14

data/CHANGES.md

@@ -1,6 +1,13 @@
 ### dev
 
-[full changelog](http://github.com/yolk/valvat/compare/v0.6.11...master)
+[full changelog](http://github.com/yolk/valvat/compare/v0.7.0...master)
+
+### 0.7.0 / 2017-05-16
+
+[full changelog](http://github.com/yolk/valvat/compare/v0.6.11...v0.7.0)
+
+* Improved regex for Cyprus, Estonia, and Lithuania (by [ndnenkov](https://github.com/ndnenkov))
+* Added checksum validations for Cyprus, Estonia, Lithuania, Romania, Malta, Hungary, and Croatia (by [ndnenkov](https://github.com/ndnenkov))
 
 ### 0.6.11 / 2017-04-07
 

data/README.md

@@ -188,6 +188,7 @@ There seems to be a problem when using the VIES service over IPv6. Sadly this is
 
 ## Contributions by
 
+* [ndnenkov](https://github.com/ndnenkov)
 * [0ctobat](https://github.com/0ctobat)
 * [kaapa](https://github.com/kaapa)
 * [descala](https://github.com/descala)

data/lib/valvat/checksum/cy.rb

@@ -0,0 +1,19 @@
+class Valvat
+  module Checksum
+    class CY < Base
+      def check_digit
+        odd_position_digit_values = [1, 0, 5, 7, 9, 13, 15, 17, 19, 21]
+
+        sum = sum_figures_by do |digit, index|
+          (8 - index).odd? ? odd_position_digit_values[digit] : digit
+        end
+
+        ('a'..'z').to_a[sum % 26]
+      end
+
+      def given_check_digit
+        given_check_digit_str.downcase
+      end
+    end
+  end
+end

data/lib/valvat/checksum/ee.rb

@@ -0,0 +1,15 @@
+class Valvat
+  module Checksum
+    class EE < Base
+      def check_digit
+        multipliers = [7, 3, 1, 7, 3, 1, 7, 3]
+
+        sum = sum_figures_by do |digit, index|
+          digit * multipliers[index]
+        end
+
+        ((sum / 10.0).ceil * 10).to_i - sum
+      end
+    end
+  end
+end

data/lib/valvat/checksum/hr.rb

@@ -0,0 +1,18 @@
+class Valvat
+  module Checksum
+    class HR < Base
+      def check_digit
+        product = 10
+        sum     = 0
+
+        figures.each do |figure|
+          sum = (figure + product) % 10
+          sum = 10 if sum.zero?
+          product = (2 * sum) % 11
+        end
+
+        (10 - (product - 1) % 10) % 10
+      end
+    end
+  end
+end

data/lib/valvat/checksum/hu.rb

@@ -0,0 +1,15 @@
+class Valvat
+  module Checksum
+    class HU < Base
+      def check_digit
+        multipliers = [3, 7, 9, 1, 3, 7, 9]
+
+        sum = sum_figures_by do |digit, index|
+          digit * multipliers[index]
+        end
+
+        (10 - sum % 10) % 10
+      end
+    end
+  end
+end

data/lib/valvat/checksum/lt.rb

@@ -0,0 +1,21 @@
+class Valvat
+  module Checksum
+    class LT < Base
+      def check_digit
+        base_checksum    = sum_with(0) % 11
+        shifted_checksum = sum_with(2) % 11
+
+        [base_checksum, shifted_checksum, 0].find { |checksum| checksum % 11 != 10 }
+      end
+
+      private
+
+      def sum_with(offset)
+        sum_figures_by do |digit, index|
+          multi_digit_multiplier = figures.size - index + offset
+          digit * (multi_digit_multiplier > 9 ? multi_digit_multiplier % 9 : multi_digit_multiplier)
+        end
+      end
+    end
+  end
+end

data/lib/valvat/checksum/mt.rb

@@ -0,0 +1,16 @@
+class Valvat
+  module Checksum
+    class MT < Base
+      check_digit_length 2
+
+      def check_digit
+        multipliers = [9, 8, 7, 6, 4, 3]
+
+        sum = sum_figures_by { |digit, index| digit * multipliers[index] }
+
+        supposed_checksum = 37 - (sum % 37)
+        supposed_checksum.zero? ? 37 : supposed_checksum
+      end
+    end
+  end
+end

data/lib/valvat/checksum/ro.rb

@@ -0,0 +1,16 @@
+class Valvat
+  module Checksum
+    class RO < Base
+      def check_digit
+        multipliers = [2, 3, 5, 7, 1, 2, 3, 5, 7]
+
+        sum = sum_figures_by { |digit, index| digit * multipliers[index] }
+        sum * 10 % 11 % 10
+      end
+
+      def figures_str
+        super.rjust(9, '0')
+      end
+    end
+  end
+end

data/lib/valvat/syntax.rb

@@ -5,11 +5,11 @@ class Valvat
         'AT' => /\AATU[0-9]{8}\Z/,                                          # Austria
         'BE' => /\ABE0[0-9]{9}\Z/,                                          # Belgium
         'BG' => /\ABG[0-9]{9,10}\Z/,                                        # Bulgaria
-        'CY' => /\ACY[0-9]{8}[A-Z]\Z/,                                      # Cyprus
+        'CY' => /\ACY(?!12)[0-59][0-9]{7}[A-Z]\Z/,                          # Cyprus
         'CZ' => /\ACZ[0-9]{8,10}\Z/,                                        # Czech Republic
         'DE' => /\ADE[0-9]{9}\Z/,                                           # Germany
         'DK' => /\ADK[0-9]{8}\Z/,                                           # Denmark
-        'EE' => /\AEE[0-9]{9}\Z/,                                           # Estonia
+        'EE' => /\AEE10[0-9]{7}\Z/,                                         # Estonia
         'GR' => /\AEL[0-9]{9}\Z/,                                           # Greece
         'ES' => /\AES([A-Z][0-9]{8}|[0-9]{8}[A-Z]|[A-Z][0-9]{7}[A-Z])\Z/,   # Spain
         'FI' => /\AFI[0-9]{8}\Z/,                                           # Finland
@@ -19,7 +19,7 @@ class Valvat
         'HU' => /\AHU[0-9]{8}\Z/,                                           # Hungary
         'IE' => /\AIE([0-9][A-Z][0-9]{5}|[0-9]{7}[A-Z]?)[A-Z]\Z/,           # Ireland
         'IT' => /\AIT[0-9]{11}\Z/,                                          # Italy
-        'LT' => /\ALT([0-9]{9}|[0-9]{12})\Z/,                               # Lithuania
+        'LT' => /\ALT([0-9]{7}1[0-9]|[0-9]{10}1[0-9])\Z/,                   # Lithuania
         'LU' => /\ALU[0-9]{8}\Z/,                                           # Luxembourg
         'LV' => /\ALV[0-9]{11}\Z/,                                          # Latvia
         'MT' => /\AMT[0-9]{8}\Z/,                                           # Malta

data/lib/valvat/version.rb

@@ -1,3 +1,3 @@
 class Valvat
-  VERSION = "0.6.11"
+  VERSION = "0.7.0"
 end

data/spec/valvat/checksum/cy_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe Valvat::Checksum::CY do
+  %w(CY01234567U CY00532445O).each do |valid_vat|
+    it "returns true on valid vat #{valid_vat}" do
+      expect(Valvat::Checksum.validate(valid_vat)).to be true
+    end
+
+    invalid_vat = "#{valid_vat[0..-4]}#{valid_vat[-2]}#{valid_vat[-3]}#{valid_vat[-1]}"
+
+    it "returns false on invalid vat #{invalid_vat}" do
+      expect(Valvat::Checksum.validate(invalid_vat)).to be false
+    end
+  end
+end

data/spec/valvat/checksum/ee_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe Valvat::Checksum::EE do
+  %w(EE101234568 EE100207415).each do |valid_vat|
+    it "returns true on valid vat #{valid_vat}" do
+      expect(Valvat::Checksum.validate(valid_vat)).to be true
+    end
+
+    invalid_vat = "#{valid_vat[0..-3]}#{valid_vat[-1]}#{valid_vat[-2]}"
+
+    it "returns false on invalid vat #{invalid_vat}" do
+      expect(Valvat::Checksum.validate(invalid_vat)).to be false
+    end
+  end
+end

data/spec/valvat/checksum/hr_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe Valvat::Checksum::HR do
+  %w(HR06282943396 HR17099025134).each do |valid_vat|
+    it "returns true on valid vat #{valid_vat}" do
+      expect(Valvat::Checksum.validate(valid_vat)).to be true
+    end
+
+    invalid_vat = "#{valid_vat[0..-3]}#{valid_vat[-1]}#{valid_vat[-2]}"
+
+    it "returns false on invalid vat #{invalid_vat}" do
+      expect(Valvat::Checksum.validate(invalid_vat)).to be false
+    end
+  end
+end

data/spec/valvat/checksum/hu_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe Valvat::Checksum::HU do
+  %w(HU10672101 HU13460370 HU10747759).each do |valid_vat|
+    it "returns true on valid vat #{valid_vat}" do
+      expect(Valvat::Checksum.validate(valid_vat)).to be true
+    end
+
+    invalid_vat = "#{valid_vat[0..-3]}#{valid_vat[-1]}#{valid_vat[-2]}"
+
+    it "returns false on invalid vat #{invalid_vat}" do
+      expect(Valvat::Checksum.validate(invalid_vat)).to be false
+    end
+  end
+end

data/spec/valvat/checksum/lt_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe Valvat::Checksum::LT do
+  %w(LT213179412 LT290061371314).each do |valid_vat|
+    it "returns true on valid vat #{valid_vat}" do
+      expect(Valvat::Checksum.validate(valid_vat)).to be true
+    end
+
+    invalid_vat = "#{valid_vat[0..-3]}#{valid_vat[-1]}#{valid_vat[-2]}"
+
+    it "returns false on invalid vat #{invalid_vat}" do
+      expect(Valvat::Checksum.validate(invalid_vat)).to be false
+    end
+  end
+end

data/spec/valvat/checksum/mt_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe Valvat::Checksum::MT do
+  %w(MT11407334 MT10126313 MT11539237).each do |valid_vat|
+    it "returns true on valid vat #{valid_vat}" do
+      expect(Valvat::Checksum.validate(valid_vat)).to be true
+    end
+
+    invalid_vat = "#{valid_vat[0..-3]}#{valid_vat[-1]}#{valid_vat[-2]}"
+
+    it "returns false on invalid vat #{invalid_vat}" do
+      expect(Valvat::Checksum.validate(invalid_vat)).to be false
+    end
+  end
+end

data/spec/valvat/checksum/ro_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe Valvat::Checksum::RO do
+  %w(RO123456789 RO99908 RO19 RO124 RO13182060).each do |valid_vat|
+    it "returns true on valid vat #{valid_vat}" do
+      expect(Valvat::Checksum.validate(valid_vat)).to be true
+    end
+
+    invalid_vat = "#{valid_vat[0..-3]}#{valid_vat[-1]}#{valid_vat[-2]}"
+
+    it "returns false on invalid vat #{invalid_vat}" do
+      expect(Valvat::Checksum.validate(invalid_vat)).to be false
+    end
+  end
+end

data/spec/valvat/checksum_spec.rb

@@ -9,7 +9,7 @@ end
 describe Valvat::Checksum do
   describe "#validate" do
     it "returns true on vat number with unknown checksum algorithm" do
-      expect(Valvat::Checksum.validate("HR12345678901")).to eql(true)
+      expect(Valvat::Checksum.validate("CZ699001237")).to eql(true)
     end
 
     it "returns false on corrupt number (e.g checks syntax)" do

data/spec/valvat/syntax_spec.rb

@@ -66,10 +66,10 @@ describe Valvat::Syntax do
     end
 
     it "validates a EE vat number" do
-      expect(subject.validate("EE678678456")).to eql(true)
-      expect(subject.validate("EE6786784560")).to eql(false)
-      expect(subject.validate("EE67867845")).to eql(false)
-      expect(subject.validate("EE67867845K")).to eql(false)
+      expect(subject.validate("EE100207415")).to eql(true)
+      expect(subject.validate("EE1002074150")).to eql(false)
+      expect(subject.validate("EE10020741")).to eql(false)
+      expect(subject.validate("EE100207415K")).to eql(false)
     end
 
     it "validates a FI vat number" do
@@ -145,15 +145,17 @@ describe Valvat::Syntax do
     end
 
     it "validates a LT vat number" do
-      expect(subject.validate("LT678678987")).to eql(true)
-      expect(subject.validate("LT678678987956")).to eql(true)
-
-      expect(subject.validate("LT67867898")).to eql(false)
-      expect(subject.validate("LT6786789870")).to eql(false)
-      expect(subject.validate("LT678678987K")).to eql(false)
-      expect(subject.validate("LT67867898709")).to eql(false)
-      expect(subject.validate("LT6786789870C")).to eql(false)
-      expect(subject.validate("LT67867898795H")).to eql(false)
+      expect(subject.validate("LT213179412")).to eql(true)
+      expect(subject.validate("LT290061371314")).to eql(true)
+
+      expect(subject.validate("LT21317942")).to eql(false)
+      expect(subject.validate("LT213179422")).to eql(false)
+      expect(subject.validate("LT2131794120")).to eql(false)
+      expect(subject.validate("LT213179412K")).to eql(false)
+      expect(subject.validate("LT29006137132")).to eql(false)
+      expect(subject.validate("LT290061371324")).to eql(false)
+      expect(subject.validate("LT29006137131C")).to eql(false)
+      expect(subject.validate("LT290061371314H")).to eql(false)
     end
 
     it "validates a LU vat number" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: valvat
 version: !ruby/object:Gem::Version
-  version: 0.6.11
+  version: 0.7.0
 platform: ruby
 authors:
 - Sebastian Munz
@@ -30,7 +30,7 @@ cert_chain:
   uE5yNhiszXkFmLQWPm57rwu8PbwT7av5kmYVhn8qkRz2aZnuAlLV3rcq2Khe5F0/
   jZmT2fJ8H8g=
   -----END CERTIFICATE-----
-date: 2017-04-07 00:00:00.000000000 Z
+date: 2017-05-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -104,18 +104,25 @@ files:
 - lib/valvat/checksum/at.rb
 - lib/valvat/checksum/be.rb
 - lib/valvat/checksum/bg.rb
+- lib/valvat/checksum/cy.rb
 - lib/valvat/checksum/de.rb
 - lib/valvat/checksum/dk.rb
+- lib/valvat/checksum/ee.rb
 - lib/valvat/checksum/es.rb
 - lib/valvat/checksum/fi.rb
 - lib/valvat/checksum/fr.rb
 - lib/valvat/checksum/gr.rb
+- lib/valvat/checksum/hr.rb
+- lib/valvat/checksum/hu.rb
 - lib/valvat/checksum/ie.rb
 - lib/valvat/checksum/it.rb
+- lib/valvat/checksum/lt.rb
 - lib/valvat/checksum/lu.rb
+- lib/valvat/checksum/mt.rb
 - lib/valvat/checksum/nl.rb
 - lib/valvat/checksum/pl.rb
 - lib/valvat/checksum/pt.rb
+- lib/valvat/checksum/ro.rb
 - lib/valvat/checksum/se.rb
 - lib/valvat/checksum/si.rb
 - lib/valvat/locales/bg.yml
@@ -145,18 +152,25 @@ files:
 - spec/valvat/checksum/at_spec.rb
 - spec/valvat/checksum/be_spec.rb
 - spec/valvat/checksum/bg_spec.rb
+- spec/valvat/checksum/cy_spec.rb
 - spec/valvat/checksum/de_spec.rb
 - spec/valvat/checksum/dk_spec.rb
+- spec/valvat/checksum/ee_spec.rb
 - spec/valvat/checksum/es_spec.rb
 - spec/valvat/checksum/fi_spec.rb
 - spec/valvat/checksum/fr_spec.rb
 - spec/valvat/checksum/gr_spec.rb
+- spec/valvat/checksum/hr_spec.rb
+- spec/valvat/checksum/hu_spec.rb
 - spec/valvat/checksum/ie_spec.rb
 - spec/valvat/checksum/it_spec.rb
+- spec/valvat/checksum/lt_spec.rb
 - spec/valvat/checksum/lu_spec.rb
+- spec/valvat/checksum/mt_spec.rb
 - spec/valvat/checksum/nl_spec.rb
 - spec/valvat/checksum/pl_spec.rb
 - spec/valvat/checksum/pt_spec.rb
+- spec/valvat/checksum/ro_spec.rb
 - spec/valvat/checksum/se_spec.rb
 - spec/valvat/checksum/si_spec.rb
 - spec/valvat/checksum_spec.rb
@@ -195,18 +209,25 @@ test_files:
 - spec/valvat/checksum/at_spec.rb
 - spec/valvat/checksum/be_spec.rb
 - spec/valvat/checksum/bg_spec.rb
+- spec/valvat/checksum/cy_spec.rb
 - spec/valvat/checksum/de_spec.rb
 - spec/valvat/checksum/dk_spec.rb
+- spec/valvat/checksum/ee_spec.rb
 - spec/valvat/checksum/es_spec.rb
 - spec/valvat/checksum/fi_spec.rb
 - spec/valvat/checksum/fr_spec.rb
 - spec/valvat/checksum/gr_spec.rb
+- spec/valvat/checksum/hr_spec.rb
+- spec/valvat/checksum/hu_spec.rb
 - spec/valvat/checksum/ie_spec.rb
 - spec/valvat/checksum/it_spec.rb
+- spec/valvat/checksum/lt_spec.rb
 - spec/valvat/checksum/lu_spec.rb
+- spec/valvat/checksum/mt_spec.rb
 - spec/valvat/checksum/nl_spec.rb
 - spec/valvat/checksum/pl_spec.rb
 - spec/valvat/checksum/pt_spec.rb
+- spec/valvat/checksum/ro_spec.rb
 - spec/valvat/checksum/se_spec.rb
 - spec/valvat/checksum/si_spec.rb
 - spec/valvat/checksum_spec.rb