valvat 0.6.1 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fd3b95aa5d283ec356195df0880ad0e64e446aa3
-  data.tar.gz: dcaba4e137938936a83fe03d81e56b4b3a87c1d6
+  metadata.gz: a11112c9d6ba5fb3bf17de04d3e3a29e9d4396ae
+  data.tar.gz: be2eb43d47a2324b16a94f40dca2107a69617fd1
 SHA512:
-  metadata.gz: 289ecdaf74f63696bc7ebcd7804ae430c9baa1671544a093291fe335ff8db46e1f655984b5c24fea08b1294234160abc13cffc1195af2f0c62997f5add56adb1
-  data.tar.gz: ca8d11429b9586fd2c85fde897b9f50cabb1921dadba56dd7b9d7a47d86801b6d54439a400493d3463311a158f9489a3a3189d9d7640b5f0450b4462969766ce
+  metadata.gz: 53cd0859a466ace1cf8945c8851ec739cfec407c015594c3740d3b992d77bc7c41793945b0329e9653f7601b03803dd7c9edaf429f55504cc43e6a0b14b7ac01
+  data.tar.gz: 3ccb4b764b57374ff27424ba9414eaa2917101b5be24e27b4115d24e58eaf0a37bdc93c67beca0a94f78eb080e1ef3f3eea27c412f928d58f275b32ac148673a

data/.travis.yml

@@ -2,6 +2,8 @@ language: ruby
 rvm:
   - 2.0.0
   - 1.9.3
+  - jruby-19mode
+  - rbx-2.1.1
 gemfile:
   - gemfiles/activemodel-4
   - gemfiles/activemodel-3-2

data/CHANGES.md

@@ -1,6 +1,12 @@
 ### dev
 
-[full changelog](http://github.com/yolk/valvat/compare/v0.6.1...master)
+[full changelog](http://github.com/yolk/valvat/compare/v0.6.2...master)
+
+### 0.6.2 / 2013-11-10
+
+[full changelog](http://github.com/yolk/valvat/compare/v0.6.1...v0.6.2)
+
+* Added blank? method to Valvat object
 
 ### 0.6.1 / 2013-09-02
 

data/Gemfile

@@ -1,6 +1,13 @@
-source "http://rubygems.org"
+source 'http://rubygems.org'
 
 # Specify your gem's dependencies in valvat.gemspec
 gemspec
 
 gem 'rake'
+gem 'guard-rspec', '~>4.0'
+gem 'rb-fsevent' if RUBY_PLATFORM.include?("x86_64-darwin")
+
+platform :rbx do
+  gem 'racc'
+  gem 'rubysl'
+end

data/README.md

@@ -14,7 +14,7 @@ Validates european vat numbers. Standalone or as a ActiveModel validator.
 * I18n locales for country specific error messages in English, German, Swedish, Italian, Portuguese, Polish, Bulgarian, Romanian and Latvian.
 * *Experimental* checksum verification
 
-valvat is tested and works with ruby 1.9.3/2.0 and ActiveModel 3.2/4.0
+valvat is tested and works with ruby MRI 1.9.3/2.0 and jruby (in 1.9 mode) and ActiveModel 3.2/4.0
 
 ## Installation
 

data/gemfiles/activemodel-3-2

@@ -1,8 +1,13 @@
 source "http://rubygems.org"
 
 gem "savon",       "2.3.0"
-gem "activemodel", "3.2.13"
+gem "activemodel", "3.2.15"
 
-gem 'rspec', '>= 2.4.0'
+gem 'rspec', '>= 2.14.0'
 gem 'fakeweb', '>= 1.3.0'
-gem 'rake'
+gem 'rake'
+
+platform :rbx do
+  gem 'racc'
+  gem 'rubysl'
+end

data/gemfiles/activemodel-4

@@ -1,8 +1,13 @@
 source "http://rubygems.org"
 
 gem "savon",       "2.3.0"
-gem "activemodel", "4.0"
+gem "activemodel", "4.0.1"
 
-gem 'rspec', '>= 2.4.0'
+gem 'rspec', '>= 2.14.0'
 gem 'fakeweb', '>= 1.3.0'
-gem 'rake'
+gem 'rake'
+
+platform :rbx do
+  gem 'racc'
+  gem 'rubysl'
+end

data/gemfiles/standalone

@@ -2,6 +2,11 @@ source "http://rubygems.org"
 
 gem "savon",       "2.3.0"
 
-gem 'rspec', '>= 2.4.0'
+gem 'rspec', '>= 2.14.0'
 gem 'fakeweb', '>= 1.3.0'
-gem 'rake'
+gem 'rake'
+
+platform :rbx do
+  gem 'racc'
+  gem 'rubysl'
+end

data/lib/valvat/version.rb

@@ -1,3 +1,3 @@
 class Valvat
-  VERSION = "0.6.1"
+  VERSION = "0.6.2"
 end

data/lib/valvat.rb

@@ -6,6 +6,10 @@ class Valvat
 
   attr_reader :raw, :vat_country_code, :to_s_wo_country
 
+  def blank?
+    raw.nil? || raw.strip == ""
+  end
+
   def valid?
     Valvat::Syntax.validate(self)
   end

data/spec/valvat/lookup_spec.rb

@@ -5,17 +5,35 @@ describe Valvat::Lookup do
     context "existing vat number" do
 
       it "returns true" do
-        Valvat::Lookup.validate("DE259597697").should eql(true)
+        result = Valvat::Lookup.validate("LU21416127")
+
+        unless result.nil?
+          result.should eql(true)
+        else
+          puts "Skipping LU vies lookup spec"
+        end
       end
 
       it "allows Valvat instance as input" do
-        Valvat::Lookup.validate(Valvat.new("DE259597697")).should eql(true)
+        result = Valvat::Lookup.validate(Valvat.new("LU21416127"))
+
+        unless result.nil?
+          result.should eql(true)
+        else
+          puts "Skipping LU vies lookup spec"
+        end
       end
     end
 
     context "not existing vat number" do
       it "returns false" do
-        Valvat::Lookup.validate("DE259597696").should eql(false)
+        result =  Valvat::Lookup.validate("LU21416128")
+
+        unless result.nil?
+          result.should eql(false)
+        else
+          puts "Skipping LU vies lookup spec"
+        end
       end
     end
 
@@ -60,23 +78,35 @@ describe Valvat::Lookup do
       end
 
       it "still returns false on not existing vat number" do
-        Valvat::Lookup.validate("DE259597696", :detail => true).should eql(false)
+        result =  Valvat::Lookup.validate("LU21416128", :detail => true)
+
+        unless result.nil?
+          result.should eql(false)
+        else
+          puts "Skipping LU vies lookup spec"
+        end
       end
     end
 
     context "with request identifier" do
       it "returns hash of details instead of true" do
-        response = Valvat::Lookup.validate("DE259597697", :requester_vat => "IE6388047V")
-        response[:request_identifier].size.should eql(16)
-        request_identifier = response[:request_identifier]
-        response.delete(:request_date).should be_kind_of(Date)
-        response.should eql({
-          :country_code=>"DE",
-          :vat_number=>"259597697",
-          :name => nil,
-          :company_type=>nil,
-          :request_identifier=> request_identifier
-        })
+        response = Valvat::Lookup.validate("LU21416127", :requester_vat => "IE6388047V")
+
+        if response
+          response[:request_identifier].size.should eql(16)
+          request_identifier = response[:request_identifier]
+          response.delete(:request_date).should be_kind_of(Date)
+          response.should eql({
+            :country_code=>"LU",
+            :vat_number=>"21416127",
+            :name => "EBAY EUROPE S.A R.L.",
+            :company_type=>nil,
+            :address => "22, BOULEVARD ROYAL\nL-2449  LUXEMBOURG",
+            :request_identifier=> request_identifier
+          })
+        else
+          puts "Skipping LU vies lookup spec"
+        end
       end
     end
 

data/spec/valvat_spec.rb

@@ -28,6 +28,22 @@ describe Valvat do
     end
   end
 
+
+  describe "#blank?" do
+    
+    it "returns true when when initialized with nil" do
+      Valvat.new(nil).should be_blank
+    end
+
+    it "returns true when when initialized with an empty string" do
+      Valvat.new(" ").should be_blank
+    end
+
+    it "returns false when initialized with a value" do
+      Valvat.new("DE259597697").should_not be_blank
+    end
+  end
+
   context "on european vat number" do
     let(:de_vat) { Valvat.new("DE259597697") } # valid & exists
     let(:invalid_checksum) { Valvat.new("DE259597687") } # valid & invalid checksum
@@ -274,4 +290,4 @@ describe Valvat do
     end
 
   end
-end
+end

data/valvat.gemspec

@@ -23,9 +23,6 @@ Gem::Specification.new do |s|
   s.add_dependency             'savon',       '>=2.3.0'
 
   s.add_development_dependency 'rspec',       '>= 2.4.0'
-  s.add_development_dependency 'guard-rspec', '>=0.1.9'
-  s.add_development_dependency 'growl',       '>=1.0.3'
-  s.add_development_dependency 'rb-fsevent',  '>=0.9.1'
   s.add_development_dependency 'activemodel', '>=3.0'
   s.add_development_dependency 'fakeweb',     '>= 1.3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valvat
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
 platform: ruby
 authors:
 - Sebastian Munz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-02 00:00:00.000000000 Z
+date: 2013-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -38,48 +38,6 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: 2.4.0
-- !ruby/object:Gem::Dependency
-  name: guard-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: 0.1.9
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: 0.1.9
-- !ruby/object:Gem::Dependency
-  name: growl
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: 1.0.3
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: 1.0.3
-- !ruby/object:Gem::Dependency
-  name: rb-fsevent
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: 0.9.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: 0.9.1
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement