valvat 0.4.7 → 0.5.0

data/spec/valvat/checksum/se_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+describe Valvat::Checksum::SE do
+  %w(SE136695975501 SE556464687401 SE502052817901 SE556555952201 SE556084097601).each do |valid_vat|
+    it "returns true on valid vat #{valid_vat}" do
+      Valvat::Checksum.validate(valid_vat).should eql(true)
+    end
+
+    invalid_vat = "#{valid_vat[0..-4]}#{valid_vat[-1]}#{valid_vat[-2]}#{valid_vat[-3]}"
+
+    it "returns false on invalid vat #{invalid_vat}" do
+      Valvat::Checksum.validate(invalid_vat).should eql(false)
+    end
+  end
+
+  it "returns false on special case invalid vat SE556464687400" do
+    Valvat::Checksum.validate("SE556464687400").should eql(false)
+  end
+end

data/spec/valvat/checksum/si_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe Valvat::Checksum::SI do
+  %w(SI59082437 SI51049406 SI86154575 SI47431857 SI22511822 SI22511880).each do |valid_vat|
+    it "returns true on valid vat #{valid_vat}" do
+      Valvat::Checksum.validate(valid_vat).should eql(true)
+    end
+
+    invalid_vat = "#{valid_vat[0..-5]}#{valid_vat[-1]}#{valid_vat[-4]}#{valid_vat[-3]}#{valid_vat[-2]}"
+
+    it "returns false on invalid vat #{invalid_vat}" do
+      Valvat::Checksum.validate(invalid_vat).should eql(false)
+    end
+  end
+
+  it "returns false on special case invalid vat SI11111107" do
+    Valvat::Checksum.validate("SI11111107").should eql(false)
+  end
+
+  it "returns false on special case invalid vat SI01111108" do
+    Valvat::Checksum.validate("SI01111108").should eql(false)
+  end
+end

data/spec/valvat/checksum_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+begin
+  require File.dirname(__FILE__) + '/../../tmp/valid_vat_numbers.rb'
+rescue LoadError
+  VALID_VAT_NUMBERS = []
+end
+
+describe Valvat::Checksum do
+  describe "#validate" do
+    it "returns true on vat number with unknown checksum algorithm" do
+      Valvat::Checksum.validate("FR99123543267").should eql(true)
+    end
+
+    it "returns false on corrupt number (e.g checks syntax)" do
+      Valvat::Checksum.validate("FI1234567891").should eql(false)
+    end
+
+    VALID_VAT_NUMBERS.each do |valid_vat|
+      it "returns true on valid vat number #{valid_vat}" do
+        Valvat::Checksum.validate(valid_vat).should eql(true)
+      end
+    end
+  end
+end

data/spec/valvat/lookup_spec.rb

@@ -71,7 +71,7 @@ describe Valvat::Lookup do
 
     context "error on request" do
       before do
-        @request = mock("request")
+        @request = double("request")
         Valvat::Lookup::Request.stub(:new => @request)
         @request.stub(:perform).and_raise(ArgumentError.new)
       end

data/spec/valvat_spec.rb

@@ -30,6 +30,7 @@ describe Valvat do
 
   context "on european vat number" do
     let(:de_vat) { Valvat.new("DE259597697") } # valid & exists
+    let(:invalid_checksum) { Valvat.new("DE259597687") } # valid & invalid checksum
     let(:at_vat) { Valvat.new("ATU458890031") } # invalid
     let(:gr_vat) { Valvat.new("EL999943280") } # valid & exists
 
@@ -44,6 +45,18 @@ describe Valvat do
       end
     end
 
+    describe "#valid_checksum?" do
+      it "returns true on valid numbers" do
+        de_vat.should be_valid_checksum
+        gr_vat.should be_valid_checksum
+      end
+
+      it "returns false on invalid numbers" do
+        at_vat.should_not be_valid_checksum
+        invalid_checksum.should_not be_valid_checksum
+      end
+    end
+
     describe "#exist(s)?" do
       context "on existing vat numbers" do
         before do

data/valvat.gemspec

@@ -6,6 +6,7 @@ Gem::Specification.new do |s|
   s.name        = "valvat"
   s.version     = Valvat::VERSION
   s.platform    = Gem::Platform::RUBY
+  s.license  = 'MIT'
   s.authors     = ["Sebastian Munz"]
   s.email       = ["sebastian@yo.lk"]
   s.homepage    = "https://github.com/yolk/valvat"
@@ -27,7 +28,7 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
 
-  s.add_dependency             'savon',       '=1.2.0'
+  s.add_dependency             'savon',       '>=2.2.0'
 
   s.add_development_dependency 'rspec',       '>= 2.4.0'
   s.add_development_dependency 'guard-rspec', '>=0.1.9'

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: valvat
 version: !ruby/object:Gem::Version
-  version: 0.4.7
-  prerelease: 
+  version: 0.5.0
 platform: ruby
 authors:
 - Sebastian Munz
@@ -14,119 +13,109 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - '='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: 2.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - '='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: 2.2.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 2.4.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 2.4.0
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.1.9
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.1.9
 - !ruby/object:Gem::Dependency
   name: growl
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.0.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.0.3
 - !ruby/object:Gem::Dependency
   name: rb-fsevent
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.9.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.9.1
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: fakeweb
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.3.0
-description: ! "  Validates european vat numbers. Standalone or as a ActiveModel validator.\n\n
-  \ * Simple syntax verification\n  * Lookup via the VIES web service\n  * Supports
-  details & requester identification\n  * (Optional) ActiveModel/Rails3 integration\n
-  \ * I18n locales for country specific error messages\n"
+description: |2
+    Validates european vat numbers. Standalone or as a ActiveModel validator.
+
+    * Simple syntax verification
+    * Lookup via the VIES web service
+    * Supports details & requester identification
+    * (Optional) ActiveModel/Rails3 integration
+    * I18n locales for country specific error messages
 email:
 - sebastian@yo.lk
 executables: []
@@ -144,6 +133,23 @@ files:
 - Rakefile
 - lib/valvat.rb
 - lib/valvat/active_model.rb
+- lib/valvat/checksum.rb
+- lib/valvat/checksum/at.rb
+- lib/valvat/checksum/be.rb
+- lib/valvat/checksum/bg.rb
+- lib/valvat/checksum/de.rb
+- lib/valvat/checksum/dk.rb
+- lib/valvat/checksum/es.rb
+- lib/valvat/checksum/fi.rb
+- lib/valvat/checksum/gr.rb
+- lib/valvat/checksum/ie.rb
+- lib/valvat/checksum/it.rb
+- lib/valvat/checksum/lu.rb
+- lib/valvat/checksum/nl.rb
+- lib/valvat/checksum/pl.rb
+- lib/valvat/checksum/pt.rb
+- lib/valvat/checksum/se.rb
+- lib/valvat/checksum/si.rb
 - lib/valvat/locales/bg.yml
 - lib/valvat/locales/de.yml
 - lib/valvat/locales/en.yml
@@ -161,40 +167,73 @@ files:
 - lib/valvat/version.rb
 - spec/spec_helper.rb
 - spec/valvat/active_model_spec.rb
+- spec/valvat/checksum/at_spec.rb
+- spec/valvat/checksum/be_spec.rb
+- spec/valvat/checksum/bg_spec.rb
+- spec/valvat/checksum/de_spec.rb
+- spec/valvat/checksum/dk_spec.rb
+- spec/valvat/checksum/es_spec.rb
+- spec/valvat/checksum/fi_spec.rb
+- spec/valvat/checksum/gr_spec.rb
+- spec/valvat/checksum/ie_spec.rb
+- spec/valvat/checksum/it_spec.rb
+- spec/valvat/checksum/lu_spec.rb
+- spec/valvat/checksum/nl_spec.rb
+- spec/valvat/checksum/pl_spec.rb
+- spec/valvat/checksum/pt_spec.rb
+- spec/valvat/checksum/se_spec.rb
+- spec/valvat/checksum/si_spec.rb
+- spec/valvat/checksum_spec.rb
 - spec/valvat/lookup_spec.rb
 - spec/valvat/syntax_spec.rb
 - spec/valvat/utils_spec.rb
 - spec/valvat_spec.rb
 - valvat.gemspec
 homepage: https://github.com/yolk/valvat
-licenses: []
+licenses:
+- MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Validates european vat numbers. Standalone or as a ActiveModel validator.
 test_files:
 - spec/spec_helper.rb
 - spec/valvat/active_model_spec.rb
+- spec/valvat/checksum/at_spec.rb
+- spec/valvat/checksum/be_spec.rb
+- spec/valvat/checksum/bg_spec.rb
+- spec/valvat/checksum/de_spec.rb
+- spec/valvat/checksum/dk_spec.rb
+- spec/valvat/checksum/es_spec.rb
+- spec/valvat/checksum/fi_spec.rb
+- spec/valvat/checksum/gr_spec.rb
+- spec/valvat/checksum/ie_spec.rb
+- spec/valvat/checksum/it_spec.rb
+- spec/valvat/checksum/lu_spec.rb
+- spec/valvat/checksum/nl_spec.rb
+- spec/valvat/checksum/pl_spec.rb
+- spec/valvat/checksum/pt_spec.rb
+- spec/valvat/checksum/se_spec.rb
+- spec/valvat/checksum/si_spec.rb
+- spec/valvat/checksum_spec.rb
 - spec/valvat/lookup_spec.rb
 - spec/valvat/syntax_spec.rb
 - spec/valvat/utils_spec.rb
 - spec/valvat_spec.rb
-has_rdoc: