valvat 0.0.1 → 0.0.2

data/CHANGES.markdown

@@ -0,0 +1,5 @@
+### 0.0.2 / 2011-01-06
+
+[full changelog](http://github.com/yolk/valvat/compare/v0.0.1...v0.0.2)
+
+* Use REST-wrapper for accessing VIES web service; this removes dependency on savon and some lines of code. See http://isvat.appspot.com/

data/Gemfile.lock

@@ -2,14 +2,11 @@ PATH
   remote: .
   specs:
     valvat (0.0.1)
-      savon (>= 0.8.2)
 
 GEM
   remote: http://rubygems.org/
   specs:
-    builder (3.0.0)
     configuration (1.2.0)
-    crack (0.1.8)
     diff-lcs (1.1.2)
     growl (1.0.3)
     guard (0.2.2)
@@ -17,16 +14,11 @@ GEM
       thor (~> 0.14.3)
     guard-rspec (0.1.9)
       guard (>= 0.2.2)
-    gyoku (0.1.1)
-      builder (>= 2.1.2)
-    httpi (0.7.7)
-      rack
     launchy (0.3.7)
       configuration (>= 0.0.5)
       rake (>= 0.8.1)
     open_gem (1.4.2)
       launchy (~> 0.3.5)
-    rack (1.2.1)
     rake (0.8.7)
     rb-fsevent (0.3.9)
     rspec (2.4.0)
@@ -37,11 +29,6 @@ GEM
     rspec-expectations (2.4.0)
       diff-lcs (~> 1.1.2)
     rspec-mocks (2.4.0)
-    savon (0.8.2)
-      builder (>= 2.1.2)
-      crack (~> 0.1.8)
-      gyoku (>= 0.1.1)
-      httpi (>= 0.7.5)
     thor (0.14.6)
 
 PLATFORMS
@@ -52,5 +39,4 @@ DEPENDENCIES
   guard-rspec (>= 0.1.9)
   rb-fsevent (>= 0.3.9)
   rspec (>= 2.4.0)
-  savon (>= 0.8.2)
   valvat!

data/{README.markdown → README.rdoc}

@@ -8,7 +8,7 @@ Validates european vat numbers. Supports simple syntax verification and lookup v
 
 == Basic Usage
 
-To verify the syntax of an vat number:
+To verify the syntax of a vat number:
 
   Valvat::Syntax.validate("DE345789003")
   => true or false
@@ -22,6 +22,22 @@ Keep in mind that the VIES webservice might be offline at some time for some cou
 
 See http://ec.europa.eu/taxation_customs/vies/viesspec.do for more accurate information at what time the service for a specific country will be down.
 
+== Utilities
+
+To split a vat number into the ISO country code and the remaining chars:
+
+  Valvat::Utils.split("ATU345789003")
+  => ["AT", "U345789003"]
+  
+_split_ always returns an array. If it can not detect the country it returns [nil, nil].
+
+To normalize a vat number:
+
+  Valvat::Utils.normalize("atu345789003")
+  => "ATU345789003"
+  
+This basically just removes trailing spaces and ensures all chars are upcase.
+
 == Links
 
 * http://ec.europa.eu/taxation_customs/vies

data/lib/valvat/lookup.rb

@@ -1,33 +1,18 @@
 require 'valvat/utils'
+require 'net/http'
+require 'yaml'
 
 module Valvat
   module Lookup
-    
     def self.validate(vat)
-      country_code, vat_number = Valvat::Utils.split(vat)
-      response = client.request "n1", "checkVat" do
-        soap.body = {"n1:countryCode" => country_code, "n1:vatNumber" => vat_number}
-        soap.namespaces["xmlns:n1"] = "urn:ec.europa.eu:taxud:vies:services:checkVat:types"
-      end
-      response.to_hash[:check_vat_response][:valid]
-    rescue => err
-      false if err.to_hash[:fault] && err.to_hash[:faultstring] = 'INVALID_INPUT'
+      parts = Valvat::Utils.split(vat)
+      return false unless parts[0]
+      
+      YAML.load(Net::HTTP.start("isvat.appspot.com", 80) {|http|
+        http.get("/#{parts.join("/")}/")
+      }.body)
+    rescue
       nil
     end
-    
-    def self.client
-      @client ||= begin
-        # Require Savon only if really needed!
-        require 'savon' unless defined?(Savon)
-        
-        # Quiet down Savon and HTTPI
-        Savon.logger.level = Logger::WARN
-        HTTPI.logger.level = Logger::WARN
-        
-        Savon::Client.new do
-          wsdl.document = 'http://ec.europa.eu/taxation_customs/vies/checkVatService.wsdl'
-        end
-      end
-    end
   end
 end

data/lib/valvat/version.rb

@@ -1,3 +1,3 @@
 module Valvat
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/valvat/lookup_spec.rb

@@ -10,8 +10,9 @@ describe Valvat::Lookup do
       Valvat::Lookup.validate("BE0817331994").should eql(false)
     end
     
-    it "returns nil on invalid input" do
-      Valvat::Lookup.validate("AE259597697").should eql(nil)
+    it "returns false on invalid country code / input" do
+      Valvat::Lookup.validate("AE259597697").should eql(false)
+      Valvat::Lookup.validate("").should eql(false)
     end
   end
 end

data/valvat.gemspec

@@ -17,10 +17,11 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
   
-  s.add_dependency 'savon', '>=0.8.2'
-  
   s.add_development_dependency 'rspec', '>= 2.4.0'
   s.add_development_dependency 'guard-rspec', '>=0.1.9'
   s.add_development_dependency 'growl', '>=1.0.3'
   s.add_development_dependency 'rb-fsevent', '>=0.3.9'
+  
+  s.has_rdoc         = true
+  s.extra_rdoc_files = ['README.rdoc']
 end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 0
-  - 1
-  version: 0.0.1
+  - 2
+  version: 0.0.2
 platform: ruby
 authors: 
 - Sebastian Munz
@@ -17,25 +17,10 @@ cert_chain: []
 date: 2011-01-06 00:00:00 +01:00
 default_executable: 
 dependencies: 
-- !ruby/object:Gem::Dependency 
-  name: savon
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 0
-        - 8
-        - 2
-        version: 0.8.2
-  type: :runtime
-  version_requirements: *id001
 - !ruby/object:Gem::Dependency 
   name: rspec
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -46,11 +31,11 @@ dependencies:
         - 0
         version: 2.4.0
   type: :development
-  version_requirements: *id002
+  version_requirements: *id001
 - !ruby/object:Gem::Dependency 
   name: guard-rspec
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -61,11 +46,11 @@ dependencies:
         - 9
         version: 0.1.9
   type: :development
-  version_requirements: *id003
+  version_requirements: *id002
 - !ruby/object:Gem::Dependency 
   name: growl
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -76,11 +61,11 @@ dependencies:
         - 3
         version: 1.0.3
   type: :development
-  version_requirements: *id004
+  version_requirements: *id003
 - !ruby/object:Gem::Dependency 
   name: rb-fsevent
   prerelease: false
-  requirement: &id005 !ruby/object:Gem::Requirement 
+  requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -91,7 +76,7 @@ dependencies:
         - 9
         version: 0.3.9
   type: :development
-  version_requirements: *id005
+  version_requirements: *id004
 description: Validates european vat numbers. Supports simple syntax verification and lookup via the VIES web service.
 email: 
 - sebastian@yo.lk
@@ -99,16 +84,17 @@ executables: []
 
 extensions: []
 
-extra_rdoc_files: []
-
+extra_rdoc_files: 
+- README.rdoc
 files: 
 - .gitignore
 - .rvmrc
+- CHANGES.markdown
 - Gemfile
 - Gemfile.lock
 - Guardfile
 - MIT-LICENSE
-- README.markdown
+- README.rdoc
 - Rakefile
 - lib/valvat.rb
 - lib/valvat/lookup.rb