values 1.2.0 → 1.2.1

data/README.md

@@ -1,12 +1,14 @@
 Values is a tiny library for creating value objects in ruby.
 These mostly look like classes created using Struct, but fix two problems with those:
 
-- Struct constructors can take less than the default number of arguments and set other fields as nil:
+Struct constructors can take less than the default number of arguments and set other fields as nil:
+
     Point = Struct.new(:x,:y)
     Point.new(1)
     => #<struct Point x=1, y=nil>
 
-- Structs are also mutable:
+Structs are also mutable:
+
     Point = Struct.new(:x,:y)
     p = Point.new(1,2)
     p.x = 2

data/VERSION

@@ -1 +1 @@
-1.2.0
+1.2.1

data/lib/values.rb

@@ -20,17 +20,15 @@ class Value
 
       def eql?(other)
         return false if other.class != self.class
-        result = true
-        self.class::VALUE_ATTRS.each do |field|
-          result = result && self.send(field) == other.send(field)
+        self.class::VALUE_ATTRS.all? do |field|
+          self.send(field) == other.send(field)
         end
-        return result
       end
 
       def hash
         result = 0
         self.class::VALUE_ATTRS.each do |field|
-          result += field.hash
+          result += self.send(field).hash
         end
         return result + self.class.hash
       end

data/spec/values_spec.rb

@@ -61,11 +61,21 @@ describe 'values' do
       Point.new(0,0).should_not == Y.new(0,0)
     end
 
+    it 'is not equal to another value with different fields' do
+      Point.new(0,0).should_not == Point.new(0,1)
+      Point.new(0,0).should_not == Point.new(1,0)
+    end
+
     it 'has an equal hash if the fields are equal' do
       p = Point.new(0,0)
       p.hash.should == Point.new(0,0).hash
     end
 
+    it 'has a non-equal hash if the fields are different' do
+      p = Point.new(0,0)
+      p.hash.should_not == Point.new(1,0).hash
+    end
+
     it 'does not have an equal hash if the class is different' do
       Point.new(0,0).hash.should_not == Y.new(0,0).hash
     end

data/values.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{values}
-  s.version = "1.2.0"
+  s.version = "1.2.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Tom Crayford"]
-  s.date = %q{2011-03-19}
+  s.date = %q{2011-04-06}
   s.description = %q{Simple immutable value objects for ruby.
 
     Make a new value class: Point = Value.new(:x, :y)

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 1
   - 2
-  - 0
-  version: 1.2.0
+  - 1
+  version: 1.2.1
 platform: ruby
 authors: 
 - Tom Crayford
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-19 00:00:00 +00:00
+date: 2011-04-06 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -111,7 +111,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: -2915973544868875541
+      hash: 3256064136083469828
       segments: 
       - 0
       version: "0"