valued 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c09b1d932113939667c5e36981e3256b25483679ebc222131d377985152a70a9
-  data.tar.gz: 823e69bdf5587363b1cae66ce2bd68ed8f38aedcdca3bddac5e59b953c27414f
+  metadata.gz: 01e8a133b1b6b38c5ad222c7d03a3ea68ca57925700a81c305dc9d66b8cd83a9
+  data.tar.gz: a03c152ff273d2ba821a1f96d3bc456b011b78908ccddd2f54ad0e1f8b041765
 SHA512:
-  metadata.gz: 7c050eb350406595297da5f44fddd9f8b87e7675ad72596eaf89b8de9075e4da48f873da3750d01f7bd47f986c56efe5dd295900a17f94c1d81aee22459d482f
-  data.tar.gz: bd235452be8f966895982d83b31650bd468af5922e27d97680f04f95e8557cfd87f5c82ca982dc36880b0f2b2b767d9c56fb573ec6e42ed6396c16f433e183e1
+  metadata.gz: 456eb9787c0b033387957c1cd516ccf1e17a177eb6e4b9878351a38424d96ac309e1eadfc79b4db943d0ed213edbfcb07b9089ed0a03aadc03d25a7bc467c7f0
+  data.tar.gz: 5cea8f73ca85b74825ef922a21a684968195a88ac5466b9d33e8be2b27391c3a454494ce5364cd60c84c2ec44ac0b4e6c0de684f16d1d8a7522f58f66043d2ce

data/.github/workflows/ci.yml

@@ -0,0 +1,35 @@
+name: Continuous Integration
+
+on:
+  push:
+    branches: [master]
+  pull_request:
+    branches: [master]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ["3.0"]
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Setup Node.js 🖲
+        uses: actions/setup-node@v2.4.0
+        with:
+          node-version: 16.x
+          check-latest: true
+      - run: npm ci
+
+      - name: Check formatting 🔍
+        run: npm run lint
+
+      - name: Setup Ruby 💎
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true
+
+      - name: Run tests ⚙️
+        run: bundle exec rake

data/.gitignore

@@ -9,3 +9,5 @@
 
 # rspec failure tracking
 .rspec_status
+
+node_modules

data/.tool-versions

@@ -0,0 +1,2 @@
+ruby 3.0.2
+nodejs 16.6.1

data/CHANGELOG.md

@@ -1,6 +1,13 @@
 # Changelog
 
+## 0.4.1
+
+- fix bug that prevented setting an attribute to `nil` with `update`
+
+## 0.4.0
+
+- remove possibility to use attributes with question marks
+
 ## 0.3.0
 
-- added a `update` method to all `Valued` and `Valued::Mutable` objects that
-  allows creating a duplicate of an object with changed attributes
+- added a `update` method to all `Valued` and `Valued::Mutable` objects that allows creating a duplicate of an object with changed attributes

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    valued (0.4.0)
+    valued (0.4.1)
 
 GEM
   remote: https://rubygems.org/
@@ -14,7 +14,7 @@ GEM
       ast (~> 2.4.0)
     rainbow (3.0.0)
     rake (13.0.1)
-    rexml (3.2.4)
+    rexml (3.2.5)
     rspec (3.9.0)
       rspec-core (~> 3.9.0)
       rspec-expectations (~> 3.9.0)
@@ -53,4 +53,4 @@ DEPENDENCIES
   valued!
 
 BUNDLED WITH
-   2.1.4
+   2.2.22

data/lib/valued.rb

@@ -3,12 +3,8 @@ require 'valued/version'
 
 module Valued
   module ClassMethods
-    def self.define_method(attr, klass)
-      klass.class_eval { attr_reader attr }
-    end
-
     def attributes(*attributes)
-      attributes.each { |attr| Valued::ClassMethods.define_method(attr, self) }
+      attributes.each { |attribute| self.class_eval { attr_reader attribute } }
       define_method('_attributes') { attributes }
       private :_attributes
     end
@@ -43,7 +39,11 @@ module Valued
   def update(new_attributes)
     self.class.new(
       _attributes.each_with_object({}) do |attribute, result|
-        result[attribute] = new_attributes[attribute] || self.send(attribute)
+        if new_attributes.key?(attribute)
+          result[attribute] = new_attributes[attribute]
+        else
+          result[attribute] = self.send(attribute)
+        end
       end
     )
   end
@@ -74,9 +74,9 @@ module Valued
 
   def inspect
     inspected_attributes =
-      _attributes.map do |attribute|
-        "#{attribute}=#{send(attribute).inspect}"
-      end.join(' ')
+      _attributes
+        .map { |attribute| "#{attribute}=#{send(attribute).inspect}" }
+        .join(' ')
     "#<#{self.class} #{inspected_attributes}>"
   end
 end

data/lib/valued/mutable.rb

@@ -1,13 +1,9 @@
 module Valued
   module Mutable
     module ClassMethods
-      def self.define_method(attr, klass)
-        klass.class_eval { attr_accessor attr }
-      end
-
       def attributes(*attributes)
-        attributes.each do |attr|
-          Valued::Mutable::ClassMethods.define_method(attr, self)
+        attributes.each do |attribute|
+          self.class_eval { attr_accessor attribute }
         end
         define_method('_attributes') { attributes }
         private :_attributes
@@ -40,7 +36,11 @@ module Valued
     def update(new_attributes)
       self.class.new(
         _attributes.each_with_object({}) do |attribute, result|
-          result[attribute] = new_attributes[attribute] || self.send(attribute)
+          if new_attributes.key?(attribute)
+            result[attribute] = new_attributes[attribute]
+          else
+            result[attribute] = self.send(attribute)
+          end
         end
       )
     end
@@ -71,9 +71,9 @@ module Valued
 
     def inspect
       inspected_attributes =
-        _attributes.map do |attribute|
-          "#{attribute}=#{send(attribute).inspect}"
-        end.join(' ')
+        _attributes
+          .map { |attribute| "#{attribute}=#{send(attribute).inspect}" }
+          .join(' ')
       "#<#{self.class} #{inspected_attributes}>"
     end
   end

data/lib/valued/version.rb

@@ -1,3 +1,3 @@
 module Valued
-  VERSION = '0.4.0'
+  VERSION = '0.4.1'
 end

data/package-lock.json

@@ -0,0 +1,51 @@
+{
+  "name": "valued",
+  "lockfileVersion": 2,
+  "requires": true,
+  "packages": {
+    "": {
+      "devDependencies": {
+        "@prettier/plugin-ruby": "^1.6.1",
+        "prettier": "^2.3.2"
+      }
+    },
+    "node_modules/@prettier/plugin-ruby": {
+      "version": "1.6.1",
+      "resolved": "https://registry.npmjs.org/@prettier/plugin-ruby/-/plugin-ruby-1.6.1.tgz",
+      "integrity": "sha512-PGDCATgVTQz0s/NB9nStiXVCIr+hG/XnKeAO/kguaHrNf8VwCpP5Ul+/KQao0z0QFBy2PDY8kWptfDQCa7WMXg==",
+      "dev": true,
+      "dependencies": {
+        "prettier": ">=1.10"
+      }
+    },
+    "node_modules/prettier": {
+      "version": "2.3.2",
+      "resolved": "https://registry.npmjs.org/prettier/-/prettier-2.3.2.tgz",
+      "integrity": "sha512-lnJzDfJ66zkMy58OL5/NY5zp70S7Nz6KqcKkXYzn2tMVrNxvbqaBpg7H3qHaLxCJ5lNMsGuM8+ohS7cZrthdLQ==",
+      "dev": true,
+      "bin": {
+        "prettier": "bin-prettier.js"
+      },
+      "engines": {
+        "node": ">=10.13.0"
+      }
+    }
+  },
+  "dependencies": {
+    "@prettier/plugin-ruby": {
+      "version": "1.6.1",
+      "resolved": "https://registry.npmjs.org/@prettier/plugin-ruby/-/plugin-ruby-1.6.1.tgz",
+      "integrity": "sha512-PGDCATgVTQz0s/NB9nStiXVCIr+hG/XnKeAO/kguaHrNf8VwCpP5Ul+/KQao0z0QFBy2PDY8kWptfDQCa7WMXg==",
+      "dev": true,
+      "requires": {
+        "prettier": ">=1.10"
+      }
+    },
+    "prettier": {
+      "version": "2.3.2",
+      "resolved": "https://registry.npmjs.org/prettier/-/prettier-2.3.2.tgz",
+      "integrity": "sha512-lnJzDfJ66zkMy58OL5/NY5zp70S7Nz6KqcKkXYzn2tMVrNxvbqaBpg7H3qHaLxCJ5lNMsGuM8+ohS7cZrthdLQ==",
+      "dev": true
+    }
+  }
+}

data/package.json

@@ -0,0 +1,12 @@
+{
+  "name": "valued",
+  "scripts": {
+    "prettify": "prettier \"**/*.{ru,rb,yml,yaml,md}\" --ignore-path=\".gitignore\"",
+    "lint": "npm run prettify -- --check",
+    "format": "npm run prettify -- --write"
+  },
+  "devDependencies": {
+    "@prettier/plugin-ruby": "^1.6.1",
+    "prettier": "^2.3.2"
+  }
+}

data/valued.gemspec

@@ -17,10 +17,11 @@ Gem::Specification.new do |spec|
 
   spec.files =
     Dir.chdir(File.expand_path('..', __FILE__)) do
-      `git ls-files -z`.split("\x0").reject do |f|
-        f.match(%r{^(test|spec|features)/})
-      end
+    `git ls-files -z`.split("\x0").reject do |f|
+      f.match(%r{^(test|spec|features)/})
     end
+  end
+
   spec.bindir = 'exe'
   spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = %w[lib]

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valued
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Mario Mainz
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-06-19 00:00:00.000000000 Z
+date: 2021-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -87,10 +87,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".travis.yml"
+- ".tool-versions"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
@@ -100,6 +101,8 @@ files:
 - lib/valued.rb
 - lib/valued/mutable.rb
 - lib/valued/version.rb
+- package-lock.json
+- package.json
 - valued.gemspec
 homepage: https://github.com/mmainz/valued
 licenses:
@@ -122,7 +125,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.2.22
 signing_key:
 specification_version: 4
 summary: A Ruby gem that makes it easy to create value objects.

data/.travis.yml

@@ -1,7 +0,0 @@
----
-sudo: false
-language: ruby
-cache: bundler
-rvm:
-  - 2.7.0
-before_install: gem install bundler -v 2.0.2