valuable 0.8.2 → 0.8.4

data/lib/valuable.rb

@@ -42,13 +42,41 @@ class Valuable
   # accepts an optional hash that will be used to populate the 
   # predefined attributes for this class.
   def initialize(atts = nil)
-    atts.each { |name, value| __send__("#{name}=", value ) }  if atts
+    self.update_attributes(atts || {})
+  end
+
+  # mass assign attributes. This method will not clear any existing attributes.
+  #
+  # class Shoe
+  #   has_value :size
+  #   has_value :owner
+  #   has_value :color, :default => 'red'
+  # end
+  #
+  # >> shoe = Shoe.new
+  # >> shoe.update_attributes(:size => 16, :owner => 'MJ')
+  # >> shoe.attributes
+  # => {:size => 16, :owner => 'MJ', :color => 'red'}
+  def update_attributes(atts)
+    atts.each{|name, value| __send__("#{name}=", value )}
   end
 
   def deep_duplicate_of(value)
     Marshal.load(Marshal.dump(value))
   end
 
+  def permissive?
+    self.class.permissive_constructor?
+  end
+
+  def method_missing(method_name, *args)
+    if method_name.to_s =~ /(\w+)=/
+      raise( ArgumentError, "#{self.class.to_s} does not have an attribute or alias '#{$1}'", caller) unless self.permissive?
+    else
+      super 
+    end
+  end
+
   class << self
 
     # Returns an array of the attributes available on this object.
@@ -76,9 +104,7 @@ class Valuable
     #   :klass - light weight type casting. Use :integer, :string or
     #   :boolean. Alternately, supply a class. 
     #
-    #   :alias - creates a second setter with the specified name. This
-    #   allows you to accept information from some other party using their 
-    #   vocabulary. Alias does not currently create a getter.
+    #   :alias - creates an alias for getter and setter with the new name.
     #
     # When a :klassified attribute is set to some new value, if the value
     # is not nil and is not already of that class, the value will be cast
@@ -107,8 +133,10 @@ class Valuable
       create_question_for(name) if options[:klass] == :boolean
       create_negative_question_for(name, options[:negative]) if options[:klass] == :boolean && options[:negative]
       
-      create_setter_for(name, name, options[:klass])
-      create_setter_for(name, options[:alias], options[:klass]) if options[:alias]
+      create_setter_for(name, options[:klass])
+
+      alias_method options[:alias], name if options[:alias]
+      alias_method "#{options[:alias]}=", "#{name}=" if options[:alias]
 
       check_options_validity(name, options)
     end
@@ -117,38 +145,39 @@ class Valuable
     # is called both by the constructor. The constructor handles type
     # casting. Setting values via the attributes hash avoids the method
     # defined here.
-    def create_setter_for(attribute, method_name, klass)
+    def create_setter_for(attribute, klass)
+      setter_method = "#{attribute}="
 
       case klass
       when NilClass
 	      
-        define_method "#{method_name}=" do |value|
+        define_method setter_method do |value|
           attributes[attribute] = value 
         end
 
       when :integer
 
-        define_method "#{method_name}=" do |value|
+        define_method setter_method do |value|
           value_as_integer = value && value.to_i
           attributes[attribute] = value_as_integer
         end
 
       when :string
 	
-	define_method "#{method_name}=" do |value|
+	define_method setter_method do |value|
           value_as_string = value && value.to_s
           attributes[attribute] = value_as_string
 	end
 
       when :boolean
 
-        define_method "#{method_name}=" do |value|
+        define_method setter_method do |value|
           attributes[attribute] = value == '0' ? false : !!value
 	end
     
       else
 
-        define_method "#{method_name}=" do |value|
+        define_method setter_method do |value|
           if value.nil?
             attributes[attribute] = nil 
 	  elsif value.is_a? klass
@@ -215,6 +244,37 @@ class Valuable
       has_value(name, :default => [] )
     end 
 
+    # Instructs the class NOT to complain if any attributes are set
+    # that haven't been declared.
+    #
+    # class Sphere < Valuable
+    #   has_value :material
+    # end
+    #
+    # >> Sphere.new(:radius => 3, :material => 'water')
+    # EXCEPTION! OH NOS!
+    #
+    # class Box < Valuable
+    #   acts_as_permissive
+    #
+    #   has_value :material
+    # end
+    #
+    # >> box = Box.new(:material => 'wood', :size => '36 x 40')
+    # >> box.attributes
+    # => {:material => 'wood'}
+    def acts_as_permissive
+      self.permissive_constructor=true
+    end
+
+    def permissive_constructor=(value)
+      @_permissive_constructor = value
+    end
+
+    def permissive_constructor?
+      !!(@_permissive_constructor ||= false)
+    end
+
     private
 
     def inherited(child)

data/test/alias_test.rb

@@ -19,4 +19,9 @@ class AliasTest < Test::Unit::TestCase
     software = Software.new('EnterpriseNamespace' => 'Enterprisey')
     assert_equal 'Enterprisey', software.enterprise_namespace
   end
+
+  def test_that_aliases_work_for_getters
+    software = Software.new(:title => 'ObtrusiveJavascriptComponent')
+    assert_equal 'ObtrusiveJavascriptComponent', software.name
+  end
 end

data/test/bad_attributes_test.rb

@@ -2,7 +2,6 @@ $: << File.expand_path(File.dirname(__FILE__) + '/../lib')
 
 require 'test/unit'
 require 'valuable.rb'
-require 'mocha'
 
 class Infrastructure < Valuable
 end
@@ -20,4 +19,21 @@ class BadAttributesTest < Test::Unit::TestCase
       Infrastructure.has_value :bar, :klass => Integer
     end
   end
+
+  def test_that_invalid_attributes_raise
+    assert_raises ArgumentError do
+      model = Class.new(Valuable)
+      model.new(:invalid => 'should not be allowed')
+    end
+  end
+
+  def test_that_invalid_attributes_can_be_ignored
+    assert_nothing_raised do
+      model = Class.new(Valuable) do
+        acts_as_permissive 
+      end
+      model.new(:invalid => 'should be ignored')
+    end
+  end
 end
+

metadata

@@ -1,7 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: valuable
 version: !ruby/object:Gem::Version 
-  version: 0.8.2
+  hash: 55
+  prerelease: false
+  segments: 
+  - 0
+  - 8
+  - 4
+  version: 0.8.4
 platform: ruby
 authors: 
 - Johnathon Wright
@@ -9,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-04-06 00:00:00 -05:00
+date: 2010-10-06 00:00:00 -05:00
 default_executable: 
 dependencies: []
 
@@ -25,6 +31,11 @@ files:
 - lib/valuable.rb
 - README.markdown
 - rakefile.rb
+- test/bad_attributes_test.rb
+- test/alias_test.rb
+- test/inheritance_test.rb
+- test/deprecated_test.rb
+- test/valuable_test.rb
 has_rdoc: true
 homepage: http://valuable.mustmodify.com
 licenses: []
@@ -35,27 +46,33 @@ rdoc_options: []
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
       version: "0"
-  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
       version: "0"
-  version: 
 requirements: []
 
 rubyforge_project: valuable
-rubygems_version: 1.3.5
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: attr_accessor on steroids with defaults, constructor, and light casting.
 test_files: 
-- test/inheritance_test.rb
-- test/valuable_test.rb
 - test/bad_attributes_test.rb
-- test/deprecated_test.rb
 - test/alias_test.rb
+- test/inheritance_test.rb
+- test/deprecated_test.rb
+- test/valuable_test.rb