valkyrie 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f944c9582622daf4bc0eddee8290ae57a7bf43f01d38c261814a8668cce8f4bb
-  data.tar.gz: 3ab12ff9a09532f59f6cc635c01d40283eb3a63ed6d0bca2f1a78d118524c0a9
+  metadata.gz: e1b458c0bf12323ee7593ba335f9b11d933bbf3bc8e2dd1174f2a682e0be10c7
+  data.tar.gz: 59ec4d50795fa715b260fd77b773a4113d90731ae12719d8ed35d494f600f056
 SHA512:
-  metadata.gz: 15bfe465aa9152f3a9fb9b6eaf5d40ce86e1e024c937bc9062a5ab421d23f5f8b05b29f1ab22a869ceb5f800f6f217cbdea443b5b34fee7330720ae702c052db
-  data.tar.gz: a2d61190c00329845a913a7f571a19549a0b0d39f9ab2654212789d16f2db212aff67f5e8a10bdf1cf1843c5e5d9bad4c604359954b5821ba06610eceed49866
+  metadata.gz: 9625fb7adb62fd504dde9e216a4b86b10c3054258f3363eb717da22e5bd1a81c8dc72608022739311a5b914528d9ac045dd66063148ec58da1de63e5cda08575
+  data.tar.gz: 4692ea78e86c4a8a74ddbea67c2b74660f7c7a2f4d69efd0c6755f6f2ba9258620eeaa7d03f1455b24a81e4c61dff5533f47072db6f9945eff92d1779696df6e

data/CHANGELOG.md

@@ -1,3 +1,18 @@
+# v2.0.1 2019-07-03
+
+## Changes since last release
+
+* Remove strftime from `Fedora::Persister::ModelConverter`
+  [tpendragon](https://github.com/tpendragon)
+* Only parse ISO8601 strings into DateTimes
+  [awead](https://github.com/awead)
+
+
+Additional thanks to the following for code review and issue reports leading to
+this release:
+
+[dgcliff](https://github.com/dgcliff)
+
 # v2.0.0 2019-06-06
 
 ## Changes since last release

data/lib/valkyrie/persistence/fedora/persister/model_converter.rb

@@ -488,10 +488,9 @@ module Valkyrie::Persistence::Fedora
         # @return [Valkyrie::Persistence::Fedora::Persister::ModelConverter::Property]
         def result
           # cast it to datetime for storage, to preserve milliseconds and date
-          # @todo Remove strftime when https://github.com/ruby-rdf/rdf/issues/394 is closed.
           map_value(converted_value:
               RDF::Literal.new(
-                value.value.to_datetime.strftime("%Y-%m-%dT%H:%M:%S.%N%z"),
+                value.value.to_datetime,
                 datatype: PermissiveSchema.valkyrie_time
               ))
         end

data/lib/valkyrie/persistence/shared/json_value_mapper.rb

@@ -137,15 +137,17 @@ module Valkyrie::Persistence::Shared
       # e. g. 1970-01-01
       # @param [Object] value
       # @return [Boolean]
+      # rubocop:disable Metrics/CyclomaticComplexity
       def self.handles?(value)
         return false unless value.is_a?(String)
-        return false unless value[4] == "-"
+        return false unless value[4] == "-" && value[10] == "T"
         year = value.to_s[0..3]
         return false unless year.length == 4 && year.to_i.to_s == year
         DateTime.iso8601(value)
       rescue
         false
       end
+      # rubocop:enable Metrics/CyclomaticComplexity
 
       # Generates a Time object in the UTC from the datestamp string value
       # @return [Time]

data/lib/valkyrie/specs/shared_specs/persister.rb

@@ -7,6 +7,7 @@ RSpec.shared_examples 'a Valkyrie::Persister' do |*flags|
       include Valkyrie::Resource::AccessControls
       attribute :title
       attribute :author
+      attribute :other_author
       attribute :member_ids
       attribute :nested_resource
       attribute :single_value, Valkyrie::Types::String.optional
@@ -179,7 +180,8 @@ RSpec.shared_examples 'a Valkyrie::Persister' do |*flags|
   it "can store DateTimes" do
     time1 = DateTime.current
     time2 = Time.current.in_time_zone
-    book = persister.save(resource: resource_class.new(title: [time1], author: [time2]))
+    time3 = "2019-01"
+    book = persister.save(resource: resource_class.new(title: [time1], author: [time2], other_author: [time3]))
 
     reloaded = query_service.find_by(id: book.id)
 
@@ -187,6 +189,7 @@ RSpec.shared_examples 'a Valkyrie::Persister' do |*flags|
     expect(reloaded.title.first.zone).to eq('UTC')
     expect(reloaded.author.first.to_i).to eq(time2.to_i)
     expect(reloaded.author.first.zone).to eq('UTC')
+    expect(reloaded.other_author.first).to eq "2019-01"
   end
 
   it "can store Floats" do

data/lib/valkyrie/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Valkyrie
-  VERSION = "2.0.0"
+  VERSION = "2.0.1"
 end

data/valkyrie.gemspec

@@ -24,7 +24,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'draper'
   spec.add_dependency 'activemodel'
   spec.add_dependency 'dry-types', '~> 1.0'
-  spec.add_dependency 'rdf'
+  spec.add_dependency 'rdf', '~> 3.0.10'
   spec.add_dependency 'activesupport'
   spec.add_dependency 'railties' # To use generators and engines
   spec.add_dependency 'reform'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valkyrie
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Trey Pendragon
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-06-20 00:00:00.000000000 Z
+date: 2019-07-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-struct
@@ -70,16 +70,16 @@ dependencies:
   name: rdf
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.0.10
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.0.10
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement