valkyrie 1.5.0.RC1 → 1.5.0.RC2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: f51055953266a92fd0ffcdd70c1204545668897e
-  data.tar.gz: 32effaf156970e235ef047d3198874b3a538533c
+SHA256:
+  metadata.gz: a34c6f01c77ee732d90f66322562160085e37800237dc332b11f7e2746988061
+  data.tar.gz: 5ac4dd5720a759fd1f9ce09591ad8010e9696ea4fda96dc20d6121cd72c37b8b
 SHA512:
-  metadata.gz: d411d99edb4ed3693b03cf40aeee8bcde69f510eaddfd0c28c2ca271480b541325a72d370c1b4f9c12422d8858a3d0e2e49abdb70623d664a21c8ca10cbcd826
-  data.tar.gz: 452bead204181f78df71e2f67f33b0d87f67510bc6c23e7a5eada9e7561f15de1a409370abcef24605e16d564066f902dafea50dc467ad9054729eb9edb2ab85
+  metadata.gz: 23775f00829a543946ef3bcdd506ae9445bbf790b4e3dbc1da2e4a879ce013ef21d91b6c974f7a8a5f5db29f252148431ea19324339815a79180ea43b72ed4dc
+  data.tar.gz: 3cc9e68db536cb2a2f88de674b00a810884fc7dce58b3abc90c34405cc3a5e7792484e43e530e1155713799512366747f36b719f1963137de57092320f4914dc

data/CHANGELOG.md

@@ -1,3 +1,14 @@
+# v1.5.0 RC2 2018-02-01
+
+## Changes since last release
+
+* Fix solr casting when an updated_at key isn't present in the solr document.
+  [tpendragon](https://github.com/tpendragon)
+
+Additional thanks to the following for code review:
+
+[mjgiarlo](https://github.com/mjgiarlo)
+
 # v1.5.0 RC1 2018-02-01
 
 ## Changes since last release

data/README.md

@@ -18,11 +18,9 @@ Jump in: [![Slack Status](http://slack.samvera.org/badge.svg)](http://slack.samv
 ## Primary Contacts
 
 ### Product Owner
-
 [Carolyn Cole](https://github.com/cam156)
 
 ### Technical Lead
-
 [Trey Pendragon](https://github.com/tpendragon)
 
 ## Help
@@ -47,7 +45,6 @@ Valkyrie is configured in two places: an initializer that registers the persiste
 configuration file that sets which options are used by default in which environments.
 
 ### Sample initializer: `config/initializers/valkyrie.rb`:
-
 Here is a sample initializer that registers a couple adapters and storage adapters, in each case linking an
 instance with a short name that can be used to refer to it in your application:
 
@@ -91,7 +88,8 @@ The initializer registers two `Valkyrie::MetadataAdapter` instances for storing
 
 Other adapter options include `Valkyrie::Persistence::BufferedPersister` for buffering in memory before bulk
 updating another persister, `Valkyrie::Persistence::CompositePersister` for storing in more than one adapter
-at once, `Valkyrie::Persistence::Solr` for storing in Solr, and `Valkyrie::Persistence::Fedora` for storing in Fedora.
+at once, `Valkyrie::Persistence::Solr` for storing in Solr, and `Valkyrie::Persistence::Fedora` for storing
+in Fedora.
 
 The initializer also registers three `Valkyrie::StorageAdapter` instances for storing files:
 * `:disk` which stores files on disk
@@ -100,7 +98,6 @@ The initializer also registers three `Valkyrie::StorageAdapter` instances for st
   testing)
 
 ### Sample configuration with custom `Valkyrie.config.resource_class_resolver`:
-
 ```
 require 'valkyrie'
 Rails.application.config.to_prepare do
@@ -111,7 +108,6 @@ end
 ```
 
 ### Sample configuration: `config/valkyrie.yml`:
-
 A sample configuration file that configures your application to use different adapters:
 
 ```
@@ -134,26 +130,12 @@ For each environment, you must set two values:
 
 The values are the short names used in your initializer.
 
-Further details can be found on the [the Wiki](https://github.com/samvera-labs/valkyrie/wiki/Persistence).
+Further details can be found on the [Persistence Wiki
+page](https://github.com/samvera-labs/valkyrie/wiki/Persistence).
 
 ## Usage
 
-### The Public API
-
-Valkyrie's public API is defined by the shared specs that are used to test each of its core classes.
-This include change sets, resources, persisters, adapters, and queries. When creating your own kinds of
-these kinds of classes, you should use these shared specs to test your classes for conformance to
-Valkyrie's API.
-
-When breaking changes are introduced, necessitating a major version change, the shared specs will reflect
-this. When new features are added and a minor version is released there will be no change to the existing shared
-specs, but there may be new ones. These new shared specs will fail in your
-application if you have custom adapters, but your application will still work.
-
-Using the shared specs in your own models is described in more [detail](https://github.com/samvera-labs/valkyrie/wiki/Shared-Specs).
-
 ### Define a Custom Work
-
 Define a custom work class:
 
 ```
@@ -172,7 +154,8 @@ order of multiple values.
 attribute :authors, Valkyrie::Types::Array.meta(ordered: true)
 ```
 
-Defining resource attributes is explained in greater detail within the [Wiki](https://github.com/samvera-labs/valkyrie/wiki/Using-Types).
+Defining resource attributes is explained in greater detail on the [Using Types Wiki
+page](https://github.com/samvera-labs/valkyrie/wiki/Using-Types).
 
 #### Work Types Generator
 
@@ -190,7 +173,6 @@ rails generate valkyrie:resource Foo/Bar title member_ids:array
 ```
 
 ### Read and Write Data
-
 ```
 # initialize a metadata adapter
 adapter = Valkyrie::MetadataAdapter.find(:postgres)
@@ -209,44 +191,64 @@ objects = adapter.query_service.find_all
 Valkyrie.config.metadata_adapter.query_service.find_all_of_model(model: MyModel)
 ```
 
-The usage of `ChangeSets` in writing data are further documented [here](https://github.com/samvera-labs/valkyrie/wiki/ChangeSets-and-Dirty-Tracking).
+The Wiki documents the usage of [Queries](https://github.com/samvera-labs/valkyrie/wiki/Queries),
+[Persistence](https://github.com/samvera-labs/valkyrie/wiki/Persistence), and
+[ChangeSets and Dirty Tracking](https://github.com/samvera-labs/valkyrie/wiki/ChangeSets-and-Dirty-Tracking).
 
-### Concurrency Support (Optimistic Locking)
-By default, it is assumed that a Valkyrie repository implementation shall use a solution supporting concurrent updates for resources (multiple resources can be updated simultaneously using a Gem such as [Sidekiq](https://github.com/mperham/sidekiq)).  In order to handle the possibility of multiple updates applied to the same resource corrupting data, Valkyrie supports optimistic locking.  For further details, please reference the [overview of optimistic locking for Valkyrie resources](https://github.com/samvera-labs/valkyrie/wiki/Optimistic-Locking).
+### Concurrency Support
+A Valkyrie repository may have concurrent updates, for example, from a load-balanced Rails application, or
+from multiple [Sidekiq](https://github.com/mperham/sidekiq) background workers).  In order to prevent multiple
+simultaneous updates applied to the same resource from losing or corrupting data, Valkyrie supports optimistic
+locking.  How to use optimistic locking with Valkyrie is documented on the [Optimistic Locking Wiki
+page](https://github.com/samvera-labs/valkyrie/wiki/Optimistic-Locking).
 
-## Installing a Development environment
+### The Public API
+Valkyrie's public API is defined by the shared specs that are used to test each of its core classes.
+This include change sets, resources, persisters, adapters, and queries. When creating your own kinds of
+these kinds of classes, you should use these shared specs to test your classes for conformance to
+Valkyrie's API.
 
-### Without Docker
+When breaking changes are introduced, necessitating a major version change, the shared specs will reflect
+this. When new features are added and a minor version is released there will be no change to the existing
+shared specs, but there may be new ones. These new shared specs will fail in your application if you have
+custom adapters, but your application will still work.
 
-#### External Requirements
-* PostgreSQL with the uuid-ossp extension.
-  * Note: Enabling uuid-ossp requires database superuser privileges.
-    * From `psql`: `alter user [username] with superuser;`
+Using the shared specs in your own models is described in more detail on the [Shared Specs Wiki
+page](https://github.com/samvera-labs/valkyrie/wiki/Shared-Specs).
 
-#### To run the test suite
-1. Start Solr and Fedora servers for testing with `rake server:test`
-1. Run `rake db:create` (First time only)
-1. Run `rake db:migrate`
+### Fedora 5 Compatibility
+When configuring your adapter, include the `fedora_version` parameter in your metadata or storage adapter
+config.  If Fedora requires auth, you can also include that in the URL, e.g.:
+
+   ```
+   Valkyrie::Storage::Fedora.new(
+     connection: Ldp::Client.new("http://fedoraAdmin:fedoraAdmin@localhost:8988/rest"),
+     fedora_version: 5
+   )
+   ```
+
+## Installing a Development environment
 
 ### With Docker
+The development and test stacks use fully contained virtual volumes and bind all services to different ports,
+so they can be running at the same time without issue.
 
 #### External Requirements
 * [Docker](https://store.docker.com/search?offering=community&type=edition) version >= 17.09.0
-*
-### Dependency Setup (Mac OSX)
 
+### Dependency Setup (Mac OSX)
 1. `brew install docker`
 1. `brew install docker-machine`
 1. `brew install docker-compose`
 
 ### Starting Docker (Mac OSX)
-
 1. `docker-machine create default`
 1. `docker-machine start default`
 1. `eval "$(docker-machine env)"`
 
 #### Starting the development mode dependencies
-1. Start Solr, Fedora, and PostgreSQL with `rake docker:dev:daemon` (or `rake docker:dev:up` in a separate shell to run them in the foreground)
+1. Start Solr, Fedora, and PostgreSQL with `rake docker:dev:daemon` (or `rake docker:dev:up` in a separate
+   shell to run them in the foreground)
 1. Run `rake db:create db:migrate` to initialize the database
 1. Develop!
 1. Run `rake docker:dev:down` to stop the server stack
@@ -256,19 +258,24 @@ By default, it is assumed that a Valkyrie repository implementation shall use a
 1. `rake docker:spec`
 
 #### To run the test suite manually
-1. Start Solr, Fedora, and PostgreSQL with `rake docker:test:daemon` (or `rake docker:test:up` in a separate shell to run them in the foreground)
+1. Start Solr, Fedora, and PostgreSQL with `rake docker:test:daemon` (or `rake docker:test:up` in a separate
+   shell to run them in the foreground)
 1. Run `rake db:create db:migrate` to initialize the database
 1. Run the gem's RSpec test suite with `rspec spec` or `rake`
 1. Run `rake docker:test:down` to stop the server stack
    * The test stack cleans up after itself on exit.
 
-## Fedora 5 Compatibility
-When configuring your adapter, include the `fedora_version` parameter in your metadata or storage adapter config.  If Fedora requires auth, you can also include that in the URL, e.g.:
-   ```
-   Valkyrie::Storage::Fedora.new(connection: Ldp::Client.new("http://fedoraAdmin:fedoraAdmin@localhost:8988/rest"), fedora_version: 5)
-   ```
+### Without Docker
 
-The development and test stacks use fully contained virtual volumes and bind all services to different ports, so they can be running at the same time without issue.
+#### External Requirements
+* PostgreSQL with the uuid-ossp extension.
+  * Note: Enabling uuid-ossp requires database superuser privileges.
+    * From `psql`: `alter user [username] with superuser;`
+
+#### To run the test suite
+1. Start Solr and Fedora servers for testing with `rake server:test`
+1. Run `rake db:create` (First time only)
+1. Run `rake db:migrate`
 
 ## Acknowledgments
 

data/lib/valkyrie/persistence/solr/orm_converter.rb

@@ -54,7 +54,7 @@ module Valkyrie::Persistence::Solr
     # Construct a Time object from the datestamp for the date of the last resource update indexed in Solr
     # @return [Time]
     def updated_at
-      DateTime.parse(solr_document.fetch("updated_at_dtsi").to_s || solr_document["timestamp"] || solr_document.fetch("created_at_dtsi").to_s).utc
+      DateTime.parse((solr_document["updated_at_dtsi"] || solr_document["timestamp"] || solr_document["created_at_dtsi"]).to_s).utc
     end
 
     # Construct the OptimisticLockToken object using the "_version_" field value in the Solr Document

data/lib/valkyrie/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Valkyrie
-  VERSION = "1.5.0.RC1"
+  VERSION = "1.5.0.RC2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: valkyrie
 version: !ruby/object:Gem::Version
-  version: 1.5.0.RC1
+  version: 1.5.0.RC2
 platform: ruby
 authors:
 - Trey Pendragon
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-02-01 00:00:00.000000000 Z
+date: 2019-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-struct
@@ -607,7 +607,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: An ORM using the Data Mapper pattern, specifically built to solve Digital