validocno 0.0.4 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 --- 
-SHA1: 
-  metadata.gz: 1c3dcc97a6fc2dbf8e31d24f40a1ccd292f3e006
-  data.tar.gz: 2d0e220cae2235931d5fe2f4ae1aeebef279b9bf
 SHA512: 
-  metadata.gz: ec4aa02e190faba1fce5ff17005633cd56cf7600b175110aad2fb44277584b9eb0beb5adf4e62a2a8ddd7b0862c3c01a1cff8281be9832cd0927d170d5a4da55
-  data.tar.gz: dd00d4950ad63e9b2db3b236b288982aec051b04b3ee739dad9838d5b693d0e7db53505b2e1e4b7053302acf25d8b2e50970294f8712fcefbe9aa7a557843c72
+  metadata.gz: 185b383a8583ca4c0bb9d13dc31f130c213e0a34fb39030a9eb4e6810997022aec3069e76303eb95a02058bb19e45add7f95547a8408c0f05494b1f1deed02b8
+  data.tar.gz: 726084ea929a160371b3a2e844a0d4b6c852c530d4bbf6d631ee3d9fc64852c39cffffc04d9457aa9fff02a952ac9da6640e983dcc722809914eac15126358f2
+SHA1: 
+  metadata.gz: e9ecae61688b852b69d897fa32600a8139402e4d
+  data.tar.gz: dacbe802188d7d89b01a6e2d94ca6a2684ee8bf6

data/lib/validocno/validator.rb

@@ -44,9 +44,13 @@ module Validocno
       end
     end
 
-    def valid?
-      return true if response_string.match(response_strings[:valid])
-      false
+    def validate
+      is_valid = response_string.match(response_strings[:valid]) ? true : false
+
+      {
+        :valid => is_valid,
+        :message => response_string
+      }
     end
 
     def response_strings

data/lib/validocno/version.rb

@@ -1,3 +1,3 @@
 module Validocno
-  VERSION = '0.0.4'
+  VERSION = '0.1.0'
 end

data/lib/validocno.rb

@@ -11,8 +11,8 @@ require 'validocno/version'
 require 'validocno/http_client'
 
 module Validocno
-  def self.valid?(doc_number)
+  def self.validate(doc_number)
     validator = Validocno::Validator.new(doc_number)
-    validator.valid?
+    validator.validate
   end
 end

data/spec/validator_spec.rb

@@ -20,16 +20,36 @@ describe Validocno::Validator do
 
   end
 
-  describe '#valid?' do
+  describe '#validate' do
     let(:invalid_doc_number) { 'A1234567890' }
-    let(:invalid_validator) { Validocno::Validator.new(invalid_doc_number) }
+    let(:expired_doc_number) { 'A0111856' }
+    let(:validator_with_invalid) { Validocno::Validator.new(invalid_doc_number) }
+    let(:validator_with_expired) { Validocno::Validator.new(expired_doc_number) }
 
-    it 'returns true when document with valid number provided' do
-      expect(validator).to be_valid
+    it 'returns hash with :valid and :message keys' do
+      expect(validator.validate).to have_key(:valid)
+      expect(validator.validate).to have_key(:message)
     end
 
-    it 'returns false when document with invalid number provided' do
-      expect(invalid_validator).to_not be_valid
+    it 'validates document with valid number' do
+      expect(validator.validate).to include(
+        :valid => true,
+        :message => "Dokument #{doc_number} on kehtiv."
+      )
+    end
+
+    it 'validates expired document' do
+      expect(validator_with_expired.validate).to include(
+        :valid => false,
+        :message => "Dokument #{expired_doc_number} on kehtetu."
+      )
+    end
+
+    it 'validates document with invalid number' do
+      expect(validator_with_invalid.validate).to include(
+        :valid => false,
+        :message => "Dokumenti #{invalid_doc_number} ei ole välja antud."
+      )
     end
   end
 end

data/spec/validocno_spec.rb

@@ -1,20 +1,39 @@
 require 'spec_helper'
 
 describe Validocno do
-  describe '.valid?' do
+  describe '.validate' do
     let(:valid_doc_number) { 'A1234567' }
+    let(:expired_doc_number) { 'A0111856' }
     let(:invalid_doc_number) { 'A1234567890' }
 
-    it 'returns true when document with valid number provided' do
-      expect(Validocno.valid?(valid_doc_number)).to be true
+    it 'returns hash with :valid and :message keys' do
+      expect(Validocno.validate(valid_doc_number)).to have_key(:valid)
+      expect(Validocno.validate(valid_doc_number)).to have_key(:message)
     end
 
-    it 'returns false when document with invalid number provided' do
-      expect(Validocno.valid?(invalid_doc_number)).to be false
+    it 'validates document with valid number' do
+      expect(Validocno.validate(valid_doc_number)).to include(
+        :valid => true,
+        :message => "Dokument #{valid_doc_number} on kehtiv."
+      )
+    end
+
+    it 'validates expired document' do
+      expect(Validocno.validate(expired_doc_number)).to include(
+        :valid => false,
+        :message => "Dokument #{expired_doc_number} on kehtetu."
+      )
+    end
+
+    it 'validates document with invalid number' do
+      expect(Validocno.validate(invalid_doc_number)).to include(
+        :valid => false,
+        :message => "Dokumenti #{invalid_doc_number} ei ole välja antud."
+      )
     end
 
     it 'raises an error without a document number' do
-      expect { Validocno.valid? }.to raise_error(ArgumentError)
+      expect { Validocno.validate }.to raise_error(ArgumentError)
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: validocno
 version: !ruby/object:Gem::Version 
-  version: 0.0.4
+  version: 0.1.0
 platform: ruby
 authors: 
 - Artem Pakk
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2014-12-03 00:00:00 Z
+date: 2014-12-04 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   requirement: &id001 !ruby/object:Gem::Requirement