validators 3.1.1 → 3.4.1

data/test/validators/validates_cpf_format_of_test.rb

@@ -15,10 +15,10 @@ class ValidatesCpfFormatOfTest < Minitest::Test
     end
   end
 
-  test "fails when gem is not available" do
-    assert_raises do
+  test "fails when cpf_cnpj is not available" do
+    assert_raises(StandardError, /cpf_cnpj is not part of the bundle/) do
       Class.new do
-        expects(:require).with("cpf").raises(LoadError)
+        Validators.expects(:require).with("cpf_cnpj").raises(LoadError, "-- cpf_cnpj")
 
         include ActiveModel::Model
         validates_cpf_format_of :document

data/test/validators/validates_email_format_of_test.rb

@@ -9,13 +9,38 @@ class ValidatesEmailFormatOfTest < Minitest::Test
     Person.validates :email, email: true
   end
 
+  test "fails when email_data is not available" do
+    assert_raises(StandardError, /email_data is not part of the bundle/) do
+      Class.new do
+        Validators.expects(:require).with("root_domain")
+        Validators.expects(:require).with("email_data").raises(LoadError, "-- email_data")
+
+        include ActiveModel::Model
+        validates_email :email
+      end
+    end
+  end
+
+  test "fails when root_domain is not available" do
+    assert_raises(StandardError, /root_domain is not part of the bundle/) do
+      Class.new do
+        Validators.expects(:require).with("root_domain").raises(LoadError, "-- root_domain")
+
+        include ActiveModel::Model
+        validates_email :email
+      end
+    end
+  end
+
   VALID_EMAILS.each do |email|
     test "accepts #{email.inspect} as a valid email" do
       user = User.new(email: email, corporate_email: email)
-      assert user.valid?
+      user.valid?
+      assert_empty user.errors
 
       user = Person.new(email: email)
-      assert user.valid?
+      user.valid?
+      assert_empty user.errors
     end
   end
 

data/test/validators/validates_ssh_private_key/common_test.rb

@@ -15,10 +15,10 @@ class ValidatesSshPrivateKeyCommonTest < Minitest::Test
     end
   end
 
-  test "fails when gem is not available" do
-    assert_raises do
+  test "fails when sshkey is not available" do
+    assert_raises(StandardError, /sshkey is not part of the bundle/) do
       Class.new do
-        expects(:require).with("sshkey").raises(LoadError)
+        Validators.expects(:require).with("sshkey").raises(LoadError.new("-- sshkey"))
 
         include ActiveModel::Model
         validates_ssh_private_key :key

data/test/validators/validates_ssh_public_key_test.rb

@@ -15,10 +15,10 @@ class ValidatesSsshPublicKeyCommonTest < Minitest::Test
     end
   end
 
-  test "fails when gem is not available" do
-    assert_raises do
+  test "fails when sshkey is not available" do
+    assert_raises(StandardError, /sshkey is not part of the bundle/) do
       Class.new do
-        expects(:require).with("sshkey").raises(LoadError)
+        Validators.expects(:require).with("sshkey").raises(LoadError, "-- sshkey")
 
         include ActiveModel::Model
         validates_ssh_public_key :key

data/test/validators/validates_subdomain_test.rb

@@ -0,0 +1,75 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+class ValidatesSubdomainTest < Minitest::Test
+  test "don't explode with nil values" do
+    model = build_model do
+      attr_accessor :subdomain
+      validates_subdomain :subdomain
+    end
+
+    instance = model.new(subdomain: nil)
+
+    refute instance.valid?
+    assert_includes instance.errors[:subdomain], "is invalid"
+  end
+
+  test "rejects invalid subdomain" do
+    model = build_model do
+      attr_accessor :subdomain
+      validates_subdomain :subdomain
+    end
+
+    instance = model.new(subdomain: "1234")
+
+    refute instance.valid?
+    assert_includes instance.errors[:subdomain], "is invalid"
+  end
+
+  test "rejects reserved subdomain" do
+    model = build_model do
+      attr_accessor :subdomain
+      validates_subdomain :subdomain
+    end
+
+    instance = model.new(subdomain: "www")
+
+    refute instance.valid?
+    assert_includes instance.errors[:subdomain],
+                    "www is a reserved subdomain"
+  end
+
+  test "rejects reserved subdomain with pattern" do
+    model = build_model do
+      attr_accessor :subdomain
+      validates_subdomain :subdomain
+    end
+
+    instance = model.new(subdomain: "www1234")
+
+    refute instance.valid?
+  end
+
+  test "uses custom list" do
+    model = build_model do
+      attr_accessor :subdomain
+      validates_subdomain :subdomain, in: %w[nope]
+    end
+
+    instance = model.new(subdomain: "nope")
+
+    refute instance.valid?
+  end
+
+  test "ignores reserved subdomain validation" do
+    model = build_model do
+      attr_accessor :subdomain
+      validates_subdomain :subdomain, reserved: false
+    end
+
+    instance = model.new(subdomain: "www")
+
+    assert instance.valid?
+  end
+end

data/test/validators/validates_url_format_of/with_tld_validation_test.rb

@@ -14,4 +14,22 @@ class ValidatesurlFormatUrlWithTldValidationTest < Minitest::Test
       assert user.valid?
     end
   end
+
+  test "rejects invalid TLD (alternative syntax)" do
+    user_model = Class.new do
+      include ActiveModel::Validations
+      attr_accessor :site_url
+
+      def self.name
+        "User"
+      end
+
+      validates :site_url, url: {tld: true}
+    end
+
+    user = user_model.new
+    user.site_url = "https://example.xy"
+
+    refute user.valid?
+  end
 end

data/test/validators/validates_url_format_of/without_tld_validation_test.rb

@@ -47,4 +47,22 @@ class ValidatesurlFormatUrlWithoutTldValidationTest < Minitest::Test
     user = User.new(url: "")
     refute user.valid?
   end
+
+  test "accepts invalid TLD (alternative syntax)" do
+    user_model = Class.new do
+      include ActiveModel::Validations
+      attr_accessor :site_url
+
+      def self.name
+        "User"
+      end
+
+      validates :site_url, url: {tld: false}
+    end
+
+    user = user_model.new
+    user.site_url = "https://example.xy"
+
+    assert user.valid?
+  end
 end

data/test/validators/{validates_reserved_username_test.rb → validates_username_test.rb}

@@ -2,11 +2,23 @@
 
 require "test_helper"
 
-class ValidatesReservedUsernameTest < Minitest::Test
+class ValidatesUsernameTest < Minitest::Test
+  test "rejects invalid username" do
+    model = build_model do
+      attr_accessor :username
+      validates_username :username
+    end
+
+    instance = model.new(username: "1234")
+
+    refute instance.valid?
+    assert_includes instance.errors[:username], "is invalid"
+  end
+
   test "rejects reserved username" do
     model = build_model do
       attr_accessor :username
-      validates_reserved_username :username
+      validates_username :username
     end
 
     instance = model.new(username: "www")
@@ -19,7 +31,7 @@ class ValidatesReservedUsernameTest < Minitest::Test
   test "rejects reserved username with pattern" do
     model = build_model do
       attr_accessor :username
-      validates_reserved_username :username
+      validates_username :username
     end
 
     instance = model.new(username: "www1234")
@@ -30,11 +42,22 @@ class ValidatesReservedUsernameTest < Minitest::Test
   test "uses custom list" do
     model = build_model do
       attr_accessor :username
-      validates_reserved_username :username, in: %w[nope]
+      validates_username :username, in: %w[nope]
     end
 
     instance = model.new(username: "nope")
 
     refute instance.valid?
   end
+
+  test "ignores reserved username validation" do
+    model = build_model do
+      attr_accessor :username
+      validates_username :username, reserved: false
+    end
+
+    instance = model.new(username: "www")
+
+    assert instance.valid?
+  end
 end

data/validators.gemspec

@@ -12,22 +12,32 @@ Gem::Specification.new do |s|
   s.summary     = "Add some nice ActiveModel/ActiveRecord validators."
   s.description = s.summary
   s.license     = "MIT"
+  s.required_ruby_version = Gem::Requirement.new(">= 2.3.0")
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map {|f| File.basename(f) }
+  s.executables   = `git ls-files -- bin/*`
+                    .split("\n")
+                    .map {|f| File.basename(f) }
   s.require_paths = ["lib"]
 
   s.add_development_dependency "activerecord"
+  s.add_development_dependency "aitch"
   s.add_development_dependency "cpf_cnpj"
+  s.add_development_dependency "email_data"
   s.add_development_dependency "minitest-utils"
   s.add_development_dependency "mocha"
+  s.add_development_dependency "nokogiri"
   s.add_development_dependency "pry-meta"
   s.add_development_dependency "rake"
+  s.add_development_dependency "root_domain"
   s.add_development_dependency "rubocop"
   s.add_development_dependency "rubocop-fnando"
   s.add_development_dependency "simplecov"
   s.add_development_dependency "simplecov-console"
+  s.add_development_dependency "simpleidn"
   s.add_development_dependency "sqlite3", "~> 1.4"
   s.add_development_dependency "sshkey"
+  s.add_development_dependency "whois"
+  s.add_development_dependency "whois-parser"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: validators
 version: !ruby/object:Gem::Version
-  version: 3.1.1
+  version: 3.4.1
 platform: ruby
 authors:
 - Nando Vieira
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-01-26 00:00:00.000000000 Z
+date: 2020-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: aitch
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: cpf_cnpj
   requirement: !ruby/object:Gem::Requirement
@@ -38,6 +52,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: email_data
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest-utils
   requirement: !ruby/object:Gem::Requirement
@@ -66,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: nokogiri
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry-meta
   requirement: !ruby/object:Gem::Requirement
@@ -94,6 +136,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: root_domain
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -150,6 +206,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simpleidn
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -178,34 +248,58 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: whois
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: whois-parser
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Add some nice ActiveModel/ActiveRecord validators.
 email:
 - fnando.vieira@gmail.com
-executables:
-- sync-disposable-hostnames
-- sync-tld
+executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/FUNDING.yml"
 - ".gitignore"
 - ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - README.md
 - Rakefile
-- bin/sync-disposable-hostnames
-- bin/sync-tld
-- data/disposable.json
-- data/reserved_hostnames.json
-- data/tld.json
+- data/reserved_subdomains.txt
 - lib/validators.rb
 - lib/validators/constants.rb
-- lib/validators/disposable_hostnames.rb
+- lib/validators/disposable_domains.rb
+- lib/validators/disposable_emails.rb
 - lib/validators/hostname.rb
 - lib/validators/ip.rb
 - lib/validators/locale/en.yml
 - lib/validators/locale/pt-BR.yml
-- lib/validators/reserved_hostnames.rb
+- lib/validators/reserved_subdomains.rb
 - lib/validators/tld.rb
 - lib/validators/validates_cnpj_format_of.rb
 - lib/validators/validates_cpf_format_of.rb
@@ -214,11 +308,11 @@ files:
 - lib/validators/validates_hostname_format_of.rb
 - lib/validators/validates_ip_address.rb
 - lib/validators/validates_ownership_of.rb
-- lib/validators/validates_reserved_hostname.rb
-- lib/validators/validates_reserved_username.rb
 - lib/validators/validates_ssh_private_key.rb
 - lib/validators/validates_ssh_public_key.rb
+- lib/validators/validates_subdomain.rb
 - lib/validators/validates_url_format_of.rb
+- lib/validators/validates_username.rb
 - lib/validators/version.rb
 - test/schema.rb
 - test/support/dates.rb
@@ -242,21 +336,21 @@ files:
 - test/validators/validates_ip_address/ipv6_test.rb
 - test/validators/validates_ip_address_test.rb
 - test/validators/validates_ownership_of_test.rb
-- test/validators/validates_reserved_hostname_test.rb
-- test/validators/validates_reserved_username_test.rb
 - test/validators/validates_ssh_private_key/bits_test.rb
 - test/validators/validates_ssh_private_key/common_test.rb
 - test/validators/validates_ssh_private_key/dsa_test.rb
 - test/validators/validates_ssh_private_key/rsa_test.rb
 - test/validators/validates_ssh_public_key_test.rb
+- test/validators/validates_subdomain_test.rb
 - test/validators/validates_url_format_of/with_tld_validation_test.rb
 - test/validators/validates_url_format_of/without_tld_validation_test.rb
+- test/validators/validates_username_test.rb
 - validators.gemspec
 homepage: http://rubygems.org/gems/validators
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -264,7 +358,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -272,7 +366,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.2
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Add some nice ActiveModel/ActiveRecord validators.
 test_files:
@@ -298,12 +392,12 @@ test_files:
 - test/validators/validates_ip_address/ipv6_test.rb
 - test/validators/validates_ip_address_test.rb
 - test/validators/validates_ownership_of_test.rb
-- test/validators/validates_reserved_hostname_test.rb
-- test/validators/validates_reserved_username_test.rb
 - test/validators/validates_ssh_private_key/bits_test.rb
 - test/validators/validates_ssh_private_key/common_test.rb
 - test/validators/validates_ssh_private_key/dsa_test.rb
 - test/validators/validates_ssh_private_key/rsa_test.rb
 - test/validators/validates_ssh_public_key_test.rb
+- test/validators/validates_subdomain_test.rb
 - test/validators/validates_url_format_of/with_tld_validation_test.rb
 - test/validators/validates_url_format_of/without_tld_validation_test.rb
+- test/validators/validates_username_test.rb